Add borders and improve hatching pattern for national parks and military areas #1994

New issue

Open

opened 2022-02-01 16:02:05 +00:00 by pastk · 5 comments

pastk commented

2022-02-01 16:02:05 +00:00

Member

To further improve on #1979 especially for the low zoom levels (z10-12) we need to add thick polygon borders and make hatching pattern more fine:

To further improve on #1979 especially for the low zoom levels (z10-12) we need to add thick polygon borders and make hatching pattern more fine: ![Screenshot_1643643462](https://user-images.githubusercontent.com/18434508/152003738-57719016-9168-45bf-a670-c7baace6a2fa.png) ![Screenshot_1643643605](https://user-images.githubusercontent.com/18434508/152003792-6bff0c01-f4a6-4234-baf3-f453a5de6a31.png)

pastk commented

2022-02-01 16:09:53 +00:00

Author

Member

The hatching fill is harcoded for national parks and military areas at the moment.
The texture is the same png cloned over several scale levels (check area-hatching in drape/texture_manager.cpp) - maybe it's possible to use a single svg?

Polygon borders are supported by the rendering engine (e.g. casing-width: 1;casing-color: @building_border;) but looks like its hardcoded only buildings can use it ATM.

The hatching fill is harcoded for national parks and military areas at the moment. The texture is the same png cloned over several scale levels (check `area-hatching` in `drape/texture_manager.cpp`) - maybe it's possible to use a single svg? Polygon borders are supported by the rendering engine (e.g. `casing-width: 1;casing-color: @building_border;`) but looks like its hardcoded only buildings can use it ATM.

biodranik commented

2022-02-01 16:18:58 +00:00

(Migrated from github.com)

It would be better to make refactoring and support custom fills for many types.

👍 1

pastk commented

2022-06-29 12:27:54 +00:00

Author

Member

The hatching fill is harcoded for national parks and military areas at the moment. The texture is the same png cloned over several scale levels (check area-hatching in drape/texture_manager.cpp) - maybe it's possible to use a single svg?

@vng it shouldn't be too hard to generate the hatching texture programmatically like the triangles pattern?
For #1415 also.

> The hatching fill is harcoded for national parks and military areas at the moment. The texture is the same png cloned over several scale levels (check `area-hatching` in `drape/texture_manager.cpp`) - maybe it's possible to use a single svg? > @vng it shouldn't be too hard to generate the hatching texture programmatically like the triangles pattern? For #1415 also.

vng commented

2022-06-29 21:46:03 +00:00

(Migrated from github.com)

Well, I think that better to draw separate png patterns, at least for wetland/swamp.

pastk commented

2022-06-30 00:19:22 +00:00

Author

Member

Well, I think that better to draw separate png patterns, at least for wetland/swamp.

I mean, there is a scaling problem with pre-generated png patterns, wouldn't it be better and easier to generate such patterns programmatically at runtime just like you did for triangles?

> Well, I think that better to draw separate png patterns, at least for wetland/swamp. I mean, there is a scaling problem with pre-generated png patterns, wouldn't it be better and easier to generate such patterns programmatically at runtime just like you did for triangles?

This repo is archived. You cannot comment on issues.