organicmaps/organicmaps-tmp

Archived

Fork 1

Add haberdashery and sewing shops to categories #2017

New issue

Closed

opened 2022-02-04 17:07:21 +00:00 by FinixFighter · 13 comments

FinixFighter commented

2022-02-04 17:07:21 +00:00

(Migrated from github.com)

Hi! It would be useful to have the categories "haberdashery" (https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhaberdashery) and sewing shop (https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsewing). They're pretty much the same thing, but both tags are active, so I think they could be merged, and then always use shop-sewing in UI and the editor (as discussed here organicmaps/organicmaps#2015).
As a suggestion for a logo, I'd say "scissors" or "scissors-2" from https://remixicon.com/ could be good.

Hi! It would be useful to have the categories "haberdashery" (https://wiki.openstreetmap.org/wiki/Tag:shop%3Dhaberdashery) and sewing shop (https://wiki.openstreetmap.org/wiki/Tag:shop%3Dsewing). They're pretty much the same thing, but both tags are active, so I think they could be merged, and then always use shop-sewing in UI and the editor (as discussed here https://git.omaps.dev/organicmaps/organicmaps/pulls/2015). As a suggestion for a logo, I'd say "scissors" or "scissors-2" from https://remixicon.com/ could be good.

pastk commented

2022-02-05 13:29:56 +00:00

Owner

Here is a guide how to do it properly: organicmaps/organicmaps#1917 (comment)

It might seem very complex at first glance but we'll help you as you go!

Here is a guide how to do it properly: https://git.omaps.dev/organicmaps/organicmaps/issues/1917#issuecomment-1030623850 It might seem very complex at first glance but we'll help you as you go!

FinixFighter commented

2022-02-23 09:00:52 +00:00

(Migrated from github.com)

Here is a guide how to do it properly: #1917 (comment)

It might seem very complex at first glance but we'll help you as you go!

Thank you! I did the first step (add data to data/mapcss-mapping.csv #2180). Second step is not necessary. Now I should upload an icon but I can't, because when I click "Upload files" it says " Uploads are disabled.
File uploads require push access to this repository. ". The file I wanted to upload is scissors-cut-line from https://remixicon.com/
How can I do that?

> Here is a guide how to do it properly: [#1917 (comment)](https://git.omaps.dev/organicmaps/organicmaps/issues/1917#issuecomment-1030623850) > > It might seem very complex at first glance but we'll help you as you go! Thank you! I did the first step (add data to data/mapcss-mapping.csv #2180). Second step is not necessary. Now I should upload an icon but I can't, because when I click "Upload files" it says " Uploads are disabled. File uploads require push access to this repository. ". The file I wanted to upload is scissors-cut-line from https://remixicon.com/ How can I do that?

biodranik commented

2022-02-23 14:25:15 +00:00

(Migrated from github.com)

You should fork this repo and create a branch in it with your changes.

pastk commented

2022-02-23 19:18:39 +00:00

Owner

Here is a guide how to do it properly: #1917 (comment)
It might seem very complex at first glance but we'll help you as you go!

Thank you! I did the first step (add data to data/mapcss-mapping.csv #2180). Second step is not necessary. Now I should upload an icon but I can't, because when I click "Upload files" it says " Uploads are disabled. File uploads require push access to this repository. ". The file I wanted to upload is scissors-cut-line from https://remixicon.com/ How can I do that?

I guess you tried to upload the file directly to the main github.com/organicmaps/organicmaps repository. In github you do all the changes in your fork of the main repo first and then create a pull request to propose to include the changes into the main repo. So you need to upload the new file into your fork into a branch which you used for #2180 already (to keep all changes together): https://github.com/FinixFighter/organicmaps/tree/patch-3

Did you consider cloning the repository to your computer? (there are instructions in https://github.com/pastk/organicmaps/blob/master/docs/INSTALL.md#getting-sources) Its much more convenient to do complex changes this way (but you need to know basics of working with git at least).

> > Here is a guide how to do it properly: [#1917 (comment)](https://git.omaps.dev/organicmaps/organicmaps/issues/1917#issuecomment-1030623850) > > It might seem very complex at first glance but we'll help you as you go! > > Thank you! I did the first step (add data to data/mapcss-mapping.csv #2180). Second step is not necessary. Now I should upload an icon but I can't, because when I click "Upload files" it says " Uploads are disabled. File uploads require push access to this repository. ". The file I wanted to upload is scissors-cut-line from https://remixicon.com/ How can I do that? I guess you tried to upload the file directly to the main `github.com/organicmaps/organicmaps` repository. In github you do all the changes in your fork of the main repo first and then create a pull request to propose to include the changes into the main repo. So you need to upload the new file into your fork into a branch which you used for #2180 already (to keep all changes together): https://github.com/FinixFighter/organicmaps/tree/patch-3 Did you consider cloning the repository to your computer? (there are instructions in https://github.com/pastk/organicmaps/blob/master/docs/INSTALL.md#getting-sources) Its much more convenient to do complex changes this way (but you need to know basics of working with git at least).

pastk commented

2022-02-23 19:26:09 +00:00

Owner

The file I wanted to upload is scissors-cut-line from https://remixicon.com/ How can I do that?

A scissors icon is used in OM for hairdressers already (see data/styles/clear/style-clear/symbols/hairdresser-m.svg) so we need something different e.g. a needle with a thread.

I did the first step (add data to data/mapcss-mapping.csv organicmaps/organicmaps#2180). Second step is not necessary.

As the shop=haberdashery and shop=sewing are identical it makes sense to merge the haberdashery tag into a sewing shop (so in OM all haberdasheries will appear as sewing shops) - it needs to be done in data/replaced_tags.txt.

> The file I wanted to upload is scissors-cut-line from https://remixicon.com/ How can I do that? A scissors icon is used in OM for hairdressers already (see `data/styles/clear/style-clear/symbols/hairdresser-m.svg`) so we need something different e.g. a needle with a thread. > I did the first step (add data to data/mapcss-mapping.csv https://git.omaps.dev/organicmaps/organicmaps/pulls/2180). Second step is not necessary. As the `shop=haberdashery` and `shop=sewing` are identical it makes sense to merge the `haberdashery` tag into a sewing shop (so in OM all haberdasheries will appear as sewing shops) - it needs to be done in `data/replaced_tags.txt`.

FinixFighter commented

2022-02-24 10:48:48 +00:00

(Migrated from github.com)

A scissors icon is used in OM for hairdressers already (see data/styles/clear/style-clear/symbols/hairdresser-m.svg) so we need something different e.g. a needle with a thread.

What about this one? https://www.flaticon.com/free-icon/thread_1248527 (attribution to this website is already in data/copyright.html file)
Alternatives:
-https://www.freepik.com/free-icon/needle_14550960.htm#query=needle&position=35&from_view=search
-https://www.freepik.com/free-icon/sewing_15571883.htm#query=needle&position=42&from_view=search
-https://www.freepik.com/free-icon/sewing_15571937.htm#query=needle&position=46&from_view=search
What do you think?

> A scissors icon is used in OM for hairdressers already (see `data/styles/clear/style-clear/symbols/hairdresser-m.svg`) so we need something different e.g. a needle with a thread. What about this one? https://www.flaticon.com/free-icon/thread_1248527 (attribution to this website is already in data/copyright.html file) Alternatives: -https://www.freepik.com/free-icon/needle_14550960.htm#query=needle&position=35&from_view=search -https://www.freepik.com/free-icon/sewing_15571883.htm#query=needle&position=42&from_view=search -https://www.freepik.com/free-icon/sewing_15571937.htm#query=needle&position=46&from_view=search What do you think?

pastk commented

2022-02-24 14:13:05 +00:00

Owner

What about this one? https://www.flaticon.com/free-icon/thread_1248527 (attribution to this website is already in data/copyright.html file) Alternatives: -https://www.freepik.com/free-icon/needle_14550960.htm#query=needle&position=35&from_view=search -https://www.freepik.com/free-icon/sewing_15571883.htm#query=needle&position=42&from_view=search -https://www.freepik.com/free-icon/sewing_15571937.htm#query=needle&position=46&from_view=search What do you think?

Some of them are really good!
My order of personal preference is
https://www.flaticon.com/free-icon/needle-with-thread-to-sew-clothes_27046
and https://www.flaticon.com/free-icon/needle_113317
https://www.freepik.com/free-icon/needle_14550960.htm
https://www.freepik.com/free-icon/sewing_15571937.htm

> > What about this one? https://www.flaticon.com/free-icon/thread_1248527 (attribution to this website is already in data/copyright.html file) Alternatives: -https://www.freepik.com/free-icon/needle_14550960.htm#query=needle&position=35&from_view=search -https://www.freepik.com/free-icon/sewing_15571883.htm#query=needle&position=42&from_view=search -https://www.freepik.com/free-icon/sewing_15571937.htm#query=needle&position=46&from_view=search What do you think? Some of them are really good! My order of personal preference is https://www.flaticon.com/free-icon/needle-with-thread-to-sew-clothes_27046 and https://www.flaticon.com/free-icon/needle_113317 https://www.freepik.com/free-icon/needle_14550960.htm https://www.freepik.com/free-icon/sewing_15571937.htm

FinixFighter commented

2022-02-24 15:14:19 +00:00

(Migrated from github.com)

My order of personal preference is https://www.flaticon.com/free-icon/needle-with-thread-to-sew-clothes_27046

Great! Can I upload it as it is, or do I have to resize/modify it in some way?

>My order of personal preference is https://www.flaticon.com/free-icon/needle-with-thread-to-sew-clothes_27046 Great! Can I upload it as it is, or do I have to resize/modify it in some way?

pastk commented

2022-02-24 15:19:48 +00:00

Owner

Yes it needs to be modified to look like other similar icons, e.g. we use the same icon color for all shops and there should be a circle around, for example see department_store, computer, book-shop, etc. in data/styles/clear/style-clear/symbols. Note that a separate "dark/night" version should be added to data/styles/clear/style-night/symbols as well.

Yes it needs to be modified to look like other similar icons, e.g. we use the same icon color for all shops and there should be a circle around, for example see department_store, computer, book-shop, etc. in `data/styles/clear/style-clear/symbols`. Note that a separate "dark/night" version should be added to `data/styles/clear/style-night/symbols` as well.

FinixFighter commented

2022-02-24 15:41:18 +00:00

(Migrated from github.com)

Yes it needs to be modified to look like other similar icons, e.g. we use the same icon color for all shops and there should be a circle around, for example see department_store, computer, book-shop, etc. in data/styles/clear/style-clear/symbols. Note that a separate "dark/night" version should be added to data/styles/clear/style-night/symbols as well.

I see. I'm sorry I think I'm not able to do so, I've never done it XD I was following the guide and I managed to edit the code, but don't know how to edit svg in the proper way.

> Yes it needs to be modified to look like other similar icons, e.g. we use the same icon color for all shops and there should be a circle around, for example see department_store, computer, book-shop, etc. in `data/styles/clear/style-clear/symbols`. Note that a separate "dark/night" version should be added to `data/styles/clear/style-night/symbols` as well. I see. I'm sorry I think I'm not able to do so, I've never done it XD I was following the guide and I managed to edit the code, but don't know how to edit svg in the proper way.

pastk commented

2022-02-24 15:50:27 +00:00

Owner

SVG is actually a text file in xml format, you can try to replace the "inner shape" code (the <path> tag) of the old icon with the code from a new one.
But don't worry if you can't do it - you've helped already by finding a good suitable icon! Thanks!

SVG is actually a text file in xml format, you can try to replace the "inner shape" code (the `<path>` tag) of the old icon with the code from a new one. But don't worry if you can't do it - you've helped already by finding a good suitable icon! Thanks!

FinixFighter commented

2022-02-24 16:40:40 +00:00

(Migrated from github.com)

SVG is actually a text file in xml format, you can try to replace the "inner shape" code (the <path> tag) of the old icon with the code from a new one. But don't worry if you can't do it - you've helped already by finding a good suitable icon! Thanks!

Ok, I'm sorry I can't help on this point. Thanks for your guidance anyway! ^^

> SVG is actually a text file in xml format, you can try to replace the "inner shape" code (the `<path>` tag) of the old icon with the code from a new one. But don't worry if you can't do it - you've helped already by finding a good suitable icon! Thanks! Ok, I'm sorry I can't help on this point. Thanks for your guidance anyway! ^^

TheAdventurer64 commented

2022-08-31 08:38:30 +00:00

(Migrated from github.com)

Any progress on this?

This repo is archived. You cannot comment on issues.