Add cuisine=bubble_tea #2107

pastk · 2022-02-13T19:48:50Z

TheAdventurer64 commented

2022-02-13 19:48:50 +00:00

(Migrated from github.com)

Signed-off-by: Aidan Ueda little.banana.peel@gmail.com

Signed-off-by: Aidan Ueda <little.banana.peel@gmail.com>

👍 1

pastk commented

2022-02-14 09:34:08 +00:00

Please add all other necessary changes (as per organicmaps/organicmaps#1981 (comment)) into this single PR.

Please add all other necessary changes (as per https://git.omaps.dev/organicmaps/organicmaps/issues/1981#issuecomment-1027908565) into this single PR.

pastk requested changes 2022-02-14 09:34:53 +00:00

data/mapcss-mapping.csv

pastk commented

2022-02-14 09:34:45 +00:00

Instead of adding a new line there please replace existing but not used one (deprecated), e.g. there is a 1324 close to other cuisines.

Instead of adding a new line there please replace existing but not used one (`deprecated`), e.g. there is a 1324 close to other cuisines.

TheAdventurer64 (Migrated from github.com) reviewed 2022-02-14 22:55:12 +00:00

data/mapcss-mapping.csv

TheAdventurer64 (Migrated from github.com) commented

2022-02-14 22:55:12 +00:00

Fixed in organicmaps/organicmaps#2107/commits/bc27e8dd60dd8f816f8d14a04bc3784bb3c68058

Fixed in https://git.omaps.dev/organicmaps/organicmaps/pulls/2107/commits/bc27e8dd60dd8f816f8d14a04bc3784bb3c68058

pastk commented

2022-02-15 09:15:38 +00:00

One thing left - please add it to data/categories_cuisines.txt to make it searchable!

One thing left - please add it to `data/categories_cuisines.txt` to make it searchable!

👍 1

pastk reviewed 2022-02-15 10:17:38 +00:00

data/strings/types_strings.txt

					
				@ -5120,2 +5120,4 @@

				    zh-Hant = 早餐

				  [type.cuisine.bubble_tea]

				    en = Bubble Tea

pastk commented

2022-02-15 10:17:38 +00:00

Please add some more translations:
ru = Чай с шариками
uk = Бульбашковий чай
es = Té de burbujas

If you want to add more languages you can look up translations in corresponding wikipedia articles https://en.wikipedia.org/wiki/Bubble_tea
Also wikipedia articles could be helpful in suggesting alternative names/aliases/synonyms for search keywords.

Please add some more translations: ru = Чай с шариками uk = Бульбашковий чай es = Té de burbujas If you want to add more languages you can look up translations in corresponding wikipedia articles https://en.wikipedia.org/wiki/Bubble_tea Also wikipedia articles could be helpful in suggesting alternative names/aliases/synonyms for search keywords.

biodranik (Migrated from github.com) reviewed 2022-02-15 10:23:29 +00:00

data/strings/types_strings.txt

					
				@ -5120,2 +5120,4 @@

				    zh-Hant = 早餐

				  [type.cuisine.bubble_tea]

				    en = Bubble Tea

biodranik (Migrated from github.com) commented

2022-02-15 10:23:29 +00:00

be = Чай з бурбалкамі

TheAdventurer64 commented

2022-02-17 19:12:26 +00:00

(Migrated from github.com)

One thing left - please add it to data/categories_cuisines.txt to make it searchable!

How would you add several search aliases? Searching for "boba tea" should also show bubble tea places in the area.

> One thing left - please add it to `data/categories_cuisines.txt` to make it searchable! How would you add several search aliases? Searching for "boba tea" should also show bubble tea places in the area.

pastk reviewed 2022-02-17 19:35:36 +00:00

data/strings/types_strings.txt

					
				@ -5120,2 +5120,4 @@

				    zh-Hant = 早餐

				  [type.cuisine.bubble_tea]

				    en = Bubble Tea

pastk commented

2022-02-17 19:35:36 +00:00

@TheAdventurer64 please also add be from above comment

@TheAdventurer64 please also add `be` from above comment

pastk commented

2022-02-17 19:37:51 +00:00

One thing left - please add it to data/categories_cuisines.txt to make it searchable!

How would you add several search aliases? Searching for "boba tea" should also show bubble tea places in the area.

Separate aliases with | e.g.

cuisine-ice_cream
en:Ice Cream|gelato
ru:Кафе-мороженое|мороженое

> > One thing left - please add it to `data/categories_cuisines.txt` to make it searchable! > > How would you add several search aliases? Searching for "boba tea" should also show bubble tea places in the area. Separate aliases with `|` e.g. ``` cuisine-ice_cream en:Ice Cream|gelato ru:Кафе-мороженое|мороженое ```

pastk approved these changes 2022-02-18 21:36:39 +00:00

pastk left a comment

Looks good, thanks!!!

If you can please run the script tools/unix/generate_localizations.sh and add a commit with resulting changes. If you don't have the means to run the script then don't worry, we'll do it ourselves!

Looks good, thanks!!! If you can please run the script `tools/unix/generate_localizations.sh` and add a commit with resulting changes. If you don't have the means to run the script then don't worry, we'll do it ourselves!

biodranik commented

2022-02-19 06:30:01 +00:00

(Migrated from github.com)

Please rebase on top of the fresh master branch first before regenerating strings.

vng (Migrated from github.com) reviewed 2022-03-05 16:45:34 +00:00

data/mapcss-mapping.csv

vng (Migrated from github.com) commented

2022-03-05 16:45:34 +00:00

Hm, does it works like this? Use '|' as a separator.