Improved romanian translation #2174

Merged
owhyy merged 6 commits from improve-romanian-translation into master 2022-03-06 17:01:24 +00:00
owhyy commented 2022-02-22 05:28:15 +00:00 (Migrated from github.com)

Signed-off-by: Babin Ion ionbabin123@mail.ru

Closes organicmaps/organicmaps#2163

Signed-off-by: Babin Ion <ionbabin123@mail.ru> Closes https://git.omaps.dev/organicmaps/organicmaps/issues/2163
rsippl (Migrated from github.com) reviewed 2022-02-22 08:50:13 +00:00
rsippl (Migrated from github.com) commented 2022-02-22 08:50:13 +00:00

"este necesar". "și până" sau doar "până"?

"este necesar". "și până" sau doar "până"?
rsippl (Migrated from github.com) reviewed 2022-02-22 08:50:48 +00:00
rsippl (Migrated from github.com) commented 2022-02-22 08:50:48 +00:00

doar

doar
rsippl (Migrated from github.com) reviewed 2022-02-22 08:54:48 +00:00
@ -13840,7 +13837,7 @@
pl = Organic Maps to bezpłatna aplikacja do map offline typu open source. Bez reklam. Bez śledzenia. Jeśli zobaczysz błąd na mapie, napraw go w OpenStreetMap. Projekt jest tworzony przez entuzjastów w czasie wolnym, dlatego potrzebujemy Twojej opinii i wsparcia.
pt = Organic Maps é uma aplicação gratuita e de código aberto de mapas offline. Sem anúncios. Sem seguimento. Se vir um erro no mapa, por favor repare-o em OpenStreetMap. O projecto é criado por entusiastas no nosso tempo livre, por isso precisamos do seu feedback e apoio.
pt-BR = Organic Maps é uma aplicação gratuita e de código aberto de mapas off-line. Sem anúncios. Sem rastreamento. Se você vir um erro no mapa, por favor, corrija em OpenStreetMap. O projeto é criado por entusiastas em nosso tempo livre, então precisamos de seu feedback e suporte.
rsippl (Migrated from github.com) commented 2022-02-22 08:54:47 +00:00

"fără de reclame" -> "fără reclame". Punct la sfarsit.

"fără de reclame" -> "fără reclame". Punct la sfarsit.
rsippl (Migrated from github.com) reviewed 2022-02-22 08:58:48 +00:00
@ -18013,7 +18011,7 @@
pl = Ta opcja zostaje włączona do logowania działań w celach diagnostycznych. Pomaga to zespołowi zidentyfikować problemy z aplikacją. Włączaj opcję tylko na żądanie wsparcia technicznego Organic Maps.
pt = Esta opção ativa o registo das ações para diagnóstico. Pode ser útil para os programadores descobrirem o problema na aplicação. Ative esta opção apenas a pedido dos programadores do Organic Maps.
rsippl (Migrated from github.com) commented 2022-02-22 08:58:48 +00:00

"echipei noastră" -> "echipei noastre"

"echipei noastră" -> "echipei noastre"
rsippl (Migrated from github.com) reviewed 2022-02-22 08:59:37 +00:00
@ -18999,7 +18997,7 @@
pl = Klawiatura nie jest dostępna podczas ruchu
pt = O teclado não está disponível ao coduzir
rsippl (Migrated from github.com) commented 2022-02-22 08:59:36 +00:00

"folistă" -> "folosită"

"folistă" -> "folosită"
rsippl commented 2022-02-22 09:29:07 +00:00 (Migrated from github.com)

[search_map]
comment = Search box placeholder text
tags = android
en = Search Map
de = Auf der Karte suchen
es = Buscar en el mapa
fr = Rechercher sur la carte
nl = Op de kaart zoeken
ro = Caută harta

This is a bit confusing. Is it really "Search Map" or "Search on the Map"? The translations are not consistent here. @pastk please review.

[search_map] comment = Search box placeholder text tags = android en = Search Map de = Auf der Karte suchen es = Buscar en el mapa fr = Rechercher sur la carte nl = Op de kaart zoeken ro = Caută harta This is a bit confusing. Is it really "Search Map" or "Search on the Map"? The translations are not consistent here. @pastk please review.
biodranik (Migrated from github.com) approved these changes 2022-02-22 09:36:54 +00:00
rsippl (Migrated from github.com) reviewed 2022-02-22 09:37:24 +00:00
@ -13840,7 +13837,7 @@
pl = Organic Maps to bezpłatna aplikacja do map offline typu open source. Bez reklam. Bez śledzenia. Jeśli zobaczysz błąd na mapie, napraw go w OpenStreetMap. Projekt jest tworzony przez entuzjastów w czasie wolnym, dlatego potrzebujemy Twojej opinii i wsparcia.
pt = Organic Maps é uma aplicação gratuita e de código aberto de mapas offline. Sem anúncios. Sem seguimento. Se vir um erro no mapa, por favor repare-o em OpenStreetMap. O projecto é criado por entusiastas no nosso tempo livre, por isso precisamos do seu feedback e apoio.
pt-BR = Organic Maps é uma aplicação gratuita e de código aberto de mapas off-line. Sem anúncios. Sem rastreamento. Se você vir um erro no mapa, por favor, corrija em OpenStreetMap. O projeto é criado por entusiastas em nosso tempo livre, então precisamos de seu feedback e suporte.
rsippl (Migrated from github.com) commented 2022-02-22 09:37:24 +00:00

"și urmărire" (tracking) got lost here, some translation is needed...

"și urmărire" (tracking) got lost here, some translation is needed...
biodranik commented 2022-02-22 09:41:21 +00:00 (Migrated from github.com)

search_map

It is used now in Android in two places:

  1. Search Activity title
  2. Voice Recognition command to launch the search.

The proper translation of course should be Search on the Map, or at least Map Search, instead of Search Map.

> search_map It is used now in Android in two places: 1. Search Activity title 2. Voice Recognition command to launch the search. The proper translation of course should be Search on the Map, or at least Map Search, instead of Search Map.
rsippl commented 2022-02-22 09:50:55 +00:00 (Migrated from github.com)

The proper translation of course should be Search on the Map, or at least Map Search, instead of Search Map.

OK then it should be something like "Caută pe hartă" instead of "Caută harta", @owhyy do you agree? I believe Italian should be "Cerca sulla mappa" instead of "Cerca mappa". de, es, fr, nl should be ok, I don't know about the others.

> The proper translation of course should be Search on the Map, or at least Map Search, instead of Search Map. OK then it should be something like "Caută pe hartă" instead of "Caută harta", @owhyy do you agree? I believe Italian should be "Cerca sulla mappa" instead of "Cerca mappa". de, es, fr, nl should be ok, I don't know about the others.
rsippl commented 2022-02-22 09:59:26 +00:00 (Migrated from github.com)
[children]
    comment = Search category for water park/disneyland/playground/toys store; any changes should be duplicated in categories.txt @children!
    en = Family holiday
    de = Freizeit mit Kindern
    fr = Vacances en famille
    it = Tempo libero
    ro = Timp liber

I don't think ro and it express well enough what's meant here. Focus is on family or children. Any ideas?

``` [children] comment = Search category for water park/disneyland/playground/toys store; any changes should be duplicated in categories.txt @children! en = Family holiday de = Freizeit mit Kindern fr = Vacances en famille it = Tempo libero ro = Timp liber ``` I don't think _ro_ and _it_ express well enough what's meant here. Focus is on family or children. Any ideas?
rsippl commented 2022-02-22 10:20:33 +00:00 (Migrated from github.com)

@biodranik here's another possible inconsistency:

[pref_zoom_summary]
    tags = android
    en = Display on the map
    de = Auf dem Bildschirm anzeigen
    es = Visualización en la pantalla
    fr = Afficher à l'écran
    id = Tampilkan pada layar
    it = Mostra sulla mappa
    nl = Weergave op het scherm
    pl = Wyświetla na ekranie
    pt = Mostrar no ecrã
    ro = Arată pe hartă

Translation en -> ro is okay, but is it really map, or is it screen? Bildschirm, pantalla, écran, scherm clearly don't mean map, but screen.

@biodranik here's another possible inconsistency: ``` [pref_zoom_summary] tags = android en = Display on the map de = Auf dem Bildschirm anzeigen es = Visualización en la pantalla fr = Afficher à l'écran id = Tampilkan pada layar it = Mostra sulla mappa nl = Weergave op het scherm pl = Wyświetla na ekranie pt = Mostrar no ecrã ro = Arată pe hartă ``` Translation en -> ro is okay, but is it really map, or is it screen? Bildschirm, pantalla, écran, scherm clearly don't mean map, but screen.
owhyy commented 2022-02-22 10:22:20 +00:00 (Migrated from github.com)
[children]
    comment = Search category for water park/disneyland/playground/toys store; any changes should be duplicated in categories.txt @children!
    en = Family holiday
    de = Freizeit mit Kindern
    fr = Vacances en famille
    it = Tempo libero
    ro = Timp liber

I don't think ro and it express well enough what's meant here. Focus is on family or children. Any ideas?

I think somethink like "Odihnă cu familia" or "Odihna cu copiii" might work

> ``` > [children] > comment = Search category for water park/disneyland/playground/toys store; any changes should be duplicated in categories.txt @children! > en = Family holiday > de = Freizeit mit Kindern > fr = Vacances en famille > it = Tempo libero > ro = Timp liber > ``` > > I don't think _ro_ and _it_ express well enough what's meant here. Focus is on family or children. Any ideas? I think somethink like "Odihnă cu familia" or "Odihna cu copiii" might work
rsippl commented 2022-02-22 10:27:36 +00:00 (Migrated from github.com)

I think somethink like "Odihnă cu familia" or "Odihna cu copiii" might work

Not sure odihna is what we want, that's more like "rest". How about something like divertisment, vacanta...

> I think somethink like "Odihnă cu familia" or "Odihna cu copiii" might work Not sure odihna is what we want, that's more like "rest". How about something like divertisment, vacanta...
biodranik commented 2022-02-22 10:45:26 +00:00 (Migrated from github.com)

Translation en -> ro is okay, but is it really map, or is it screen? Bildschirm, pantalla, écran, scherm clearly don't mean map, but screen.

Zoom buttons are visible on the map screen. So probably it's ok. Maybe explicitly saying "On the map screen" is better :)

> > Translation en -> ro is okay, but is it really map, or is it screen? Bildschirm, pantalla, écran, scherm clearly don't mean map, but screen. Zoom buttons are visible on the map screen. So probably it's ok. Maybe explicitly saying "On the map screen" is better :)
rsippl commented 2022-02-22 10:49:51 +00:00 (Migrated from github.com)

Zoom buttons are visible on the map screen. So probably it's ok. Maybe explicitly saying "On the map screen" is better :)

I see, so neither map nor screen are wrong, then let's keep it as it is.

> Zoom buttons are visible on the map screen. So probably it's ok. Maybe explicitly saying "On the map screen" is better :) I see, so neither map nor screen are wrong, then let's keep it as it is.
owhyy commented 2022-02-22 10:50:49 +00:00 (Migrated from github.com)
   [download_resources_continue]
   tags = android
   en = Go to Map
   ...
   nl = Ga naar de kaart
   pl = Przejdź do mapy
   pt = Ir ao mapa
   pt-BR = Ir para o mapa
   ro = Du-te la hartă

What about here? I think „Mergi la hartă” sounds better? What do you think? @rsippl

``` [download_resources_continue] tags = android en = Go to Map ... nl = Ga naar de kaart pl = Przejdź do mapy pt = Ir ao mapa pt-BR = Ir para o mapa ro = Du-te la hartă ``` What about here? I think „Mergi la hartă” sounds better? What do you think? @rsippl
rsippl commented 2022-02-22 10:55:41 +00:00 (Migrated from github.com)

What about here? I think „Mergi la hartă” sounds better? What do you think? @rsippl

Both are fine by me, OTOH it's been a while since I was a native RO speaker :)

> What about here? I think „Mergi la hartă” sounds better? What do you think? @rsippl Both are fine by me, OTOH it's been a while since I was a native RO speaker :)
rsippl commented 2022-02-22 10:58:52 +00:00 (Migrated from github.com)
[editor_report_problem_desription_1]
    tags = android
    en = Please describe the problem in detail so that the OpenStreeMap community can fix the error.
...
    ro = Descrie problema în detaliu, astfel încât comunitatea OpenStreeMap să poată remedia eroarea.

@owhyy can you please fix the "OpenStreeMap" typo in the whole file? Thanks.

``` [editor_report_problem_desription_1] tags = android en = Please describe the problem in detail so that the OpenStreeMap community can fix the error. ... ro = Descrie problema în detaliu, astfel încât comunitatea OpenStreeMap să poată remedia eroarea. ``` @owhyy can you please fix the "OpenStreeMap" typo in the whole file? Thanks.
rsippl commented 2022-02-22 11:09:20 +00:00 (Migrated from github.com)
[editor_login_error_dialog]
    tags = android
    en = Login error.
    fr = Erreur de connexion.
    it = Errore accesso.
    pt = Erro de início de sessão.
    pt-BR = Erro no login.
    ro = Eroare de conectare.

@owhyy is conectare/connexion really login? In my opinion, connection is somewhere lower in the network stack...

``` [editor_login_error_dialog] tags = android en = Login error. fr = Erreur de connexion. it = Errore accesso. pt = Erro de início de sessão. pt-BR = Erro no login. ro = Eroare de conectare. ``` @owhyy is conectare/connexion really login? In my opinion, connection is somewhere lower in the network stack...
rsippl (Migrated from github.com) reviewed 2022-02-22 11:19:50 +00:00
@ -2401,3 +2400,4 @@
it = Divertimento in famiglia
ja = 家族の休日
ko = 가족 기념일
nb = Familieferie
rsippl (Migrated from github.com) commented 2022-02-22 11:19:50 +00:00

... cu familia / cu copiii ? Keep in mind we also have [entertainment]. How about we also change "it" to "Divertimento in famiglia", it's surely better than "Tempo libero"

... cu familia / cu copiii ? Keep in mind we also have [entertainment]. How about we also change "it" to "Divertimento in famiglia", it's surely better than "Tempo libero"
rsippl commented 2022-02-22 11:30:07 +00:00 (Migrated from github.com)
[editor_other_info]
    tags = android,ios
    en = Send a note to OSM editors
    de = Notiz an OSM-Redakteure senden
    it = Invia un messaggio a OSM
    ro = Trimite un mesaj către OSM

"editors" has no translation here, @owhyy how about redacția OSM, editorii, or something like that?

``` [editor_other_info] tags = android,ios en = Send a note to OSM editors de = Notiz an OSM-Redakteure senden it = Invia un messaggio a OSM ro = Trimite un mesaj către OSM ``` "editors" has no translation here, @owhyy how about redacția OSM, editorii, or something like that?
owhyy (Migrated from github.com) reviewed 2022-02-22 11:40:56 +00:00
@ -2401,3 +2400,4 @@
it = Divertimento in famiglia
ja = 家族の休日
ko = 가족 기념일
nb = Familieferie
owhyy (Migrated from github.com) commented 2022-02-22 11:40:55 +00:00

... cu familia / cu copiii ? Keep in mind we also have [entertainment]. How about we also change "it" to "Divertimento in famiglia", it's surely better than "Tempo libero"

totally forgot about that

> ... cu familia / cu copiii ? Keep in mind we also have [entertainment]. How about we also change "it" to "Divertimento in famiglia", it's surely better than "Tempo libero" totally forgot about that
rsippl commented 2022-02-22 11:42:22 +00:00 (Migrated from github.com)
[foot]
    tags = android,ios
    en = ft
    be = фут
    bg = фут
    de = ft
    es = pie
    it = piede
    ro = picior

I think we're better off using the "ft" abbreviation here. The translation uses the singular form in many languages. In Romanian 23 picior looks awful, in fr, it etc. this should be similar. @biodranik maybe you should decide this.

``` [foot] tags = android,ios en = ft be = фут bg = фут de = ft es = pie it = piede ro = picior ``` I think we're better off using the "ft" abbreviation here. The translation uses the singular form in many languages. In Romanian _23 picior_ looks awful, in _fr_, _it_ etc. this should be similar. @biodranik maybe you should decide this.
owhyy commented 2022-02-22 11:42:44 +00:00 (Migrated from github.com)
[editor_login_error_dialog]
    tags = android
    en = Login error.
    fr = Erreur de connexion.
    it = Errore accesso.
    pt = Erro de início de sessão.
    pt-BR = Erro no login.
    ro = Eroare de conectare.

@owhyy is conectare/connexion really login? In my opinion, connection is somewhere lower in the network stack...

you're probably right. Would "Eroare de conectare" be a better choice? or can you find something better?

> ``` > [editor_login_error_dialog] > tags = android > en = Login error. > fr = Erreur de connexion. > it = Errore accesso. > pt = Erro de início de sessão. > pt-BR = Erro no login. > ro = Eroare de conectare. > ``` > > @owhyy is conectare/connexion really login? In my opinion, connection is somewhere lower in the network stack... you're probably right. Would "Eroare de conectare" be a better choice? or can you find something better?
owhyy commented 2022-02-22 11:43:21 +00:00 (Migrated from github.com)
[foot]
    tags = android,ios
    en = ft
    be = фут
    bg = фут
    de = ft
    es = pie
    it = piede
    ro = picior

I think we're better off using the "ft" abbreviation here. The translation uses the singular form in many languages. In Romanian 23 picior looks awful, in fr, it etc. this should be similar. @biodranik maybe you should decide this.

I agree

> ``` > [foot] > tags = android,ios > en = ft > be = фут > bg = фут > de = ft > es = pie > it = piede > ro = picior > ``` > > I think we're better off using the "ft" abbreviation here. The translation uses the singular form in many languages. In Romanian _23 picior_ looks awful, in _fr_, _it_ etc. this should be similar. @biodranik maybe you should decide this. I agree
rsippl commented 2022-02-22 11:53:56 +00:00 (Migrated from github.com)

you're probably right. Would "Eroare de conectare" be a better choice? or can you find something better?

Let's leave it as it is. Seems "conectare" is used as "login" in Romanian, similar to French (to me, to connect is a lower-level operation than to log in)

> you're probably right. Would "Eroare de conectare" be a better choice? or can you find something better? Let's leave it as it is. Seems "conectare" is used as "login" in Romanian, similar to French (to me, to connect is a lower-level operation than to log in)
rsippl commented 2022-02-22 12:00:04 +00:00 (Migrated from github.com)
[hour]
    tags = android
    en = h
    it = o
    ro = o

I'm quite sure this isn't right, neither in ro nor in it. @owhyy if you agree, please delete both.

``` [hour] tags = android en = h it = o ro = o ``` I'm quite sure this isn't right, neither in _ro_ nor in _it_. @owhyy if you agree, please delete both.
biodranik commented 2022-02-22 13:49:28 +00:00 (Migrated from github.com)

I think we're better off using the "ft" abbreviation here. The translation uses the singular form in many languages. In Romanian 23 picior looks awful, in fr, it etc. this should be similar. @biodranik maybe you should decide this.

Yes, just leave it untranslated and default en translation will be used. Or insert ft for clarity. The main idea is that it should be recognizable by someone speaking Romanian.

> I think we're better off using the "ft" abbreviation here. The translation uses the singular form in many languages. In Romanian _23 picior_ looks awful, in _fr_, _it_ etc. this should be similar. @biodranik maybe you should decide this. Yes, just leave it untranslated and default en translation will be used. Or insert ft for clarity. The main idea is that it should be recognizable by someone speaking Romanian.
biodranik (Migrated from github.com) reviewed 2022-02-22 13:51:14 +00:00
@ -2401,3 +2400,4 @@
it = Divertimento in famiglia
ja = 家族の休日
ko = 가족 기념일
nb = Familieferie
biodranik (Migrated from github.com) commented 2022-02-22 13:51:14 +00:00

Please don't forget that all these changes should be also reflected in data/categories.txt file (see comment = above):
comment = Search category for water park/disneyland/playground/toys store; any changes should be duplicated in categories.txt @children!

Please don't forget that all these changes should be also reflected in data/categories.txt file (see comment = above): `comment = Search category for water park/disneyland/playground/toys store; any changes should be duplicated in categories.txt @children!`
rsippl commented 2022-02-22 13:56:19 +00:00 (Migrated from github.com)
[subtittle_opt_out]
    tags = android
    en = Tracking settings
    ro = Opțiuni traseu

I think that "traseu" here (which means route) should be replaced with "tracking" or something equivalent. This is used as a menu subtitle on the settings page, AFAIK it's used for choosing between the Android and the Google location services. The latter are likely more precise but have implications with respect to tracking.

``` [subtittle_opt_out] tags = android en = Tracking settings ro = Opțiuni traseu ``` I think that "traseu" here (which means route) should be replaced with "tracking" or something equivalent. This is used as a menu subtitle on the settings page, AFAIK it's used for choosing between the Android and the Google location services. The latter are likely more precise but have implications with respect to tracking.
rsippl commented 2022-02-22 15:07:46 +00:00 (Migrated from github.com)
[access_rules_author_only]
    en = Online editing
    ...
    it = Modifica online
    ...
    ro = Modifică în internet

@owhyy I think "Modifică online" is better.

[avoid_unpaved]
    tags = android,ios
    en = Unpaved roads
    ...
    ro = Drum neasfaltat

Plural is needed here, "Drumuri neasfaltate". Similarly, in the [avoid_ferry] section, "Trecere cu bac" -> "Treceri cu bac".

[then_turn]
    en = Then
    it = Poi
    ...
    ro = După

If this is for voice instructions, then I think "Apoi" would make more sense.

[week_ago_sorttype]
    ...
    ro = Acum o săptămînă

săptămână

[isolines_toast_zooms_1_10]
    tags = android,ios
    en = Zoom in to explore isolines
    ...
    es = Amplía el mapa para ver las isolíneas
    ...
    it = Ingrandisci mappa per vedere l'isolinea
    ...
    pt = Amplie o mapa para ver as curvas de nível
    ...
    ro = Mărește harta pentru a vedea contururile

"contururile" is too generic. How about "izoliniile" (or "cotele", or "curbele de nivel", not sure which one is used more).

``` [access_rules_author_only] en = Online editing ... it = Modifica online ... ro = Modifică în internet ``` @owhyy I think "Modifică online" is better. ``` [avoid_unpaved] tags = android,ios en = Unpaved roads ... ro = Drum neasfaltat ``` Plural is needed here, "Drumuri neasfaltate". Similarly, in the [avoid_ferry] section, "Trecere cu bac" -> "Treceri cu bac". ``` [then_turn] en = Then it = Poi ... ro = După ``` If this is for voice instructions, then I think "Apoi" would make more sense. ``` [week_ago_sorttype] ... ro = Acum o săptămînă ``` săptămână ``` [isolines_toast_zooms_1_10] tags = android,ios en = Zoom in to explore isolines ... es = Amplía el mapa para ver las isolíneas ... it = Ingrandisci mappa per vedere l'isolinea ... pt = Amplie o mapa para ver as curvas de nível ... ro = Mărește harta pentru a vedea contururile ``` "contururile" is too generic. How about "izoliniile" (or "cotele", or "curbele de nivel", not sure which one is used more).
pastk reviewed 2022-02-22 15:13:52 +00:00
pastk left a comment
Owner

Wow, you are doing great job here! I like the teamwork that's going on here!

For the terms with not a very clear meaning (the ones you asked for clarification above) please add/update comment = - it will help other translators a lot!

Wow, you are doing great job here! I like the teamwork that's going on here! For the terms with not a very clear meaning (the ones you asked for clarification above) please add/update `comment =` - it will help other translators a lot!
rsippl commented 2022-02-23 08:08:00 +00:00 (Migrated from github.com)

Good catch ;)

I was talking about "Primăvară" -> "Izvor" :)

Overall, extremely good work, @owhyy, thank you. @biodranik, LGTM. Thanks guys!

> Good catch ;) I was talking about "Primăvară" -> "Izvor" :) Overall, extremely good work, @owhyy, thank you. @biodranik, LGTM. Thanks guys!
owhyy commented 2022-02-23 08:24:02 +00:00 (Migrated from github.com)

Good catch ;)

I was talking about "Primăvară" -> "Izvor" :)

Overall, extremely good work, @owhyy, thank you. @biodranik, LGTM. Thanks guys!

Thank you! You did just as much work as I did :)

> > Good catch ;) > > I was talking about "Primăvară" -> "Izvor" :) > > Overall, extremely good work, @owhyy, thank you. @biodranik, LGTM. Thanks guys! Thank you! You did just as much work as I did :)
biodranik (Migrated from github.com) reviewed 2022-02-23 14:29:08 +00:00
biodranik (Migrated from github.com) commented 2022-02-23 14:29:08 +00:00

There is also data/strings/types_strings.txt with types translations. It would be better if here, in categories, will be at least the same string that is used in types_strings.txt (plus some more synonyms that people can type).
We plan to refactor to avoid duplication in the future, but now, unfortunately, there is no other way.

There is also data/strings/types_strings.txt with types translations. It would be better if here, in categories, will be at least the same string that is used in types_strings.txt (plus some more synonyms that people can type). We plan to refactor to avoid duplication in the future, but now, unfortunately, there is no other way.
owhyy (Migrated from github.com) reviewed 2022-02-23 16:52:40 +00:00
owhyy (Migrated from github.com) commented 2022-02-23 16:52:39 +00:00

There is also data/strings/types_strings.txt with types translations. It would be better if here, in categories, will be at least the same string that is used in types_strings.txt (plus some more synonyms that people can type). We plan to refactor to avoid duplication in the future, but now, unfortunately, there is no other way.

okay, so if I understand correctly, I need to change the types_strings.txt words to match the first word of categories.txt?

> There is also data/strings/types_strings.txt with types translations. It would be better if here, in categories, will be at least the same string that is used in types_strings.txt (plus some more synonyms that people can type). We plan to refactor to avoid duplication in the future, but now, unfortunately, there is no other way. okay, so if I understand correctly, I need to change the types_strings.txt words to match the first word of categories.txt?
biodranik (Migrated from github.com) reviewed 2022-02-23 17:15:11 +00:00
biodranik (Migrated from github.com) commented 2022-02-23 17:15:11 +00:00

types_strings contains texts that are visible to users. Users expect that these visible types (we sometimes call them "categories") will also be searchable. That's why the translation from types_strings should be duplicated in categories.txt (but only if this type should be searchable by users).

types_strings contains texts that are _visible_ to users. Users expect that these _visible_ types (we sometimes call them "categories") will also be searchable. That's why the translation from types_strings should be duplicated in categories.txt (but only if this type should be _searchable_ by users).
pastk requested changes 2022-02-23 19:03:07 +00:00

"spital" is defined in a @hospital search group already, its better not to duplicate it here

"spital" is defined in a `@hospital` search group already, its better not to duplicate it here

The @post search group is used for postboxes and parcel lockers also, so it will be inappropriate to display parcel lockers amongst search results if someone used an "oficiu poștal" alias.
Please add this alias directly to amenity-post_office type instead.

The `@post` search group is used for postboxes and parcel lockers also, so it will be inappropriate to display parcel lockers amongst search results if someone used an "oficiu poștal" alias. Please add this alias directly to `amenity-post_office` type instead.

just "A unit of measure" is enough, what do you think?

just "A unit of measure" is enough, what do you think?
pastk approved these changes 2022-02-24 08:29:13 +00:00

Here "spital" is redundant also, because its defined in @hospital already (at line 3450).

Here "spital" is redundant also, because its defined in `@hospital` already (at line 3450).
rsippl commented 2022-02-25 08:18:36 +00:00 (Migrated from github.com)

@owhyy would you please join the discussion at organicmaps/organicmaps#1797, the pull request there concerns Romanian translation conflicting with this one, and a native speaker would be of great help there (I do speak RO but I don't consider myself native). Thank you!

@owhyy would you please join the discussion at https://git.omaps.dev/organicmaps/organicmaps/pulls/1797, the pull request there concerns Romanian translation conflicting with this one, and a native speaker would be of great help there (I do speak RO but I don't consider myself native). Thank you!
biodranik (Migrated from github.com) approved these changes 2022-03-06 17:00:48 +00:00
pastk reviewed 2022-03-06 17:11:20 +00:00

please update it in types_strings.txt too

please update it in types_strings.txt too
pastk reviewed 2022-03-06 17:14:25 +00:00

Nevermind, I'll fix it in a separate commit

Nevermind, I'll fix it in a separate commit
This repo is archived. You cannot comment on pull requests.
No reviewers
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#2174
No description provided.