Editor: existing object is updated instead of creation of a new one #2298

New issue

Closed

opened 2022-03-27 16:29:43 +00:00 by dbf256 · 7 comments

dbf256 commented

2022-03-27 16:29:43 +00:00

(Migrated from github.com)

Find a POI object on map, zoom to it
In menu choose Add new place
Add a new place, put a cross onto existing POI
Instead of a new POI, existing one is updated with tags from new one. For example, check version '3' in https://www.openstreetmap.org/node/5418889456/history - cafe is merged with sports shop

1. Find a POI object on map, zoom to it 2. In menu choose Add new place 3. Add a new place, put a cross onto existing POI 4. Instead of a new POI, existing one is updated with tags from new one. For example, check version '3' in https://www.openstreetmap.org/node/5418889456/history - cafe is merged with sports shop

👍 1

biodranik commented

2022-03-27 17:34:35 +00:00

(Migrated from github.com)

Creating a POI at the same place where another POI is already located doesn't look right. Better behavior would be to disable this scenario or avoid it.

Timmy-Tesseract commented

2022-10-13 00:13:31 +00:00

(Migrated from github.com)

This happened to me twice by accident yesterday.

A bakery that went out of business was replaced by a restaurant. Because OM doesn't allow for change of main tag I wanted to create a new node right next to old POI with intention of deleting old POI later in JOSM. This resulted in name being overwritten but amenity=restaurant additionally added to shop=bakery. I didn't even intentionally put location exactly on existing POI but because the building has a very high POI density it was still close enough to cause updating the existing POI instead of creating new one.

https://www.openstreetmap.org/node/1437310148/history

The second time an existing POI was in wrong location (should have been on the other side of the building) so I had to create new POI very close to it. This again caused an unintended overwrite of existing POI.

https://www.openstreetmap.org/node/7127363186/history

I think if "add new place" is selected OM should always create a new POI even if node coordinates are almost identical with existing POI.

This happened to me twice by accident yesterday. A bakery that went out of business was replaced by a restaurant. Because OM doesn't allow for change of main tag I wanted to create a new node right next to old POI with intention of deleting old POI later in JOSM. This resulted in name being overwritten but amenity=restaurant additionally added to shop=bakery. I didn't even intentionally put location exactly on existing POI but because the building has a very high POI density it was still close enough to cause updating the existing POI instead of creating new one. https://www.openstreetmap.org/node/1437310148/history The second time an existing POI was in wrong location (should have been on the other side of the building) so I had to create new POI very close to it. This again caused an unintended overwrite of existing POI. https://www.openstreetmap.org/node/7127363186/history I think if "add new place" is selected OM should always create a new POI even if node coordinates are almost identical with existing POI.

biodranik commented

2022-10-23 22:58:21 +00:00

(Migrated from github.com)

I think if "add new place" is selected OM should always create a new POI even if node coordinates are almost identical with existing POI.

What about duplicate features? One of the popular cases is when several users add the same place from Organic Maps independently from each other.

> I think if "add new place" is selected OM should always create a new POI even if node coordinates are almost identical with existing POI. What about duplicate features? One of the popular cases is when several users add the same place from Organic Maps independently from each other.

dbf256 commented

2022-10-24 05:25:58 +00:00

(Migrated from github.com)

What about duplicate features? One of the popular cases is when several users add the same place from Organic Maps independently from each other.

This case is when POI is not available yet in Organic Maps but is in Openstreetmap I think? In this case 'merge' function in Organic Maps will not help as it is not aware about it.

> > What about duplicate features? One of the popular cases is when several users add the same place from Organic Maps independently from each other. This case is when POI is not available yet in Organic Maps but is in Openstreetmap I think? In this case 'merge' function in Organic Maps will not help as it is not aware about it.

biodranik commented

2022-10-24 07:45:13 +00:00

(Migrated from github.com)

The most popular case: several OM users try to add the same place. Until they update the map data from OSM, they won't see that the place was already added. More frequent map updates will improve the situation but not fix it completely. So the better approach is to make a smarter "merge" algorithm that knows about different types and can decide properly when a feature should be merged/updated or not. Why is it important? Because someone can input only the type and name, someone else can also add opening hours, etc.

Timmy-Tesseract commented

2022-10-28 04:53:02 +00:00

(Migrated from github.com)

Maybe merge function could be limited to instances where new and existing POI have identical name? This should pretty much eliminate accidental overwrite of still existing POIs.

biodranik commented

2022-10-28 12:11:40 +00:00

(Migrated from github.com)

What about identical types (also with a missing name, for example)? Or with a typo in the name (or minor difference - space, dash, ' or ")?

This repo is archived. You cannot comment on issues.