"TypeAlwaysExists" POIs have wrong render priority #2332

New issue

Open

opened 2022-04-01 17:44:16 +00:00 by pastk · 1 comment

pastk commented

2022-04-01 17:44:16 +00:00

Owner

This hotel is displayed instead of surrounding POIs (a charging station and a cafe) which have a higher priority.

See screens 1 and 2:

It also makes the cafe's POI "blink" - which is annoying - a cafe is displayed at z15, then it disappears at z16-17 (because displaced by the hotel which is rendered from z16-), and appears again at z18 (because there is space to display both POIs).

I/MapsmeCore: drape/overlay_tree.cpp:232 InsertHandle()  Text Priority(ff0001c44a000d00) 9-18446744073709551615-0 Pervyy poyezd
I/MapsmeCore: drape/overlay_tree.cpp:555 StoreDisplacementInfo()  Displace ( 2 ): Text Priority(ff0001c44a000d00) 9-18446744073709551615-0 Pervyy poyezd -> POI Priority(f00001c7ee00ffff) 150034-18446744073709551615-0
I/MapsmeCore: drape/overlay_tree.cpp:555 StoreDisplacementInfo()  Displace ( 2 ): Text Priority(ff0001c44a000d00) 9-18446744073709551615-0 Pervyy poyezd -> POI Priority(f10001c7a000ffff) 85847-18446744073709551615-0

As seen in the log hotel's priority starts with ff which means its minVisibilityScale is 0, which is wrong.

This is because the hotel has internet_access making TypeAlwaysExists() return true and consequently that makes GetMinDrawableScale() return 0.

When internet_access is removed from TypeAlwaysExists() then priorities are fixed, see the 3rd screen above.

We've added recycling and organic tags recently into TypeAlwaysExists() hence all POIs with these tags will hijack rendering priority too.
I don't know why TypeAlwaysExists() is used in drawing priority calculation, but it looks wrong (or maybe tags like internet_access and organic shouldn't be processed there).

[This hotel](https://www.openstreetmap.org/node/4168059149) is displayed instead of surrounding POIs (a charging station and a cafe) which have a higher priority. See screens 1 and 2: ![poi-priority](https://user-images.githubusercontent.com/18434508/161312728-71b249bc-69e6-4800-9d71-9cc3f0409e71.png) It also makes the cafe's POI "blink" - which is annoying - a cafe is displayed at z15, then it disappears at z16-17 (because displaced by the hotel which is rendered from z16-), and appears again at z18 (because there is space to display both POIs). ``` I/MapsmeCore: drape/overlay_tree.cpp:232 InsertHandle() Text Priority(ff0001c44a000d00) 9-18446744073709551615-0 Pervyy poyezd I/MapsmeCore: drape/overlay_tree.cpp:555 StoreDisplacementInfo() Displace ( 2 ): Text Priority(ff0001c44a000d00) 9-18446744073709551615-0 Pervyy poyezd -> POI Priority(f00001c7ee00ffff) 150034-18446744073709551615-0 I/MapsmeCore: drape/overlay_tree.cpp:555 StoreDisplacementInfo() Displace ( 2 ): Text Priority(ff0001c44a000d00) 9-18446744073709551615-0 Pervyy poyezd -> POI Priority(f10001c7a000ffff) 85847-18446744073709551615-0 ``` As seen in the log hotel's priority starts with `ff` which means its `minVisibilityScale` is 0, which is wrong. This is because the hotel has `internet_access` making `TypeAlwaysExists()` return true and consequently that makes `GetMinDrawableScale()` return 0. When `internet_access` is removed from `TypeAlwaysExists()` then priorities are fixed, see the 3rd screen above. We've added `recycling` and `organic` tags recently into `TypeAlwaysExists()` hence all POIs with these tags will hijack rendering priority too. I don't know why `TypeAlwaysExists()` is used in drawing priority calculation, but it looks wrong (or maybe tags like `internet_access` and `organic` shouldn't be processed there).

pastk commented

2022-04-01 17:44:34 +00:00

Author

Owner

@vng

This repo is archived. You cannot comment on issues.