[strings] Added Euskara (eu) translations #2335

dvdmrtnz · 2022-04-02T09:30:08Z

dvdmrtnz commented

2022-04-02 09:30:08 +00:00

I added Euskara (eu) translations on data/categories.txt, data/strings/strings.txt, and data/strings/types_strings.txt.

I tried to run the ./tools/unix/generate_localizations.sh script but no files were generated with the Euskara translations. I guess it is because it is a new language.

What else do I need to do to add Euskara as a new language?

I added Euskara (eu) translations on `data/categories.txt`, `data/strings/strings.txt`, and `data/strings/types_strings.txt`. I tried to run the `./tools/unix/generate_localizations.sh` script but no files were generated with the Euskara translations. I guess it is because it is a new language. What else do I need to do to add Euskara as a new language?

biodranik commented

2022-04-02 09:43:49 +00:00

(Migrated from github.com)

Many other files should be changed as well.

Is basque language supported in iOS and Android? How to enable it?

Many other files should be changed as well. Is basque language supported in iOS and Android? How to enable it?

pastk commented

2022-04-02 09:45:13 +00:00

What else do I need to do to add Euskara as a new language?

For iOS please check this commit organicmaps/organicmaps#912/files
Probably you need to do it via Xcode.. @biodranik can advice the details

For both iOS and android you need to create localization folders for Euskara manually first (e.g. android/res/values-eu/).
Or run Twine with --create-folders options (its run in the bottom of the tools/unix/generate_localizations.sh script).

> > What else do I need to do to add Euskara as a new language? For iOS please check this commit https://git.omaps.dev/organicmaps/organicmaps/pulls/912/files#diff-971cf1e5ff9bebd47aff357857614bea60d35aeb08d592989b47582266e98d80 Probably you need to do it via Xcode.. @biodranik can advice the details For both iOS and android you need to create localization folders for Euskara manually first (e.g. `android/res/values-eu/`). Or run Twine with `--create-folders` options (its run in the bottom of the `tools/unix/generate_localizations.sh` script).

dvdmrtnz commented

2022-04-02 10:03:47 +00:00

Many other files should be changed as well.

Is basque language supported in iOS and Android? How to enable it?

Yes, it works both on iOS and Android.

For example, here is the Android system language selection:

And here is the iOS app language selection for OsmAnd:

> Many other files should be changed as well. > > Is basque language supported in iOS and Android? How to enable it? Yes, it works both on iOS and Android. For example, here is the Android system language selection: ![](https://user-images.githubusercontent.com/47610359/161378172-6248ce36-0109-4aac-a073-71f652f79d29.jpg) And here is the iOS app language selection for OsmAnd: ![](https://user-images.githubusercontent.com/47610359/161378163-58b61efe-7bd7-459e-ab60-bdb6d87d796c.jpeg)

biodranik commented

2022-04-02 12:15:37 +00:00

(Migrated from github.com)

There are several places where new translations should be enabled. But to do it, please add all missing translations into files listed here: https://github.com/organicmaps/organicmaps/blob/master/docs/TRANSLATIONS.md

dvdmrtnz commented

2022-04-03 15:30:28 +00:00

I added translations on:

data/categories_cuisines.txt
data/strings/sounds.txt
iphone/plist.txt
data/countries_names.txt

Any other file that should be translated?

I added translations on: * `data/categories_cuisines.txt` * `data/strings/sounds.txt` * `iphone/plist.txt` * `data/countries_names.txt` Any other file that should be translated?

pastk reviewed 2022-04-03 16:16:56 +00:00

pastk left a comment

I checked the files briefly.
Wow, that's a tremendous work, thanks!!

I checked the files briefly. Wow, that's a tremendous work, thanks!!

data/categories_cuisines.txt

pastk commented

2022-04-03 16:09:43 +00:00

Should start from a capital?

dvdmrtnz reviewed 2022-04-03 18:52:12 +00:00

data/categories_cuisines.txt

dvdmrtnz commented

2022-04-03 18:52:12 +00:00

Fixed! Thanks!

pastk commented

2022-04-09 12:33:23 +00:00

A new language should be added into indexer/categories_holder.hpp definitely and also folders holding android and ios localization files should be created manually (see my previous posts here).

A new language should be added into `indexer/categories_holder.hpp` definitely and also folders holding android and ios localization files should be created manually (see my previous posts here).

dvdmrtnz commented

2022-04-10 14:11:20 +00:00

I added eu to indexer/categories_holder.hpp and added the iOS and Android localization folders.

However, I don’t have access to a macOS machine so I can’t add the language on the Xcode project.

I added eu to `indexer/categories_holder.hpp` and added the iOS and Android localization folders. However, I don’t have access to a macOS machine so I can’t add the language on the Xcode project.

biodranik (Migrated from github.com) reviewed 2022-04-10 20:10:04 +00:00

biodranik (Migrated from github.com) left a comment

Thanks a lot for your work! I'll enable the language in iOS before the merge.

You made searchable categories (like food, gas, etc.) in categories.txt and strings.txt equal, right?

Can you please also try to download, unzip and install this debug apk to test if your changes are working correctly? https://github.com/organicmaps/organicmaps/suites/6064429391/artifacts/209481843

Thanks a lot for your work! I'll enable the language in iOS before the merge. You made searchable categories (like food, gas, etc.) in categories.txt and strings.txt equal, right? Can you please also try to download, unzip and install this debug apk to test if your changes are working correctly? https://github.com/organicmaps/organicmaps/suites/6064429391/artifacts/209481843

indexer/categories_holder.hpp

					
				@ -114,0 +109,4 @@

				      {"sv", 32},

				      {"sw", 33},

				      {"th", 34},

				      {"tr", 35},

biodranik (Migrated from github.com) commented

2022-04-10 20:03:33 +00:00

Let's sort them by name. I know, it's annoying, we'll refactor it in the future.

dvdmrtnz commented

2022-04-10 23:36:24 +00:00

Thanks a lot for your work! I'll enable the language in iOS before the merge.

You made searchable categories (like food, gas, etc.) in categories.txt and strings.txt equal, right?

Yes I did make sure that they are the same

Can you please also try to download, unzip and install this debug apk to test if your changes are working correctly? https://github.com/organicmaps/organicmaps/suites/6064429391/artifacts/209481843

Translations seem to be working fine except for the countries/regions names on the download maps section of the app. They are showing in English. Why could this be?

> Thanks a lot for your work! I'll enable the language in iOS before the merge. > > You made searchable categories (like food, gas, etc.) in categories.txt and strings.txt equal, right? Yes I did make sure that they are the same > Can you please also try to download, unzip and install this debug apk to test if your changes are working correctly? https://github.com/organicmaps/organicmaps/suites/6064429391/artifacts/209481843 Translations seem to be working fine except for the countries/regions names on the download maps section of the app. They are showing in English. Why could this be?

biodranik commented

2022-04-11 05:50:08 +00:00

(Migrated from github.com)

Translations seem to be working fine except for the countries/regions names on the download maps section of the app. They are showing in English. Why could this be?

Please create a corresponding eu folder in data/countries-strings/ and run tools/unix/generate_localizations.sh, these folders are not created automatically to avoid the generation of partially translated and not fully enabled languages.

> Translations seem to be working fine except for the countries/regions names on the download maps section of the app. They are showing in English. Why could this be? Please create a corresponding eu folder in data/countries-strings/ and run tools/unix/generate_localizations.sh, these folders are not created automatically to avoid the generation of partially translated and not fully enabled languages.

biodranik commented

2022-04-11 05:58:16 +00:00

(Migrated from github.com)

Also create eu.json folder in data/sound-strings/ and regenerate translations.

Also create `eu.json` folder in `data/sound-strings/` and regenerate translations.

dvdmrtnz reviewed 2022-04-11 16:29:21 +00:00

indexer/categories_holder.hpp

					
				@ -114,0 +109,4 @@

				      {"sv", 32},

				      {"sw", 33},

				      {"th", 34},

				      {"tr", 35},

dvdmrtnz commented

2022-04-11 16:29:20 +00:00

Done

pastk approved these changes 2022-04-11 16:52:37 +00:00

biodranik commented

2022-04-11 17:46:16 +00:00

(Migrated from github.com)

I've created PR with iOS fixes https://github.com/dvdmrtnz/organicmaps/pull/1

pastk approved these changes 2022-04-11 19:21:20 +00:00

biodranik commented

2022-04-11 22:20:34 +00:00

(Migrated from github.com)

Thank you very much for your contribution! We already started maps generation, so eu lang on the map will not appear in the upcoming update, only in the next one.