Buggy handling of interrupted map downloads #2436

New issue

Open

opened 2022-04-21 16:30:27 +00:00 by pastk · 3 comments

pastk commented

2022-04-21 16:30:27 +00:00

Member

Map size for interrupted download is always shown as "1 MB" (expected: actual map size to download)
If there is a single interrupted map inside of a big country, then a tap on the "!" (error) country icon tries to download a whole country (or at least free space estimation is done for the whole country), expected: resume interrupted maps only inside this country.
If interrupted download is cancelled by the user then temp files are not deleted.
If there was an interrupted update then the map will look like not downloaded at all and the "Update All" button changes to "Download All"
If there were interrupted downloads and maps were moved (e.g. from SD to internal) then some temp files (*.mwm.ready.downloading) are left at the source storage
If a download has interrupted because of lack of space (e.g. some other app used the space that was reserved for downloader) then an error "Download has failed. Please check your settings and make sure you are connected to Internet. Cancel / Retry" appears, but it should be a "Not enough space" error

Details and steps to reproduce.
(to emulate download interruption turn off cellular data in android settings while download is in progress, after a bit of time an error will be shown and map's icon will change to the red "!")

"1 MB" and temp files case:

Start map downloading
Interrupt
Map's size will change to "1 MB" and the icon will change to a red "!"
Long tap on the map and choose "cancel"
The map will disappear from the downloader screen
Check map files folder, there will be corresponding *.mwm.ready.downloading and *.mwm.ready.resume temp files

Wrong free space estimation case:

Start a small single map download from a big country (e.g. Russia), ensure you don't have enough storage space for the whole country.
Interrupt
Go back to the list of downloaded maps
The whole country will have a red "!" icon and there will be a "Download All" button in the bottom
Tap on country's icon
An "insufficient space" error will be shown, as like the downloader is trying to download a whole country
Go inside of the country again (tap on country name)
Tap on interrupted map icon
The download will resume (free space requirement is estimated properly)

Updates case:

Start maps updating via "Update All"
Interrupt
All updates will get a red "!" icon, a button in the bottom will change to "Download All"
Resume update of any interrupted country
Cancel it by tapping a cross icon
All red "!" icons of updatable maps will change back to yellow "update" icons

Everything is tested on Android 5.0 emulator with maps residing on SD card.

- [ ] Map size for interrupted download is always shown as "1 MB" (expected: actual map size to download) - [ ] If there is a single interrupted map inside of a big country, then a tap on the "!" (error) country icon tries to download a whole country (or at least free space estimation is done for the whole country), expected: resume interrupted maps only inside this country. - [ ] If interrupted download is cancelled by the user then temp files are not deleted. - [ ] If there was an interrupted update then the map will look like not downloaded at all and the "Update All" button changes to "Download All" - [ ] If there were interrupted downloads and maps were moved (e.g. from SD to internal) then some temp files (`*.mwm.ready.downloading`) are left at the source storage - [ ] If a download has interrupted because of lack of space (e.g. some other app used the space that was reserved for downloader) then an error "Download has failed. Please check your settings and make sure you are connected to Internet. Cancel / Retry" appears, but it should be a "Not enough space" error Details and steps to reproduce. (to emulate download interruption turn off cellular data in android settings while download is in progress, after a bit of time an error will be shown and map's icon will change to the red "!") "1 MB" and temp files case: 1. Start map downloading 2. Interrupt 3. Map's size will change to "1 MB" and the icon will change to a red "!" 4. Long tap on the map and choose "cancel" 5. The map will disappear from the downloader screen 6. Check map files folder, there will be corresponding `*.mwm.ready.downloading` and `*.mwm.ready.resume` temp files Wrong free space estimation case: 1. Start a small single map download from a big country (e.g. Russia), ensure you don't have enough storage space for the whole country. 2. Interrupt 4. Go back to the list of downloaded maps 5. The whole country will have a red "!" icon and there will be a "Download All" button in the bottom 6. Tap on country's icon 7. An "insufficient space" error will be shown, as like the downloader is trying to download a whole country 8. Go inside of the country again (tap on country name) 9. Tap on interrupted map icon 10. The download will resume (free space requirement is estimated properly) ![interrupted](https://user-images.githubusercontent.com/18434508/164503004-e6eacd4d-af3c-40ff-a2e2-b5e76b95136a.png) Updates case: 1. Start maps updating via "Update All" 2. Interrupt 3. All updates will get a red "!" icon, a button in the bottom will change to "Download All" 4. Resume update of any interrupted country 5. Cancel it by tapping a cross icon 6. All red "!" icons of updatable maps will change back to yellow "update" icons Everything is tested on Android 5.0 emulator with maps residing on SD card.

rtsisyk commented

2023-01-07 09:29:43 +00:00

Owner

Thanks for aggregating all related problems into this mega-ticket!

vrubleg commented

2023-01-08 17:36:01 +00:00

(Migrated from github.com)

Another related bug:

Turn on airplane mode.
Start to download a map.
Remove this not yet downloaded map.
Restart Organic Maps (force close and start again).

The result: Organic Maps shows the removed map in the list and tries to download it again.

Another related bug: 1. Turn on airplane mode. 2. Start to download a map. 3. Remove this not yet downloaded map. 4. Restart Organic Maps (force close and start again). The result: Organic Maps shows the removed map in the list and tries to download it again.

👍 1

biodranik commented

2023-01-08 21:49:19 +00:00

(Migrated from github.com)

Wow, the download is not canceled properly. CC @vng

This repo is archived. You cannot comment on issues.