[Routing] Potential typo in definitions of default speed for ETA #2523

New issue

Open

opened 2022-05-05 11:39:01 +00:00 by AntonM030481 · 3 comments

AntonM030481 commented

2022-05-05 11:39:01 +00:00

(Migrated from github.com)

104a03ab59/routing_common/car_model_coefs.hpp (L46)
I suppose it should be:
{HighwayType::HighwayResidential, InOutCitySpeedKMpH({20.00, 20.00} /* in city */, {26.00, 26.00} /* out city */)},

https://github.com/organicmaps/organicmaps/blob/104a03ab59f42429c3bde92aeb61ed947c89f538/routing_common/car_model_coefs.hpp#L46 I suppose it should be: `{HighwayType::HighwayResidential, InOutCitySpeedKMpH({20.00, 20.00} /* in city */, {26.00, 26.00} /* out city */)},`

AntonM030481 commented

2022-05-06 07:09:49 +00:00

(Migrated from github.com)

As a result speed of HighwayResidential for ETA estimations is higher than for edge weight.
This is agains the general rule.

As a result speed of HighwayResidential for ETA estimations is higher than for edge weight. This is agains the general rule.

vng commented

2022-05-10 19:30:58 +00:00

(Migrated from github.com)

Well, in general it's ok when edge's weight is different from edge's eta.
Right here I can't say for sure is it good or bad. But we definitely should review default speeds for all profiles ..

Well, in general it's ok when edge's weight is different from edge's eta. Right here I can't say for sure is it good or bad. But we definitely should review default speeds for all profiles ..

AntonM030481 commented

2022-05-11 07:37:50 +00:00

(Migrated from github.com)

Sure it can be different.
I was just surprised +30% and the fact, that the next number is 26 too.
So for me it looks like copy-paste mistake.

Sure it can be different. I was just surprised +30% and the fact, that the next number is 26 too. So for me it looks like copy-paste mistake.

This repo is archived. You cannot comment on issues.