organicmaps/organicmaps-tmp

Archived

Fork 1

[styles] Add bicycle repair station #2691

Closed

j13m126 wants to merge 0 commits from bikeservice into master

j13m126 commented

2022-06-07 23:24:03 +00:00

(Migrated from github.com)

I managed to add amenity=bicycle_repair_station and test it on a small map.

Ad translations: I used Google Translate to translate "bicycle repair station" in types_strings.txt and "bicycle repair" additionally in categories.txt.

Ad icons: I rotated and placed this wrench above the bike.

I didn't add rendering/visibility rules to data/styles/vehicle/include/Icons.mapcss because I didn't see any rules for bicycle_parking or bike_rental either.

The only thing I didn't do (of the howto) is adding/fixing the current classifier tests.

I'm gonna relax and wait (for your review) now :)

I managed to add amenity=bicycle_repair_station and test it on a small map. ![grafik](https://user-images.githubusercontent.com/7961926/172497969-08a57c4b-4211-481b-87ab-a17986cf30ea.png) Ad translations: I used Google Translate to translate "bicycle repair station" in `types_strings.txt` and "bicycle repair" additionally in `categories.txt`. Ad icons: I rotated and placed this [wrench](https://fonts.google.com/icons?selected=Material%20Icons%20Outlined%3Abuild%3A) above the bike. I didn't add rendering/visibility rules to `data/styles/vehicle/include/Icons.mapcss` because I didn't see any rules for bicycle_parking or bike_rental either. The only thing I didn't do (of the [howto](https://github.com/organicmaps/organicmaps/blob/master/docs/STYLES.md#how-to-add-a-new-map-feature--poi-type)) is adding/fixing the current classifier tests. I'm gonna relax and wait (for your review) now :)

pastk requested changes 2022-06-08 15:26:46 +00:00

pastk left a comment

Owner

The wrench on the icon looks very similar to the key on the bike rental icon.
Also the surrounding circle is not needed - its not a business.
Maybe use/adapt an icon from OSM wiki?

The wrench on the icon looks very similar to the key on the bike rental icon. Also the surrounding circle is not needed - its not a business. Maybe use/adapt [an icon](https://wiki.openstreetmap.org/wiki/File:Bicycle_repair_station-14.svg) from OSM wiki?

data/categories.txt

pastk commented

2022-06-08 15:22:59 +00:00

Owner

I think 3repair is too general, so should be used in combination with bicycle only.
E.g. you can use 4repair of bicycles.
bicycle repair is not necessary because 4Bicycle Repair Station covers it already.

I think `3repair` is too general, so should be used in combination with `bicycle` only. E.g. you can use `4repair of bicycles`. `bicycle repair` is not necessary because `4Bicycle Repair Station` covers it already.

j13m126 commented

2022-06-08 16:34:33 +00:00

(Migrated from github.com)

The wrench on the icon looks very similar to the key on the bike rental icon. Also the surrounding circle is not needed - its not a business. Maybe use/adapt an icon from OSM wiki?

I agree, it might look too similar. I'll replace the wrench with the one you suggested, remove the background and share it. For consistency, I think we shouldn't use a different icon for the bike.

> The wrench on the icon looks very similar to the key on the bike rental icon. Also the surrounding circle is not needed - its not a business. Maybe use/adapt [an icon](https://wiki.openstreetmap.org/wiki/File:Bicycle_repair_station-14.svg) from OSM wiki? I agree, it might look too similar. I'll replace the wrench with the one you suggested, remove the background and share it. For consistency, I think we shouldn't use a different icon for the bike.

👍 1

vng commented

2022-06-09 13:43:23 +00:00

(Migrated from github.com)

Please, rebase on fresh master and leave only 3 commits:

[classifier] Added amenity=bicycle-repair-station.
[styles] Regenerated.
[strings] Regenerated.

Please, rebase on fresh master and leave only 3 commits: - [classifier] Added amenity=bicycle-repair-station. - [styles] Regenerated. - [strings] Regenerated.

👍 1

j13m126 commented

2022-06-09 22:13:10 +00:00

(Migrated from github.com)

What do you think?

What do you think? ![Bildschirmfoto vom 2022-06-10 00-37-50](https://user-images.githubusercontent.com/7961926/172956994-2d2644bd-717a-452c-99c6-c85be241e859.png) ![Bildschirmfoto vom 2022-06-10 00-38-19](https://user-images.githubusercontent.com/7961926/172957004-e5c560b7-8ef4-4de8-b5db-c1a82b529842.png)

pastk approved these changes 2022-06-10 10:46:35 +00:00

pastk left a comment

Owner

The icon looks great now, thanks!

vng commented

2022-06-11 08:42:28 +00:00

(Migrated from github.com)

@j13m126 I can help you to rebase and organize commits.

This repo is archived. You cannot comment on pull requests.

No reviewers

pastk