[search] Make all existing sports searchable #2740
Labels
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
2 participants
Due date
No due date set.
Dependencies
No dependencies set.
Reference: organicmaps/organicmaps-tmp#2740
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "sports_search"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I used Google Translate to add all missing sports translations for a couple of languages.
Cricket and Bowls translations are incomplete because 🦗 and 🥣.
Just to be sure, these are the languages I used:
ar:arabic
cs:czech
da:danish
de:german
el:greek
es:spanish
es-mx:spanish
eu:baskan
fa:persian
fi:finnish
fr:french
hu:hungarian
id:indonesian
it:italian
ja:japanese
ko:korean
mr:marathi
nb:norwegian
nl:dutch
pl:polish
pt:portuguese
pt-BR:portuguese
ro:romanian
ru:russian
sk:slovak
sv:swedish
sw:swahili
th:thai
tr:turkish
uk:ukrainian
vi:vietnamese
zh-Hans:simplified chinese
zh-Hant:traditional chinese
#2511
Please add missing be translations.
@pastk please proof-read and fix that pt-BR bug.
The case should the same as for other translations.
@ -6114,0 +6113,4 @@
it:Football americano
ja:アメリカンフットボール
ko:미식 축구
mr:अमेरिकन फुटबॉल
be:Амерыканскі футбол
Thanks for the translations!
categories.txt
only changes.types_strings.txt
!I wish we have it automated similarly to a google translation script we have!
@ -6157,0 +6240,4 @@
sport-baseball
en:Baseball
ar:البيسبول
be:Бейсбол
ru:Боулз
uk:Боулз
ru:Кёрлинг
I think quite a lot of translations here maybe bogus because its synonymous to "curly-ing".
Pls change to
ru:Место для дайвинга
Місце для дайвінгу
uk:Стрільба
ru:Футбол
Case doesn't really matter for
categories.txt
.Hopefully one day we have an autoformatter for it!
Btw, you can double-check your list of languages by running
tools/python/strings_utils.py -pl -t
, basically all languages with a lot of existing translations could be considered as "supported".Alright, thanks for all the corrections.
This is what I did:
I'll update translations in
types_strings.txt
in another PR, if you don't mind. That might take a while.Please remove the regenerate commit.
I checked a wikipedia article on Australian Football and its not Rugby, its a separate kind of sport!
@ -6157,0 +6240,4 @@
sport-baseball
en:Baseball
ar:البيسبول
be:Бейсбол
Please remove it, its deprecated and just ~100 uses worldwide.
It was quite a lot of work to do, thanks a lot!!
@pastk @vng
Please double-check all pt (Portuguese) translations with DeepL. Google doesn't support pt-PT, only pt-BR.
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
If the translation is the same as the base lang (es or pt), then it should not be overridden. @pastk right?
@ -6157,0 +6293,4 @@
id:Bola basket
it:Pallacanestro
ja:バスケットボール
ko:농구
@vng @pastk are these new and old types added into the generalized category like "sport(s)"?
@ -6157,0 +6713,4 @@
el:Κολύμβηση
es:Natación
eu:Igeriketa
fa:شنا
en:Football
en-US:Soccer
@pastk @vng do we support it?
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
Its not necessary anymore, but it won't hurt either.
Our translation files are full of duplicates like this from the [recent] times when duplicating was mandatory.
It should be deduplicated by an autoformatting script some day.
@ -6157,0 +6713,4 @@
el:Κολύμβηση
es:Natación
eu:Igeriketa
fa:شنا
yes
@ -6157,0 +6293,4 @@
id:Bola basket
it:Pallacanestro
ja:バスケットボール
ko:농구
there is no such category yet
@ -6157,0 +6293,4 @@
id:Bola basket
it:Pallacanestro
ja:バスケットボール
ko:농구
@vng can you add it?
alright
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
There is no reason to create new duplicates and support them. Fewer lines = easier support.
@ -6157,0 +6293,4 @@
id:Bola basket
it:Pallacanestro
ja:バスケットボール
ko:농구
Can be done in this PR, the same as
@food
or any other in this file.@ -6157,0 +6293,4 @@
id:Bola basket
it:Pallacanestro
ja:バスケットボール
ko:농구
What will be a use case for such a category though?
I can see people searching for e.g. a sports venue or a sports ground / fitness station around, but why looking for a list of kinds of sports?
@ -6157,0 +6713,4 @@
el:Κολύμβηση
es:Natación
eu:Igeriketa
fa:شنا
ok, atm it looks like regional languages don't work in
categories.txt
at all@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
True, my point is just its tedious and inefficient to do by hand ("мартышкин труд"), so I would rather accept as is instead of insisting people spend their time on insignificant things which could be fixed later in bulk.
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
Consistency even with minor details makes a good example for other contributors.
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
@biodranik @pastk I can try to create a simple script to de-duplicate non-base strings if base string value is the same to fix existing data. Are you fine with it?
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
@dbf256 That'd be great!
So the de-duplication shall apply to regional languages only, e.g.
es-MX
,en-AU
,pt-BR
etc. See #1757 for a reference. TBH I don't remember ifzh-Hant
/zh-Hans
should follow this rule too or not - need to check...(you may want to re-use that outdated
categories_converter.py
script if its of any value)And then we'll be able to expand the script to add auto-formatting, validation, etc. to categories.txt too!
@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
Also - if you want and you have time - it'll be great to do the same de-duplication to
types_strings.txt
andstrings.txt
, its better to add this functionality to an existing scriptstrings_utils.py
which processes those files.@ -6137,0 +6158,4 @@
pt:Tiro com arco
pt-BR:Tiro com arco
ro:TIR cu arcul
ru:Стрельба из лука
Here is the full picture:
Czech translation looks great! Good job!
This is OK, but I would prefer
Střelba
.Thank you for looking over. I added Střelba.