organicmaps/organicmaps-tmp

Archived

Fork 1

[navigation] populate incoming speed camera place page #2904

Merged

arnaudvergnet merged 2 commits from speed-camera-pp into master

2022-10-06 08:53:11 +00:00

arnaudvergnet commented

2022-07-02 17:27:20 +00:00

(Migrated from github.com)

Adds information in the place page for incoming speed cameras (the ones shown in red).

For the moment, the place page shows the camera position and the title is the max speed if any.

I need help for this one as I have trouble retrieving the speed camera information. The SpeedCameraMark object does not contain a lot of information, and I was not able to retrieve the POI/Feature associated.

Here is what it looks like for the moment:

But here is how regular speed cameras look like:

I would like to retrieve the information from the regular speed camera and integrate it in the SpeedCameraMark but I am lost on how to proceed. Could please help me understand where to look?

Closes #1657

Adds information in the place page for incoming speed cameras (the ones shown in red). For the moment, the place page shows the camera position and the title is the max speed if any. I need help for this one as I have trouble retrieving the speed camera information. The `SpeedCameraMark` object does not contain a lot of information, and I was not able to retrieve the POI/Feature associated. Here is what it looks like for the moment: ![Screenshot_1656782339](https://user-images.githubusercontent.com/80701113/177010218-dcd915ef-9328-43cc-837f-593ad05faf89.png) But here is how regular speed cameras look like: ![Screenshot_1656782706](https://user-images.githubusercontent.com/80701113/177010344-8d5d6546-d034-4607-b04c-01082c1bfdc2.png) I would like to retrieve the information from the regular speed camera and integrate it in the `SpeedCameraMark` but I am lost on how to proceed. Could please help me understand where to look? Closes #1657

biodranik commented

2022-07-08 22:37:51 +00:00

(Migrated from github.com)

I would like to retrieve the information from the regular speed camera and integrate it in the SpeedCameraMark

@vng is it possible?

> I would like to retrieve the information from the regular speed camera and integrate it in the SpeedCameraMark @vng is it possible?

biodranik commented

2022-07-08 22:39:00 +00:00

(Migrated from github.com)

@arnaudvergnet is this UX really needed? Drivers usually don't have time and the opportunity to tap the screen while driving. All camera info should be drawn on the screen automatically or announced via TTS.

👍 1

arnaudvergnet commented

2022-07-09 06:13:06 +00:00

(Migrated from github.com)

@arnaudvergnet is this UX really needed? Drivers usually don't have time and the opportunity to tap the screen while driving. All camera info should be drawn on the screen automatically or announced via TTS.

The target is not the driver but the copilot. Everything you click in OM shows the place page, it would be strange if those speed cameras did not. The infoation people would be certainly looking for is the distance to the camera.

> @arnaudvergnet is this UX really needed? Drivers usually don't have time and the opportunity to tap the screen while driving. All camera info should be drawn on the screen automatically or announced via TTS. The target is not the driver but the copilot. Everything you click in OM shows the place page, it would be strange if those speed cameras did not. The infoation people would be certainly looking for is the distance to the camera.

biodranik commented

2022-07-09 06:17:55 +00:00

(Migrated from github.com)

Generally, yes, info may be displayed.
But cameras are displayed in navigation mode only at the moment, the combination of co-pilot + navigation mode is a rare one, so the priority of that task is definitely not the highest one.

Generally, yes, info may be displayed. But cameras are displayed in navigation mode only at the moment, the combination of co-pilot + navigation mode is a rare one, so the priority of that task is definitely not the highest one.

arnaudvergnet commented

2022-07-09 07:24:09 +00:00

(Migrated from github.com)

Considering how bad the TTS is on phones without Google, I would not say having a copilot is a very rare case. If it is too much work to show the camera info, a quick workaround would be to prevent the empty place page from showing.

biodranik commented

2022-07-09 11:22:30 +00:00

(Migrated from github.com)

Yeah, showing at least something, without much effort and risks to break something, is good enough.

rtsisyk commented

2022-07-23 06:48:53 +00:00

Owner

I didn't get idea of this patch, but it would be nice to display the speed limit on the top of navigation screen.

arnaudvergnet commented

2022-07-23 08:53:34 +00:00

(Migrated from github.com)

I didn't get idea of this patch, but it would be nice to display the speed limit on the top of navigation screen.

In current version of OM when you select an incoming speed camera, it opens an empty place page. This makes the app feel unfinished and impacts user experience. This PR aims to at least fill some information in the place page. If filling information is too difficult, the place page should not be shown.

> I didn't get idea of this patch, but it would be nice to display the speed limit on the top of navigation screen. In current version of OM when you select an incoming speed camera, it opens an empty place page. This makes the app feel unfinished and impacts user experience. This PR aims to at least fill some information in the place page. If filling information is too difficult, the place page should not be shown.

👍 1

vng (Migrated from github.com) approved these changes 2022-09-07 11:15:28 +00:00

rtsisyk approved these changes 2022-09-11 17:06:01 +00:00

biodranik (Migrated from github.com) requested changes 2022-09-11 18:24:33 +00:00

map/framework.cpp

biodranik (Migrated from github.com) commented

2022-09-11 18:24:04 +00:00

Are measurement units displayed? They are necessary.

biodranik commented

2022-09-11 18:25:34 +00:00

(Migrated from github.com)

Speed Camera type text should also be visible.

arnaudvergnet (Migrated from github.com) reviewed 2022-09-11 21:02:36 +00:00

map/framework.cpp

arnaudvergnet (Migrated from github.com) commented

2022-09-11 21:02:35 +00:00

I would love to display those but I don't know how to retrieve them

biodranik (Migrated from github.com) reviewed 2022-09-11 21:23:24 +00:00

map/framework.cpp

biodranik (Migrated from github.com) commented

2022-09-11 21:23:24 +00:00

@vng knows )

arnaudvergnet commented

2022-09-11 21:23:48 +00:00

(Migrated from github.com)

Speed Camera type should also be visible.

I have trouble understanding how the place page works in the cpp side. Seems like incoming (red) speed cameras are not handled the same way as regular (black) speed cameras. They are "user marks" and not features so I do not know how to retrieve the necessary data.

> Speed Camera type should also be visible. I have trouble understanding how the place page works in the cpp side. Seems like incoming (red) speed cameras are not handled the same way as regular (black) speed cameras. They are "user marks" and not features so I do not know how to retrieve the necessary data.

vng commented

2022-09-12 06:35:53 +00:00

(Migrated from github.com)

PTAL

vng commented

2022-09-12 06:37:34 +00:00

(Migrated from github.com)

I'm unable to fully test it on mobiles.

arnaudvergnet commented

2022-09-12 08:04:54 +00:00

(Migrated from github.com)

Works perfectly thanks!

Works perfectly thanks! ![Screenshot_1662969831](https://user-images.githubusercontent.com/80701113/189603127-26a0b170-b9df-4b29-ac31-3f12b960238f.png)

vng commented

2022-10-06 08:06:21 +00:00

(Migrated from github.com)

@biodranik PTAL

biodranik (Migrated from github.com) approved these changes 2022-10-06 08:15:47 +00:00

biodranik (Migrated from github.com) left a comment

Can be merged if works properly on iOS too.

This repo is archived. You cannot comment on pull requests.

No reviewers

vng

rtsisyk

biodranik