Fix testserver behaviour after migration to Python 3 #2967

strump · 2022-07-15T08:50:37Z

strump commented

2022-07-15 08:50:37 +00:00

Errors were ignored in ResponseProvider.py. Added more logging.

Replaced float division with int division.

Fixed some API mismatch in http.server implementation between Python 2 and Python 3.

Is there any way we can run all unit tests with this branch version of scripts?

Errors were ignored in `ResponseProvider.py`. Added more logging. Replaced float division with int division. Fixed some API mismatch in `http.server` implementation between Python 2 and Python 3. Is there any way we can run all unit tests with this branch version of scripts?

strump reviewed 2022-07-15 08:52:06 +00:00

tools/python/ResponseProvider.py

					
				@ -13,3 +13,3 @@

				        self.__response_code = response_code

				        self.__message = message

				        self.__message = message if type(message) is bytes else message.encode('utf8')

				        self.__headers = headers

strump commented

2022-07-15 08:52:06 +00:00

Sometimes message is just a string but sometimes it's bytes object containing file content. So make sure it's always converted to bytes.

Sometimes `message` is just a string but sometimes it's `bytes` object containing file content. So make sure it's always converted to `bytes`.

biodranik commented

2022-07-15 08:57:51 +00:00

(Migrated from github.com)

Is there any way we can run all unit tests with this branch version of scripts?

Please add explicit exclusions for these test python scripts in linux checks here .github/workflows

> Is there any way we can run all unit tests with this branch version of scripts? Please add explicit exclusions for these test python scripts in linux checks here .github/workflows

biodranik (Migrated from github.com) reviewed 2022-07-15 12:51:35 +00:00

.github/workflows/linux-check.yaml

biodranik (Migrated from github.com) commented

2022-07-15 12:50:15 +00:00

Надо оставить под чеком только нужные скрипты, иначе будет много ненужных запусков на другие скрипты, не под чеками.

strump reviewed 2022-07-15 13:07:56 +00:00

.github/workflows/linux-check.yaml

strump commented

2022-07-15 13:07:56 +00:00

Можно сделать двумя путями:

Добавить все подпапки tools кроме tools/python:

on:
  workflow_dispatch: # Manual trigger
  pull_request:
    paths-ignore:
    ...
    - tools/android/**
    - tools/autobuild/**
    - tools/centos6/**
    - tools/download_statistics/**
    - tools/kothic/**
    - tools/loadersim/**
    - tools/macdeployqtfix/**
    - tools/osmctools/**
    # - tools/python/** ## Эту папку разрешить
    - tools/python_tests/**
    - tools/ruby/**
    - tools/shaders_compiler/**
    - tools/twine/**
    - tools/unix/**

Совместить список разрешений и запретов как в доке написано:

on:
  workflow_dispatch: # Manual trigger
  pull_request:
    paths:
      - '**'
      - '!.gitignore'
      - '!.github/**'
      - '!CONTRIBUTORS'
      - '!LICENSE'
      - '!NOTICE'
      - '!README.md'
      - '!android/**'
      - '!iphone/**'
      - '!data/strings/**'
      - '!docs/**'
      - '!packaging/**'
      - '!pyhelpers/**'
      - '!tools/**'
      - 'tools/python/**'
      - '!xcode/**'

Можно сделать двумя путями: 1) Добавить все подпапки `tools` кроме `tools/python`: ``` on: workflow_dispatch: # Manual trigger pull_request: paths-ignore: ... - tools/android/** - tools/autobuild/** - tools/centos6/** - tools/download_statistics/** - tools/kothic/** - tools/loadersim/** - tools/macdeployqtfix/** - tools/osmctools/** # - tools/python/** ## Эту папку разрешить - tools/python_tests/** - tools/ruby/** - tools/shaders_compiler/** - tools/twine/** - tools/unix/** ``` 2) Совместить список разрешений и запретов как в [доке](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-and-excluding-paths) написано: ``` on: workflow_dispatch: # Manual trigger pull_request: paths: - '**' - '!.gitignore' - '!.github/**' - '!CONTRIBUTORS' - '!LICENSE' - '!NOTICE' - '!README.md' - '!android/**' - '!iphone/**' - '!data/strings/**' - '!docs/**' - '!packaging/**' - '!pyhelpers/**' - '!tools/**' - 'tools/python/**' - '!xcode/**' ```