organicmaps/organicmaps-tmp

Archived

Fork 1

Android auto #2994

Merged

shankarpriyank merged 31 commits from Android_Auto into android_auto

2022-09-08 18:28:30 +00:00

shankarpriyank commented

2022-07-19 16:36:38 +00:00

(Migrated from github.com)

https://gist.github.com/shankarpriyank/5b54628a14d989b353933de2a4b62ad0a

Google Summer of Code 2022 Work Product Submission

Student: Priyank Shankar (@shankarpriyank)
Organisation: Organic Maps
Project: Developing Support For Android Auto

Overview of Work Done

My project started with figuring out how to make an app to support Android Auto, ie to show up on the launcher of AA, so my contributions started with this commit.
But there was one problem, for any android app to support Android Auto , its minSdk version has to be 23 or above, but right now the Organic Maps had a minSdk version of 21 and changing this would mean cutting out support for a significant proportion of its users, so it was clear at this point that my code could not be merged into the main branch directly.
After the app was showing up on the launcher it was time to work on its functionality, the app we are on can be put in the category of navigation apps, and Google provides a template for navigation apps to build upon. So the next step I took was to use the navigation template and get the app up and running.
Organic Maps uses its customized renderer to draw the map, and the navigation template provides you with the functionality to expose a surface to render upon.
Things started to slow down after this commit, I found out the hard way that the C++ implementation of the renderer is a whole another world.
But even after sorting out the logic, and calling the renderer properly we were encountering errors.
I with the help of my mentor @rtsisyk started debugging, we suspected that maybe vulkan doesn't work, so we forbid the renderer from using vulkan
But even with this, the errors were still popping up, this was a major setback in the project my mentor and I spent a lot of time trying out different ways to fix the issues , and finally with commit, we had a sigh of relief, finally the map was rendering on the screen of DHU.
We added basic buttons for zooming in and zooming out on the map. And while we were still figuring out how to support dragging and scrollin on the map, we realized that not all AA units support touch screen.
Also we realized there are stability issues with our current implementation, though the stability issues are almost fixed but we still need to do some work on the ux.
As not all AA units support touch screens, navigating through the app can be tough, so we are trying out possibilites to use voice commands to start routing to a particular destination using the Routing Logic.
We ran into another wall, routing was not working at all on our branch, maybe the hacks we made to make rendering possible on AA is the reason, we investigated it and fixed the its cause. All this mess was caused due to an single line of code which was commented out
Routing started working but there is still one more thing to fix, the router is somehow configured to lauch only on the device itself and not on the DHU/AA. Once we fix this routing feature would be all done
This branch contain all the changes done so far.

https://gist.github.com/shankarpriyank/5b54628a14d989b353933de2a4b62ad0a # Google Summer of Code 2022 Work Product Submission **Student**: Priyank Shankar ([@shankarpriyank](https://github.com/shankarpriyank)) **Organisation**: [Organic Maps](https://organicmaps.app/) **Project**: [Developing Support For Android Auto](https://summerofcode.withgoogle.com/programs/2022/projects/51VM0qGG) --- ## Overview of Work Done - My project started with figuring out how to make an app to support Android Auto, ie to show up on the launcher of AA, so my contributions started with this [commit](https://git.omaps.dev/organicmaps/organicmaps/commit/110d6df3e7c0635260d0c1d00952b1c5d2b1ecf9). - But there was one problem, for any android app to support Android Auto , its minSdk version has to be 23 or above, but right now the Organic Maps had a minSdk version of 21 and changing this would mean cutting out support for a significant proportion of its users, so it was clear at this point that my code could not be merged into the main branch directly. - After the app was showing up on the launcher it was time to work on its functionality, the app we are on can be put in the category of navigation apps, and Google provides a template for navigation apps to build upon. So the next step I took was to use the navigation template and get the app up and running. - Organic Maps uses its customized renderer to draw the map, and the navigation template provides you with the functionality to expose a surface to render upon. - Things started to slow down after this [commit](https://git.omaps.dev/organicmaps/organicmaps/commit/65170c84f78c15228409790f905bcda74da557d2), I found out the hard way that the C++ implementation of the renderer is a whole another world. - But even after sorting out the logic, and calling the renderer properly we were encountering errors. - I with the help of my mentor [@rtsisyk](https://github.com/rtsisyk) started debugging, we suspected that maybe vulkan doesn't work, so we forbid the renderer from using [vulkan](https://git.omaps.dev/organicmaps/organicmaps/commit/7a0b48a4e49a4ac17933dd3dbfa79f25dc13e502#diff-f6babaa5516369993795e068c031496e7b4a8a66c5bc1e261bd96c424b4bddf4R109) - But even with this, the errors were still popping up, this was a major setback in the project my mentor and I spent a lot of time trying out different ways to fix the issues , and finally with [commit](https://git.omaps.dev/organicmaps/organicmaps/commit/79e1056384f0385b1c1a2083b82ae103c4b0329b), we had a sigh of relief, finally the map was rendering on the screen of DHU. - We added basic buttons for zooming in and zooming out on the map. And while we were still figuring out how to support dragging and scrollin on the map, we realized that not all AA units support touch screen. - Also we realized there are stability issues with our current implementation, though the stability issues are almost fixed but we still need to do some work on the ux. - As not all AA units support touch screens, navigating through the app can be tough, so we are trying out possibilites to use voice commands to start routing to a particular destination using the Routing Logic. - We ran into another wall, routing was not working at all on our branch, maybe the hacks we made to make rendering possible on AA is the reason, we investigated it and fixed the its cause. All this mess was caused due to an single line of code which was commented out - Routing started working but there is still one more thing to fix, the router is somehow configured to lauch only on the device itself and not on the DHU/AA. Once we fix this routing feature would be all done - This [branch](https://github.com/organicmaps/organicmaps/tree/android_auto) contain all the changes done so far.

👍 3

strump requested changes 2022-07-20 08:00:03 +00:00

android/gradle.properties

strump commented

2022-07-20 07:50:56 +00:00

Member

You want to cancel Android 5.0 and 5.1 support and make Android 6.0 minimal requirement. What blocks you from using propMinSdkVersion=21?

You want to cancel Android 5.0 and 5.1 support and make Android 6.0 minimal requirement. What blocks you from using `propMinSdkVersion=21`?

android/src/com/androidAuto/HelloWorldScreen.java

strump commented

2022-07-20 07:51:41 +00:00

Member

Please remove unsused commented blocks of code.

strump commented

2022-07-20 07:55:34 +00:00

Member

Istead of Log.e(...) you better use Log.w(...) for warnings and Log.i(...) for information output and Log.d(...) for debug.

Istead of `Log.e(...)` you better use `Log.w(...)` for warnings and `Log.i(...)` for information output and `Log.d(...)` for debug.

strump commented

2022-07-20 07:56:50 +00:00

Member

Please use resources.getString(...) for multilanguage support instead of hardcoded "Exit" string.

Please use `resources.getString(...)` for multilanguage support instead of hardcoded "Exit" string.

strump commented

2022-07-20 07:57:20 +00:00

Member

Excepion is ignored. Should add at least logging here.

strump commented

2022-07-20 07:58:58 +00:00

Member

Please use more coherent class names instead of HelloWorldScreen and HelloWorldService.

Please use more coherent class names instead of `HelloWorldScreen` and `HelloWorldService`.

android/src/com/mapswithme/maps/SplashActivity.java

strump commented

2022-07-20 07:59:51 +00:00

Member

Why did you removed init() call?

Why did you removed `init()` call?

shankarpriyank (Migrated from github.com) reviewed 2022-07-20 08:06:56 +00:00

android/gradle.properties

shankarpriyank (Migrated from github.com) commented

2022-07-20 08:06:56 +00:00

Actually , to use Android Auto, this is required
https://developer.android.com/training/cars/apps/auto
And I am sorry I should have made this pr as a draft as there is still a lot of work to be done, that is why there a lot of commented-out code and improper log statements

Actually , to use Android Auto, this is required https://developer.android.com/training/cars/apps/auto And I am sorry I should have made this pr as a draft as there is still a lot of work to be done, that is why there a lot of commented-out code and improper log statements

This repo is archived. You cannot comment on pull requests.

No reviewers

strump