Category search can't find by full name #3260

New issue

Closed

opened 2022-08-26 10:56:09 +00:00 by strump · 3 comments

strump commented

2022-08-26 10:56:09 +00:00

Member

Steps to reproduce:

OrgancMaps for iPad v.2022.08.23-3, or OM for Android v.2022.07.27-3
Set Ukrainian locale
Open Organic maps and create new POI
In categories search enter "Витвір"

Expected result: Category "Витвір мистецства" (which means Artwork) is found
Actual result: No categories found

But if I search by "Твір мистецтва" or "Скульптура" then category is found:

Looks like NewFeatureCategories::Search(std::string const & query) method only looks for string from categories.txt but ignores type_strings.txt.

**Steps to reproduce:** * OrgancMaps for iPad v.2022.08.23-3, or OM for Android v.2022.07.27-3 * Set Ukrainian locale * Open Organic maps and create new POI * In categories search enter "Витвір" **Expected result:** Category "Витвір мистецства" (which means Artwork) is found **Actual result:** No categories found <img src="https://user-images.githubusercontent.com/720808/186888306-d3252de9-4583-44e2-b1a0-0631c60a6889.png" width="300"/> But if I search by "Твір мистецтва" or "Скульптура" then category is found: <img src="https://user-images.githubusercontent.com/720808/186888488-f469b064-1097-4952-9c1f-1f3dee1ed42a.png" width="300px"/> <img src="https://user-images.githubusercontent.com/720808/186888494-0d30b0ff-3eb5-4fbe-94b2-b779c891df94.png" width="300px"/> Looks like `NewFeatureCategories::Search(std::string const & query)` method only looks for string from `categories.txt` but ignores `type_strings.txt`.

RedAuburn commented

2022-08-26 11:29:18 +00:00

Member

organicmaps/organicmaps#3250 i just had a similar issue, i submitted a temporary fix, but using type_strings.txt would be much better 👍

https://git.omaps.dev/organicmaps/organicmaps/issues/3250 i just had a similar issue, i submitted a temporary fix, but using `type_strings.txt` would be much better 👍

biodranik commented

2022-08-27 19:59:19 +00:00

(Migrated from github.com)

@vng what if we merge types strings into loaded categories?

vng commented

2022-08-28 05:48:36 +00:00

(Migrated from github.com)

Having all types as search categories is not a good idea
Search categories should inherit type strings as we discussed for many times
I suspect that this issue not only about category-type strings. Strange behaviour according to screenshots, should investigate.

- Having _all_ types as search categories is not a good idea - Search categories should _inherit_ type strings as we discussed for many times - I suspect that this issue not only about category-type strings. Strange behaviour according to screenshots, should investigate.

This repo is archived. You cannot comment on issues.