organicmaps/organicmaps-tmp

Archived

Fork 1

[string] Fix Italian generic "Stop": set "Bus stop" + "Bus tram" #3286

Merged

valerio-bozzolan merged 1 commit from string-fix-stop-bus-tram into master

2022-08-30 08:45:20 +00:00

valerio-bozzolan commented

2022-08-28 17:16:01 +00:00

(Migrated from github.com)

This small change allows many people in Italy not to confuse search results related to tram and bus stops (and train stations): now all of them have a different description.

This bug was originally reported by @amreo during an OpenStreetMap mapping party in the lovely La Pigna, Sanremo (Italy):

https://scambi.org/2022/lab/18/

Added the Signed-off-by as expected but I've not executed the ruby stuff, sorry.

Please note (since in some projects it's a problem in compilation): There is an apostrophe character in my translation: '

This change also adds the ability to search "pullman" (widely used in Torino) plus a couple of autocomplete limitation (3 characters).

Thank you for this amazing Free/Libre and Open Source Project.

This small change allows many people in Italy not to confuse search results related to tram and bus stops (and train stations): now all of them have a different description. This bug was originally reported by @amreo during an OpenStreetMap mapping party in the lovely La Pigna, Sanremo (Italy): https://scambi.org/2022/lab/18/ Added the `Signed-off-by` as expected but I've not executed the `ruby` stuff, sorry. Please note (since in some projects it's a problem in compilation): There is an apostrophe character in my translation: `'` This change also adds the ability to search "pullman" (widely used in Torino) plus a couple of autocomplete limitation (3 characters). Thank you for this amazing Free/Libre and Open Source Project.

👀 1 ❤️ 1

biodranik (Migrated from github.com) reviewed 2022-08-28 19:54:25 +00:00

data/categories.txt

biodranik (Migrated from github.com) commented

2022-08-28 19:54:24 +00:00

Can the user type "fermata" in the search to find any type of stop? If yes, then please add it also as a synonym here and below.

Can the user type "fermata" in the search to find _any_ type of stop? If yes, then please add it also as a synonym here and below.

vng (Migrated from github.com) reviewed 2022-08-29 08:11:33 +00:00

data/categories.txt

vng (Migrated from github.com) commented

2022-08-29 08:11:33 +00:00

Category search does match separate tokens always. This change will affect suggestion's name only. Search will work the same way for "fermata", "autobus", "tram".

The only thing that entropy is increasing a bit with "del/dell" :)

Category search does match separate tokens always. This change will affect suggestion's name only. Search will work the same way for "fermata", "autobus", "tram". The only thing that _entropy_ is increasing a bit with "del/dell" :)

vng (Migrated from github.com) approved these changes 2022-08-29 08:13:24 +00:00

valerio-bozzolan (Migrated from github.com) reviewed 2022-08-29 08:45:32 +00:00

data/categories.txt

valerio-bozzolan (Migrated from github.com) commented

2022-08-29 08:45:32 +00:00

If I understand correctly, "fermata" and "autobus" are just tokens, so feel free to say "yeah please drop -dell-" since it just means "of the". Unless an exact string match is not is weight-rewarded.

vng (Migrated from github.com) reviewed 2022-08-29 09:56:42 +00:00

data/categories.txt

vng (Migrated from github.com) commented

2022-08-29 09:56:42 +00:00

Did you test this changes somehow? "dell" is ok if we want to get grammatically valid suggest name.
Or "Fermata autobus", "Fermata tram" are also good suggestions?

Did you test this changes somehow? "dell" is ok if we want to get grammatically valid suggest name. Or "Fermata autobus", "Fermata tram" are also good suggestions?

valerio-bozzolan (Migrated from github.com) reviewed 2022-08-29 10:00:39 +00:00

data/categories.txt

valerio-bozzolan (Migrated from github.com) commented

2022-08-29 10:00:39 +00:00

Not tested. Here all the variants that could be nice to take in consideration:

fermata dell'autobus (← canonical) / fermata autobus
fermata del pullman / fermata pullman
fermata del bus / fermata bus
bus stop

Not tested. Here all the variants that could be nice to take in consideration: - fermata dell'autobus (← canonical) / fermata autobus - fermata del pullman / fermata pullman - fermata del bus / fermata bus - bus stop

vng (Migrated from github.com) reviewed 2022-08-29 11:44:29 +00:00

data/categories.txt

vng (Migrated from github.com) commented

2022-08-29 11:44:29 +00:00

Seems like you don't understand my point. "Fermata tram", or "Fermata autobus" search already should work on current app version with correct results. Please, check it out.

Your fix is good for blue suggest result names on top. Instead of generic "Fermata", the app will suggest "Fermata dell'autobus" or "Fermata del tram".

Seems like you don't understand my point. "Fermata tram", or "Fermata autobus" search already should work on current app version with correct results. Please, check it out. Your fix is good for _blue suggest_ result names on top. Instead of generic "Fermata", the app will suggest "Fermata dell'autobus" or "Fermata del tram".

vng (Migrated from github.com) reviewed 2022-08-29 11:48:37 +00:00

data/categories.txt

vng (Migrated from github.com) commented

2022-08-29 11:48:36 +00:00

From my perspective, I'd prefer simple:

it:3autobus|3Fermata

it:3tram|3Fermata

Main transport as a first keyword for suggest. "Fermata" as a synonym for any transport ..

From my perspective, I'd prefer simple: it:3autobus|3Fermata it:3tram|3Fermata Main transport as a first keyword for suggest. "Fermata" as a synonym for any transport ..