organicmaps/organicmaps-tmp

Archived

Fork 1

[styles] Add Music School, Driving School, Language School #3302

Merged

root merged 3 commits from school-types into master

2022-09-12 20:02:04 +00:00

dvdmrtnz commented

2022-08-30 17:10:44 +00:00

Contributor

This PR adds icons for amenity=music_school, amenity=driving_school and amenity=language_school

Closes organicmaps/organicmaps#3287
Closes organicmaps/organicmaps#3271

Music School:

Driving School:

Language School:

This PR adds icons for `amenity=music_school`, `amenity=driving_school` and `amenity=language_school` Closes https://git.omaps.dev/organicmaps/organicmaps/issues/3287 Closes https://git.omaps.dev/organicmaps/organicmaps/issues/3271 Music School: ![](https://user-images.githubusercontent.com/47610359/187497559-97082452-5586-4e42-bacf-a72150ae68dd.png) ![](https://user-images.githubusercontent.com/47610359/187497576-ba91570d-80b0-4a94-ad94-65f528490363.png) Driving School: ![](https://user-images.githubusercontent.com/47610359/187497522-1d1c2d17-55d0-464b-bcb6-4bdd7455d8bd.png) ![](https://user-images.githubusercontent.com/47610359/187497541-74f85bb1-9fa7-4996-8b11-76e0be6fcbad.png) Language School: ![](https://user-images.githubusercontent.com/47610359/187497465-e446576d-0150-4ae4-9e86-22a262418a06.png) ![](https://user-images.githubusercontent.com/47610359/187497507-0df96ccb-83db-4075-bbc8-7f3cf799a365.png)

vng (Migrated from github.com) reviewed 2022-08-31 18:49:43 +00:00

data/mapcss-mapping.csv

vng (Migrated from github.com) commented

2022-08-31 18:49:43 +00:00

nit: Put this definitions somewhere instead of "deprecated." Lets say into 1148, 1149 near "amenity|driving_school;1161;"

biodranik commented

2022-08-31 19:46:38 +00:00

(Migrated from github.com)

Thanks! The icon for the driving school is not recognizable by some people. Are there any better ideas?

👍 2

dvdmrtnz commented

2022-09-01 07:39:07 +00:00

Author

Contributor

Thanks! The icon for the driving school is not recognizable by some people. Are there any better ideas?

Do you have any suggestions on what other icon to use?

> Thanks! The icon for the driving school is not recognizable by some people. Are there any better ideas? Do you have any suggestions on what other icon to use?

TheAdventurer64 commented

2022-09-01 07:56:51 +00:00

(Migrated from github.com)

Thanks! The icon for the driving school is not recognizable by some people. Are there any better ideas?

Do you have any suggestions on what other icon to use?

Maybe this one of a steering wheel? https://www.flaticon.com/free-icon/steering-wheel_3190249

> > Thanks! The icon for the driving school is not recognizable by some people. Are there any better ideas? > > > > Do you have any suggestions on what other icon to use? Maybe this one of a steering wheel? https://www.flaticon.com/free-icon/steering-wheel_3190249

dvdmrtnz commented

2022-09-01 08:10:06 +00:00

Author

Contributor

Maybe this one of a steering wheel? https://www.flaticon.com/free-icon/steering-wheel_3190249

I believe we are already using a steering wheel symbol for shop=car_parts

https://github.com/organicmaps/organicmaps/blob/master/data/styles/clear/style-clear/symbols/car-part-m.svg

> Maybe this one of a steering wheel? https://www.flaticon.com/free-icon/steering-wheel_3190249 I believe we are already using a steering wheel symbol for shop=car_parts https://github.com/organicmaps/organicmaps/blob/master/data/styles/clear/style-clear/symbols/car-part-m.svg

strump commented

2022-09-01 10:02:16 +00:00

Member

Maybe something like this icon: https://www.flaticon.com/free-icon/driving-school_7468714 (not sure about license)

Maybe something like this icon: https://www.flaticon.com/free-icon/driving-school_7468714 (not sure about license) <img width="256" alt="Screenshot 2022-09-01 at 13 01 23" src="https://user-images.githubusercontent.com/720808/187888129-c57e50c1-b7fc-459c-9c6f-8a1ff858411d.png">

biodranik commented

2022-09-01 10:21:30 +00:00

(Migrated from github.com)

@strump This one has a too complex shape to recognize. A traffic cone icon is associated with some road works. So far without better options, we can merge the cone, but let's continue brainstorming.

dvdmrtnz commented

2022-09-03 09:42:32 +00:00

Author

Contributor

@strump This one has a too complex shape to recognize. A traffic cone icon is associated with some road works. So far without better options, we can merge the cone, but let's continue brainstorming.

We could make an icon looking like an "L" sign that is used on some countries if you think it will be more recognizable than the traffic cone: https://commons.wikimedia.org/wiki/Category:Learner_driver_signs

> @strump This one has a too complex shape to recognize. A traffic cone icon is associated with some road works. So far without better options, we can merge the cone, but let's continue brainstorming. We could make an icon looking like an "L" sign that is used on some countries if you think it will be more recognizable than the traffic cone: https://commons.wikimedia.org/wiki/Category:Learner_driver_signs

TheAdventurer64 commented

2022-09-03 09:57:46 +00:00

(Migrated from github.com)

@dvdmrtnz where were these icons sourced from?

dvdmrtnz commented

2022-09-03 10:05:37 +00:00

Author

Contributor

@dvdmrtnz where were these icons sourced from?

They are from Flaticon. On the Language School I did some modifications.

https://www.flaticon.com/free-icon/musical-note_461146
https://www.flaticon.com/free-icon/cone_620828
https://www.flaticon.com/free-icon/chat_589708

I believe this source is fine to use, right? It is attributed on https://github.com/organicmaps/organicmaps/blob/master/data/copyright.html#L330

> @dvdmrtnz where were these icons sourced from? They are from Flaticon. On the Language School I did some modifications. https://www.flaticon.com/free-icon/musical-note_461146 https://www.flaticon.com/free-icon/cone_620828 https://www.flaticon.com/free-icon/chat_589708 I believe this source is fine to use, right? It is attributed on https://github.com/organicmaps/organicmaps/blob/master/data/copyright.html#L330

biodranik commented

2022-09-03 11:42:23 +00:00

(Migrated from github.com)

It would be better to use different icon sources, to avoid populating store descriptions with properly translated attribution texts.

dvdmrtnz commented

2022-09-03 13:26:32 +00:00

Author

Contributor

Okay, I remade the icons using other sources.

I also made a different version of the driving school icon. Let me know what you think.

Music School (Source: https://fontawesome.com/icons/music?f=classic&s=solid):

Driving School (Source: Modified https://github.com/organicmaps/organicmaps/blob/master/data/styles/clear/style-clear/symbols/car-wash-m.svg)

Language School (Source: based on https://fonts.google.com/icons?selected=Material+Icons+Outlined:chat_bubble_outline: with some modifications)

Okay, I remade the icons using other sources. I also made a different version of the driving school icon. Let me know what you think. Music School (Source: https://fontawesome.com/icons/music?f=classic&s=solid): ![imagen](https://user-images.githubusercontent.com/47610359/188272369-1a851223-7f7f-4a1d-a6de-fee56298dcb7.png) Driving School (Source: Modified https://github.com/organicmaps/organicmaps/blob/master/data/styles/clear/style-clear/symbols/car-wash-m.svg) ![imagen](https://user-images.githubusercontent.com/47610359/188272366-f1630559-64a8-4fc8-bf82-2e75b1c92a46.png) Language School (Source: based on https://fonts.google.com/icons?selected=Material+Icons+Outlined:chat_bubble_outline: with some modifications) ![imagen](https://user-images.githubusercontent.com/47610359/188272361-74fda815-9921-4c07-9587-ea36c06caafe.png)

biodranik (Migrated from github.com) reviewed 2022-09-03 19:03:40 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! An interesting idea, is it possible to make the car under the L more recognizable?

dvdmrtnz commented

2022-09-04 15:18:13 +00:00

Author

Contributor

Thanks! An interesting idea, is it possible to make the car under the L more recognizable?

I don't really know how to make it more recognizable. Do you have an idea?

> Thanks! An interesting idea, is it possible to make the car under the L more recognizable? I don't really know how to make it more recognizable. Do you have an idea?

biodranik commented

2022-09-04 21:04:51 +00:00

(Migrated from github.com)

I don't really know how to make it more recognizable. Do you have an idea?

Bigger wheels
A bit more narrow cabin
Mirrors

> I don't really know how to make it more recognizable. Do you have an idea? - Bigger wheels - A bit more narrow cabin - Mirrors

TheAdventurer64 commented

2022-09-09 17:52:24 +00:00

(Migrated from github.com)

What if we did a car with a graduation cap on the top?

biodranik commented

2022-09-10 10:40:29 +00:00

(Migrated from github.com)

Interesting idea :) There is also this:

Interesting idea :) There is also this: ![image](https://user-images.githubusercontent.com/170263/189479687-d3250162-daa7-459b-93d0-d9b5fe295111.png)

😆 1

biodranik (Migrated from github.com) approved these changes 2022-09-11 18:45:07 +00:00

biodranik (Migrated from github.com) left a comment

Let's merge these icons until there are no better ones. Please rebase and also add be translation (and sort) for the driving school in categories and types_strings.

Let's merge these icons until there are no better ones. Please rebase and also add `be` translation (and sort) for the driving school in categories and types_strings.

vng commented

2022-09-12 11:21:32 +00:00

(Migrated from github.com)

@dvdmrtnz Don't you mind if I will update your branch?

dvdmrtnz commented

2022-09-12 16:37:55 +00:00

Author

Contributor

@dvdmrtnz Don't you mind if I will update your branch?

No problem.

Let's merge these icons until there are no better ones. Please rebase and also add be translation (and sort) for the driving school in categories and types_strings.

Done added be translation.

> @dvdmrtnz Don't you mind if I will update your branch? No problem. > Let's merge these icons until there are no better ones. Please rebase and also add `be` translation (and sort) for the driving school in categories and types_strings. Done added `be` translation.

biodranik (Migrated from github.com) approved these changes 2022-09-12 17:42:27 +00:00

biodranik (Migrated from github.com) left a comment

LGTM

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik