[strings] Add nl-Dutch translations #3338

Merged

jimcarst merged 2 commits from strings-nl-dutch into master

2022-09-04 20:39:12 +00:00

jimcarst commented

2022-09-04 14:41:05 +00:00

(Migrated from github.com)

Added all missing Dutch translations in strings.txt and types_strings.txt.

Encountered some errors in string_utils.py on Windows.

Incorrect paths
Writing the sorted file crashes at non-Latin characters

  File "./organicmaps\tools\python\strings_utils.py", line 642, in <module>
    strings.write_formatted(target_file=args.output, langs=args.langs, keep_resolved=args.keep_resolved)
  File "./organicmaps\tools\python\strings_utils.py", line 359, in write_formatted
    self._write_translations_for_langs(outfile, sorted_langs, tran, ref_tran)
  File "./organicmaps\tools\python\strings_utils.py", line 365, in _write_translations_for_langs
    outfile.write("    {0} = {1}\n".format(
  File "./cp1252.py", line 19, in encode
    return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode characters in position 9-17: character maps to <undefined>

Because of this the files still need to be sorted, and regenerated.

Added all missing Dutch translations in `strings.txt` and `types_strings.txt`. Encountered some errors in `string_utils.py` on Windows. - Incorrect paths - Writing the sorted file crashes at non-Latin characters ```py File "./organicmaps\tools\python\strings_utils.py", line 642, in <module> strings.write_formatted(target_file=args.output, langs=args.langs, keep_resolved=args.keep_resolved) File "./organicmaps\tools\python\strings_utils.py", line 359, in write_formatted self._write_translations_for_langs(outfile, sorted_langs, tran, ref_tran) File "./organicmaps\tools\python\strings_utils.py", line 365, in _write_translations_for_langs outfile.write(" {0} = {1}\n".format( File "./cp1252.py", line 19, in encode return codecs.charmap_encode(input,self.errors,encoding_table)[0] UnicodeEncodeError: 'charmap' codec can't encode characters in position 9-17: character maps to <undefined> ``` Because of this the files still need to be sorted, and regenerated.

vng (Migrated from github.com) approved these changes 2022-09-04 16:19:01 +00:00

vng (Migrated from github.com) left a comment

Thanks a lot! Is it possible to put "nl = ..." into the list with sorted order? We try to keep sorted list of languages to make it easy for other contributors.

jimcarst commented

2022-09-04 18:21:07 +00:00

(Migrated from github.com)

@vng Sorted, and fixed string_utils.py.

@vng Sorted, and fixed `string_utils.py`.

👍 1

biodranik (Migrated from github.com) approved these changes 2022-09-04 20:38:50 +00:00

biodranik (Migrated from github.com) left a comment

Thank you for the contribution!

501Ghost commented

2022-09-05 15:51:00 +00:00

(Migrated from github.com)

This is my first time uploading anything to Github so I hope this won't cause any conflicts or other issues. Please let me know if I did this correctly.

types_strings.txt

I just made more Dutch translations for types_strings.txt (the one I found at https://github.com/organicmaps/organicmaps/blob/master/data/strings/types_strings.txt). It includes both new translations and edits of existing ones. I also added a single Italian translation for highway=motorway and an update for the English wlan tag. This is my first time uploading anything to Github so I hope this won't cause any conflicts or other issues. Please let me know if I did this correctly. [types_strings.txt](https://github.com/organicmaps/organicmaps/files/9491062/types_strings.txt)

This repo is archived. You cannot comment on pull requests.

No reviewers

vng

biodranik