organicmaps/organicmaps-tmp

Archived

Fork 1

[android] set bottom map buttons max width to 300dp #3353

Merged

arnaudvergnet merged 1 commit from bottom-map-buttons into master

2022-09-11 05:34:14 +00:00

arnaudvergnet commented

2022-09-05 17:26:57 +00:00

(Migrated from github.com)

When the screen is larger than 300dp, bottom map buttons will align to the left as requested in organicmaps/organicmaps#2905 (comment). This threshold can be edited in the map_buttons_bottom_max_width value.

To make code easier to maintain, bottom menu buttons have been extracted into their own layout file.

Pixel 5

Portrait	Landscape

Nexus One

Portrait	Landscape

Pixel C

Portrait	Landscape

When the screen is larger than 300dp, bottom map buttons will align to the left as requested in https://git.omaps.dev/organicmaps/organicmaps/pulls/2905#issuecomment-1236192812. This threshold can be edited in the `map_buttons_bottom_max_width` value. To make code easier to maintain, bottom menu buttons have been extracted into their own layout file. ## Pixel 5 | Portrait | Landscape | |-|-| | ![Screenshot_1662397632](https://user-images.githubusercontent.com/80701113/188494950-76f89560-267e-42e8-9e46-45994298906a.png) | ![Screenshot_1662397637](https://user-images.githubusercontent.com/80701113/188494958-d486d2e5-f110-4b3b-a0ae-a9c21dac81ec.png) | ## Nexus One | Portrait | Landscape | |-|-| | ![Screenshot_1662397763](https://user-images.githubusercontent.com/80701113/188494967-56a0301a-3926-4682-b126-d553798650c4.png) | ![Screenshot_1662397768](https://user-images.githubusercontent.com/80701113/188494972-830e7406-b6a0-4131-b2db-6806a359a467.png) | ## Pixel C | Portrait | Landscape | |-|-| | ![Screenshot_1662398474](https://user-images.githubusercontent.com/80701113/188494981-761eb91d-d656-4225-8d76-c5e90d1e9ba7.png) | ![Screenshot_1662398486](https://user-images.githubusercontent.com/80701113/188494986-a9329434-ff32-4051-88fd-f072e90a5e97.png) |

biodranik commented

2022-09-05 21:07:44 +00:00

(Migrated from github.com)

Thanks, Arnaud! Now as we started to test it and get feedback, there are several different ideas:

Group buttons in the center in portrait mode, so it's easier to tap for left and right-handed people.
As landscape mode is usually operated with two hands, it could be more logical to either split buttons to both edges, or move them to the right (so when we add "left-handed interface" option they will mirror to the left).

It would be interesting to use different layouts on different devices, by different people, and get some preliminary feedback.

Thanks, Arnaud! Now as we started to test it and get feedback, there are several different ideas: 1. Group buttons in the center in portrait mode, so it's easier to tap for left and right-handed people. 2. As landscape mode is usually operated with two hands, it could be more logical to either split buttons to both edges, or move them to the right (so when we add "left-handed interface" option they will mirror to the left). It would be interesting to use different layouts on different devices, by different people, and get some preliminary feedback.

arnaudvergnet commented

2022-09-05 21:22:51 +00:00

(Migrated from github.com)

Group buttons in the center in portrait mode, so it's easier to tap for left and right-handed people

Do you want to have less spacing between buttons, or are you only talking about portrait on tablets?

As landscape mode is usually operated with two hands, it could be more logical to either split buttons to both edges, or move them to the right (so when we add "left-handed interface" option they will mirror to the left).

Moving them to the right might be easier to implement so we may stick with this first and get feedback.

> Group buttons in the center in portrait mode, so it's easier to tap for left and right-handed people Do you want to have less spacing between buttons, or are you only talking about portrait on tablets? > As landscape mode is usually operated with two hands, it could be more logical to either split buttons to both edges, or move them to the right (so when we add "left-handed interface" option they will mirror to the left). Moving them to the right might be easier to implement so we may stick with this first and get feedback.

arnaudvergnet commented

2022-09-06 07:38:17 +00:00

(Migrated from github.com)

Pixel 5

Portrait	Landscape

Pixel C

Portrait	Landscape

I made the maximum width 300dp instead of 450dp and forced the menu to align to the right on portrait. As I only check the orientation, the menu is centered in tablet as well. Do you prefer to align the menu to the right no matter the orientation in tablet (meaning checking the available width instead of orientation) ? ## Pixel 5 | Portrait | Landscape | |-|-| | ![Screenshot_1662449633](https://user-images.githubusercontent.com/80701113/188574747-e976c827-2a11-4ad5-867a-9848ae88a789.png) | ![Screenshot_1662449638](https://user-images.githubusercontent.com/80701113/188574760-49d1e39f-d755-456c-8c11-ec67e2d3beaa.png) | ## Pixel C | Portrait | Landscape | |-|-| | ![Screenshot_1662449561](https://user-images.githubusercontent.com/80701113/188574726-6b9b9dd6-c03c-4d2d-8670-addf6067bbc4.png) | ![Screenshot_1662449566](https://user-images.githubusercontent.com/80701113/188574739-afd190ba-21dc-4b8c-a46c-f1f4a7884608.png) |

vng (Migrated from github.com) reviewed 2022-09-07 21:23:43 +00:00

vng (Migrated from github.com) left a comment

I like last screenshots.
Center in portrait and right in landscape.
Does Android have some system settings for left-handed people?

I like last screenshots. Center in portrait and right in landscape. Does Android have some system settings for left-handed people?

android/res/values/dimens.xml

vng (Migrated from github.com) commented

2022-09-07 21:22:10 +00:00

"I made the maximum width 300dp instead of 450dp "
So what is a final value?

"I made the maximum width 300dp instead of 450dp " So what is a final value?

arnaudvergnet (Migrated from github.com) reviewed 2022-09-07 22:54:45 +00:00

android/res/values/dimens.xml

arnaudvergnet (Migrated from github.com) commented

2022-09-07 22:54:45 +00:00

I did not push yet, I wanted to have feedback first

arnaudvergnet commented

2022-09-07 22:57:04 +00:00

(Migrated from github.com)

Does Android have some system settings for left-handed people

I know you can force the RTL layout from the developers options but I haven't looked more into it.

> Does Android have some system settings for left-handed people I know you can force the RTL layout from the developers options but I haven't looked more into it.

vng (Migrated from github.com) approved these changes 2022-09-09 08:49:55 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

vng