organicmaps/organicmaps-tmp

Archived

Fork 1

[android] Map buttons fixes #3398

Merged

arnaudvergnet merged 3 commits from map-buttons-fixes into master

2022-09-14 05:16:56 +00:00

arnaudvergnet commented

2022-09-13 11:56:05 +00:00

(Migrated from github.com)

Replaces organicmaps/organicmaps#3392

Makes all map buttons background 80% alpha as requested in organicmaps/organicmaps#2905 (comment).

Also replaces search and menu icons with better SVGs. Finally makes sure the position icon is fully opaque.

Day mode	Night mode

Replaces https://git.omaps.dev/organicmaps/organicmaps/pulls/3392 Makes all map buttons background 80% alpha as requested in https://git.omaps.dev/organicmaps/organicmaps/pulls/2905#issuecomment-1243056354. Also replaces search and menu icons with better SVGs. Finally makes sure the position icon is fully opaque. | Day mode | Night mode | |-|-| | ![Screenshot_1663069953](https://user-images.githubusercontent.com/80701113/189894129-fbca93f9-fc86-4cc6-b1e3-e560356d85b4.png) | ![Screenshot_1663069964](https://user-images.githubusercontent.com/80701113/189894132-8a120e7e-3c35-4402-9ee4-7e475080b788.png) |

🚀 1

vng (Migrated from github.com) approved these changes 2022-09-13 13:26:47 +00:00

biodranik (Migrated from github.com) approved these changes 2022-09-13 14:26:11 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! It looks great!

Is the white color on buttons at night mode exactly the same as it is in stores now? Subjectively, it looks brighter in your change (maybe I'm wrong).
Buttons are hardly visible now in the night mode. Would it be possible to make some (barely visible) gray contour around them? This is probably for another PR.

Thanks! It looks great! 1. Is the white color on buttons at night mode exactly the same as it is in stores now? Subjectively, it looks brighter in your change (maybe I'm wrong). 2. Buttons are hardly visible now in the night mode. Would it be possible to make some (barely visible) gray contour around them? This is probably for another PR.

arnaudvergnet commented

2022-09-13 14:52:35 +00:00

(Migrated from github.com)

In the stores, the map buttons are a bit grey, only the bottom bar is white. In light mode they both use the same color. I don't know why there was a difference but I prefer how it is in this PR, it is easier to see.
I can try to experiment in another PR with the opacity and contour.

1. In the stores, the map buttons are a bit grey, only the bottom bar is white. In light mode they both use the same color. I don't know why there was a difference but I prefer how it is in this PR, it is easier to see. 2. I can try to experiment in another PR with the opacity and contour.

biodranik commented

2022-09-13 15:02:00 +00:00

(Migrated from github.com)

Found a few more issues after testing (they can be fixed later separately):

THE IMPORTANT ONE! Location button icons changed and become non-intuitive/different from what it was before. Users will highly likely be confused. Previous icons (non-vertical filled arrow and vertical filled arrow with a vertical line) were very intuitive for corresponding modes. We need to find corresponding icons in vector form or ask someone to draw them.
In the market version zoom buttons are brighter in the night mode, but layers and crosshair are a bit darker.
+ and - in zoom buttons should be slightly larger.
Menu lines should be slightly larger and bolder.
Star icon has different shape now, it would be great to find a similar shape :)

Found a few more issues after testing (they can be fixed later separately): 0. THE IMPORTANT ONE! Location button icons changed and become non-intuitive/different from what it was before. Users will highly likely be confused. Previous icons (non-vertical filled arrow and vertical filled arrow with a vertical line) were very intuitive for corresponding modes. We need to find corresponding icons in vector form or ask someone to draw them. 1. In the market version zoom buttons are brighter in the night mode, but layers and crosshair are a bit darker. 2. `+` and `-` in zoom buttons should be slightly larger. 3. Menu lines should be slightly larger and bolder. 4. Star icon has different shape now, it would be great to find a similar shape :)

arnaudvergnet commented

2022-09-13 15:12:14 +00:00

(Migrated from github.com)

Why do you want to have a difference in brightness for the buttons? It seems clearer to me to have all the buttons behave the same.

For the icons, I simply used the ones available in the Android Studio vector icon picker. We should decide on one source for all icons (if it is not already the case) to make sure they have the same style. I do not know what you usually use, but I often go with the community made [Material Design Icons](https://materialdesignicons.com/). Why do you want to have a difference in brightness for the buttons? It seems clearer to me to have all the buttons behave the same.

rtsisyk approved these changes 2022-09-13 18:40:12 +00:00

biodranik commented

2022-09-13 21:46:18 +00:00

(Migrated from github.com)

@arnaudvergnet not sure that "the same stule" is a proper case here. We need different icons, and if nobody can draw them, then let's use different sources to unblock the development.

The rounded star can be used from Android Studio icons (they actually match most of the Material Icons).

Different colors were probably better to visually distinguish plus and minus zoom buttons. But let's see how it goes with real users.

@arnaudvergnet not sure that "the same stule" is a proper case here. We need different icons, and if nobody can draw them, then let's use different sources to unblock the development. The rounded star can be used from Android Studio icons (they actually match most of the Material Icons). Different colors were probably better to visually distinguish plus and minus zoom buttons. But let's see how it goes with real users.

👍 1

biodranik commented

2022-09-13 21:47:26 +00:00

(Migrated from github.com)

I would also add that the dark style is mainly designed now for driving a car at night. It would be great if someone tries it and says if buttons are too bright or not.

arnaudvergnet commented

2022-09-14 07:24:24 +00:00

(Migrated from github.com)

@biodranik I updated the navigation icons what do you think ? organicmaps/organicmaps#3407

@biodranik I updated the navigation icons what do you think ? https://git.omaps.dev/organicmaps/organicmaps/pulls/3407

This repo is archived. You cannot comment on pull requests.

No reviewers

vng

biodranik

rtsisyk