Substation icon shouldn't have a circle #3427
Labels
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
3 participants
Due date
No due date set.
Dependencies
No dependencies set.
Reference: organicmaps/organicmaps-tmp#3427
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Power=substation icon shouldn't have a circle as it is currently very confusing when looking for POIs on high zoom, I would assume it's an amenity since all unimportant POIs are rendered without a circle.
You're right! @endim8 can you please remove circles from these icons?
just removing the circle make it quite hard to read:

maybe an outline like this would be better?":

also need to remove circle from chimney-m.svg
Of course, the icon should be colored like other icons. It shouldn't be too attractive and different from others visually.
I think having it as just an outline in the color of other icons this type would be fitting, that's the way the fire hydrant is done. Something like this (recolored example from Material Design Icons - if needed I can upload this elsewhere, not sure if github compresses images here)

I made these icons based off of the ones currently used, they fit other icons used in the app, however I'm not sure how to add them to the desktop app or what to do to contribute them


I made dark mode versions of the above icons too. If I were to PR these, would I still have to build everything and regenerate styles if I'm not adding any new icons, just replacing old ones? @biodranik


(not sure why they vary in size on github, they're both 24x24 svgs)
It is necessary to test/see how new icons are looking on the map before merging them. If you can't do it yourself, maybe someone else can help you?
I tested the icons modified by @lunarna-gh. Here they are:
I also tested a modified power symbol with fill inside using the same color.
What do you think?
A contoured one looks good. What about the dark mode? Can you please share a screenshot of how it looks there?
Here they are in dark mode:
Thanks!
I'm not sure what you mean by this. Can you explain a bit more?
Yes, it's the same.
Here are the images with some other icons around:
Is this what you mean? I moved the nodes slightly closer together, can make it thinner if wanted




Yes, thanks! These look a bit better, maybe try even thinner?
What do you think about filled vs non-filled?
I'm not sure about filled vs non-filled because I've spent so long looking at these icons that they both stand out to me. I originally proposed non-filled because it would fit the fire hydrant icon, but it seems like a lot of gray icons are filled. You can choose which one you think is less eye-catching.




I've made it thinner in the center again and slightly thinner on the sides to make the filled version look less thick.
Apparently these aren't good for use in-app because they feature Inkscape artefacts, I saved them instead of exporting. I can export these tomorrow.
I saved these as optimized .svgs which fit the structure of other svgs used in OM. Unfortunately GitHub issues don't support uploading optimized .svgs, GitHub can't process these files without tidy formatting, so I uploaded these to filen (can upload to a github repo if necessary) https://filen.io/f/6d74e21c-f307-49bb-8c97-6f11b35e3502#!KrJMW8Ip8FQIbJwIXSwqjbYWJaqiIaaB
@dvdmrtnz Do you prefer filled or unfilled?
I would prefer filled as it matches with the rest of the icons on OrganicMaps.
@lunarna-gh Do you want me to make a PR with these icons or will you make it yourself?
You can make the PR with the filled icons, please check if these work though. I'll try to see if the tool @biodranik mentioned changes the code in a second.
It seems the changes, while minor, have made it uploadable to GitHub since the tool was made with file preview support in mind. The optimization process is pretty similar to mine, I didn't realize there was one built in with OM, I'll use it from now on.
@dvdmrtnz Feel free to PR these


I will make the PR now.
I had to modify the power symbol because the transparent border on the dark mode was mixing with the transparent fill and creating a different shade of white. See:
Thanks for testing, it's interesting that OM treats borders this way, will keep it in mind. I'll close the issue now