[android] Position arrow overlaps with bottom bar in navigation mode. #3441

New issue

Open

opened 2022-09-18 09:09:17 +00:00 by vng · 4 comments

vng commented

2022-09-18 09:09:17 +00:00

(Migrated from github.com)

Samsung Galaxy S20 FE (Snapdragon), latest beta:

Samsung Galaxy S20 FE (Snapdragon), latest beta: ![photo_2022-09-18 12 08 19](https://user-images.githubusercontent.com/175612/190894610-a2285f11-d447-4e30-b919-968863cc41c4.jpeg)

👍 1

arnaudvergnet commented

2022-09-18 10:59:58 +00:00

(Migrated from github.com)

Is the font size changed in Android settings? This may have been introduced by organicmaps/organicmaps#3085. Before this patch the navigation bar was of fixed height (so text could be cut off if the font was too large). Now the height scales with the content so if the font is too large, this issue may occur.

A good fix would be to move the camera depending on the navigation menu height but I have no clue on how to do that.

Is the font size changed in Android settings? This may have been introduced by https://git.omaps.dev/organicmaps/organicmaps/pulls/3085. Before this patch the navigation bar was of fixed height (so text could be cut off if the font was too large). Now the height scales with the content so if the font is too large, this issue may occur. A good fix would be to move the camera depending on the navigation menu height but I have no clue on how to do that.

👍 1

biodranik commented

2022-09-18 12:15:22 +00:00

(Migrated from github.com)

@vng let's slightly increase the arrow height first. Even without this issue, it was positioned too low.

@arnaudvergnet A proper fix should take into account the nav bar, of course. So we have several choices here:

Pass the new height into the core so it can adjust the arrow height. Can be tricky, and may lead to an unusable UI if a user sets a very large font and has a very small screen.
Fix the height of the nav bar as it was before, but dynamically format/reduce the font size in the displayed info to fit it. That is easier to implement, but can be inconvenient for some users with bad eyesight. Can be a good temporary solution though.
Get rid of the nav bar completely (or partially by making a hole in the center) in favor of a new UI/UX, as we did for the main map screen. The current speed and speed limit can be displayed in a circle somewhere in the (top?) corner. The remaining time and distance can also be displayed somewhere else (e.g. in the bottom left and bottom right corners, or even in the top street info bar).

@vng let's slightly increase the arrow height first. Even without this issue, it was positioned too low. @arnaudvergnet A proper fix should take into account the nav bar, of course. So we have several choices here: 1. Pass the new height into the core so it can adjust the arrow height. Can be tricky, and may lead to an unusable UI if a user sets a very large font and has a very small screen. 2. Fix the height of the nav bar as it was before, but dynamically format/reduce the font size in the displayed info to fit it. That is easier to implement, but can be inconvenient for some users with bad eyesight. Can be a good temporary solution though. 3. Get rid of the nav bar completely (or partially by making a hole in the center) in favor of a new UI/UX, as we did for the main map screen. The current speed and speed limit can be displayed in a circle somewhere in the (top?) corner. The remaining time and distance can also be displayed somewhere else (e.g. in the bottom left and bottom right corners, or even in the top street info bar).

👍 1

rtsisyk commented

2022-09-20 05:35:16 +00:00

Owner

This bug still present in the current master. On Samsung S10 (Android 12) the arrow is not overlapped, but it is noticeably lower than it was before. On Pixel 4a (Android 13) the ends of the arrow are overlapped a little bit.

biodranik commented

2022-10-08 16:01:45 +00:00

(Migrated from github.com)

It is resolved, right?

This repo is archived. You cannot comment on issues.