multiple problems with TRACK_POINTERS enabled #357

Closed
opened 2021-04-30 01:15:37 +00:00 by Dushistov · 1 comment
Dushistov commented 2021-04-30 01:15:37 +00:00 (Migrated from github.com)

I see multiple problems with TRACK_POINTERS enabled in drape/drape_diagnostics.hpp:

LOG TID(3) WARNING   9.13931 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f3538aa1470 ] was destroyed, but had references, ref count =  2
LOG TID(3) WARNING   9.13959 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f35389d3200 ] was destroyed, but had references, ref count =  2
LOG TID(3) WARNING    9.1396 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f35389d5300 ] was destroyed, but had references, ref count =  2
LOG TID(3) WARNING   9.13962 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f35389d9500 ] was destroyed, but had references, ref count =  2
LOG TID(3) WARNING   9.13969 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f3538d3cb80 ] was destroyed, but had references, ref count =  2
TID(3) ASSERT FAILED
drape/pointers.cpp:53
CHECK(it->second.first > 0) 
OMaps: ../drape/pointers.cpp:53: void DpPointerTracker::DerefPtr(void*): Проверочное утверждение «false» не выполнено.

I build and run 5a979ab1c2 on Linux PC.
After run I change scale and immediately hit assert at ../drape/pointers.cpp:53: void DpPointerTracker::DerefPtr(void*)

I see multiple problems with TRACK_POINTERS enabled in drape/drape_diagnostics.hpp: ``` LOG TID(3) WARNING 9.13931 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f3538aa1470 ] was destroyed, but had references, ref count = 2 LOG TID(3) WARNING 9.13959 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f35389d3200 ] was destroyed, but had references, ref count = 2 LOG TID(3) WARNING 9.1396 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f35389d5300 ] was destroyed, but had references, ref count = 2 LOG TID(3) WARNING 9.13962 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f35389d9500 ] was destroyed, but had references, ref count = 2 LOG TID(3) WARNING 9.13969 drape/pointers.cpp:37 DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f3538d3cb80 ] was destroyed, but had references, ref count = 2 TID(3) ASSERT FAILED drape/pointers.cpp:53 CHECK(it->second.first > 0) OMaps: ../drape/pointers.cpp:53: void DpPointerTracker::DerefPtr(void*): Проверочное утверждение «false» не выполнено. ``` I build and run 5a979ab1c25631b16564d91d320399c613671231 on Linux PC. After run I change scale and immediately hit assert at `../drape/pointers.cpp:53: void DpPointerTracker::DerefPtr(void*)`
Dushistov commented 2021-04-30 02:59:58 +00:00 (Migrated from github.com)

Looks like this happens:

DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f3538d3cb80 ] was destroyed, but had references, ref count = 2

because all unique_ptr was dropped when RenderGroup was dropped here, but all ref_ptr<OverlayHandle> that points to already deleted unique_ptr<OverlayHandle> still exists in OverlayTree.
Because of OverlayTree::Remove(ref_ptr handle) only set flag to invalidate them in the next frame rendering.

Looks like this happens: > DestroyPtr() Drape pointer [ PN2dp13OverlayHandleE 0x7f3538d3cb80 ] was destroyed, but had references, ref count = 2 because all unique_ptr<OverlayHandle> was dropped when `RenderGroup` was dropped [here](https://github.com/organicmaps/organicmaps/blob/5a979ab1c25631b16564d91d320399c613671231/drape_frontend/frontend_renderer.cpp#L77), but all `ref_ptr<OverlayHandle>` that points to already deleted `unique_ptr<OverlayHandle>` still exists in `OverlayTree`. Because of [OverlayTree::Remove(ref_ptr<OverlayHandle> handle)](https://github.com/organicmaps/organicmaps/blob/5a979ab1c25631b16564d91d320399c613671231/drape/overlay_tree.cpp#L156) only set flag to invalidate them in the next frame rendering.
This repo is archived. You cannot comment on issues.
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#357
No description provided.