organicmaps/organicmaps-tmp
Archived
13
Fork 1
Code Issues 2.7k Pull requests 182 Projects Releases 65 Wiki Activity Actions

Add physiotherapist #3844

Merged
Mr-Mime merged 4 commits from master into master 2022-11-11 13:44:37 +00:00
Conversation 14 Commits 4 Files changed 115 +8417 -7962
Mr-Mime commented 2022-11-08 19:28:50 +00:00 (Migrated from github.com)
Copy link

To fix/close #3831 I made the following changes:

  1. Created a new type for the classificator
  2. Added the necessary translations (done with deepl)
  3. Added the new type to the editor
  4. Added a new icon (taken from tablericons)
  5. Regenerated styles, symbols and strings

I was not able to completely test the changes.
The map I created locally doe not show the new icons neither anything else at the location where I expect a physiotherapist.
Thus I can neither test the icon and if the strings on the place page are correct.

Omaps release My generated map
signal-2022-11-08-202420_002 signal-2022-11-08-201732_002

I generated the map with python -m maps_generator --countries="Germany_Berlin" --skip="Coastline".
I'll continue to find out what I am doing wrong / which step I am missing.
Any help or hint is appreciated.

To fix/close #3831 I made the following changes: 1. Created a new type for the classificator 2. Added the necessary translations (done with deepl) 3. Added the new type to the editor 4. Added a new icon (taken from [tablericons](https://tablericons.com/)) 5. Regenerated styles, symbols and strings I was not able to completely test the changes. The map I created locally doe not show the new icons neither anything else at the location where I expect a physiotherapist. Thus I can neither test the icon and if the strings on the place page are correct. | Omaps release | My generated map | | --- | --- | | ![signal-2022-11-08-202420_002](https://user-images.githubusercontent.com/37423773/200656531-e23f38ae-24b6-4cb2-817c-7e06116023cd.jpeg) | ![signal-2022-11-08-201732_002](https://user-images.githubusercontent.com/37423773/200656630-6a240f8a-720e-43a2-adff-e118827c681c.png) I generated the map with `python -m maps_generator --countries="Germany_Berlin" --skip="Coastline"`. I'll continue to find out what I am doing wrong / which step I am missing. Any help or hint is appreciated.
MetehanOzyurek (Migrated from github.com) approved these changes 2022-11-08 19:30:24 +00:00
jimcarst (Migrated from github.com) approved these changes 2022-11-08 19:42:30 +00:00
lunarna-gh (Migrated from github.com) approved these changes 2022-11-08 22:01:24 +00:00
biodranik commented 2022-11-08 22:19:03 +00:00 (Migrated from github.com)
Copy link

@vng can you please take a look?

@vng can you please take a look?
vng (Migrated from github.com) reviewed 2022-11-09 06:05:09 +00:00
data/styles/clear/include/Icons.mapcss
vng (Migrated from github.com) commented 2022-11-09 06:05:09 +00:00

Add healthcare=physiotherapist to other places in this file, exactly like healthcare=laboratory.
It should also have {text: name} style.

Add healthcare=physiotherapist to other places in this file, exactly like healthcare=laboratory. It should also have {text: name} style.
Mr-Mime (Migrated from github.com) reviewed 2022-11-09 08:20:10 +00:00
data/styles/clear/include/Icons.mapcss
Mr-Mime (Migrated from github.com) commented 2022-11-09 08:20:09 +00:00

I added the entries in data/styles/clear/include/Icons.mapcss and regenerated the styles.
However on my locally built map, I still do not see anything.

What I did
  1. tools/unix/generate_symbols.sh
  2. tools/unix/generate_drules.sh
  3. python -m maps_generator --countries="Germany_Berlin" --skip="Coastline"
  4. Copied the result to the phone
I added the entries in `data/styles/clear/include/Icons.mapcss` and regenerated the styles. However on my locally built map, I still do not see anything. <details> <summary>What I did</summary> 1. `tools/unix/generate_symbols.sh` 2. `tools/unix/generate_drules.sh` 3. `python -m maps_generator --countries="Germany_Berlin" --skip="Coastline"` 4. Copied the result to the phone </details>
matheusgomesms (Migrated from github.com) approved these changes 2022-11-09 10:56:23 +00:00
biodranik commented 2022-11-09 11:26:08 +00:00 (Migrated from github.com)
Copy link

You didn't edit data/styles/vehicle/include/Basemap.mapcss and data/styles/clear/include/Basemap.mapcss

You didn't edit data/styles/vehicle/include/Basemap.mapcss and data/styles/clear/include/Basemap.mapcss
vng commented 2022-11-09 12:39:17 +00:00 (Migrated from github.com)
Copy link

This is enough. Now you should see therapist icons, right?
Basemap.mapcss can be skipped here ..

This is enough. Now you should see therapist icons, right? Basemap.mapcss can be skipped here ..
j13m126 (Migrated from github.com) reviewed 2022-11-09 12:45:35 +00:00
data/strings/types_strings.txt
j13m126 (Migrated from github.com) commented 2022-11-09 12:45:35 +00:00

physiotherapist should be capitalized

physiotherapist should be capitalized
j13m126 (Migrated from github.com) reviewed 2022-11-09 12:54:07 +00:00
data/strings/types_strings.txt
j13m126 (Migrated from github.com) commented 2022-11-09 12:54:07 +00:00

also: please add estonian.
et = Füsioterapeut

also: please add estonian. et = Füsioterapeut
j13m126 (Migrated from github.com) reviewed 2022-11-09 12:54:42 +00:00
data/categories.txt
@ -4570,0 +4588,4 @@
ja:理学療法士
ko:물리치료사
mr:फिजिओथेरपिस्ट
nb:Fysioterapeut
j13m126 (Migrated from github.com) commented 2022-11-09 12:54:41 +00:00

et:Füsioterapeut

et:Füsioterapeut
Mr-Mime (Migrated from github.com) reviewed 2022-11-09 13:13:25 +00:00
data/strings/types_strings.txt
Mr-Mime (Migrated from github.com) commented 2022-11-09 13:13:25 +00:00

Thanks fixed in organicmaps/organicmaps#3844/commits/c6d60829ca1adb2318cb47df31d48933a2abfede

Thanks fixed in https://git.omaps.dev/organicmaps/organicmaps/pulls/3844/commits/c6d60829ca1adb2318cb47df31d48933a2abfede
Mr-Mime (Migrated from github.com) reviewed 2022-11-09 13:13:41 +00:00
data/categories.txt
@ -4570,0 +4588,4 @@
ja:理学療法士
ko:물리치료사
mr:फिजिओथेरपिस्ट
nb:Fysioterapeut
Mr-Mime (Migrated from github.com) commented 2022-11-09 13:13:41 +00:00

Added in organicmaps/organicmaps#3844/commits/c6d60829ca1adb2318cb47df31d48933a2abfede

Added in https://git.omaps.dev/organicmaps/organicmaps/pulls/3844/commits/c6d60829ca1adb2318cb47df31d48933a2abfede
Mr-Mime commented 2022-11-09 13:20:25 +00:00 (Migrated from github.com)
Copy link

This is enough. Now you should see therapist icons, right?

Yes I just forgot that I also need to rebuild the app.

Light mode Dark mode PP (before I updated the translation)
signal-2022-11-09-135315 signal-2022-11-09-135312 signal-2022-11-09-141645

You didn't edit data/styles/vehicle/include/Basemap.mapcss and data/styles/clear/include/Basemap.mapcss

@biodranik and @vng what about the Basemaps?
Could you shortly explain what this is for?

If I should add the changes there just let me know.
Right now @biodranik says "yes" and @vng "no" ;)

> This is enough. Now you should see therapist icons, right? Yes I just forgot that I also need to rebuild the app. | Light mode | Dark mode | PP (before I updated the translation) | | --- | --- | --- | | ![signal-2022-11-09-135315](https://user-images.githubusercontent.com/37423773/200840056-f6e2b7d0-e341-47b9-a594-fcd178f7bcf3.png) | ![signal-2022-11-09-135312](https://user-images.githubusercontent.com/37423773/200840130-a280d416-15ee-4250-afb1-25c9bda265ed.png) | ![signal-2022-11-09-141645](https://user-images.githubusercontent.com/37423773/200840345-a2913cdd-1234-4313-9304-e9c469d4dbfe.png) | --- > You didn't edit data/styles/vehicle/include/Basemap.mapcss and data/styles/clear/include/Basemap.mapcss @biodranik and @vng what about the Basemaps? Could you shortly explain what this is for? If I should add the changes there just let me know. Right now @biodranik says "yes" and @vng "no" ;)
vng commented 2022-11-09 14:15:39 +00:00 (Migrated from github.com)
Copy link

There is no any specific purpose on different *.mapcss files, just some logical code distinguish, made a long time ago. I usually check the final styles in drules_proto_*.txt If they are ok, no problem here ..
We have a lot of bloat mapcss code now (many useless entries), so the basic rule is to achieve needed behaviour with the minimum changes. I suspect that if you make additional therapist changes in Basemap files, you will get the same drules_proto output anyway ..

There is no any specific purpose on different ```*.mapcss``` files, just some _logical_ code distinguish, made a long time ago. I usually check the final styles in ```drules_proto_*.txt``` If they are ok, no problem here .. We have a lot of _bloat_ mapcss code now (many useless entries), so the basic rule is to achieve needed behaviour with the minimum changes. I suspect that if you make additional _therapist_ changes in Basemap files, you will get the same drules_proto output anyway ..
👍 1
vng commented 2022-11-09 14:20:16 +00:00 (Migrated from github.com)
Copy link

Please, sign your commits with DCO and make 4 final commits:

  • actual changes
  • regenerated symbols
  • regenerated styles
  • regenerated strings
Please, sign your commits with DCO and make 4 final commits: - actual changes - regenerated symbols - regenerated styles - regenerated strings
dvdmrtnz commented 2022-11-09 15:38:03 +00:00
Contributor
Copy link

The style of symbol in the PR is like the sports symbols or some other minor things on the map .

Shoudn't this symbol be in the style of the hospital symbol , or the pharmacy symbol ?

The style of symbol in the PR is like the sports symbols <img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/tennis-m.svg" height="30" /><img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/soccer-m.svg" height="30" /><img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/basketball-m.svg" height="30" /> or some other minor things on the map <img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/chimney-m.svg" height="30" /><img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/power-m.svg" height="30" />. Shoudn't this symbol be in the style of the hospital symbol <img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/hospital-m.svg" height="30" />, or the pharmacy symbol <img src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/pharmacy-m.svg" height="30" /> ?
Mr-Mime commented 2022-11-09 17:50:41 +00:00 (Migrated from github.com)
Copy link

The style of symbol in the PR is like the sports symbols or some other minor things on the map .

Shoudn't this symbol be in the style of the hospital symbol , or the pharmacy symbol ?

I see your point there, as it is still in the medical/doctors domain, it would be good to have a similar coloring and shape.
This is how OsmAnd App shows a normal doctor on the right and a physiotherapist on the left.

I will test my svg skills and create a icon similar to the pharmacy one but with the proposed physiotherapist icon inside.

> The style of symbol in the PR is like the sports symbols <img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/tennis-m.svg"><img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/soccer-m.svg"><img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/basketball-m.svg"> or some other minor things on the map <img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/chimney-m.svg"><img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/power-m.svg">. > > Shoudn't this symbol be in the style of the hospital symbol <img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/hospital-m.svg">, or the pharmacy symbol <img alt="" height="30" src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/pharmacy-m.svg"> ? I see your point there, as it is still in the medical/doctors domain, it would be good to have a similar coloring and shape. This is how OsmAnd App shows a normal doctor on the right and a physiotherapist on the left. <img src="https://user-images.githubusercontent.com/37423773/200902507-27c26b99-a3f2-4f04-a305-007f9dd9d36c.jpeg" width=400 /> I will test my svg skills and create a icon similar to the pharmacy one but with the proposed physiotherapist icon inside.
Mr-Mime commented 2022-11-09 19:32:25 +00:00 (Migrated from github.com)
Copy link

@dvdmrtnz What do you think about these?

I personally like the rounded one more.
Other opinions and improvement ideas are welcome!

Proposed physiotherapist icon Physiotherapist with rounded elements Hospital icon for comparison
@dvdmrtnz What do you think about these? I personally like the rounded one more. Other opinions and improvement ideas are welcome! | Proposed physiotherapist icon | Physiotherapist with rounded elements | Hospital icon for comparison | | --- | --- | --- | | <img src="https://user-images.githubusercontent.com/37423773/200921959-7efc8a27-3729-4a80-9c62-fd32409dd0be.svg" width=200px /> | <img src="https://user-images.githubusercontent.com/37423773/200923471-337eeca6-0954-4074-8a77-235016129218.svg" width=200px /> | <img alt="" width=200px src="https://raw.githubusercontent.com/organicmaps/organicmaps/master/data/styles/clear/style-clear/symbols/hospital-m.svg">
dvdmrtnz commented 2022-11-09 21:04:06 +00:00
Contributor
Copy link

I like the rounded one more, too. Good job! 👍

I like the rounded one more, too. Good job! 👍
👍 1
Mr-Mime commented 2022-11-09 22:06:29 +00:00 (Migrated from github.com)
Copy link

@vng and / or @biodranik I'd like to have a opinion from a member, regarding the icon decision.
Afterwards I make the changes and push new commits.

@vng and / or @biodranik I'd like to have a opinion from a member, regarding the icon decision. Afterwards I make the changes and push new commits.
biodranik commented 2022-11-09 22:55:39 +00:00 (Migrated from github.com)
Copy link

The rounded icon looks good, thanks for your help!
Just make sure that it has the same color as other icons/doctor icons in light and dark modes.

The rounded icon looks good, thanks for your help! Just make sure that it has the same color as other icons/doctor icons in light and dark modes.
Mr-Mime commented 2022-11-10 00:15:43 +00:00 (Migrated from github.com)
Copy link

I added the new icon and regenerated the symbols.
Here you can see it in light and night mode.
As visible it looks like the doctor icon regarding the coloring and the opacity (for night mode).

night light
signal-2022-11-10-005401 signal-2022-11-10-005338

@j13m126 I had to remove the estonian translation from the categories.txt, as it crashed the android app on startup.
It seems like as the estonian translation is not officially added yet and thus the app fails to handle the language code.

Snippet from the android log 
 E  indexer/categories_holder.cpp:231 LoadFromStream(): CHECK(langCode != kUnsupportedLocaleCode) Invalid language code: et at line: 4580
2022-11-10 00:43:15.273 30405-30405 libc                    app.organicmaps.debug                A  /home/lennox/coding/organicmaps/indexer/categories_holder.cpp:231: void CategoriesHolder::LoadFromStream(std::istream &): assertion "false" failed
2022-11-10 00:43:15.273 30405-30405 libc                    app.organicmaps.debug                A  Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 30405 (ganicmaps.debug), pid 30405 (ganicmaps.debug)
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A  Cmdline: app.organicmaps.debug
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A  pid: 30405, tid: 30405, name: ganicmaps.debug  >>> app.organicmaps.debug <<<
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A        #02 pc 0000000002bb7140  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (CategoriesHolder::LoadFromStream(std::__ndk1::basic_istream<char, std::__ndk1::char_traits<char> >&)+996) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A        #03 pc 0000000002bb6a20  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (CategoriesHolder::CategoriesHolder(std::__ndk1::unique_ptr<Reader, std::__ndk1::default_delete<Reader> >&&)+152) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A        #04 pc 0000000002bb9a50  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (GetDefaultCategories()+160) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A        #05 pc 00000000020df6c4  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (Framework::Framework(FrameworkParams const&)+3788) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.703 30537-30537 DEBUG                   pid-30537                            A        #06 pc 0000000001fe5e88  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (android::Framework::Framework()+168) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #07 pc 0000000001ffc4b8  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #08 pc 0000000001ffc448  /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (Java_app_organicmaps_MwmApplication_nativeInitFramework+60) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #16 pc 00000000000128fa  [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.MwmApplication.initNativeFramework+10)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #22 pc 00000000000128d6  [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.MwmApplication.init+6)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #28 pc 00000000000135cc  [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.SplashActivity.init+8)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #34 pc 0000000000013570  [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.SplashActivity.-$$Nest$minit+0)
2022-11-10 00:43:15.704 30537-30537 DEBUG                   pid-30537                            A        #37 pc 00000000000134d0  [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.SplashActivity$1.run+4)
---------------------------- PROCESS ENDED (30405) for package app.organicmaps.debug ----------------------------
I added the new icon and regenerated the symbols. Here you can see it in light and night mode. As visible it looks like the doctor icon regarding the coloring and the opacity (for night mode). | night | light | | --- | --- | | ![signal-2022-11-10-005401](https://user-images.githubusercontent.com/37423773/200968556-4bd28b93-db1d-4875-ad11-e013e302e2e5.jpeg) | ![signal-2022-11-10-005338](https://user-images.githubusercontent.com/37423773/200968493-6f7157b0-f11f-4732-8fc5-7ff68f4f54c4.jpeg) | --- @j13m126 I had to remove the estonian translation from the `categories.txt`, as it crashed the android app on startup. It seems like as the estonian translation is not officially added yet and thus the app fails to handle the language code. <details> <summary>Snippet from the android log</summary> ``` E indexer/categories_holder.cpp:231 LoadFromStream(): CHECK(langCode != kUnsupportedLocaleCode) Invalid language code: et at line: 4580 2022-11-10 00:43:15.273 30405-30405 libc app.organicmaps.debug A /home/lennox/coding/organicmaps/indexer/categories_holder.cpp:231: void CategoriesHolder::LoadFromStream(std::istream &): assertion "false" failed 2022-11-10 00:43:15.273 30405-30405 libc app.organicmaps.debug A Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 30405 (ganicmaps.debug), pid 30405 (ganicmaps.debug) 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A Cmdline: app.organicmaps.debug 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A pid: 30405, tid: 30405, name: ganicmaps.debug >>> app.organicmaps.debug <<< 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A #02 pc 0000000002bb7140 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (CategoriesHolder::LoadFromStream(std::__ndk1::basic_istream<char, std::__ndk1::char_traits<char> >&)+996) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A #03 pc 0000000002bb6a20 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (CategoriesHolder::CategoriesHolder(std::__ndk1::unique_ptr<Reader, std::__ndk1::default_delete<Reader> >&&)+152) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A #04 pc 0000000002bb9a50 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (GetDefaultCategories()+160) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A #05 pc 00000000020df6c4 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (Framework::Framework(FrameworkParams const&)+3788) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.703 30537-30537 DEBUG pid-30537 A #06 pc 0000000001fe5e88 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (android::Framework::Framework()+168) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #07 pc 0000000001ffc4b8 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #08 pc 0000000001ffc448 /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/lib/arm64/liborganicmaps.so (Java_app_organicmaps_MwmApplication_nativeInitFramework+60) (BuildId: c96499914cb00f6fa256fba02102992b6be7ab5b) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #16 pc 00000000000128fa [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.MwmApplication.initNativeFramework+10) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #22 pc 00000000000128d6 [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.MwmApplication.init+6) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #28 pc 00000000000135cc [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.SplashActivity.init+8) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #34 pc 0000000000013570 [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.SplashActivity.-$$Nest$minit+0) 2022-11-10 00:43:15.704 30537-30537 DEBUG pid-30537 A #37 pc 00000000000134d0 [anon:dalvik-classes4.dex extracted in memory from /data/app/~~zWS_tF5CatyVb1SFOSuQ1w==/app.organicmaps.debug-yOvAA-l2njWcPCR_IyOiiA==/base.apk!classes4.dex] (app.organicmaps.SplashActivity$1.run+4) ---------------------------- PROCESS ENDED (30405) for package app.organicmaps.debug ---------------------------- ```` </details>
biodranik commented 2022-11-10 00:22:56 +00:00 (Migrated from github.com)
Copy link

Don't worry, we'll enable estonian translations later in a separate commit.

Don't worry, we'll enable estonian translations later in a separate commit.
biodranik (Migrated from github.com) approved these changes 2022-11-10 00:25:23 +00:00
data/categories.txt
@ -4570,0 +4578,4 @@
el:Φυσικοθεραπευτής
es:Fisioterapeuta
eu:Fisioterapeuta
fa:فیزیوتراپیست
biodranik (Migrated from github.com) commented 2022-11-10 00:25:16 +00:00

For the future reference: case in categories.txt file is not required, because these strings are used for search only, and are not visible to users.

For the future reference: case in categories.txt file is not required, because these strings are used for search only, and are not visible to users.
data/strings/types_strings.txt
biodranik (Migrated from github.com) commented 2022-11-08 22:16:53 +00:00

Capital P

Capital P
Mr-Mime (Migrated from github.com) reviewed 2022-11-10 00:30:59 +00:00
data/categories.txt
@ -4570,0 +4578,4 @@
el:Φυσικοθεραπευτής
es:Fisioterapeuta
eu:Fisioterapeuta
fa:فیزیوتراپیست
Mr-Mime (Migrated from github.com) commented 2022-11-10 00:30:59 +00:00

Okay thanks, I just orientated on the other entries.
But is noted for future work 👍

Okay thanks, I just orientated on the other entries. But is noted for future work :+1:
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
MetehanOzyurek
jimcarst
lunarna-gh
matheusgomesms
biodranik
Labels
Clear labels   
Accessibility

issues affecting users with specific needs

  
Accessibility

issues affecting users with specific needs

  
Address

Issues with addresses, post codes, city/town/village borders

  
Address

Issues with addresses, post codes, city/town/village borders

  
Android

Android development

  
Android

Android development

  
Android Auto

Android Auto

  
Android Auto

Android Auto

  
Android Automotive (AAOS)

   
Android Automotive (AAOS)

   
API

Short Links, deep links and url schemes, including ge0 and om://

  
API

Short Links, deep links and url schemes, including ge0 and om://

  
AppGallery

Huawei AppGallery

  
AppGallery

Huawei AppGallery

  
AppStore

Apple AppStore

  
AppStore

Apple AppStore

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Battery and Performance

Performance and battery consumption-related issues and optimizations

  
Blocker

An issue blocking the release

  
Blocker

An issue blocking the release

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Bookmarks and Tracks

Bookmarks, imported tracks, and KML, KMZ, KMB, GPX, GPZ import or export

  
Borders

Country borders and polygons

  
Borders

Country borders and polygons

  
Bug

Something isn't working

  
Bug

Something isn't working

  
Build

Compilation issue

  
Build

Compilation issue

  
CarPlay

CarPlay Integration

  
CarPlay

CarPlay Integration

  
Classificator

Classify object by types

  
Classificator

Classify object by types

  
Community

Community relations

  
Community

Community relations

  
Core

Cross-platform C++ libraries with a core functionality

  
Core

Cross-platform C++ libraries with a core functionality

  
CrashReports

Crash Reporting

  
CrashReports

Crash Reporting

  
Cycling

Bike, cycle, biking and related

  
Cycling

Bike, cycle, biking and related

  
Desktop

Desktop application

  
Desktop

Desktop application

  
DevEx

Developer Experience

  
DevEx

Developer Experience

  
DevOps

Automation and pipelines

  
DevOps

Automation and pipelines

  
dev_sandbox

A desktop app to debug rendering

  
dev_sandbox

A desktop app to debug rendering

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Directions

Issues with next turns, labels, streets, voice instructions

  
Documentation

Improvements or additions to documentation

  
Documentation

Improvements or additions to documentation

  
Downloader

Map dowloader

  
Downloader

Map dowloader

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Drape

Drape OpenGL, Vulkan and Metal graphics rendering engine

  
Driving

Drive a car related issues

  
Driving

Drive a car related issues

  
Duplicate

This issue or pull request already exists

  
Duplicate

This issue or pull request already exists

  
Editor

OSM Editor

  
Editor

OSM Editor

  
Elevation

Isolines and altitude

  
Elevation

Isolines and altitude

  
Enhancement

New feature or request, an improvement of some existing feature

  
Enhancement

New feature or request, an improvement of some existing feature

  
Epic

A large body work

  
Epic

A large body work

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
External Map Datasets

TIGER, Ordnance Survey, ASTER, SRTM, etc.

  
F-Droid

F-Droid build and distribution

  
F-Droid

F-Droid build and distribution

  
Fonts

Font and text rendering

  
Fonts

Font and text rendering

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Frequently User Reported

Most annoying UX and other issues for users reported by many people

  
Fund

   
Fund

   
Generator

Related to generator tool.

  
Generator

Related to generator tool.

  
Good first issue

Good for newcomers

  
Good first issue

Good for newcomers

  
Google Play

Google Play

  
Google Play

Google Play

  
GPS

Location and positioning issues

  
GPS

Location and positioning issues

  
GSoC

Ideas for Google Summer of Code

  
GSoC

Ideas for Google Summer of Code

  
iCloud

   
iCloud

   
Icons

Map and app icons

  
Icons

Map and app icons

  
iOS

iOS development

  
iOS

iOS development

  
Legal

Legal aspects

  
Legal

Legal aspects

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux Desktop

Ubuntu, Gentoo, Red Hat, Debian, Cent OS, Fedora, etc.

  
Linux packaging

   
Linux packaging

   
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Linux Phone

LibreM, PinePhone, Wayland and other mobile Linux versions

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Mac OS

Desktop issues related to Mac OS X, OM running on M1, M2, M3 Apple silicon, or Qt version

  
Map Data

OpenStreetMap data related issues

  
Map Data

OpenStreetMap data related issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Metro

Subway, Tube, light-rail public transport issues

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Navigation

Issues related to the active Navigator / Navigation mode

  
Need Feedback

Further information is requested

  
Need Feedback

Further information is requested

  
Night Mode

Night or dark mode feature

  
Night Mode

Night or dark mode feature

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
NLnet 2024-06-281

Tasks related to NLnet 2024-06-281 project.

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
No Feature Parity

A platform needs this to be implemented to have feature parity with other platforms

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Opening Hours

Business Hours, off time, holidays, seasonal

  
Outdoors

Hiking, mtb, 4x4...

  
Outdoors

Hiking, mtb, 4x4...

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
POI Info

Feature metadata, OSM tags that are displayed in Place Page

  
Privacy

Privacy

  
Privacy

Privacy

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Public Transport

Bus, trolleybus, train, tram, metro, subway, light rail

  
Raw Idea

An idea that needs to be elaborated

  
Raw Idea

An idea that needs to be elaborated

  
Refactoring

   
Refactoring

   
Regional

This issue is different depending on the country or region

  
Regional

This issue is different depending on the country or region

  
Regression

A regression bug

  
Regression

A regression bug

  
Releases

Meta-tickets for tracking the release procedure

  
Releases

Meta-tickets for tracking the release procedure

  
RoboTest

Robo / Monkey Auto Tests

  
RoboTest

Robo / Monkey Auto Tests

  
Route Planning

Preview and plan your track

  
Route Planning

Preview and plan your track

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Routing

Route building issues, e.g. valid route, valid ETA

  
Ruler

Helicopter routing, "as a crow flies"

  
Ruler

Helicopter routing, "as a crow flies"

  
Search

Search

  
Search

Search

  
Security

Security improvements

  
Security

Security improvements

  
Styles

Map drawing styles

  
Styles

Map drawing styles

  
Tests

   
Tests

   
Track Recording

Track Recording

  
Track Recording

Track Recording

  
Translations

Localization and translations issues

  
Translations

Localization and translations issues

  
TTS

Text-to-Speech

  
TTS

Text-to-Speech

  
UI

User interface issues

  
UI

User interface issues

  
UX

User eXperience, an issue with usability

  
UX

User eXperience, an issue with usability

  
Walk Navigation

Foot pedestrian mode

  
Walk Navigation

Foot pedestrian mode

  
Watches

Android Watches or Apple Watches support

  
Watches

Android Watches or Apple Watches support

  
Web

https://organicmaps.app/

  
Web

https://organicmaps.app/

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Wikipedia

Issues related to Wiki articles embedded in OM data files.

  
Windows

Windows

  
Windows

Windows

  
Won't fix

Unfeasible or impossible to resolve

  
Won't fix

Unfeasible or impossible to resolve

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

  
World Map

Issues about improving the base map of the whole world that is bundled with the app

No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#3844
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?