organicmaps/organicmaps-tmp

Archived

Fork 1

Unable to open openstreetmap.org link on osm login fragment #3950

New issue

Closed

opened 2022-11-23 06:03:45 +00:00 by Jean-BaptisteC · 7 comments

Jean-BaptisteC commented

2022-11-23 06:03:45 +00:00

(Migrated from github.com)

How reproduce:

Start OM --> settings --> Profile OSM (Need app without OSM connection)
Click on openstreetmap.org
OM restart

To reproduce openstreetmap.org has been enabled on Android app settings (open by default)

I think OM try to open link because he has detected like openable link but he has not GPS coordinates to load position on map
Maybe be more restrictive on openable link, to allow users to open openstreemap.org on browser without start OM

78f09b392d/android/AndroidManifest.xml (L554)

Android 13 - Pixel 6
v2022.11.02-2-Google

How reproduce: - Start OM --> settings --> Profile OSM (Need app without OSM connection) - Click on [openstreetmap.org](openstreetmap.org) - OM restart To reproduce openstreetmap.org has been enabled on Android app settings (open by default) I think OM try to open link because he has detected like openable link but he has not GPS coordinates to load position on map Maybe be more restrictive on openable link, to allow users to open openstreemap.org on browser without start OM https://github.com/organicmaps/organicmaps/blob/78f09b392d5a12c9033934d8044ee88d52bd5854/android/AndroidManifest.xml#L554 Android 13 - Pixel 6 v2022.11.02-2-Google

biodranik commented

2022-11-23 06:11:04 +00:00

(Migrated from github.com)

You're right, OM should intercept only links with coordinates, like https://www.openstreetmap.org/#map=15/45.8610/18.4110, and should not intercept general links, including wiki.

But it also should not crash.

@rtsisyk can you please fix it?

You're right, OM should intercept only links with coordinates, like `https://www.openstreetmap.org/#map=15/45.8610/18.4110`, and should not intercept general links, including wiki. But it also should not crash. @rtsisyk can you please fix it?

rtsisyk commented

2023-01-07 09:14:57 +00:00

Owner

You're right, OM should intercept only links with coordinates, like https://www.openstreetmap.org/#map=15/45.8610/18.4110, and should not intercept general links, including wiki.

But it also should not crash.

@rtsisyk can you please fix it?

Unfortunately, there is no way to intercept only links only with "#map=". Only scheme, host, port, path can be used to filter URLs.

940bbad149/android/AndroidManifest.xml (L553-L558)

Shall we remove "/" hook?

P.S. intercepting of unverified links doesn't work on Android 12+.

> You're right, OM should intercept only links with coordinates, like `https://www.openstreetmap.org/#map=15/45.8610/18.4110`, and should not intercept general links, including wiki. > > But it also should not crash. > > @rtsisyk can you please fix it? Unfortunately, there is no way to intercept only links only with "#map=". Only scheme, host, port, path can be used to filter URLs. https://github.com/organicmaps/organicmaps/blob/940bbad1497b3e13ccd372d9c7667965e082758a/android/AndroidManifest.xml#L553-L558 Shall we remove "/" hook? P.S. intercepting of unverified links doesn't work on Android 12+.

biodranik commented

2023-01-07 18:00:11 +00:00

(Migrated from github.com)

Let's leave it as is for Android 5-11, but fix the crash.

rtsisyk commented

2023-01-08 17:29:34 +00:00

Owner

Let's leave it as is for Android 5-11, but fix the crash.

Any details about the crash? I can't repro any crashes with https://www.openstreetmap.org/#map=15/45.8610/18.4110above.

> Let's leave it as is for Android 5-11, but fix the crash. Any details about the crash? I can't repro any crashes with `https://www.openstreetmap.org/#map=15/45.8610/18.4110`above.

Jean-BaptisteC commented

2023-01-08 17:52:14 +00:00

(Migrated from github.com)

I have doing some test, we don't have crash, i guess OM restart activity to open link
Here is log when i click on OSM link in login fragment

01-08 18:48:41.527  1461  1523 I ActivityManager: Start proc 31387:com.android.chrome:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:9/u0ai9 for  {com.android.chrome/org.chromium.content.app.SandboxedProcessService0:9}
01-08 18:48:41.527 31387 31387 E libc    : SetHeapTaggingLevel: re-enabling tagging after it was disabled is not supported
01-08 18:48:41.533 31387 31387 E ocessService0:9: Not starting debugger since process cannot load the jdwp agent.
01-08 18:48:41.592  1461  1889 I ActivityManager: Killing 31387:com.android.chrome:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:9/u0a176i-8991 (adj 0): isolated not needed
01-08 18:48:41.711 30156 30156 E cr_CompositorSurfaceMgr: surfaceDestroyed format : 4

I have doing some test, we don't have crash, i guess OM restart activity to open link Here is log when i click on OSM link in login fragment ``` 01-08 18:48:41.527 1461 1523 I ActivityManager: Start proc 31387:com.android.chrome:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:9/u0ai9 for {com.android.chrome/org.chromium.content.app.SandboxedProcessService0:9} 01-08 18:48:41.527 31387 31387 E libc : SetHeapTaggingLevel: re-enabling tagging after it was disabled is not supported 01-08 18:48:41.533 31387 31387 E ocessService0:9: Not starting debugger since process cannot load the jdwp agent. 01-08 18:48:41.592 1461 1889 I ActivityManager: Killing 31387:com.android.chrome:sandboxed_process0:org.chromium.content.app.SandboxedProcessService0:9/u0a176i-8991 (adj 0): isolated not needed 01-08 18:48:41.711 30156 30156 E cr_CompositorSurfaceMgr: surfaceDestroyed format : 4 ```

rtsisyk commented

2023-01-08 17:58:29 +00:00

Owner

I am still thinking about removing / to avoid potential troubles...

I am still thinking about removing `/` to avoid potential troubles...

Jean-BaptisteC commented

2023-01-08 18:10:06 +00:00

(Migrated from github.com)

I have find a solution to open link in browser, if we replace openstreetmap.org by osm.org, link is open in browser.
Just replace constants links with openstreetmap.org by osm.org

I have find a solution to open link in browser, if we replace openstreetmap.org by osm.org, link is open in browser. Just replace constants links with openstreetmap.org by osm.org

👍 1

This repo is archived. You cannot comment on issues.