WIP: GPX Support #4067

dvdmrtnz · 2022-12-10T23:31:28Z

dvdmrtnz commented

2022-12-10 23:31:28 +00:00

I'm working on adding some basic GPX support to Organic Maps. This is still a work in progress...

I'm working on adding some basic GPX support to Organic Maps. This is still a work in progress... https://git.omaps.dev/organicmaps/organicmaps/issues/624

👍 4 ❤️ 4 🚀 2

rtsisyk reviewed 2022-12-10 23:31:28 +00:00

biodranik (Migrated from github.com) reviewed 2022-12-11 07:05:00 +00:00

biodranik (Migrated from github.com) left a comment

Cool! The idea is to read GPX and convert/store it in our internal KML-compatible format, right? And do the same for the export. Right?

biodranik (Migrated from github.com) reviewed 2022-12-11 07:07:11 +00:00

biodranik (Migrated from github.com) left a comment

I would start with unit tests that can read a sample GPX file with all features that OM supports at the moment. And then new features could be added to the sample file and the test could be expanded.
Then your work can be done in TDD manner:

We help with tests review
You fix failing tests by implementing missing functionality.

I would start with unit tests that can read a sample GPX file with _all_ features that OM supports at the moment. And then new features could be added to the sample file and the test could be expanded. Then your work can be done in TDD manner: - We help with tests review - You fix failing tests by implementing missing functionality.

dvdmrtnz commented

2023-01-21 11:18:59 +00:00

Cool! The idea is to read GPX and convert/store it in our internal KML-compatible format, right? And do the same for the export. Right?

Yes

I would start with unit tests that can read a sample GPX file with all features that OM supports at the moment. And then new features could be added to the sample file and the test could be expanded. Then your work can be done in TDD manner:

We help with tests review

You fix failing tests by implementing missing functionality.

I added a very simple unit test as a starting point but I don't know how to run it. Could you guide me a little bit on how to run tests? I am currently working on a macOS computer with Xcode.

> Cool! The idea is to read GPX and convert/store it in our internal KML-compatible format, right? And do the same for the export. Right? Yes > I would start with unit tests that can read a sample GPX file with _all_ features that OM supports at the moment. And then new features could be added to the sample file and the test could be expanded. Then your work can be done in TDD manner: > > * We help with tests review > * You fix failing tests by implementing missing functionality. I added a very simple unit test as a starting point but I don't know how to run it. Could you guide me a little bit on how to run tests? I am currently working on a macOS computer with Xcode.

biodranik (Migrated from github.com) reviewed 2023-01-28 15:53:21 +00:00

biodranik (Migrated from github.com) left a comment

You can select kml_tests as a target binary in XCode and run it.

To run tests from command line or Github Actions, please add your gpx_test.cpp into kml/kml_tests/CMakeLists.txt

You can select kml_tests as a target binary in XCode and run it. To run tests from command line or Github Actions, please add your gpx_test.cpp into kml/kml_tests/CMakeLists.txt

android/AndroidManifest.xml

					
				@ -590,0 +597,4 @@

				        <data android:scheme="data"/>

				        <data android:host="*"/>

				        <data android:mimeType="*/*"/>

				        <data android:pathPattern=".*\\.gpx" />

biodranik (Migrated from github.com) commented

2023-01-28 15:27:52 +00:00

OSMand uses:

			<intent-filter
				android:label="@string/app_name"
				android:priority="50">
				<action android:name="android.intent.action.VIEW" />
				<category android:name="android.intent.category.DEFAULT" />
				<category android:name="android.intent.category.BROWSABLE" />
				<data android:scheme="file"/>
				<data android:scheme="content"/>
				<data android:host="*"/>
				<data android:mimeType="*/*"/>
				<data android:pathPattern=".*\\.gpx" />
				<data android:pathPattern=".*\\..*\\.gpx" />
				<data android:pathPattern=".*\\..*\\..*\\.gpx" />
				<data android:pathPattern=".*\\..*\\..*\\..*\\.gpx" />
				<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.gpx" />
				<data android:pathPattern=".*\\.gpx.zip" />
				<data android:pathPattern=".*\\..*\\.gpx.zip" />
				<data android:pathPattern=".*\\..*\\..*\\.gpx.zip" />
				<data android:pathPattern=".*\\..*\\..*\\..*\\.gpx.zip" />
				<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.gpx.zip" />
			</intent-filter>

OSMand uses: ``` <intent-filter android:label="@string/app_name" android:priority="50"> <action android:name="android.intent.action.VIEW" /> <category android:name="android.intent.category.DEFAULT" /> <category android:name="android.intent.category.BROWSABLE" /> <data android:scheme="file"/> <data android:scheme="content"/> <data android:host="*"/> <data android:mimeType="*/*"/> <data android:pathPattern=".*\\.gpx" /> <data android:pathPattern=".*\\..*\\.gpx" /> <data android:pathPattern=".*\\..*\\..*\\.gpx" /> <data android:pathPattern=".*\\..*\\..*\\..*\\.gpx" /> <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.gpx" /> <data android:pathPattern=".*\\.gpx.zip" /> <data android:pathPattern=".*\\..*\\.gpx.zip" /> <data android:pathPattern=".*\\..*\\..*\\.gpx.zip" /> <data android:pathPattern=".*\\..*\\..*\\..*\\.gpx.zip" /> <data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.gpx.zip" /> </intent-filter> ```

map/bookmark_helpers.hpp

					
				@ -73,3 +74,4 @@

				enum class KmlFileType

				{

				  Text,

				  Gpx,

biodranik (Migrated from github.com) commented

2023-01-28 15:50:30 +00:00

Don't change the enum order, please. Add Gpx at the end.

map/bookmark_manager.cpp

					
				@ -1875,0 +1873,4 @@

				      std::unique_ptr<kml::FileData> kmlData;

				      if (ext == ".gpx")

				      {

				        kmlData = LoadKmlFile(fileSavePath, KmlFileType::Gpx);

biodranik (Migrated from github.com) commented

2023-01-28 15:51:28 +00:00

Please check docs/CPP_STYLE.md and use it everywhere, to save the reviewer's and your time later.

biodranik (Migrated from github.com) reviewed 2023-03-14 13:15:20 +00:00

biodranik (Migrated from github.com) left a comment

To anyone who wants to continue GPX implementation:

There is no need to store GPX file internally. KML file spec is broader than GPX, so let's keep using KML format under the hood, as it works now.

The idea to add GPX support in an easy way:

Implement the import converter for GPX files: when any GPX file is opened, it should be converted to either internal structures and saved as KML (this approach will likely be faster), or converted directly to KML, and then "imported" as it was a KML file.
Implement unit tests to convert/parse GPX files.
(Can be done later, as a separate task) Implement GPX export in the same manner, by converting KML file into GPX format when a user pressed "export" button.

To anyone who wants to continue GPX implementation: There is no need to store GPX file internally. KML file spec is broader than GPX, so let's keep using KML format under the hood, as it works now. The idea to add GPX support in an easy way: 1. Implement the import _converter_ for GPX files: when any GPX file is opened, it should be converted to either internal structures and saved as KML (this approach will likely be faster), or converted directly to KML, and then "imported" as it was a KML file. 2. Implement unit tests to convert/parse GPX files. 3. (Can be done later, as a separate task) Implement GPX export in the same manner, by converting KML file into GPX format when a user pressed "export" button.

This repo is archived. You cannot comment on pull requests.

No reviewers

rtsisyk