[kothic] add metatypes like `all`, `nodearea`, `nodeline` etc to simplify drules #4137

New issue

Open

opened 2022-12-22 16:39:42 +00:00 by RedAuburn · 3 comments

RedAuburn commented

2022-12-22 16:39:42 +00:00

Member

It would be nice to have metatypes that generate styles for real types, this would massively simplify the styles.mapcss files.

eg.

Going from:

node|z13[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;icon-min-distance: 1;}
node|z14[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;}
node|z15-16[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;}
node|z17-[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;text-optional: true;}

area|z13[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;icon-min-distance: 1;}
area|z14[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;}
area|z15-16[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;}
area|z17-[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;text-optional: true;}

all|z13[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;icon-min-distance: 1;}
all|z14[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;}
all|z15-16[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;}
all|z17-[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;text-optional: true;}

It would be nice to have metatypes that generate styles for real types, this would massively simplify the styles.mapcss files. eg. Going from: ``` node|z13[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;icon-min-distance: 1;} node|z14[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;} node|z15-16[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;} node|z17-[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;text-optional: true;} area|z13[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;icon-min-distance: 1;} area|z14[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;} area|z15-16[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;} area|z17-[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;text-optional: true;} ``` to ``` all|z13[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;icon-min-distance: 1;} all|z14[railway=station][transport=subway][city=lille] {icon-image: subway-lille-s.svg;} all|z15-16[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;} all|z17-[railway=station][transport=subway][city=lille] {icon-image: subway-lille-m.svg;text-optional: true;} ```

👍 1

biodranik commented

2022-12-23 08:33:36 +00:00

(Migrated from github.com)

That is a good idea. Take a look at https://github.com/organicmaps/kothic, I think this can be done easy.

pastk commented

2023-01-21 19:46:23 +00:00

Owner

all probably works already, check wildcard usage in defaults_new.mapcss, e.g.

*::int_name
{
  text-offset: 1;
}

*[amenity],
*[office],
...
{
  text-position: center;
}

But in your subway sample it shouldn't be *, but node + area w/o line.

`all` probably works already, check wildcard usage in `defaults_new.mapcss`, e.g. ``` *::int_name { text-offset: 1; } *[amenity], *[office], ... { text-position: center; } ``` But in your subway sample it shouldn't be `*`, but node + area w/o line.

pastk commented

2023-01-25 13:41:11 +00:00

Owner

Actually I think we can drop node/line/area type definitions in mapcss completely as they're redundant.
E.g. there are no node/line/area types in compiled drules files.
E.g. if there is an area-specific attribute defined like fill-color: then kothic will create a corresponding area element in drules regardless of the type defined.

Right now its possible to e.g. delete all duplicate node definitions and leave area ones only for some types - and nothing will change. However in some cases its more tricky as e.g. priorities are different for node and area elements.

CC @vng

Actually I think we can drop `node/line/area` type definitions in mapcss completely as they're redundant. E.g. there are no `node/line/area` types in compiled drules files. E.g. if there is an area-specific attribute defined like `fill-color:` then kothic will create a corresponding `area` element in drules regardless of the type defined. Right now its possible to e.g. delete all duplicate `node` definitions and leave `area` ones only for some types - and nothing will change. However in some cases its more tricky as e.g. priorities are different for node and area elements. CC @vng

👍 1

This repo is archived. You cannot comment on issues.