[Editor] Building- instead of POI-details shown in editor for POIs where type conists of three parts and building=* is present #433

New issue

Open

opened 2021-05-18 15:10:14 +00:00 by PetbkA · 5 comments

PetbkA commented

2021-05-18 15:10:14 +00:00

(Migrated from github.com)

There's a couple of "churches" in Astrakhan:

In OM their Category is Church, in OSM amenity = place_of_worship.

When I'm editing the first, only the fields in Address block are available, while in the other there's also a Name of the place and Details blocks. These fields should be available in the first object too

There's a couple of "churches" in Astrakhan: - [Никольская Надвратная Церковь (4125105)](https://www.openstreetmap.org/relation/4125105) - [Троицкий Собор (83336219)](https://www.openstreetmap.org/way/83336219) In OM their `Category` is _Church_, in OSM `amenity` = _[place_of_worship](https://wiki.openstreetmap.org/wiki/Tag:amenity=place%20of%20worship?uselang=en)_. When I'm editing the first, only the fields in `Address` block are available, while in the other there's also a `Name of the place` and `Details` blocks. These fields should be available in the first object too

biodranik commented

2021-05-18 15:27:03 +00:00

(Migrated from github.com)

Please check/edit data/editor.config file.

PetbkA commented

2021-05-20 03:07:09 +00:00

(Migrated from github.com)

Please check/edit data/editor.config file.

I don't see such file neither in /data/data/app.omaps nor in //Android/data/app.omaps.

I have root access. File browser: ES File Explorer Pro 1.1.4.1

> Please check/edit data/editor.config file. I don't see such file neither in _/data/data/app.omaps_ nor in _/<ExternalSD>/Android/data/app.omaps_. I have root access. File browser: ES File Explorer Pro 1.1.4.1

biodranik commented

2021-05-20 12:52:00 +00:00

(Migrated from github.com)

This file is in this repository.

PetbkA commented

2021-05-22 09:53:27 +00:00

(Migrated from github.com)

This file is in this repository.

I guess you mean this file. I've checked it. I guess the lines concerning the objects on question are:

      <field_group name="poi">
        <field_ref name="name" />
        <field_ref name="street" />
        <field_ref name="housenumber" />
        <field_ref name="level" />
        <field_ref name="opening_hours" />
        <field_ref name="phone" />
        <field_ref name="email" />
        <field_ref name="website" />
      </field_group>
...
      <type id="amenity-place_of_worship">
        <include group="poi" />
      </type>

So both of the objects should be treated the same way, but they aren't. As for difference between objects:

The first has type = multipolygon, although I can't see anything in editor.conf about it;
The second has tag historic = castle.

I doubt that the first object should have historic = castle, so I guess that the problem is in type = multipolygon .

I can't know for sure what should be fixed here so I wouldn't risk to do it myself

> This file is in this repository. I guess you mean [this file](https://github.com/organicmaps/organicmaps/blob/master/data/editor.config). I've checked it. I guess the lines concerning the objects on question are: ``` xml <field_group name="poi"> <field_ref name="name" /> <field_ref name="street" /> <field_ref name="housenumber" /> <field_ref name="level" /> <field_ref name="opening_hours" /> <field_ref name="phone" /> <field_ref name="email" /> <field_ref name="website" /> </field_group> ... <type id="amenity-place_of_worship"> <include group="poi" /> </type> ``` So both of the objects should be treated the same way, but they aren't. As for difference between objects: 1. The first has [type](https://wiki.openstreetmap.org/wiki/Key:type) = _multipolygon_, although I can't see anything in _editor.conf_ about it; 2. The second has tag [historic](https://wiki.openstreetmap.org/wiki/Historic) = _castle_. I doubt that the first object should have [historic](https://wiki.openstreetmap.org/wiki/Historic) = _castle_, so I guess that the problem is in [type](https://wiki.openstreetmap.org/wiki/Key:type) = _multipolygon_ . I can't know for sure what should be fixed here so I wouldn't risk to do it myself

biodranik commented

2021-05-22 12:35:53 +00:00

(Migrated from github.com)

Thanks for pointing it out! There is a bug, we'll check it.

👍 1

This repo is archived. You cannot comment on issues.