Enhancing Windows 10 open source build documentation in INSTALL.md #4512

Merged

unsuman merged 11 commits from resolving-open-source-build-on-win10 into master

2023-02-19 18:02:07 +00:00

unsuman commented

2023-02-17 01:19:32 +00:00

(Migrated from github.com)

I was trying to configure the repo with open source build in Windows 10 but then I faced a lot of errors and difficulties building and running the scripts. All thanks to @biodranik for helping me out and fix the errors. I documented what he specified and what I did to successfully configure the repo for an open source build in this PR.

biodranik (Migrated from github.com) reviewed 2023-02-17 08:06:39 +00:00

biodranik (Migrated from github.com) left a comment

The documentation should be updated in place, where it is relevant, instead of adding some new paragraphs.

biodranik (Migrated from github.com) reviewed 2023-02-17 22:57:57 +00:00

docs/INSTALL.md

biodranik (Migrated from github.com) commented

2023-02-17 22:55:15 +00:00

This line can be moved below, it is needed only for the non-WSL case.

docs/INSTALL.md

biodranik (Migrated from github.com) commented

2023-02-17 22:57:51 +00:00

Let's describe separately two setups:

With WSL + installed g++ (sudo apt install g++), no Developer command prompt is needed.
Without WSL, but with Visual Studio Installer with MSVC build tools + (likely) Windows SDK (I assume that only Windows 11 may need it, Windows 10 likely will work without it), and with the Developer command prompt.

Let's describe separately two setups: 1. With WSL + installed g++ (sudo apt install g++), no Developer command prompt is needed. 2. Without WSL, but with Visual Studio Installer with MSVC build tools + (likely) Windows SDK (I assume that only Windows 11 may need it, Windows 10 likely will work without it), and with the Developer command prompt.

unsuman (Migrated from github.com) reviewed 2023-02-18 12:37:38 +00:00

docs/INSTALL.md

unsuman (Migrated from github.com) commented

2023-02-18 12:37:38 +00:00

I have defined two setups, you may review it.

biodranik (Migrated from github.com) reviewed 2023-02-18 20:56:52 +00:00

docs/INSTALL.md

biodranik (Migrated from github.com) commented

2023-02-18 20:52:06 +00:00

3. Run `./configure.sh` in WSL.

```suggestion 3. Run `./configure.sh` in WSL. ```

biodranik (Migrated from github.com) commented

2023-02-18 20:53:44 +00:00

This step should not be needed, right? Can you please double-check it, by running

git clean -xfd
git submodule foreach --recursive git clean -xfd

and then repeating these steps?

This step should not be needed, right? Can you please double-check it, by running ``` git clean -xfd git submodule foreach --recursive git clean -xfd ``` and then repeating these steps?

biodranik (Migrated from github.com) commented

2023-02-18 20:55:08 +00:00

Are you sure that all these components are necessary? I assume that MSVC build tools should be enough, no? Would you please try it?

biodranik (Migrated from github.com) commented

2023-02-18 20:55:59 +00:00

Can't SDK be installed from Visual Studio installer?

unsuman (Migrated from github.com) reviewed 2023-02-18 23:55:30 +00:00

docs/INSTALL.md

unsuman (Migrated from github.com) commented

2023-02-18 23:55:30 +00:00

Ok, now I know step 4 isn't required.

unsuman (Migrated from github.com) reviewed 2023-02-19 00:31:50 +00:00

docs/INSTALL.md

unsuman (Migrated from github.com) commented

2023-02-19 00:31:50 +00:00

Actually Desktop development with C++ as workload is not needed, one need to just install Visual Studio and MSVC build tools as individual components.