Better support for OLC (Open Location Code)

Gustavo22Soaresh commented

2021-05-27 01:09:41 +00:00

(Migrated from github.com)

I like the app a lot, but it would be interesting to show in the coordinates part also the OLC of the point, since the app already works with OLC
Thanks!

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

I like the app a lot, but it would be interesting to show in the coordinates part also the OLC of the point, since the app already works with OLC Thanks! [![image.png](https://i.postimg.cc/DznmqTFc/image.png)](https://postimg.cc/VJZY82JS)  ## Upvote & Fund - We're using [Polar.sh](https://polar.sh/organicmaps) so you can upvote and help fund this issue. - We receive the funding once the issue is completed & confirmed by you. - Thank you in advance for helping prioritize & fund our backlog. <a href="https://polar.sh/organicmaps/organicmaps/issues/457"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://polar.sh/api/github/organicmaps/organicmaps/issues/457/pledge.svg?darkmode=1"> <img alt="Fund with Polar" src="https://polar.sh/api/github/organicmaps/organicmaps/issues/457/pledge.svg"> </picture> </a>

👍 13 👀 1 ❤️ 1

biodranik commented

2021-05-27 17:42:05 +00:00

(Migrated from github.com)

That shouldn't be hard: add a third coordinates option on a click.

🚀 2

rtsisyk commented

2021-07-14 06:36:36 +00:00

Owner

I have never heard about Open Location Code. It seems to be some Google stuff nobody else uses. Could you please explain why we should support this format?

lxgr commented

2021-08-15 16:41:01 +00:00

(Migrated from github.com)

It's an open format that essentially maps WGS84 latitude/longitude coordinates to short alphanumeric strings.

It has a couple of nice properties like not requiring language-specific word lists (unlike a somewhat popular proprietary alternative), being easy to copy/paste, avoiding localization issues (for example "N" and "E" are not as universal as +/-, yet often WGS84 is given in the former, as well as the ambiguity between "." and "," as the decimal separator) and possibly others.

Given that it's free/open and this repository apparently already includes a support library for it, it would be nice to be able to use these "plus codes" in addition to the existing decimal and DMS WGS84 options.

It's an open [format](https://en.wikipedia.org/wiki/Open_Location_Code) that essentially maps WGS84 latitude/longitude coordinates to short alphanumeric strings. It has a couple of nice properties like not requiring language-specific word lists (unlike a somewhat popular proprietary alternative), being easy to copy/paste, avoiding localization issues (for example "N" and "E" are not as universal as +/-, yet often WGS84 is given in the former, as well as the ambiguity between "." and "," as the decimal separator) and possibly others. Given that it's [free/open](https://github.com/google/open-location-code) and this repository apparently already includes a [support library](https://github.com/organicmaps/organicmaps/tree/master/3party/open-location-code) for it, it would be nice to be able to use these "plus codes" in addition to the existing decimal and DMS WGS84 options.

👍 9

strump commented

2021-09-24 13:06:35 +00:00

Member

There are 2 ways OLC code could be generated:

Full format: 796RWF8Q+WF
Short format: WF8Q+WF, Praia

To build short code there should be some reference point (Praia in example). Usually city is picked as a reference point. See Guidance for shortening codes. Is there any API in OrganicMaps to get nearest city for <lat, lon> pair?

There are 2 ways OLC code could be generated: * Full format: `796RWF8Q+WF` * Short format: `WF8Q+WF, Praia` To build short code there should be some reference point (`Praia` in example). Usually city is picked as a reference point. See [Guidance for shortening codes](https://github.com/google/open-location-code/wiki/Guidance-for-shortening-codes). Is there any API in OrganicMaps to get nearest city for <lat, lon> pair?

👍 1

biodranik commented

2021-09-25 04:31:27 +00:00

(Migrated from github.com)

Check what is in 3party/open-location-code (it may need to be updated).

strump commented

2021-09-30 09:14:21 +00:00

Member

Search by short OLC works incorrectly in ver. 2021.09.14-4-Google. OrganicMaps thinks that V75V+8R is valid short code. But correct short OLC is V75V+8R Paris, France.

How to reproduce:

Enter V75V+8R into search field.
OM will show coordinates
Change GPS position
Enter V75V+8R into search field again
OM will show new coordinates.

Expected behaviour:

After user enters V75V+8R in search field nothing should happen.
Only wher user enters V75V+8R Paris, France OrganicMaps should decode coordinates.

The problem is in code search/processor.cpp.

See https://plus.codes/map for expected behaviour of coordinates <-> short OLC convertion.

Search by short OLC works incorrectly in ver. 2021.09.14-4-Google. OrganicMaps thinks that `V75V+8R` is valid short code. But correct short OLC is `V75V+8R Paris, France`. **How to reproduce:** 1. Enter `V75V+8R` into search field. 2. OM will show coordinates 3. Change GPS position 4. Enter `V75V+8R` into search field again 5. OM will show new coordinates. **Expected behaviour:** 1. After user enters `V75V+8R` in search field nothing should happen. 2. Only wher user enters `V75V+8R Paris, France` OrganicMaps should decode coordinates. The problem is in code [search/processor.cpp](https://github.com/organicmaps/organicmaps/blob/master/search/processor.cpp#L705). See https://plus.codes/map for expected behaviour of coordinates <-> short OLC convertion.

👍 2

biodranik commented

2021-10-01 20:56:45 +00:00

(Migrated from github.com)

Is there any API in OrganicMaps to get nearest city for <lat, lon> pair?

@vng there should be some sample in the code. It is easy to fetch all cities and towns in the area with the nearest distance filter.

> Is there any API in OrganicMaps to get nearest city for <lat, lon> pair? @vng there should be some sample in the code. It is easy to fetch all cities and towns in the area with the nearest distance filter.

biodranik commented

2021-10-01 20:57:56 +00:00

(Migrated from github.com)

Search by short OLC works incorrectly in ver. 2021.09.14-4-Google. OrganicMaps thinks that V75V+8R is valid short code. But correct short OLC is V75V+8R Paris, France.

What should be the correct behavior for incorrect short codes?
How to properly support short codes?

> Search by short OLC works incorrectly in ver. 2021.09.14-4-Google. OrganicMaps thinks that `V75V+8R` is valid short code. But correct short OLC is `V75V+8R Paris, France`. 1. What should be the correct behavior for incorrect short codes? 2. How to properly support short codes?

strump commented

2021-10-03 09:51:20 +00:00

Member

В двух словах, короткий OLC не работает без указания города. Например V75V+8R Paris, France - это точка в Париже. И во всех примерах при декодировании короткого OLC нужно дополнительно указывать Reference Location. См openlocationcode_example.cc. Если пользователь в строке поиска явно указал город, нужно использовать центр города для декодирования короткого OLC. Если пользователь не добавил город, то, наверное, можно найти ближайший и использовать его (но не уверен насколько это правильное поведение).

В двух словах, короткий OLC не работает без указания города. Например `V75V+8R Paris, France` - это точка в Париже. И во всех примерах при декодировании короткого OLC нужно дополнительно указывать Reference Location. См [openlocationcode_example.cc](https://github.com/google/open-location-code/blob/main/cpp/openlocationcode_example.cc#L51). Если пользователь в строке поиска явно указал город, нужно использовать центр города для декодирования короткого OLC. Если пользователь не добавил город, то, наверное, можно найти ближайший и использовать его (но не уверен насколько это правильное поведение).

😕 3

Snapy commented

2021-12-14 12:54:34 +00:00

(Migrated from github.com)

Request to add support for plus codes urls (ex https://plus.codes/8FW4V7FW+G2) as per https://t.me/organicmaps/10160

Also short codes without locality are valid (according to https://github.com/google/open-location-code/wiki/Supporting-plus-codes-in-your-app#supporting-plus-codes-for-search) so that's one less problem. Knowing which locality could be found using geolocation, map focus, offline maps, bookmarks and/or something else.

Request to add support for plus codes urls (ex https://plus.codes/8FW4V7FW+G2) as per https://t.me/organicmaps/10160 Also short codes without locality are valid (according to https://github.com/google/open-location-code/wiki/Supporting-plus-codes-in-your-app#supporting-plus-codes-for-search) so that's one less problem. Knowing which locality could be found using geolocation, map focus, offline maps, bookmarks and/or something else.

👍 6

biodranik commented

2021-12-15 21:53:46 +00:00

(Migrated from github.com)

To be valid without locality, short codes should be provided with place hints. Opening them from an URL will not help much. The hope is that only global codes are shared via links.

vn971 commented

2022-05-18 14:22:56 +00:00

(Migrated from github.com)

Could you please explain why we should support this format?

Because this is the only format that one can conveniently copy out of google, paste in a map that supports it and have it working. That is important(!) because you would frequently get exactly those codes, and you need a quick conversion function.

Can somebody please clarify what information do we need to provide to remove the label Need Feedback and accept it into organicmaps timeline?

// I've only recently found out that OrganicMaps exists, being a fan of the old pre-fork version before (mapsme). Already donated a bit and would love to do more.

> Could you please explain why we should support this format? Because this is the only format that one can conveniently copy out of google, paste in a map that supports it and have it working. That is *important*(!) because you would frequently get exactly those codes, and you need a quick conversion function. Can somebody please clarify what information do we need to provide to remove the label `Need Feedback` and accept it into organicmaps timeline? // I've only recently found out that OrganicMaps exists, being a fan of the old pre-fork version before (mapsme). Already donated a bit and would love to do more.

👍 3

biodranik commented

2022-05-19 05:02:02 +00:00

(Migrated from github.com)

@vn971 Someone needs to test the current implementation (at least in Android where it was implemented) and make a full list of issues (also mentioned in this thread). So any developer can read and implement it as the next step )

euf commented

2022-12-20 12:48:01 +00:00

(Migrated from github.com)

As I see, to fully support OLC codes, OM should (according to this document mentioned before):

generate global codes for sharing, such as 796RWF8Q+WF
search for local codes with a locality, such as WF8Q+WF Praia, Cabo Verde
generate local codes with a locality for sharing, such as WF8Q+WF Praia, Cabo Verde

The original poster was focused on (1).

As for me, (2) seems more important, since Google Maps sharing always produces local codes with a locality in the format V75V+8R Paris. When I paste them to OM, it is not recognised at all. Then I have to manually delete Paris part, and after that OM decodes V75V+8R to some coordinates, presumably relevant to my current position, which seems to be the best guess — but not always correct one.

From a developer point of view (2) and (3) may require more advanced geocoding than (1). Anyway, completing all three would result in a full support of OLC.

As I see, to fully support OLC codes, OM should (according to [this document mentioned before](https://github.com/google/open-location-code/wiki/Supporting-plus-codes-in-your-app#supporting-plus-codes-for-search)): 1. generate **global codes** for sharing, such as `796RWF8Q+WF` 2. search for **local codes** with a locality, such as `WF8Q+WF Praia, Cabo Verde` 3. generate **local codes** with a locality for sharing, such as `WF8Q+WF Praia, Cabo Verde` The original poster was focused on (1). As for me, (2) seems more important, since Google Maps sharing always produces **local codes** with a locality in the format `V75V+8R Paris`. When I paste them to OM, it is not recognised at all. Then I have to manually delete `Paris` part, and after that OM decodes `V75V+8R` to some coordinates, presumably relevant to my current position, which seems to be the best guess — but not always correct one. From a developer point of view (2) and (3) may require more advanced geocoding than (1). Anyway, completing all three would result in a full support of OLC.

👍 5

zyphlar commented

2022-12-22 22:34:00 +00:00

Member

As an intermediary, if OM can't easily geolocate the "Praia, Cabo Verde" part, then simply ignoring everything after the shortcode would be preferable so that at least a result is returned (usually the correct one, if you're near the target city.)

Then, later, geolocating the city name can be a further improvement.

As an intermediary, if OM can't easily geolocate the "Praia, Cabo Verde" part, then simply ignoring everything after the shortcode would be preferable so that at least a result is returned (usually the correct one, if you're near the target city.) Then, later, geolocating the city name can be a further improvement.

👍 1

Rows
Columns

Better support for OLC (Open Location Code) #457

Upvote & Fund