[android-auto] Refactoring #4989

AndrewShkrob · 2023-04-15T15:26:54Z

AndrewShkrob commented

2023-04-15 15:26:54 +00:00

Links to organicmaps/organicmaps#4936

Links to https://git.omaps.dev/organicmaps/organicmaps/pulls/4936

rtsisyk reviewed 2023-04-15 15:26:54 +00:00

biodranik (Migrated from github.com) approved these changes 2023-04-15 15:46:01 +00:00

android/src/app/organicmaps/car/SurfaceRenderer.java

biodranik (Migrated from github.com) commented

2023-04-15 15:39:54 +00:00

Add TODO why is it commented, and when it should be uncommented?

android/src/app/organicmaps/car/screens/CategoriesScreen.java

					
				@ -76,3 +77,4 @@

				    final Header.Builder builder = new Header.Builder();

				    builder.setStartHeaderAction(Action.BACK);

				    builder.setTitle(getCarContext().getString(R.string.categories));

				    return builder.build();

biodranik (Migrated from github.com) commented

2023-04-15 15:42:35 +00:00

It's better to use the following pattern:

TODO(name or initials or nickname): show that dialog

It's better to use the following pattern: ``` TODO(name or initials or nickname): show that dialog ```

android/src/app/organicmaps/car/screens/CategoriesScreen.java

biodranik (Migrated from github.com) commented

2023-04-15 15:41:33 +00:00

Why the size of categories is limited? We have complains from the carplay users about it.

android/src/app/organicmaps/car/screens/NavigationScreen.java

biodranik (Migrated from github.com) commented

2023-04-15 15:44:37 +00:00

@vng what do you think about moving { to a newline?

android/src/app/organicmaps/car/screens/NavigationScreen.java

					
				@ -12,1 +17,4 @@

				{

				  @NonNull

				  private final RoutingController mRoutingController;

biodranik (Migrated from github.com) commented

2023-04-15 15:43:23 +00:00

Is it a good idea to use annotations like NonNull, etc.?

Is it a good idea to use annotations like `NonNull`, etc.?

AndrewShkrob reviewed 2023-04-15 15:53:03 +00:00

android/src/app/organicmaps/car/screens/CategoriesScreen.java

AndrewShkrob commented

2023-04-15 15:53:03 +00:00

It is limited to MAX_CATEGORIES_SIZE according to the AA restrictions.
https://developer.android.com/reference/androidx/car/app/constraints/ConstraintManager

It is limited to `MAX_CATEGORIES_SIZE` according to the AA restrictions. https://developer.android.com/reference/androidx/car/app/constraints/ConstraintManager

AndrewShkrob reviewed 2023-04-15 16:03:32 +00:00

android/src/app/organicmaps/car/screens/CategoriesScreen.java

AndrewShkrob commented

2023-04-15 16:03:32 +00:00

Btw, that's why I created CATEGORIES list. We should discuss what categories (and their priority) should be displayed on this screen.

Btw, that's why I created `CATEGORIES` list. We should discuss what categories (and their priority) should be displayed on this screen.

vng (Migrated from github.com) approved these changes 2023-04-17 17:55:08 +00:00

android/src/app/organicmaps/car/screens/BookmarksScreen.java

vng (Migrated from github.com) commented

2023-04-17 17:53:44 +00:00

Ту не будет проблем? Где вызывается эта getBookmarks() ?

AndrewShkrob reviewed 2023-04-17 17:58:22 +00:00

android/src/app/organicmaps/car/screens/BookmarksScreen.java

AndrewShkrob commented

2023-04-17 17:58:22 +00:00

А какие проблемы могут быть? В createBookmarkCategoriesList()

А какие проблемы могут быть? В `createBookmarkCategoriesList()`

vng (Migrated from github.com) reviewed 2023-04-17 18:06:16 +00:00

android/src/app/organicmaps/car/screens/BookmarksScreen.java

vng (Migrated from github.com) commented

2023-04-17 18:06:16 +00:00

Если мы не будем показывает в списке невидимые категории, то как юзер их сделает видимыми?
Сейчас видимость - это галка чекбокса в андроид. Или я не прав тут?

Если мы не будем показывает в списке невидимые категории, то как юзер их сделает видимыми? Сейчас видимость - это галка чекбокса в андроид. Или я не прав тут?