organicmaps/organicmaps-tmp

Archived

Fork 1

Wrong offline region for province in China #511

New issue

Open

opened 2021-06-06 12:21:44 +00:00 by LaoshuBaby · 10 comments

LaoshuBaby commented

2021-06-06 12:21:44 +00:00

(Migrated from github.com)

When I zoom in to look for things around me，I found that I was placed in the wrong province.The area I was browsing is not 河北省(Hebei Province), but is 北京市(Beijing)

I noticed when I look for detaild things in 北京市 and 天津市(Tianjin), the app will notice me that I need to download the whole 河北省. The 北京市 and 天津市 are surrounded by 河北省.

Here is the relation of those 3 province:

北京市:https://www.openstreetmap.org/relation/912940
天津市:https://www.openstreetmap.org/relation/912999
河北省:https://www.openstreetmap.org/relation/912998

And if this is not enough, you can see the wiki for more detail of province in China

Wikipedia:zh:中华人民共和国行政区划
OSM Wiki:Zh-hans:中华人民共和国#省级行政区 (HAVE RELATION ID)

Those 3 province have the equal administrative level, so I think this should be separate into 3 different offline package.

When I zoom in to look for things around me，I found that I was placed in the wrong province.The area I was browsing is not ```河北省```(Hebei Province), but is ```北京市```(Beijing) I noticed when I look for detaild things in ```北京市``` and ```天津市```(Tianjin), the app will notice me that I need to download the whole ```河北省```. The ```北京市``` and ```天津市``` are surrounded by ```河北省```. --- Here is the relation of those 3 province: + ```北京市```:https://www.openstreetmap.org/relation/912940 + ```天津市```:https://www.openstreetmap.org/relation/912999 + ```河北省```:https://www.openstreetmap.org/relation/912998 And if this is not enough, you can see the wiki for more detail of province in China + Wikipedia:[zh:中华人民共和国行政区划](https://zh.wikipedia.org/wiki/%E4%B8%AD%E5%8D%8E%E4%BA%BA%E6%B0%91%E5%85%B1%E5%92%8C%E5%9B%BD%E8%A1%8C%E6%94%BF%E5%8C%BA%E5%88%92) + OSM Wiki:[Zh-hans:中华人民共和国#省级行政区](https://wiki.openstreetmap.org/wiki/Zh-hans:%E4%B8%AD%E5%8D%8E%E4%BA%BA%E6%B0%91%E5%85%B1%E5%92%8C%E5%9B%BD#%E7%9C%81%E7%BA%A7%E8%A1%8C%E6%94%BF%E5%8C%BA) (HAVE RELATION ID) --- Those 3 province have the equal administrative level, so I think this should be separate into 3 different offline package.

LaoshuBaby commented

2021-06-06 12:23:53 +00:00

(Migrated from github.com)

Here are screenshots in APP

(Pic is large so click if needed)

Screenshot_2021-06-06-20-02-16-022_app omaps beta
Screenshot_2021-06-06-20-02-47-322_app omaps beta

Here are screenshots in APP (Pic is large so click if needed) [Screenshot_2021-06-06-20-02-16-022_app omaps beta](https://user-images.githubusercontent.com/42690037/120924175-f2aaab80-c704-11eb-9498-6bc49e41dade.png) [Screenshot_2021-06-06-20-02-47-322_app omaps beta](https://user-images.githubusercontent.com/42690037/120924177-f50d0580-c704-11eb-960f-2c024cd37608.jpg)

biodranik commented

2021-06-06 12:56:41 +00:00

(Migrated from github.com)

Looks like our province borders are incorrect, right?

You may help by fixing them, all borders are in data/borders and there may be some script in tools to generate poly files.

Looks like our province borders are incorrect, right? You may help by fixing them, all borders are in data/borders and there may be some script in tools to generate poly files.

LaoshuBaby commented

2021-06-06 14:12:59 +00:00

(Migrated from github.com)

Looks like our province borders are incorrect, right?

You may help by fixing them, all borders are in data/borders and there may be some script in tools to generate poly files.

https://github.com/organicmaps/organicmaps/blob/master/data/borders/China_Hebei.poly

So I needed to manual modify this file (like geojson?) and so much points? And how can I need to deduct the inner regions of the two provinces here?

I' m new to this repository, and don't know the grammar of this kind of file, also don't know which kind of script can help me.

So could you give me a link of related document so I can learn it?

> > > Looks like our province borders are incorrect, right? > > You may help by fixing them, all borders are in data/borders and there may be some script in tools to generate poly files. https://github.com/organicmaps/organicmaps/blob/master/data/borders/China_Hebei.poly So I needed to manual modify this file (like geojson?) and so much points? And how can I need to deduct the inner regions of the two provinces here? **:(** I' m new to this repository, and don't know the grammar of this kind of file, also don't know which kind of script can help me. So could you give me a link of related document so I can learn it?

LaoshuBaby commented

2021-08-29 08:46:36 +00:00

(Migrated from github.com)

Is there any repair progress?

biodranik commented

2021-08-29 09:11:37 +00:00

(Migrated from github.com)

Maps were split not ideally, with the idea to have a limited file size, not with the idea to reflect the region with 100% accuracy.

But if you see that borders are slightly incorrect, please edit/fix them in .poly files (including nearby regions), and make a Pull Request with your changes (or send files to us). The important thing is not to have any "holes" between regions, because it can break the routing algorithm.

Maps were split not ideally, with the idea to have a limited file size, not with the idea to reflect the region with 100% accuracy. But if you see that borders are slightly incorrect, please edit/fix them in .poly files (including nearby regions), and make a Pull Request with your changes (or send files to us). The important thing is not to have any "holes" between regions, because it can break the routing algorithm.

LaoshuBaby commented

2021-08-29 09:24:25 +00:00

(Migrated from github.com)

Maps were split not ideally, with the idea to have a limited file size, not with the idea to reflect the region with 100% accuracy.

But if you see that borders are slightly incorrect, please edit/fix them in .poly files (including nearby regions), and make a Pull Request with your changes (or send files to us). The important thing is not to have any "holes" between regions, because it can break the routing algorithm.

In which tools I can create .poly files? Notepad? Already have some generator?
If have docs, I can do this job, or I only can request your maintainer. That's why I open this issue
The shape of Hebei is like this, will this is a "hole" problem?

> > > Maps were split not ideally, with the idea to have a limited file size, not with the idea to reflect the region with 100% accuracy. > > But if you see that borders are slightly incorrect, please edit/fix them in .poly files (including nearby regions), and make a Pull Request with your changes (or send files to us). The important thing is not to have any "holes" between regions, because it can break the routing algorithm. 1. In which tools I can create .poly files? Notepad? Already have some generator? If have docs, I can do this job, or I only can request your maintainer. That's why I open this issue 2. The shape of Hebei is like this, will this is a "hole" problem? ![Hebei](https://user-images.githubusercontent.com/42690037/131245345-b4bd3753-f0d8-45f6-8ada-0d9616e4c9cf.png)

biodranik commented

2021-08-29 09:40:14 +00:00

(Migrated from github.com)

What you mention would be a problem too. I mentioned another "hole" issue:

What you mention would be a problem too. I mentioned another "hole" issue: ![image](https://user-images.githubusercontent.com/170263/131245979-ea689f16-0076-429b-b870-a3ceeb83e467.png)

biodranik commented

2021-08-29 09:41:56 +00:00

(Migrated from github.com)

JOSM editor has a plugin that supports editing .poly files. You can load several neighboring regions and visually see/edit/correct them.

LaoshuBaby commented

2021-09-09 16:13:21 +00:00

(Migrated from github.com)

JOSM editor has a plugin that supports editing .poly files. You can load several neighboring regions and visually see/edit/correct them.

This is my modified version in #1277

Hebei is using 3 area to describe.

In face only 2 land area is Hebei province, but you said that poly file shouldn't have a hole, so those sea were added in Hebei province

> > > JOSM editor has a plugin that supports editing .poly files. You can load several neighboring regions and visually see/edit/correct them. This is my modified version in #1277 ![图片](https://user-images.githubusercontent.com/42690037/132722637-045dcb79-6ea9-4085-bd18-d53c00427aa5.png) Hebei is using 3 area to describe. In face only 2 land area is Hebei province, but you said that poly file shouldn't have a hole, so those sea were added in Hebei province ![图片](https://user-images.githubusercontent.com/42690037/132722810-29a81657-7773-499e-bf3e-2a730e8d52bb.png)

👍 1

biodranik commented

2021-09-09 16:32:08 +00:00

(Migrated from github.com)

Can you please also show us what were the borders in previous poly files, without your modifications? Just download them again from the repository and make a screenshot, to better understand the difference?

This repo is archived. You cannot comment on issues.