[Android] Transit steps info is now scrollable. #5885

strump · 2023-08-31T18:46:46Z

strump commented

2023-08-31 18:46:46 +00:00

In case of big number of ruler steps bottom panel becomes too big. See #5880 for sample

Added scrolling to the panel layout.

Result:
https://github.com/organicmaps/organicmaps/assets/720808/0ec1b719-588a-444d-a556-6bc167d3ff88

Note: this is temporary solution. The best approach is to draw segment length on the map itself.

In case of big number of ruler steps bottom panel becomes too big. See #5880 for sample Added scrolling to the panel layout. Result: https://github.com/organicmaps/organicmaps/assets/720808/0ec1b719-588a-444d-a556-6bc167d3ff88 **Note:** this is temporary solution. The best approach is to draw segment length on the map itself.

strump reviewed 2023-08-31 18:47:41 +00:00

android/res/layout/routing_bottom_panel_transit.xml

strump commented

2023-08-31 18:47:41 +00:00

Replaced RelativeLayout with ConstraintLayout because is supports max height constraint.

Replaced `RelativeLayout` with `ConstraintLayout` because is supports max height constraint.

strump reviewed 2023-08-31 18:48:19 +00:00

android/res/layout/routing_bottom_panel_transit.xml

strump commented

2023-08-31 18:48:19 +00:00

RecyclerView height is limited by 150dp.

`RecyclerView` height is limited by 150dp.

Jean-BaptisteC (Migrated from github.com) requested changes 2023-09-02 14:23:47 +00:00

Jean-BaptisteC (Migrated from github.com) left a comment

❌ Pixel 6 - Android 13

Bottomsheet overlap buttons

❌ Pixel 6 - Android 13 Bottomsheet overlap buttons <img src="https://github.com/organicmaps/organicmaps/assets/87148630/de540f97-908b-494c-a9cf-364c97c308db" height=300 />

Jean-BaptisteC (Migrated from github.com) approved these changes 2023-09-06 07:27:02 +00:00

Jean-BaptisteC (Migrated from github.com) left a comment

✅ Pixel 6 - Android 13

I have see another problem, but I don't know if can be fix easily

When I create ruler routing and select POI present in routing, OM open place page and buttons follow place page and not bottomsheet routing

✅ Pixel 6 - Android 13 I have see another problem, but I don't know if can be fix easily <img src="https://github.com/organicmaps/organicmaps/assets/87148630/f8f03f33-49b8-4b02-90fd-bafa9b8b282a" height=300 /> When I create ruler routing and select POI present in routing, OM open place page and buttons follow place page and not bottomsheet routing

vng (Migrated from github.com) reviewed 2023-09-08 21:28:44 +00:00

android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java

vng (Migrated from github.com) commented

2023-09-08 21:28:03 +00:00

nit: Move comment up before final ScrollView parentScroll = ...

android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java

					
				@ -210,6 +213,8 @@ final class RoutingBottomMenuController implements View.OnClickListener

				      rv.addItemDecoration(mTransitViewDecorator);

				      rv.setAdapter(adapter);

				      adapter.setItems(pointsToRulerSteps(points));

vng (Migrated from github.com) commented

2023-09-08 21:28:37 +00:00

nit: Add function like updateScroll() to avoid copy-paste?

strump reviewed 2023-09-12 06:20:34 +00:00

android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java

					
				@ -210,6 +213,8 @@ final class RoutingBottomMenuController implements View.OnClickListener

				      rv.addItemDecoration(mTransitViewDecorator);

				      rv.setAdapter(adapter);

				      adapter.setItems(pointsToRulerSteps(points));