[android] Improved touch target size #6776

rtsisyk · 2023-12-04T08:41:14Z

SigmaZardan commented

2023-12-04 08:41:14 +00:00

(Migrated from github.com)

This PR addresses the enhancement of touch target sizes for various UI elements in the app, optimizing the user experience on touch-enabled devices. The changes were identified using Android Studio's built-in feature, which highlighted UI elements in XML files requiring adjustments for better touch interaction.

Screenshots
Attached screenshots showcasing the changes are available in this PR.

Major UI Element Changes

Toolbar Search Control Textfield:
Increased touch target size to improve ease of use during search operations.
Button with Progress and Cancel Button:
Adjusted touch targets for better accessibility during progress and cancellation operations.
Map Download Button (First-time Open):
Enlarged touch area for the button displayed when downloading maps on initial application launch.
Share Button:
Enhanced touch target size for improved accessibility when sharing content.
Cancel Buttons:
Increased touch target sizes for cancel buttons across various dialogs.
Dialog Edit Text Field (Bookmark List Screen):
Adjusted touch targets for better usability in the bookmark list screen.
Textfields in Edit Bookmark:
Optimized touch target sizes for textfields in the edit bookmark functionality.

Testing
The changes have been thoroughly tested on the Android emulator (Pixel 5, API level 34) to ensure compatibility and a seamless user experience.

Screenshots
Screenshot 2023-12-04 at 13 11 01
Screenshot 2023-12-04 at 13 12 39
Screenshot 2023-12-04 at 13 14 52
Screenshot 2023-12-04 at 13 16 14
Screenshot 2023-12-04 at 13 17 22
Screenshot 2023-12-04 at 13 19 12
Screenshot 2023-12-04 at 13 23 58
Screenshot 2023-12-04 at 13 25 24
Screenshot 2023-12-04 at 13 34 45

This PR addresses the enhancement of touch target sizes for various UI elements in the app, optimizing the user experience on touch-enabled devices. The changes were identified using Android Studio's built-in feature, which highlighted UI elements in XML files requiring adjustments for better touch interaction. Screenshots Attached screenshots showcasing the changes are available in this PR. Major UI Element Changes 1. Toolbar Search Control Textfield: Increased touch target size to improve ease of use during search operations. 2. Button with Progress and Cancel Button: Adjusted touch targets for better accessibility during progress and cancellation operations. 3. Map Download Button (First-time Open): Enlarged touch area for the button displayed when downloading maps on initial application launch. 4. Share Button: Enhanced touch target size for improved accessibility when sharing content. 5. Cancel Buttons: Increased touch target sizes for cancel buttons across various dialogs. 6. Dialog Edit Text Field (Bookmark List Screen): Adjusted touch targets for better usability in the bookmark list screen. 7. Textfields in Edit Bookmark: Optimized touch target sizes for textfields in the edit bookmark functionality. Testing The changes have been thoroughly tested on the Android emulator (Pixel 5, API level 34) to ensure compatibility and a seamless user experience. Screenshots <img width="290" alt="Screenshot 2023-12-04 at 13 11 01" src="https://github.com/organicmaps/organicmaps/assets/94971168/1d1b28f0-a2f8-4989-9b28-f7719b2af8b0"> <img width="286" alt="Screenshot 2023-12-04 at 13 12 39" src="https://github.com/organicmaps/organicmaps/assets/94971168/a3e5c88b-4006-4150-9d34-f6497760e4fa"> <img width="285" alt="Screenshot 2023-12-04 at 13 14 52" src="https://github.com/organicmaps/organicmaps/assets/94971168/3dddff02-72e5-4f3b-a766-7e00881e32f6"> <img width="285" alt="Screenshot 2023-12-04 at 13 16 14" src="https://github.com/organicmaps/organicmaps/assets/94971168/4ad076d1-946a-47e5-8590-b9d41cc145fb"> <img width="285" alt="Screenshot 2023-12-04 at 13 17 22" src="https://github.com/organicmaps/organicmaps/assets/94971168/ed8b8206-b106-4148-abda-c8369ee90641"> <img width="283" alt="Screenshot 2023-12-04 at 13 19 12" src="https://github.com/organicmaps/organicmaps/assets/94971168/47e71657-8d51-413c-bb09-f6dc162242bf"> <img width="289" alt="Screenshot 2023-12-04 at 13 23 58" src="https://github.com/organicmaps/organicmaps/assets/94971168/8288489b-d767-42fb-b213-0717f7a3ecf8"> <img width="285" alt="Screenshot 2023-12-04 at 13 25 24" src="https://github.com/organicmaps/organicmaps/assets/94971168/8d885050-af2b-4311-87dd-e61951f3491e"> <img width="285" alt="Screenshot 2023-12-04 at 13 34 45" src="https://github.com/organicmaps/organicmaps/assets/94971168/f7897150-201f-49ed-8432-010436f1a8d3">

🎉 3

rtsisyk reviewed 2023-12-04 08:41:14 +00:00

Jean-BaptisteC (Migrated from github.com) approved these changes 2023-12-05 17:15:23 +00:00

Jean-BaptisteC (Migrated from github.com) left a comment

Please don't reformat files, it's more easier to review :)
Can you rebase your branch and keep 2 two commits (one for changes in xml and another for bookmarks changes)

Please don't reformat files, it's more easier to review :) Can you rebase your branch and keep 2 two commits (one for changes in xml and another for bookmarks changes)

				`@ -24,6 +24,7 @@`
				`android:layout_width="match_parent"`

Rows
Columns