Fix the PP screen freezing on ios 12 #6931

kirylkaveryn · 2023-12-22T16:26:40Z

kirylkaveryn commented

2023-12-22 16:26:40 +00:00

This PR fixes organicmaps/organicmaps#6917
For some reason 92c7b90c59
breaks PP screen on iOS12 so for iOS<13.0 the implementation code will be used.

Needs to be tested on iOS12!

This PR fixes https://git.omaps.dev/organicmaps/organicmaps/issues/6917 For some reason https://git.omaps.dev/organicmaps/organicmaps/commit/92c7b90c596f7c8702fdff2ab81a5b1e0b0d9457 breaks PP screen on iOS12 so for iOS<13.0 the implementation code will be used. Needs to be tested on iOS12!

biodranik (Migrated from github.com) reviewed 2023-12-22 16:48:57 +00:00

iphone/Maps/UI/PlacePage/PlacePageViewController.swift

					
				@ -78,2 +78,3 @@

				    if previousTraitCollection == nil {

				    // See https://github.com/organicmaps/organicmaps/issues/6917 for the details.

				    if #available(iOS 13.0, *), previousTraitCollection == nil {

				      scrollView.contentInset = alternativeSizeClass(iPhone: UIEdgeInsets(top: view.height, left: 0, bottom: 0, right: 0),

biodranik (Migrated from github.com) commented

2023-12-22 16:48:57 +00:00

Thanks! Please add short comments referencing the fixed issue to make it clear for future code readers.

biodranik (Migrated from github.com) reviewed 2023-12-22 16:58:39 +00:00

iphone/Maps/UI/PlacePage/PlacePageViewController.swift

					
				@ -79,3 +79,4 @@

				    if #available(iOS 13.0, *), previousTraitCollection == nil {

				      scrollView.contentInset = alternativeSizeClass(iPhone: UIEdgeInsets(top: view.height, left: 0, bottom: 0, right: 0),

				                                                     iPad: UIEdgeInsets.zero)

				      scrollView.layoutIfNeeded()

biodranik (Migrated from github.com) commented

2023-12-22 16:58:38 +00:00

This doesn't compile with XCode 13...

biodranik (Migrated from github.com) reviewed 2023-12-22 17:00:03 +00:00

iphone/Maps/UI/PlacePage/PlacePageViewController.swift

					
				@ -79,3 +79,4 @@

				    if #available(iOS 13.0, *), previousTraitCollection == nil {

				      scrollView.contentInset = alternativeSizeClass(iPhone: UIEdgeInsets(top: view.height, left: 0, bottom: 0, right: 0),

				                                                     iPad: UIEdgeInsets.zero)

				      scrollView.layoutIfNeeded()

biodranik (Migrated from github.com) commented

2023-12-22 17:00:03 +00:00

Looks like this approach should be used instead: bad1e95043/ProtonMail/ProtonMail/AppDelegate.swift (L226)

Looks like this approach should be used instead: https://github.com/ProtonMail/ios-mail/blob/bad1e950430f3ae1d893dc8e4ad5f4833ecfbfe2/ProtonMail/ProtonMail/AppDelegate.swift#L226

biodranik (Migrated from github.com) reviewed 2023-12-22 21:18:03 +00:00

iphone/Maps/UI/PlacePage/PlacePageViewController.swift

biodranik (Migrated from github.com) commented

2023-12-22 21:18:03 +00:00

      // See https://git.omaps.dev/organicmaps/organicmaps/issues/6917 for the details.

```suggestion // See https://git.omaps.dev/organicmaps/organicmaps/issues/6917 for the details. ```

biodranik (Migrated from github.com) approved these changes 2023-12-22 21:18:27 +00:00

biodranik (Migrated from github.com) left a comment

Thank you!

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

2 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#6931

Rows
Columns