Add icons and adjust POIs visibilities #7056

Merged

root merged 4 commits from pastk-styles-icons into master

2024-01-11 11:33:37 +00:00

pastk commented

2024-01-02 17:39:08 +00:00

Member

Summary of changes:

new ford icon
smaller/lighter pass/saddle icons
small icon versions where needed

main style

natural-saddle visibility from z14- to z15- (less important than peaks and passes)
natural-rock from 15 to 16
barrier-border_control from 15 to 14
leisure-golf_course from 17 to 15
man_made-survey_point from 16 to 18
water sources from 15 to 16
amenity-ice_cream caption from 19 to 17

outdoors

new power-tower icon
new man_made-mast/flagpole icons on z14-
natural-saddle from 11 to 13
natural-rock from 15 to 14
tourism-camp_site/caravan_site from 14 to 13
tourism-chalet from 15 to 14
barrier-border_control from 14 to 12
amenity-bbq from 18 to 16
amenity-toilets from 18 to 15
tourism-information-board/map/guidepost from 16 to 15
tourism-information-office/visitor_center from 15 to 13
highway-rest_area from 15 to 14
man_made-survey_point from z16 to z14

vehicle style

added amenity-toilets from 17
added shop-convenience from 17
barrier-border_control from 15 to 14
tourism-artwork from 15 to 18

Thanks @patepelo for help with the icons!

closes #6697
closes #5799
closes #6713
closes #6953
some points from #6016

Summary of changes: - new ford icon - smaller/lighter pass/saddle icons - small icon versions where needed main style - natural-saddle visibility from z14- to z15- (less important than peaks and passes) - natural-rock from 15 to 16 - barrier-border_control from 15 to 14 - leisure-golf_course from 17 to 15 - man_made-survey_point from 16 to 18 - water sources from 15 to 16 - amenity-ice_cream caption from 19 to 17 outdoors - new power-tower icon - new man_made-mast/flagpole icons on z14- - natural-saddle from 11 to 13 - natural-rock from 15 to 14 - tourism-camp_site/caravan_site from 14 to 13 - tourism-chalet from 15 to 14 - barrier-border_control from 14 to 12 - amenity-bbq from 18 to 16 - amenity-toilets from 18 to 15 - tourism-information-board/map/guidepost from 16 to 15 - tourism-information-office/visitor_center from 15 to 13 - highway-rest_area from 15 to 14 - man_made-survey_point from z16 to z14 vehicle style - added amenity-toilets from 17 - added shop-convenience from 17 - barrier-border_control from 15 to 14 - tourism-artwork from 15 to 18 Thanks @patepelo for help with the icons! - closes #6697 - closes #5799 - closes #6713 - closes #6953 - some points from #6016

❤️ 1

patepelo reviewed 2024-01-02 17:39:08 +00:00

vng (Migrated from github.com) reviewed 2024-01-04 02:03:33 +00:00

vng (Migrated from github.com) left a comment

Keep some unique notation/agreement for svg dimensions? Looks like they are different (github renders small or large). For example barrier-entrance-s and bcontrol-s.
Regenerate symbols?

- Keep some unique notation/agreement for svg dimensions? Looks like they are different (github renders small or large). For example barrier-entrance-s and bcontrol-s. - Regenerate symbols?

euf (Migrated from github.com) requested changes 2024-01-08 23:54:08 +00:00

euf (Migrated from github.com) left a comment

I'm afraid that further work needed for some icons.

First of all, at least ford-m.svg, mast-m.svg, power-tower-m.svg are too small to be legible at mdpi (aka @1) screen resolution, especially if you remember the 0.75 downscaling. Even after merging #7118 the 5×5px and 8×8px images are too small for my taste. Ford icon even has an outline which is less than half-pixel width, it should also be fixed.

Secondly, are you sure we should go with this obscure cartographic signs? Fellow tourist may not see these symbols as meaningful icons. Are there any downsides for using more clear images? I've made some quick drafts based on Roentgen designs. Here are they rendered at mdpi compared to proposed icons. What do you think?

Power tower: vs.
Flagpole: vs.
Mast: vs.

I'm afraid that further work needed for some icons. First of all, at least `ford-m.svg`, `mast-m.svg`, `power-tower-m.svg` are too small to be legible at `mdpi` (aka `@1`) screen resolution, especially if you remember the 0.75 downscaling. Even after merging #7118 the 5×5px and 8×8px images are too small for my taste. Ford icon even has an outline which is less than half-pixel width, it should also be fixed. Secondly, are you sure we should go with this obscure cartographic signs? Fellow tourist may not see these symbols as meaningful icons. Are there any downsides for using more clear images? I've made some quick drafts based on Roentgen designs. Here are they rendered at mdpi compared to proposed icons. What do you think? Power tower: ![power_tower](https://github.com/organicmaps/organicmaps/assets/11754264/c2160fe7-ea75-499a-be0c-4504e8b2a49b) vs. ![power-tower-m](https://github.com/organicmaps/organicmaps/assets/11754264/4e7a6428-efcf-4eea-968a-b21336344692) Flagpole: ![flagpole](https://github.com/organicmaps/organicmaps/assets/11754264/86b4353a-0ded-47d5-9b86-06474e78ff05) vs. ![mast-m](https://github.com/organicmaps/organicmaps/assets/11754264/64210d29-8c93-45c6-8520-05aca3f192f0) Mast: ![power_pole](https://github.com/organicmaps/organicmaps/assets/11754264/348caa7a-0138-4ff1-ac62-6e19361037a5) vs. ![mast-m](https://github.com/organicmaps/organicmaps/assets/11754264/64210d29-8c93-45c6-8520-05aca3f192f0)

vng (Migrated from github.com) approved these changes 2024-01-10 20:38:19 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

patepelo

euf

vng