Add sorting bookmarks and tracks by name #7182

2024-01-15T22:48:51Z

sklueber commented

2024-01-15 22:48:51 +00:00

(Migrated from github.com)

This PR adds the ability to sort bookmarks and tracks alphabetically by name (A->Z). This also allows a crude way of custom sorting by prefixing names accordingly.

Tracks and bookmarks are kept as separate blocks. As there is no concept of reversing the sort order yet, I could add the reverse order as an additional sort type but I wanted to leave that up to discussion first.

Menu item	Result	Result with tracks and bookmarks

Fixes (partially) #1066 (as the lists themselves are not sorted) and partially #4250

This PR adds the ability to sort bookmarks and tracks alphabetically by name (A->Z). This also allows a crude way of custom sorting by prefixing names accordingly. Tracks and bookmarks are kept as separate blocks. As there is no concept of reversing the sort order yet, I could add the reverse order as an additional sort type but I wanted to leave that up to discussion first. | Menu item | Result | Result with tracks and bookmarks | |--------|--------|--------| |![Screenshot_20240115-132758](https://github.com/organicmaps/organicmaps/assets/48260138/ff810407-acd4-4c8c-8ca1-30dd1401eb6a)| ![Screenshot_20240115-132804](https://github.com/organicmaps/organicmaps/assets/48260138/fc59be8d-333b-44e5-8931-bda625726f52) | ![Screenshot_20240115-154930](https://github.com/organicmaps/organicmaps/assets/48260138/031afd6e-5b36-4d3a-ae95-d5f100a9ea42) Fixes (partially) #1066 (as the lists themselves are not sorted) and partially #4250

biodranik (Migrated from github.com) reviewed 2024-01-15 23:04:05 +00:00

biodranik (Migrated from github.com) left a comment

Thanks!

What are the issues with the implementation?
What about the performance?
Is it feasible to sort entries in memory once, save them in the correct order into the KML file (internally, bookmarks are stored in KML), and then load/restore the sorted order from that file directly?

Thanks! 1. What are the issues with the implementation? 2. What about the performance? 3. Is it feasible to sort entries in memory once, save them in the correct order into the KML file (internally, bookmarks are stored in KML), and then load/restore the sorted order from that file directly?

android/app/src/main/java/app/organicmaps/bookmarks/ChooseBookmarksSortingTypeFragment.java

biodranik (Migrated from github.com) commented

2024-01-15 23:02:00 +00:00

120 chars in line is ok.

data/strings/strings.txt

					
				@ -25355,0 +24994,4 @@

				  [by_name]

				    comment = Android

				    tags = android

				    en = By name

biodranik (Migrated from github.com) commented

2024-01-15 23:01:40 +00:00

    en = By Name
    af = Op Naam
    ar = بالاسم
    az = Ada görə
    be = Па імені
    bg = По име
    ca = Per nom
    cs = Podle jména
    da = efter navn
    de = Nach Name
    el = Με όνομα
    es = Por nombre
    es-MX = Por nombre
    et = Nime järgi
    eu = Izenaren arabera
    fa = بر اساس اسم
    fi = Nimen mukaan
    fr = Par nom
    he = לפי שם
    hi = नाम द्वारा
    hu = Név szerint
    id = Berdasarkan Nama
    it = Per nome
    ja = 名前で
    ko = 이름별
    lt = Pagal pavadinimą
    mr = नावाने
    nb = Etter navn
    nl = Op naam
    pl = Według nazwy
    pt = Por nome
    ro = După nume
    ru = По имени
    sk = Podľa mena
    sv = Efter namn
    sw = Kwa Jina
    th = ตามชื่อ
    tr = İsme göre
    uk = За назвою
    vi = Theo Tên
    zh-Hans = 按名称
    zh-Hant = 按名字

``` en = By Name af = Op Naam ar = بالاسم az = Ada görə be = Па імені bg = По име ca = Per nom cs = Podle jména da = efter navn de = Nach Name el = Με όνομα es = Por nombre es-MX = Por nombre et = Nime järgi eu = Izenaren arabera fa = بر اساس اسم fi = Nimen mukaan fr = Par nom he = לפי שם hi = नाम द्वारा hu = Név szerint id = Berdasarkan Nama it = Per nome ja = 名前で ko = 이름별 lt = Pagal pavadinimą mr = नावाने nb = Etter navn nl = Op naam pl = Według nazwy pt = Por nome ro = După nume ru = По имени sk = Podľa mena sv = Efter namn sw = Kwa Jina th = ตามชื่อ tr = İsme göre uk = За назвою vi = Theo Tên zh-Hans = 按名称 zh-Hant = 按名字 ```

iphone/Maps/LocalizedStrings/es-MX.lproj/Localizable.strings

biodranik (Migrated from github.com) commented

2024-01-15 22:55:33 +00:00

This file should be excluded.

sklueber (Migrated from github.com) reviewed 2024-01-16 20:17:37 +00:00

data/strings/strings.txt

					
				@ -25355,0 +24994,4 @@

				  [by_name]

				    comment = Android

				    tags = android

				    en = By name

sklueber (Migrated from github.com) commented

2024-01-16 20:17:37 +00:00

Having "by Name" capitalized is inconsistent with the other sorting options, so I kept it lowercase

Having "by **N**ame" capitalized is inconsistent with the other sorting options, so I kept it lowercase

biodranik (Migrated from github.com) reviewed 2024-03-05 12:37:37 +00:00

biodranik (Migrated from github.com) left a comment

@sklueber I'm very sorry for the delay with the review. Let's fix and merge this important improvement!

Please rebase, check and fix failing checks, for example https://github.com/organicmaps/organicmaps/actions/runs/7547039543/job/20805713595#step:6:6262

@sklueber I'm very sorry for the delay with the review. Let's fix and merge this important improvement! Please rebase, check and fix failing checks, for example https://github.com/organicmaps/organicmaps/actions/runs/7547039543/job/20805713595#step:6:6262

map/bookmark_manager.cpp

biodranik (Migrated from github.com) commented

2024-03-05 12:35:28 +00:00

nit:

  // Sorting by name should always be possible.

nit: ```suggestion // Sorting by name should always be possible. ```

map/bookmark_manager.cpp

biodranik (Migrated from github.com) commented

2024-03-05 12:34:47 +00:00

    sortedMarks.push_back(&mark);

```suggestion sortedMarks.push_back(&mark); ```

map/bookmark_manager.cpp

biodranik (Migrated from github.com) commented

2024-03-05 12:35:07 +00:00

    bookmarkBlock.m_markIds.push_back(mark->m_id);

```suggestion bookmarkBlock.m_markIds.push_back(mark->m_id); ```

This repo is archived. You cannot comment on pull requests.

No reviewers

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#7182

Rows
Columns