Update categories.txt #832

2021-07-10T11:24:50Z

jamescridland commented

2021-07-10 11:24:50 +00:00

(Migrated from github.com)

Adding en-GB and en-AU variants where required, fixing "Centre" to be the correct spelling and en-US to override with "Center", and tidying up some descriptions. (I'm British, but live in Australia).

biodranik (Migrated from github.com) reviewed 2021-07-10 16:12:32 +00:00

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:12:32 +00:00

The first name is capitalized because it's visible to users. Others are just search synonyms and visible to users only in the search field suggestions, so we don't capitalize them. A number before a word means "how many characters user should type in the search field to see the hint with a full word). So if you think people may search for grocer, it may make sense to add a number, for example, 4, so the full word "grocer" will appear after typing "groc" (but there is already "3grocery" there, so they will appear both, and it may be too verbose). You may check how it works with other already present search synonyms.

biodranik (Migrated from github.com) reviewed 2021-07-10 16:15:44 +00:00

data/categories.txt

					
				@ -1550,3 +1559,4 @@

				eb-AU:Drinks|U+1F379

				ru:Напитки|соки

				bg:напитки|питиета

				ar:مشروبات|عصائر

biodranik (Migrated from github.com) commented

2021-07-10 16:15:44 +00:00

These shopping synonyms are for more general "shopping" search queries. Do you think that people don't expect to find a Department Store when they type "shopping"?

biodranik (Migrated from github.com) reviewed 2021-07-10 16:17:12 +00:00

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:17:12 +00:00

Capitalized Dealer in all 3 cases will look better on the screen.

biodranik (Migrated from github.com) reviewed 2021-07-10 16:32:46 +00:00

biodranik (Migrated from github.com) left a comment

Thanks! I left some comments :)

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:19:34 +00:00

Please capitalize Drugstore.

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:20:07 +00:00

I'd add prefix 4 here and below for the hint.

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:21:28 +00:00

It's a recycling center which accepts clothes, and probably may be confused with a Clothes shop. See https://wiki.openstreetmap.org/wiki/Tag:amenity%3Drecycling

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:23:30 +00:00

For these cases (when the main word is the same in dialects, but search synonyms may be different), it's better to leave only en: and add all additional synonyms there (may be with a number hint).

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:25:02 +00:00

@vng if a user has en-GB locale and types "Trash", will he find this feature?

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:26:44 +00:00

@vng the same question here: can we remove all search synonyms for the regional version? Will the search find it with en-US locale if a user types gym?

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:28:16 +00:00

This is not a service station: https://wiki.openstreetmap.org/wiki/Tag:highway%3Drest_area

data/categories.txt

biodranik (Migrated from github.com) commented

2021-07-10 16:32:01 +00:00

:)
https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbiergarten

To be clear, a biergarten is not the same as (what is known in the UK as) a "beer garden", i.e., an outside area associated with a pub. These are not biergartens in the Bavarian sense and may be tagged as a beer_garden or by adding outdoor_seating=* to the pub, cafe or restaurant.

:) https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dbiergarten > To be clear, a biergarten is not the same as (what is known in the UK as) a "beer garden", i.e., an outside area associated with a pub. These are not biergartens in the Bavarian sense and may be tagged as a beer_garden or by adding outdoor_seating=* to the pub, cafe or restaurant.

jamescridland (Migrated from github.com) reviewed 2021-07-11 10:06:30 +00:00

data/categories.txt

jamescridland (Migrated from github.com) commented

2021-07-11 10:06:30 +00:00

Understood. I'll remove the "Grocer", given the presence of '3grocery'.

jamescridland (Migrated from github.com) reviewed 2021-07-11 10:14:31 +00:00

data/categories.txt

					
				@ -1550,3 +1559,4 @@

				eb-AU:Drinks|U+1F379

				ru:Напитки|соки

				bg:напитки|питиета

				ar:مشروبات|عصائر

jamescridland (Migrated from github.com) commented

2021-07-11 10:14:31 +00:00

"A department store is a large store with multiple clothing and other general merchandise departments." - I would not expect a department store to appear if I searched for a shopping centre. A shopping centre is lots of shops, not just one: "a single building with multiple commercial retail stores where the entrances to the stores let onto a common enclosed area".

"Shopping" is a bit vague here, but either it appears as a synonym for all shops, or it doesn't. As it is, it appears as a synonym for nothing else other than a department store, which is inconsistent.

A search for "shopping centre" should not return a department store. Surely?

(And a search for "shopping" will return a shopping centre or shopping mall)

"A [department store](https://wiki.openstreetmap.org/wiki/Tag:shop=department_store) is a large store with multiple clothing and other general merchandise departments." - I would not expect a department store to appear if I searched for a shopping centre. A [shopping centre](https://wiki.openstreetmap.org/wiki/Tag:shop=mall) is lots of shops, not just one: "a single building with multiple commercial retail stores where the entrances to the stores let onto a common enclosed area". "Shopping" is a bit vague here, but either it appears as a synonym for _all_ shops, or it doesn't. As it is, it appears as a synonym for nothing else other than a department store, which is inconsistent. A search for "shopping centre" should not return a department store. Surely? (And a search for "shopping" will return a shopping centre or shopping mall)

jamescridland (Migrated from github.com) reviewed 2021-07-11 10:15:55 +00:00

data/categories.txt

jamescridland (Migrated from github.com) commented

2021-07-11 10:15:55 +00:00

Sure, this is a matter of style. I disagree that it looks better, and in all other languages it isn't capitalised in this way, but I'll make this change.

jamescridland (Migrated from github.com) reviewed 2021-07-11 10:16:23 +00:00

data/categories.txt

jamescridland (Migrated from github.com) commented

2021-07-11 10:16:23 +00:00

Sure.

jamescridland (Migrated from github.com) reviewed 2021-07-11 10:17:05 +00:00

data/categories.txt

jamescridland (Migrated from github.com) commented

2021-07-11 10:17:04 +00:00

Sure.

jamescridland (Migrated from github.com) reviewed 2021-07-11 10:20:03 +00:00

data/categories.txt

jamescridland (Migrated from github.com) commented

2021-07-11 10:20:03 +00:00

Agree. The same goes for all these recycling entries. I've changed this to "Clothes Recycling", and changed "Glass" below to "Glass Waste". I've also "ucwords" capitalised them all, as is the requested style.