[ios] Add a products section to the place page #8638

kirylkaveryn · 2024-07-05T10:44:00Z

kirylkaveryn commented

2024-07-05 10:44:00 +00:00

Close organicmaps/organicmaps#8514

This PR contains only the iOS UI.
The core implementation is organicmaps/organicmaps#9695

https://github.com/organicmaps/organicmaps/assets/79797627/f36874f6-e138-4c4e-b0db-5448e9f9a7af

Supported languages:

"en": {
"de": {
"fr": {
"nl": {
"it": {
"es": {
"pt": {

Supported regions:

"FR": [
"DE": [
"NL": [
"IT": [
"ES": [
"PT": [
"BE": [
"AT": [
"LU": [
"MC": [
"AD": [
"SM": [

Close https://git.omaps.dev/organicmaps/organicmaps/issues/8514 This PR contains only the iOS UI. The core implementation is https://git.omaps.dev/organicmaps/organicmaps/pulls/9695 https://github.com/organicmaps/organicmaps/assets/79797627/f36874f6-e138-4c4e-b0db-5448e9f9a7af <img src="https://github.com/user-attachments/assets/adb55adf-267d-434e-b6e3-48a11d324a4b" width="350px"> <img src="https://github.com/user-attachments/assets/e2c6a6d2-55bb-4130-aee0-b543432d64f4" width="350px"> Supported languages: "en": { "de": { "fr": { "nl": { "it": { "es": { "pt": { Supported regions: "FR": [ "DE": [ "NL": [ "IT": [ "ES": [ "PT": [ "BE": [ "AT": [ "LU": [ "MC": [ "AD": [ "SM": [

👍 1

biodranik (Migrated from github.com) reviewed 2024-07-05 10:44:00 +00:00

oleg-rswll reviewed 2024-07-05 10:44:00 +00:00

rtsisyk approved these changes 2024-11-16 13:37:31 +00:00

vng (Migrated from github.com) reviewed 2024-11-18 04:02:17 +00:00

vng (Migrated from github.com) left a comment

Well, since we have json config loading in Core, why do we make decode in Swift?
This routing will be the same for Android also.

Make some high level getter function from Core that will also contain conditional checks (foreground time, time since the first launch, number of sessions, etc)

If we want to advise different money options depending on foreground time :)
And unit tests there are easier to implement.

Well, since we have json config loading in Core, why do we make _decode_ in Swift? This routing will be the same for Android also. Make some _high level_ getter function from Core that will also contain conditional checks (foreground time, time since the first launch, number of sessions, etc) If we want to advise different money options depending on foreground time :) And unit tests there are easier to implement.

pastk reviewed 2024-11-18 17:07:44 +00:00

iphone/Maps/Core/Products/ProductsManager.swift

pastk commented

2024-11-18 17:07:44 +00:00

Its better to allow much longer time (e.g. a month) before asking new users to donate. Allow them time to use the app in a real situation (e.g. a trip), learn its functionality and understand/appreciate value it brings.

Also it'd help in cases when users re-install the app often. Alpha/beta testers included?

Its better to allow much longer time (e.g. a month) before asking new users to donate. Allow them time to use the app in a real situation (e.g. a trip), learn its functionality and understand/appreciate value it brings. Also it'd help in cases when users re-install the app often. Alpha/beta testers included?

pastk reviewed 2024-11-22 18:54:04 +00:00

platform/platform_tests/meta_config_tests.cpp

pastk commented

2024-11-22 18:53:43 +00:00

aboutScreenPrompt is not used atm?

`aboutScreenPrompt` is not used atm?

kirylkaveryn reviewed 2024-11-22 19:42:20 +00:00

platform/platform_tests/meta_config_tests.cpp

kirylkaveryn commented

2024-11-22 19:42:20 +00:00

Yes, it was removed from the neon and will not be used for now

vng (Migrated from github.com) approved these changes 2024-11-25 17:21:49 +00:00

jimcarst (Migrated from github.com) reviewed 2024-11-25 17:24:50 +00:00

data/strings/strings.txt

					
				@ -6871,0 +6989,4 @@

				    lv = Atbalstīt Organic Maps

				    mr = Organic Maps ला समर्थन द्या

				    nb = Støtte Organic Maps

				    nl = Ondersteun Organic Maps

jimcarst (Migrated from github.com) commented

2024-11-25 17:24:50 +00:00

    nl = Ondersteun Organic Maps

```suggestion nl = Ondersteun Organic Maps ```

map-per reviewed 2024-11-25 17:32:25 +00:00

map-per left a comment

DE review

data/strings/strings.txt

					
				@ -6871,0 +6879,4 @@

				    ca = Ja donat

				    cs = Již darováno

				    da = Allerede doneret

				    de = Bereits gespendet

map-per commented

2024-11-25 17:30:15 +00:00

    de = Bereits gespendet

```suggestion de = Bereits gespendet ```

data/strings/strings.txt

					
				@ -6871,0 +6924,4 @@

				    ca = Recorda més tard

				    cs = Připomeň později

				    da = Mind mig senere

				    de = Später erinnern

map-per commented

2024-11-25 17:27:04 +00:00

    de = Später erinnern

```suggestion de = Später erinnern ```

vng (Migrated from github.com) reviewed 2024-11-25 17:50:20 +00:00

vng (Migrated from github.com) left a comment

Besides native lang comment, I suppose we should not use Camel Case here, but:

Already donated
Remind later

Besides native lang comment, I suppose we should not use Camel Case here, but: - Already donated - Remind later

data/strings/strings.txt

					
				@ -6871,0 +6902,4 @@

				    pt = Já doado

				    pt-BR = Já doado

				    ro = Deja donat

				    ru = Уже пожертвовано

vng (Migrated from github.com) commented

2024-11-25 17:49:24 +00:00

Уже задонатил?

pastk reviewed 2024-11-25 18:24:36 +00:00

data/strings/strings.txt

					
				@ -6871,0 +6902,4 @@

				    pt = Já doado

				    pt-BR = Já doado

				    ro = Deja donat

				    ru = Уже пожертвовано

pastk commented

2024-11-25 18:24:36 +00:00

не подходит для женщин, надо нейтрально
"Уже пожертвовано"
поэтому нормально

не подходит для женщин, надо нейтрально "Уже пожертвовано" поэтому нормально

andergd (Migrated from github.com) requested changes 2024-11-25 18:59:01 +00:00

data/strings/strings.txt

					
				@ -6871,0 +6883,4 @@

				    el = Ήδη δωρεά

				    es = Ya donado

				    et = Juba annetatud

				    eu = Dohaintza jada emana

andergd (Migrated from github.com) commented

2024-11-25 18:55:09 +00:00

eu = Dohaintza jada emana

data/strings/strings.txt

					
				@ -6871,0 +6974,4 @@

				    el = Υποστήριξε το Organic Maps

				    es = Apoyar Organic Maps

				    et = Toetada Organic Maps

				    eu = Sustatu Organic Maps

andergd (Migrated from github.com) commented

2024-11-25 18:56:05 +00:00

eu = Sustatu Organic Maps

rtsisyk reviewed 2024-11-25 19:49:16 +00:00

data/strings/strings.txt

					
				@ -6871,0 +6902,4 @@

				    pt = Já doado

				    pt-BR = Já doado

				    ro = Deja donat

				    ru = Уже пожертвовано

rtsisyk commented

2024-11-25 19:49:16 +00:00

Пожертвовано - это про церковь.

soshial (Migrated from github.com) reviewed 2024-11-25 20:10:32 +00:00

data/strings/strings.txt

					
				@ -6871,0 +6902,4 @@

				    pt = Já doado

				    pt-BR = Já doado

				    ro = Deja donat

				    ru = Уже пожертвовано

soshial (Migrated from github.com) commented

2024-11-25 20:10:32 +00:00

А можно нормальным русским языком без вот этих "донатов"? 🍩

"Пожертвование" и "благотворительность" — абсолютно нормальные слова и не обязательно сразу церковь.

А можно нормальным русским языком без вот этих "донатов"? 🍩 "Пожертвование" и "благотворительность" — абсолютно нормальные слова и не обязательно сразу церковь.

soshial (Migrated from github.com) reviewed 2024-11-25 20:13:35 +00:00

data/strings/strings.txt

					
				@ -6871,0 +6894,4 @@

				    it = Già donato

				    ja = 寄付済み

				    ko = 기부완료

				    lt = Jau noziedoju

soshial (Migrated from github.com) commented

2024-11-25 20:13:35 +00:00

Latvian was omitted

lv = Jau noziedoju

Latvian was omitted lv = Jau noziedoju

This repo is archived. You cannot comment on pull requests.

No reviewers

biodranik

oleg-rswll

rtsisyk

vng

andergd

No labels

Android Automotive (AAOS)

API

AppGallery

AppStore

Battery and Performance

External Map Datasets

F-Droid

Fonts

Frequently User Reported

No milestone

No project

No assignees

6 participants

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#8638

Rows
Columns