Traffic lights v2 #8790

strump · 2024-07-29T15:07:01Z

strump commented

2024-07-29 15:07:01 +00:00

Finishing PR #7281 by @RedAuburn

Rebased his branch to master. And fixed drules_merge.py script (this also affected speed cameras).

(This block https://osm.org/?mlat=51.48147&mlon=-0.00903 on the screenshot)

Map with traffic lights: UK_England_Greater London.mwm

Finishing PR #7281 by @RedAuburn Rebased his branch to `master`. And fixed `drules_merge.py` script (this also affected speed cameras). <img width="500" alt="Screenshot 2024-07-29 at 18 01 33" src="https://github.com/user-attachments/assets/0e9b45db-fb66-4b15-8913-913f6496766b"/> _(This block https://osm.org/?mlat=51.48147&mlon=-0.00903 on the screenshot)_ Map with traffic lights: [UK_England_Greater London.mwm](https://drive.proton.me/urls/R523V2FFWM#rj3ReD7UrBTC)

❤️ 1

strump reviewed 2024-07-29 15:11:39 +00:00

tools/python/stylesheet/drules_merge.py

strump commented

2024-07-29 15:11:39 +00:00

There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.

> There are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors.

biodranik (Migrated from github.com) approved these changes 2024-07-29 16:47:59 +00:00

biodranik (Migrated from github.com) left a comment

@vng PTAL, I'm ok with traffic lights for vehicles only as the first step. The same type will be used to penalize routing too, right?

data/replaced_tags.txt

					
				@ -151,4 +151,2 @@

				crossing=traffic_signals : highway=traffic_signals

				# Replace top tags from here https://taginfo.openstreetmap.org/search?q=recycling on the common ones.

biodranik (Migrated from github.com) commented

2024-07-29 16:44:23 +00:00

Crossing traffic lights will be ignored now, correct? They should be added separately, right? @euf can we do a red + green icon for crossings?

data/styles/vehicle/include/Icons.mapcss

					
				@ -125,2 +125,4 @@

				/*check offset int_name*/

				/* 3.2 Road Icons */

				node|z19-[highway=traffic_signals],

biodranik (Migrated from github.com) commented

2024-07-29 16:46:41 +00:00

For vehicle style, does it make sense to show traffic lights earlier? Will they be visible at all on mobile devices when the camera is up at the city speed of 30-50 mph?

tools/python/stylesheet/drules_merge.py

biodranik (Migrated from github.com) commented

2024-07-29 16:47:02 +00:00

    for z in range(zooms2[typ][0].scale, zooms2[typ][1].scale + 1):

```suggestion for z in range(zooms2[typ][0].scale, zooms2[typ][1].scale + 1): ```

vng (Migrated from github.com) approved these changes 2024-07-29 18:14:38 +00:00

euf (Migrated from github.com) reviewed 2024-08-05 08:09:24 +00:00

data/replaced_tags.txt

					
				@ -151,4 +151,2 @@

				crossing=traffic_signals : highway=traffic_signals

				# Replace top tags from here https://taginfo.openstreetmap.org/search?q=recycling on the common ones.