Thanks! Looks like the code can be simplified, and the already existing code may be reused, @Endem10n what do you think?
Java sometimes sounds too verbose for simple, already implemented tasks.

Thanks! Looks like the code can be simplified, and the already existing code may be reused, @Endem10n what do you think? Java sometimes sounds too verbose for simple, already implemented tasks.

Endem10n (Migrated from github.com) reviewed 2021-07-24 11:35:53 +00:00

android/src/com/mapswithme/maps/bookmarks/BookmarkCategoriesAdapter.java

Endem10n (Migrated from github.com) commented

2021-07-24 11:35:53 +00:00

@SeanConn15 could you, please, add empty line between class bodies?

Endem10n commented

2021-07-24 11:51:47 +00:00

(Migrated from github.com)

@biodranik LGTM. In this case all code that added in PR is needed. Not sure, that we should unite some of listeners for bookmark list. Need to think it over a bit in background, if we need to refactor some code in bookmarks functionality in different places and how exactly. For now I suggest to merge PR. I'd prefer to do some refactoring in bookmarks later in separate PR.

rtsisyk reviewed 2021-07-24 13:43:19 +00:00

rtsisyk left a comment

Owner

The patch follows existing style and solves #824 problem, as described. I agree that original code has too many useless abstraction levels. However, this is not a problem of this patch.

Approved. Thanks for the contribution!

The patch follows existing style and solves #824 problem, as described. I agree that original code has too many useless abstraction levels. However, this is not a problem of this patch. Approved. Thanks for the contribution!

rtsisyk approved these changes 2021-07-24 13:43:28 +00:00

SeanConn15 commented

2021-07-24 18:17:33 +00:00

(Migrated from github.com)

added space and signed off.

biodranik (Migrated from github.com) approved these changes 2021-07-24 22:13:52 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

Endem10n

rtsisyk

biodranik