WIP: [Android] Speedometer warning static threshold #9150

strump · 2024-08-29T09:11:35Z

strump commented

2024-08-29 09:11:35 +00:00

Introduced static SPEED_LIMIT_THRESHOLD for speedometer warning. If current_speed > speed_limit + SPEED_LIMIT_THRESHOLD then speedometer becomes red.

Depending on user locale SPEED_LIMIT_THRESHOLD value should be treated either as kilometers-per-hour or as miles-per-hour.

We can change threshold from static value to configurable parameter.

Expected result:

Current speed	Speed on UI	Limit	Limit + Threshold	Status
`59.4` kph	`59`	`60`	`61`	Ok
`60.1` kph	`60`	`60`	`61`	Ok
`60.9` kph	`60`	`60`	`61`	Ok
`61.2` kph	`61`	`60`	`61`	Warning
`65.5` kph	`65`	`60`	`61`	Warning

Introduced static `SPEED_LIMIT_THRESHOLD` for speedometer warning. If `current_speed > speed_limit + SPEED_LIMIT_THRESHOLD` then speedometer becomes red. Depending on user locale `SPEED_LIMIT_THRESHOLD` value should be treated either as kilometers-per-hour or as miles-per-hour. We can change threshold from static value to configurable parameter. Expected result: | Current speed | Speed on UI | Limit | Limit + Threshold | Status | | ------------- | ------------ | ----- | ----------------- | ------- | | `59.4` kph | `59` | `60` | `61` | Ok | | `60.1` kph | `60` | `60` | `61` | Ok | | `60.9` kph | `60` | `60` | `61` | Ok | | `61.2` kph | `61` | `60` | `61` | Warning | | `65.5` kph | `65` | `60` | `61` | Warning |

strump reviewed 2024-08-29 09:12:31 +00:00

android/app/src/main/cpp/app/organicmaps/util/StringUtils.cpp

					
				@ -85,0 +87,4 @@

				Java_app_organicmaps_util_StringUtils_nativeLocalizedSpeedToMps(JNIEnv * env, jclass, jdouble speed)

				{

				    return measurement_utils::UnitsToMps(speed, measurement_utils::GetMeasurementUnits());

				}

strump commented

2024-08-29 09:12:31 +00:00

Should we have conversion from mph/kph to meters-per-hour here? Is StringUtils a good place for it?

Should we have conversion from mph/kph to meters-per-hour here? Is `StringUtils` a good place for it?

strump reviewed 2024-08-29 09:32:40 +00:00

platform/measurement_utils.cpp

					
				@ -187,0 +192,4 @@

				    case Units::Metric: return KmphToMps(speed); break;

				  }

				  UNREACHABLE();

				}

strump commented

2024-08-29 09:32:40 +00:00

TODO: cover with unit-tests

biodranik (Migrated from github.com) reviewed 2024-08-29 20:19:16 +00:00

android/app/src/main/java/app/organicmaps/widget/menu/NavMenu.java

biodranik (Migrated from github.com) commented

2024-08-29 20:19:16 +00:00

Calling JNI every time is not cheap. Would it be possible to include the necessary flag (or tri-state int like LAWFUL/HIT_LIMIT/HIT_THRESHOLD) in RoutingInfo struct from the C++ core and use/share it on all platforms?