[ios] Crash in BookmarkManager::GetBmCategory() during searching/bm deleting #9362

New issue

Open

opened 2024-09-25 15:09:09 +00:00 by kirylkaveryn · 0 comments

kirylkaveryn commented

2024-09-25 15:09:09 +00:00

Member

One of the most common new crashes in ios starting from the 2024.08.09 release version is when the BuildPlacePageInfo - > FillBookmarkInfo -> GetBmCategory methods are called:

1. while searching

2024-09-20_23-27-31.5714_+0200-e62e3e8b19bc7c09f4b90da84955514298f44d6d.crash.zip

Incident Identifier: 9D20547C-D5DD-49D9-A70B-2A5A4B18DD11
Distributor ID:      com.apple.AppStore
Hardware Model:      iPhone13,2
Process:             Organic Maps [42817]
Path:                /private/var/containers/Bundle/Application/AB9FC08B-E6D1-49C7-BEF9-AE8D38EBCB55/Organic Maps.app/Organic Maps
Identifier:          app.organicmaps
Version:             2024.08.15 (16)
AppStoreTools:       15F31e
AppVariant:          1:iPhone13,2:15
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           app.organicmaps [7467]

Date/Time:           2024-09-20 23:27:31.5714 +0200
Launch Time:         2024-09-20 19:07:38.1633 +0200
OS Version:          iPhone OS 17.6.1 (21G93)
Release Type:        User
Baseband Version:    4.70.01
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: SIGNAL 6 Abort trap: 6
Terminating Process: Organic Maps [42817]

Triggered by Thread:  0

Thread 0 name:
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001e01042ec __pthread_kill + 8 (:-1)
1   libsystem_pthread.dylib       	0x00000001f3ef7c0c pthread_kill + 268 (pthread.c:1721)
2   libsystem_c.dylib             	0x000000019f403ba0 abort + 180 (abort.c:118)
3   Organic Maps                  	0x0000000102b8c64c BookmarkManager::GetBmCategory(unsigned long long) const + 260 (bookmark_manager.hpp:606)
4   Organic Maps                  	0x0000000102bb6e08 BookmarkManager::GetCategoryName(unsigned long long) const + 248 (bookmark_manager.cpp:1602)
5   Organic Maps                  	0x0000000102c08814 Framework::FillBookmarkInfo(Bookmark const&, place_page::Info&) const + 96 (framework.cpp:574)
6   Organic Maps                  	0x0000000102c06c64 Framework::BuildPlacePageInfo(place_page::BuildInfo const&) + 6056 (framework.cpp:2188)
7   Organic Maps                  	0x0000000102c1295c Framework::SelectSearchResult(search::Result const&, bool) + 380 (framework.cpp:1297)
8   Organic Maps                  	0x00000001026e3bac -[MWMSearchManager processSearchWithResult:] + 260 (MWMSearchManager.mm:157)
9   Organic Maps                  	0x0000000102683490 -[MWMSearchTableViewController tableView:didSelectRowAtIndexPath:] + 332 (MWMSearchTableViewController.mm:121)
10  UIKitCore                     	0x0000000199957904 -[UITableView _selectRowAtIndexPath:animated:scrollPosition:notifyDelegate:isCellMultiSelect:deselectPrevious:performCustomSelectionAction:] + 1232 (UITableView.m:9323)

2. while deleting the bookmark

2024-09-19_20-16-41.1396_+0400-957c400c76e5a86a9d77ce57e277936f8bb42189.crash.zip

Incident Identifier: 7661A52B-431F-4740-9937-83B4101E8FCB
Distributor ID:      com.apple.AppStore
Hardware Model:      iPhone15,2
Process:             Organic Maps [18114]
Path:                /private/var/containers/Bundle/Application/724C86F3-14C3-4E6B-BB76-78415E2FED20/Organic Maps.app/Organic Maps
Identifier:          app.organicmaps
Version:             2024.08.15 (16)
AppStoreTools:       15F31e
AppVariant:          1:iPhone15,2:16
Code Type:           ARM-64 (Native)
Role:                Foreground
Parent Process:      launchd [1]
Coalition:           app.organicmaps [954]

Date/Time:           2024-09-19 20:16:41.1396 +0400
Launch Time:         2024-09-19 11:39:40.0312 +0400
OS Version:          iPhone OS 17.6.1 (21G93)
Release Type:        User
Baseband Version:    2.60.02
Report Version:      104

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Termination Reason: SIGNAL 6 Abort trap: 6
Terminating Process: Organic Maps [18114]

Triggered by Thread:  0

Thread 0 name:
Thread 0 Crashed:
0   libsystem_kernel.dylib        	0x00000001e44d02ec __pthread_kill + 8 (:-1)
1   libsystem_pthread.dylib       	0x00000001f82c3c0c pthread_kill + 268 (pthread.c:1721)
2   libsystem_c.dylib             	0x00000001a37cfba0 abort + 180 (abort.c:118)
3   Organic Maps                  	0x0000000102ba864c BookmarkManager::GetBmCategory(unsigned long long) const + 260 (bookmark_manager.hpp:606)
4   Organic Maps                  	0x0000000102bd2e08 BookmarkManager::GetCategoryName(unsigned long long) const + 248 (bookmark_manager.cpp:1602)
5   Organic Maps                  	0x0000000102c24814 Framework::FillBookmarkInfo(Bookmark const&, place_page::Info&) const + 96 (framework.cpp:574)
6   Organic Maps                  	0x0000000102c22c64 Framework::BuildPlacePageInfo(place_page::BuildInfo const&) + 6056 (framework.cpp:2188)
7   Organic Maps                  	0x0000000102ed0798 Framework::UpdatePlacePageInfoForCurrentSelection(std::__1::optional<place_page::BuildInfo> const&) + 48 (framework.cpp:2215)
8   Organic Maps                  	0x0000000102ed0798 +[MWMFrameworkHelper updateAfterDeleteBookmark] + 320 (MWMFrameworkHelper.mm:192)
9   Organic Maps                  	0x00000001026b23b4 -[MWMPlacePageManager removeBookmark:] + 136 (MWMPlacePageManager.mm:188)
10  Organic Maps                  	0x00000001026e547c +[MWMPlacePageManagerHelper removeBookmark:] + 76 (MWMPlacePageManagerHelper.mm:153)
11  Organic Maps                  	0x00000001025bedec PlacePageInteractor.actionBar(_:didPressButton:) + 12 (<compiler-generated>:185)
12  Organic Maps                  	0x00000001025bedec protocol witness for ActionBarViewControllerDelegate.actionBar(_:didPressButton:) in conformance PlacePageInteractor + 12 (ActionBarViewController.swift:197)
13  Organic Maps                  	0x00000001025bedec ActionBarViewController.tapOnButton(with:) + 12 (<compiler-generated>:0)
14  Organic Maps                  	0x00000001025bedec @objc ActionBarViewController.tapOnButton(with:) + 116
15  Organic Maps                  	0x00000001026d2090 -[MWMActionBarButton tap] + 76 (MWMActionBarButton.m:156)
16  UIKitCore                     	0x000000019de6a4f8 -[UIApplication sendAction:to:from:forEvent:] + 100 (UIApplication.m:5616)

I can't reproduce this bugs...

The last commit that affects the PP filling with the bookmark info is #bf5825733ee6510cadf0b9ecd03c0454341b9f23
@strump can you help me to investigate possible issues? Can this bug be related to the latest changes in FillBookmarkInfo and BuildPlacePageInfo?

One of the most common new crashes in ios starting from the 2024.08.09 release version is when the `BuildPlacePageInfo` - > `FillBookmarkInfo` -> `GetBmCategory` methods are called: ### 1. while searching [2024-09-20_23-27-31.5714_+0200-e62e3e8b19bc7c09f4b90da84955514298f44d6d.crash.zip](https://github.com/user-attachments/files/17133818/2024-09-20_23-27-31.5714_%2B0200-e62e3e8b19bc7c09f4b90da84955514298f44d6d.crash.zip) ``` Incident Identifier: 9D20547C-D5DD-49D9-A70B-2A5A4B18DD11 Distributor ID: com.apple.AppStore Hardware Model: iPhone13,2 Process: Organic Maps [42817] Path: /private/var/containers/Bundle/Application/AB9FC08B-E6D1-49C7-BEF9-AE8D38EBCB55/Organic Maps.app/Organic Maps Identifier: app.organicmaps Version: 2024.08.15 (16) AppStoreTools: 15F31e AppVariant: 1:iPhone13,2:15 Code Type: ARM-64 (Native) Role: Foreground Parent Process: launchd [1] Coalition: app.organicmaps [7467] Date/Time: 2024-09-20 23:27:31.5714 +0200 Launch Time: 2024-09-20 19:07:38.1633 +0200 OS Version: iPhone OS 17.6.1 (21G93) Release Type: User Baseband Version: 4.70.01 Report Version: 104 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Termination Reason: SIGNAL 6 Abort trap: 6 Terminating Process: Organic Maps [42817] Triggered by Thread: 0 Thread 0 name: Thread 0 Crashed: 0 libsystem_kernel.dylib 0x00000001e01042ec __pthread_kill + 8 (:-1) 1 libsystem_pthread.dylib 0x00000001f3ef7c0c pthread_kill + 268 (pthread.c:1721) 2 libsystem_c.dylib 0x000000019f403ba0 abort + 180 (abort.c:118) 3 Organic Maps 0x0000000102b8c64c BookmarkManager::GetBmCategory(unsigned long long) const + 260 (bookmark_manager.hpp:606) 4 Organic Maps 0x0000000102bb6e08 BookmarkManager::GetCategoryName(unsigned long long) const + 248 (bookmark_manager.cpp:1602) 5 Organic Maps 0x0000000102c08814 Framework::FillBookmarkInfo(Bookmark const&, place_page::Info&) const + 96 (framework.cpp:574) 6 Organic Maps 0x0000000102c06c64 Framework::BuildPlacePageInfo(place_page::BuildInfo const&) + 6056 (framework.cpp:2188) 7 Organic Maps 0x0000000102c1295c Framework::SelectSearchResult(search::Result const&, bool) + 380 (framework.cpp:1297) 8 Organic Maps 0x00000001026e3bac -[MWMSearchManager processSearchWithResult:] + 260 (MWMSearchManager.mm:157) 9 Organic Maps 0x0000000102683490 -[MWMSearchTableViewController tableView:didSelectRowAtIndexPath:] + 332 (MWMSearchTableViewController.mm:121) 10 UIKitCore 0x0000000199957904 -[UITableView _selectRowAtIndexPath:animated:scrollPosition:notifyDelegate:isCellMultiSelect:deselectPrevious:performCustomSelectionAction:] + 1232 (UITableView.m:9323) ``` ### 2. while deleting the bookmark [2024-09-19_20-16-41.1396_+0400-957c400c76e5a86a9d77ce57e277936f8bb42189.crash.zip](https://github.com/user-attachments/files/17133800/2024-09-19_20-16-41.1396_%2B0400-957c400c76e5a86a9d77ce57e277936f8bb42189.crash.zip) ``` Incident Identifier: 7661A52B-431F-4740-9937-83B4101E8FCB Distributor ID: com.apple.AppStore Hardware Model: iPhone15,2 Process: Organic Maps [18114] Path: /private/var/containers/Bundle/Application/724C86F3-14C3-4E6B-BB76-78415E2FED20/Organic Maps.app/Organic Maps Identifier: app.organicmaps Version: 2024.08.15 (16) AppStoreTools: 15F31e AppVariant: 1:iPhone15,2:16 Code Type: ARM-64 (Native) Role: Foreground Parent Process: launchd [1] Coalition: app.organicmaps [954] Date/Time: 2024-09-19 20:16:41.1396 +0400 Launch Time: 2024-09-19 11:39:40.0312 +0400 OS Version: iPhone OS 17.6.1 (21G93) Release Type: User Baseband Version: 2.60.02 Report Version: 104 Exception Type: EXC_CRASH (SIGABRT) Exception Codes: 0x0000000000000000, 0x0000000000000000 Termination Reason: SIGNAL 6 Abort trap: 6 Terminating Process: Organic Maps [18114] Triggered by Thread: 0 Thread 0 name: Thread 0 Crashed: 0 libsystem_kernel.dylib 0x00000001e44d02ec __pthread_kill + 8 (:-1) 1 libsystem_pthread.dylib 0x00000001f82c3c0c pthread_kill + 268 (pthread.c:1721) 2 libsystem_c.dylib 0x00000001a37cfba0 abort + 180 (abort.c:118) 3 Organic Maps 0x0000000102ba864c BookmarkManager::GetBmCategory(unsigned long long) const + 260 (bookmark_manager.hpp:606) 4 Organic Maps 0x0000000102bd2e08 BookmarkManager::GetCategoryName(unsigned long long) const + 248 (bookmark_manager.cpp:1602) 5 Organic Maps 0x0000000102c24814 Framework::FillBookmarkInfo(Bookmark const&, place_page::Info&) const + 96 (framework.cpp:574) 6 Organic Maps 0x0000000102c22c64 Framework::BuildPlacePageInfo(place_page::BuildInfo const&) + 6056 (framework.cpp:2188) 7 Organic Maps 0x0000000102ed0798 Framework::UpdatePlacePageInfoForCurrentSelection(std::__1::optional<place_page::BuildInfo> const&) + 48 (framework.cpp:2215) 8 Organic Maps 0x0000000102ed0798 +[MWMFrameworkHelper updateAfterDeleteBookmark] + 320 (MWMFrameworkHelper.mm:192) 9 Organic Maps 0x00000001026b23b4 -[MWMPlacePageManager removeBookmark:] + 136 (MWMPlacePageManager.mm:188) 10 Organic Maps 0x00000001026e547c +[MWMPlacePageManagerHelper removeBookmark:] + 76 (MWMPlacePageManagerHelper.mm:153) 11 Organic Maps 0x00000001025bedec PlacePageInteractor.actionBar(_:didPressButton:) + 12 (<compiler-generated>:185) 12 Organic Maps 0x00000001025bedec protocol witness for ActionBarViewControllerDelegate.actionBar(_:didPressButton:) in conformance PlacePageInteractor + 12 (ActionBarViewController.swift:197) 13 Organic Maps 0x00000001025bedec ActionBarViewController.tapOnButton(with:) + 12 (<compiler-generated>:0) 14 Organic Maps 0x00000001025bedec @objc ActionBarViewController.tapOnButton(with:) + 116 15 Organic Maps 0x00000001026d2090 -[MWMActionBarButton tap] + 76 (MWMActionBarButton.m:156) 16 UIKitCore 0x000000019de6a4f8 -[UIApplication sendAction:to:from:forEvent:] + 100 (UIApplication.m:5616) ``` I can't reproduce this bugs... The last commit that affects the PP filling with the bookmark info is [#bf5825733ee6510cadf0b9ecd03c0454341b9f23](https://git.omaps.dev/organicmaps/organicmaps/commit/bf5825733ee6510cadf0b9ecd03c0454341b9f23) @strump can you help me to investigate possible issues? Can this bug be related to the latest changes in `FillBookmarkInfo` and `BuildPlacePageInfo`?

This repo is archived. You cannot comment on issues.