[android][ios][carplay][android-auto] Show speed limit sign on all platforms

ccptr commented

2021-07-29 23:52:22 +00:00

(Migrated from github.com)

If the speed limit is known it'd be nice to be able to see it.

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

If the speed limit is known it'd be nice to be able to see it.  ## Upvote & Fund - We're using [Polar.sh](https://polar.sh/organicmaps) so you can upvote and help fund this issue. - We receive the funding once the issue is completed & confirmed by you. - Thank you in advance for helping prioritize & fund our backlog. <a href="https://polar.sh/organicmaps/organicmaps/issues/952"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://polar.sh/api/github/organicmaps/organicmaps/issues/952/pledge.svg?darkmode=1"> <img alt="Fund with Polar" src="https://polar.sh/api/github/organicmaps/organicmaps/issues/952/pledge.svg"> </picture> </a>

👍 68 👀 1 ❤️ 1 🚀 2

biodranik commented

2021-08-11 06:18:10 +00:00

(Migrated from github.com)

Even better would be an easy and convenient way to add/improve speed limits along the way :)

👍 8 🚀 2

Orejane commented

2021-08-12 11:42:37 +00:00

(Migrated from github.com)

EStimation of Arrival Time should be based on speed limit

👍 5

biodranik commented

2021-08-12 12:02:45 +00:00

(Migrated from github.com)

Not every road in OSM has existing speed limit tag set. During the ride you may see the (probably outdated) speed limit, then see nothing. And then see a speed limit again.

ccptr commented

2021-08-19 02:40:30 +00:00

(Migrated from github.com)

EStimation of Arrival Time should be based on speed limit

Is it not?

> EStimation of Arrival Time should be based on speed limit Is it not?

Orejane commented

2021-08-19 05:00:23 +00:00

(Migrated from github.com)

EStimation of Arrival Time should be based on speed limit

Is it not?

as speed limit does not show I cannot tell it for sure, but my impression is that estimation is wrong in town

> > EStimation of Arrival Time should be based on speed limit > > Is it not? as speed limit does not show I cannot tell it for sure, but my impression is that estimation is wrong in town

Nic787 commented

2021-12-22 05:21:23 +00:00

(Migrated from github.com)

EStimation of Arrival Time should be based on speed limit

Is it not?

as speed limit does not show I cannot tell it for sure, but my impression is that estimation is wrong in town

Remind me of a time in Iceland where the estimated time of a trip was 1h30, but Google Maps was giving me 2h30... Guess who was right...

I guess if speed limit is not known, it could give an average or a way to update OSM speed limit directly into the app?

> > > EStimation of Arrival Time should be based on speed limit > > > > > > Is it not? > > as speed limit does not show I cannot tell it for sure, but my impression is that estimation is wrong in town Remind me of a time in Iceland where the estimated time of a trip was 1h30, but Google Maps was giving me 2h30... Guess who was right... I guess if speed limit is not known, it could give an average or a way to update OSM speed limit directly into the app?

alensiljak commented

2022-04-07 12:36:59 +00:00

(Migrated from github.com)

In my opinion, the algorithm must be smarter than just calculating the estimated time based on the speed limits. One will simply never reach the destination in the time given by the speed limit in a residential area. Simply hit one traffic light and you're already off. The traffic lights make a huge difference, apart from the traffic itself. I'm often surprised by the 20-minute estimates when the actual ride to the town takes over one and half hours.

Other than that - please - the speed limit is quite important in the city. Where I live, there is a entangled mix of limits with 30, 50, 70+ speed limits and the signs are not always there. I'm not sure where the OSM guys get that data but I would never figured it out just by looking at the traffic signs. And that is an information overload when in a different town.

Adding the speed limits to OSM through the app would be great but even just showing it in the navigation mode would be a great improvement (would actually make me use the app for navigation).

Edit: elements that affect the travel speed under normal conditions:

traffic lights
speed bumps
pedestrian crossings
rail/tram crossings
road surface (good luck respecting the 100km/h speed limit on a gravel road)
road curvature
gates, checkpoints (toll road entrance, for example)
on-road traffic

In my opinion, the algorithm must be smarter than just calculating the estimated time based on the speed limits. One will simply **never** reach the destination in the time given by the speed limit in a residential area. Simply hit one traffic light and you're already off. The traffic lights make a huge difference, apart from the traffic itself. I'm often surprised by the 20-minute estimates when the actual ride to the town takes over one and half hours. Other than that - **please** - the speed limit is quite important in the city. Where I live, there is a entangled mix of limits with 30, 50, 70+ speed limits and the signs are not always there. I'm not sure where the OSM guys get that data but I would never figured it out just by looking at the traffic signs. And that is an information overload when in a different town. Adding the speed limits to OSM through the app would be great but even just showing it in the navigation mode would be a great improvement (would actually make me use the app for navigation). Edit: elements that affect the travel speed under normal conditions: - traffic lights - speed bumps - pedestrian crossings - rail/tram crossings - road surface (good luck respecting the 100km/h speed limit on a gravel road) - road curvature - gates, checkpoints (toll road entrance, for example) - on-road traffic

👍 4

ccptr commented

2022-04-07 15:30:51 +00:00

(Migrated from github.com)

I'm often surprised by the 20-minute estimates when the actual ride to the town takes over one and half hours.

Are you sure OSM has speed limit data for those roads? There were a couple highways in between two towns that I often routed between that didn't have maxspeed set, and as a result OsmAnd took me on some weird routes with completely inaccurate ETAs. That sounds like it's assuming 100 km/h on 30-50 km/h roads or something.

>I'm often surprised by the 20-minute estimates when the actual ride to the town takes over one and half hours. Are you sure OSM has speed limit data for those roads? There were a couple highways in between two towns that I often routed between that didn't have `maxspeed` set, and as a result OsmAnd took me on some weird routes with completely inaccurate ETAs. That sounds like it's assuming 100 km/h on 30-50 km/h roads or something.

Talkless commented

2022-04-11 13:57:05 +00:00

(Migrated from github.com)

Not every road in OSM has existing speed limit tag set

Maybe it would be possible to incorporate implicit default speed limits database: https://wiki.openstreetmap.org/wiki/Default_speed_limits

Biggest question if, does map processor "knows" if road is urban (within place area) or rural using OSM data?

> Not every road in OSM has existing speed limit tag set Maybe it would be possible to incorporate implicit default speed limits database: https://wiki.openstreetmap.org/wiki/Default_speed_limits Biggest question if, does map processor "knows" if road is urban (within place area) or rural using OSM data?

👍 1

AntonM030481 commented

2022-05-05 06:48:40 +00:00

(Migrated from github.com)

You can here OSM map here, where each road is marked with it's speed limit (if info is present):
https://www.openstreetbrowser.org/#map=17/50.07620/19.89539&categories=car_maxspeed
You can easily add speed limit there if no info is present.

You can here OSM map here, where each road is marked with it's speed limit (if info is present): https://www.openstreetbrowser.org/#map=17/50.07620/19.89539&categories=car_maxspeed You can easily add speed limit there if no info is present. ![image](https://user-images.githubusercontent.com/85622715/166874623-7d33c0cf-ad41-47e4-8927-0c8f3d5658fe.png)

👍 4

AntonM030481 commented

2022-06-06 06:49:34 +00:00

(Migrated from github.com)

@biodranik so, why not to show the speed limit from OSM data?

alensiljak commented

2022-06-06 06:56:21 +00:00

(Migrated from github.com)

Perhaps the title should be adjusted to narrow down to showing the speed limit in navigation mode? It would really help driving in the city. Especially now that the routing feel better and the routes are different (and seem better) to other apps that I have, but which also use OSM data.

Also, if you sort the issues by the number of 👍s, this is the most up-voted issue.

Perhaps the title should be adjusted to narrow down to showing the speed limit in navigation mode? It would really help driving in the city. Especially now that the routing feel better and the routes are different (and seem better) to other apps that I have, but which also use OSM data. Also, if you sort the issues by the number of 👍s, this is the most up-voted issue.

biodranik commented

2022-06-06 09:21:21 +00:00

(Migrated from github.com)

@AntonM030481 implement it ) it was partially done already.

👍 3

bitboy85 commented

2022-06-07 10:01:16 +00:00

(Migrated from github.com)

If a speed limit is known, it should be shown :)
The data might be outdated, but this argument is also true for other parts of the map:
Closed roads, exits, new lanes, new crossings...
If someone notice wrong data, the person is at least able to correct it. (Or making a note on osm)

If a speed limit is known, it should be shown :) The data might be outdated, but this argument is also true for other parts of the map: Closed roads, exits, new lanes, new crossings... If someone notice wrong data, the person is at least able to correct it. (Or making a note on osm)

👍 9

AntonM030481 commented

2022-06-09 05:46:32 +00:00

(Migrated from github.com)

@biodranik challenge accepted 😄

👍 3

biodranik commented

2022-06-09 05:48:54 +00:00

(Migrated from github.com)

If a speed limit is known, it should be shown :)

The data might be outdated, but this argument is also true for other parts of the map:

Closed roads, exits, new lanes, new crossings...

If someone notice wrong data, the person is at least able to correct it. (Or making a note on osm)

The problem is what to show when the speed limit is not known. An empty circle? A guess?

> If a speed limit is known, it should be shown :) > > The data might be outdated, but this argument is also true for other parts of the map: > > Closed roads, exits, new lanes, new crossings... > > If someone notice wrong data, the person is at least able to correct it. (Or making a note on osm) The problem is what to show when the speed limit is not known. An empty circle? A guess?

alensiljak commented

2022-06-09 05:51:00 +00:00

(Migrated from github.com)

The problem is what to show when the speed limit is not known. An empty circle? A guess?

Nothing?

> The problem is what to show when the speed limit is not known. An empty circle? A guess? Nothing?

👍 8

AntonM030481 commented

2022-06-09 11:49:23 +00:00

(Migrated from github.com)

Waze does it like this:

If speed limit is unknown - red circle is not shown.

Waze does it like this: ![image](https://user-images.githubusercontent.com/85622715/172839670-de557d93-2aa9-4476-8b8b-13361685aa50.jpeg) If speed limit is unknown - red circle is not shown.

👍 4

Talkless commented

2022-06-13 18:16:48 +00:00

(Migrated from github.com)

The problem is what to show when the speed limit is not known. An empty circle? A guess?

Maybe a transparent, gayish circle with "?" inside of it, but maybe better just don't show it.

> The problem is what to show when the speed limit is not known. An empty circle? A guess? Maybe a transparent, gayish circle with "?" inside of it, but maybe better just don't show it.

xephos1one commented

2022-09-21 16:33:39 +00:00

(Migrated from github.com)

Biggest question if, does map processor "knows" if road is urban (within place area) or rural using OSM data?

See https://wiki.openstreetmap.org/wiki/Key:zone:traffic and https://wiki.openstreetmap.org/wiki/Key:zone:maxspeed
Also look at relations like https://www.openstreetmap.org/relation/8131479 that define default values like access restrictions and maxspeed for a country.

How to implement it and what at all - I don't know.

And to add a last link: https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Maxspeed
It's a different version of the link that already got posted but it might still be helpful.

> Biggest question if, does map processor "knows" if road is urban (within place area) or rural using OSM data? See https://wiki.openstreetmap.org/wiki/Key:zone:traffic and https://wiki.openstreetmap.org/wiki/Key:zone:maxspeed Also look at relations like https://www.openstreetmap.org/relation/8131479 that define default values like access restrictions and maxspeed for a country. How to implement it and what at all - I don't know. And to add a last link: https://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Maxspeed It's a different version of the link that already got posted but it might still be helpful.

tomicdusan commented

2022-09-29 09:11:42 +00:00

(Migrated from github.com)

Yeah, this is really good to be displayed on screen if you use navi abroad (traveling, etc), pretty please? :)

pm4rcin commented

2022-10-30 11:24:23 +00:00

(Migrated from github.com)

@AntonM030481 what stops you from implementing it? Is it lack of free time or you still haven't decided on how it should look (style, size etc.)? If the latter here's my opinion with rationale:

I think that something similiar to Magic Earth's implementation would be best (maybe the size and/or style could be adjusted). Rationale:
When you want to check the speed limit you usually want to see it as fast as possible and focus on driving after seeing it. So it should be the shortest path for eyes. From my experience it's faster to focus on something that's on top because you generally have phone below line eyes and the path to look on right or right with slight down is fast and you don't have to move the eyes to the down corner of your phone (there's probably a paper on that but who cares :D).

@AntonM030481 what stops you from implementing it? Is it lack of free time or you still haven't decided on how it should look (style, size etc.)? If the latter here's my opinion with rationale: > I think that something similiar to Magic Earth's implementation would be best (maybe the size and/or style could be adjusted). Rationale: When you want to check the speed limit you usually want to see it as fast as possible and focus on driving after seeing it. So it should be the shortest path for eyes. From my experience it's faster to focus on something that's on top because you generally have phone below line eyes and the path to look on right or right with slight down is fast and you don't have to move the eyes to the down corner of your phone (there's probably a paper on that but who cares :D).

AntonM030481 commented

2022-11-04 13:19:18 +00:00

(Migrated from github.com)

@pm4rcin I had implemented basic text version for iOS several releases ago.
But I don't have enough experience yet to upgrade it to graphics and port to Android.

@pm4rcin I had implemented basic text version for iOS several releases ago. But I don't have enough experience yet to upgrade it to graphics and port to Android.

alensiljak commented

2022-11-04 14:57:43 +00:00

(Migrated from github.com)

Is there a way to use the text version, i.e. in a format [current speed/speed limit] or similar? The need for seeing this information is relatively high, irrespective of the presentation of it. A visual speed-limit sign would be nice but having the information on the dashboard is a priority. If the feature is waiting for nice graphics I'd be all up for having whatever is available right now, and let the work on the visuals happen later.

biodranik commented

2022-11-04 15:13:01 +00:00

(Migrated from github.com)

You can check organicmaps/organicmaps#2963 and implement the same for Android.

You can check https://git.omaps.dev/organicmaps/organicmaps/pulls/2963 and implement the same for Android.

👍 1

alensiljak commented

2022-11-04 19:51:16 +00:00

(Migrated from github.com)

You can check #2963 and implement the same for Android.

Not so simple, unfortunately. It seems that the ObjectC code for iPhone has direct access to the FollowingInfo class, which contains the speed limit information in m_speedLimitMps, whereas in Android it goes through JNI.

There is a problem when I'm, in Framework.cpp, method Java_app_organicmaps_Framework_nativeGetRouteFollowingInfo trying to pass info.m_speedLimitMps to the constructor for RoutingInfo. Always getting an Abort in native code so I don't see in the debugger what's the problem is. I've added the parameter to the RoutingInfo constructor. And there is already another double value, m_completionPercent, being used directly, without any type conversions.

If I set the speedLimit to be String and try to pass it as jni::ToJavaString(env, info.m_speedLimitMps), I get something like "no ToJavaString method available", even though it is used several times in the same instruction without problem. There's something with accessing the speed limit field. I have not worked with JNI and NDK directly before so I'm not sure how this works exactly.

> You can check #2963 and implement the same for Android. Not so simple, unfortunately. It seems that the ObjectC code for iPhone has direct access to the FollowingInfo class, which contains the speed limit information in m_speedLimitMps, whereas in Android it goes through JNI. There is a problem when I'm, in `Framework.cpp`, method `Java_app_organicmaps_Framework_nativeGetRouteFollowingInfo` trying to pass `info.m_speedLimitMps` to the constructor for `RoutingInfo`. Always getting an Abort in native code so I don't see in the debugger what's the problem is. I've added the parameter to the RoutingInfo constructor. And there is already another double value, `m_completionPercent`, being used directly, without any type conversions. If I set the speedLimit to be String and try to pass it as `jni::ToJavaString(env, info.m_speedLimitMps)`, I get something like "no ToJavaString method available", even though it is used several times in the same instruction without problem. There's something with accessing the speed limit field. I have not worked with JNI and NDK directly before so I'm not sure how this works exactly.

biodranik commented

2022-11-04 20:13:09 +00:00

(Migrated from github.com)

On Android, the reason for the error/abort is always printed in the log. You can also setup JNI debugger in Android Studio:
https://developer.android.com/studio/debug

On Android, the reason for the error/abort is always printed in the log. You can also setup JNI debugger in Android Studio: https://developer.android.com/studio/debug

alensiljak commented

2022-11-04 20:55:45 +00:00

(Migrated from github.com)

Thanks for the tip! I did not really understand the obscure syntax for GetConstructorID, it seems.

Continuing in #3817.

Thanks for the tip! I did not really understand the obscure syntax for GetConstructorID, it seems. Continuing in #3817.

❤️ 1

alensiljak commented

2022-11-05 13:27:30 +00:00

(Migrated from github.com)

Now that the #3817 is more-or-less in place, I see two suggestions:

Add a visual indicator for the speed limit. Eventually a setting that controls the displays of it (on/off).
Indicate overstepping the limit based on a calculation (including a threshold) and indicate with an audio and visual signal. The current speed limit overstepping acts a bit weird, I think.

These can be created and discussed as separate issues, I believe.

Now that the #3817 is more-or-less in place, I see two suggestions: 1. Add a visual indicator for the speed limit. Eventually a setting that controls the displays of it (on/off). 2. Indicate overstepping the limit based on a calculation (including a threshold) and indicate with an audio and visual signal. The current speed limit overstepping acts a bit weird, I think. These can be created and discussed as separate issues, I believe.

bitboy85 commented

2022-12-10 10:23:22 +00:00

(Migrated from github.com)

Additional suggestions:

show speed limit in non-navigation mode
unknown speed limits might be represented by a red circle with a question mark or even better: use the countrys default limit for this type of road because many roads in citys or towns are not tagged
note that some highways in germany (and maybe other countries) have no limit at all.

Additional suggestions: - show speed limit in non-navigation mode - unknown speed limits might be represented by a red circle with a question mark or even better: use the countrys default limit for this type of road because many roads in citys or towns are not tagged - note that some highways in germany (and maybe other countries) have no limit at all.

👍 1

Talkless commented

2022-12-10 11:50:47 +00:00

(Migrated from github.com)

unknown speed limits might be represented by a red circle with a question mark or even better: use the countrys default limit for this type of road because many roads in citys or towns are not tagged

Not sure if it's easy to distinguish if your'e in city or not?

Maybe show table of speed limits, like ones you see when crossing boarder, showing speed limits for cities, higways, motorways, etc..? Though that might be not that easy to specify too...?

> unknown speed limits might be represented by a red circle with a question mark or even better: use the countrys default limit for this type of road because many roads in citys or towns are not tagged Not sure if it's easy to distinguish if your'e in city or not? Maybe show table of speed limits, like ones you see when crossing boarder, showing speed limits for cities, higways, motorways, etc..? Though that might be not that easy to specify too...?

bitboy85 commented

2022-12-10 12:24:11 +00:00

(Migrated from github.com)

I think its perfectly doable. Osm usually uses administrative bounderies for countries, states, cities... so you need to do 3 things: 1. check if your position is within such an area. 2. During driving check if you cross an administrative boundary (to update rules). 3. Set the information in relation to the road type. For example highways "within" might have no limit.
The needed algo might be already there.

I think its perfectly doable. Osm usually uses administrative bounderies for countries, states, cities... so you need to do 3 things: 1. check if your position is within such an area. 2. During driving check if you cross an administrative boundary (to update rules). 3. Set the information in relation to the road type. For example highways "within" might have no limit. The needed algo might be already there.

pm4rcin commented

2022-12-10 13:49:48 +00:00

(Migrated from github.com)

I think its perfectly doable. Osm usually uses administrative bounderies for countries, states, cities... so you need to do 3 things: 1. check if your position is within such an area. 2. During driving check if you cross an administrative boundary (to update rules). 3. Set the information in relation to the road type. For example highways "within" might have no limit. The needed algo might be already there.

Default limit is not a good idea because it's not like city boundary is the same as the Urban speed limit boundary. In Poland we have green signs for city boundary but the white sings aka Urban area are separate so you can be in the city boundary but outside Urban area (it usually means there aren't homes and pedestrian ways nearby (simplified definition)). Better idea is to add speed limits to missing roads. To view them check Anton's link.

> I think its perfectly doable. Osm usually uses administrative bounderies for countries, states, cities... so you need to do 3 things: 1. check if your position is within such an area. 2. During driving check if you cross an administrative boundary (to update rules). 3. Set the information in relation to the road type. For example highways "within" might have no limit. The needed algo might be already there. Default limit is not a good idea because it's not like city boundary is the same as the Urban speed limit boundary. In Poland we have green signs for city boundary but the white sings aka Urban area are separate so you can be in the city boundary but outside Urban area (it usually means there aren't homes and pedestrian ways nearby (simplified definition)). Better idea is to add speed limits to missing roads. To view them check [Anton's link](https://git.omaps.dev/organicmaps/organicmaps/issues/952#issuecomment-1118227251).

👍 2

Talkless commented

2022-12-10 14:12:48 +00:00

(Migrated from github.com)

In Poland we have green signs for city boundary but the white sings aka Urban area are separate

Good point. In Lithuania, blue signs means there's no city limit while crossing urban area, white signs means you go at 50.

> In Poland we have green signs for city boundary but the white sings aka Urban area are separate Good point. In Lithuania, blue signs means there's no city limit while crossing urban area, white signs means you go at 50.

Rows
Columns

[android][ios][carplay][android-auto] Show speed limit sign on all platforms #952

Upvote & Fund