[qt][linux]: Add touchpad pinch zoom gesture #9679

pastk · 2024-11-17T15:30:05Z

Ferenc- commented

2024-11-17 15:30:05 +00:00

(Migrated from github.com)

No description provided.

pastk reviewed 2024-11-17 15:30:05 +00:00

RedAuburn reviewed 2024-11-17 15:30:05 +00:00

biodranik (Migrated from github.com) reviewed 2024-11-17 16:02:31 +00:00

qt/draw_widget.cpp

					
				@ -240,0 +230,4 @@

				         it != qtTouchEvent->points().cend() && i < 2; /* For now drape_frontend can only handle max 2 touches */

				         ++it, ++i)

				    {

				      df::Touch touch;

biodranik (Migrated from github.com) commented

2024-11-17 16:02:31 +00:00

Why is this code Linux-only? Are there any cross-platform Qt implementations we can reuse everywhere?

Ferenc- (Migrated from github.com) reviewed 2024-11-17 16:44:56 +00:00

qt/draw_widget.cpp

					
				@ -240,0 +230,4 @@

				         it != qtTouchEvent->points().cend() && i < 2; /* For now drape_frontend can only handle max 2 touches */

				         ++it, ++i)

				    {

				      df::Touch touch;

Ferenc- (Migrated from github.com) commented

2024-11-17 16:44:56 +00:00

Are you asking me why a bunch of things like the QNativeGestureEvent behaviour is documented to be platform dependent? Next to another bunch of behaviors, that are not documented but de facto platform dependent (meaning you can try it out yourself, plus the forums are full of posts confirming that).
If that is the case, then I am not the right person to answer that.

Are you asking me why a bunch of things like the [QNativeGestureEvent behaviour is documented to be platform dependent](https://doc.qt.io/qt-6/qnativegestureevent.html)? Next to another bunch of behaviors, that are not documented but de facto platform dependent (meaning you can try it out yourself, plus the forums are full of posts confirming that). If that is the case, then I am not the right person to answer that.

biodranik (Migrated from github.com) reviewed 2024-11-17 16:51:50 +00:00

qt/draw_widget.cpp

					
				@ -240,0 +230,4 @@

				         it != qtTouchEvent->points().cend() && i < 2; /* For now drape_frontend can only handle max 2 touches */

				         ++it, ++i)

				    {

				      df::Touch touch;

biodranik (Migrated from github.com) commented

2024-11-17 16:51:50 +00:00

Why can't this code be used on all platforms? E.g. on mac and linux at the same time? It's more about ifdef necessity.

vng (Migrated from github.com) reviewed 2024-11-17 17:55:39 +00:00

qt/draw_widget.cpp

					
				@ -240,0 +230,4 @@

				         it != qtTouchEvent->points().cend() && i < 2; /* For now drape_frontend can only handle max 2 touches */

				         ++it, ++i)

				    {

				      df::Touch touch;

vng (Migrated from github.com) commented

2024-11-17 17:55:39 +00:00

Context:
organicmaps/organicmaps#9616
organicmaps/organicmaps#9635

You can take my last branch (#9635) and make it work nicely in MacOS :)

Context: https://git.omaps.dev/organicmaps/organicmaps/pulls/9616 https://git.omaps.dev/organicmaps/organicmaps/pulls/9635 You can take my last branch (#9635) and make it work nicely in MacOS :)