mwm_diff_tool should be built by the generator_tool target #9719

Open
opened 2024-11-23 00:18:18 +00:00 by RedAuburn · 0 comments
Member

currently, running the map build instructions results in this:

📦[harry@Organic-Maps-Devbox python]$ python -m maps_generator --countries="UK_England_East Midlands" --skip="Coastline"
Loading configuration from /var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/var/etc/map_generator.ini
[2024-11-23 00:12:59,924] INFO env Start setup ...
[2024-11-23 00:12:59,924] INFO env Check for the osmctools binaries...
[2024-11-23 00:12:59,924] INFO env Found osmctools at /var/home/harry/Documents/Git/organicmaps/../osmctools/osmconvert, /var/home/harry/Documents/Git/organicmaps/../osmctools/osmupdate, /var/home/harry/Documents/Git/organicmaps/../osmctools/osmfilter
[2024-11-23 00:12:59,924] INFO env Check generator tool ...
[2024-11-23 00:12:59,924] INFO env Looking for generator tool in /var/home/harry/Documents/Git/organicmaps/../omim-build-release ...
[2024-11-23 00:12:59,924] INFO env Generator tool found - /var/home/harry/Documents/Git/organicmaps/../omim-build-release/generator_tool
[2024-11-23 00:12:59,924] INFO env Check mwm_diff_tool. Looking for it in /var/home/harry/Documents/Git/organicmaps/../omim-build-release ...
[2024-11-23 00:12:59,937] ERROR env Uncaught exception: mwm_diff_tool not found in /var/home/harry/Documents/Git/organicmaps/../omim-build-release
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/__main__.py", line 250, in <module>
    main()
  File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/__main__.py", line 232, in main
    env = Env(
          ^^^^
  File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/generator/env.py", line 423, in __init__
    self.diff_tool = self.setup_mwm_diff_tool()
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/generator/env.py", line 538, in setup_mwm_diff_tool
    mwm_diff_tool_path = find_executable(settings.BUILD_PATH, "mwm_diff_tool")
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/utils/file.py", line 57, in find_executable
    raise FileNotFoundError(f"{exe} not found in {path}")
FileNotFoundError: mwm_diff_tool not found in /var/home/harry/Documents/Git/organicmaps/../omim-build-release

The docs don't mention that you also have to run ./tools/unix/build_omim.sh -r mwm_diff_tool. This should instead also be built while building generator_tool.

currently, running the map build instructions results in this: ``` 📦[harry@Organic-Maps-Devbox python]$ python -m maps_generator --countries="UK_England_East Midlands" --skip="Coastline" Loading configuration from /var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/var/etc/map_generator.ini [2024-11-23 00:12:59,924] INFO env Start setup ... [2024-11-23 00:12:59,924] INFO env Check for the osmctools binaries... [2024-11-23 00:12:59,924] INFO env Found osmctools at /var/home/harry/Documents/Git/organicmaps/../osmctools/osmconvert, /var/home/harry/Documents/Git/organicmaps/../osmctools/osmupdate, /var/home/harry/Documents/Git/organicmaps/../osmctools/osmfilter [2024-11-23 00:12:59,924] INFO env Check generator tool ... [2024-11-23 00:12:59,924] INFO env Looking for generator tool in /var/home/harry/Documents/Git/organicmaps/../omim-build-release ... [2024-11-23 00:12:59,924] INFO env Generator tool found - /var/home/harry/Documents/Git/organicmaps/../omim-build-release/generator_tool [2024-11-23 00:12:59,924] INFO env Check mwm_diff_tool. Looking for it in /var/home/harry/Documents/Git/organicmaps/../omim-build-release ... [2024-11-23 00:12:59,937] ERROR env Uncaught exception: mwm_diff_tool not found in /var/home/harry/Documents/Git/organicmaps/../omim-build-release Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/__main__.py", line 250, in <module> main() File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/__main__.py", line 232, in main env = Env( ^^^^ File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/generator/env.py", line 423, in __init__ self.diff_tool = self.setup_mwm_diff_tool() ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/generator/env.py", line 538, in setup_mwm_diff_tool mwm_diff_tool_path = find_executable(settings.BUILD_PATH, "mwm_diff_tool") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/var/home/harry/Documents/Git/organicmaps/tools/python/maps_generator/utils/file.py", line 57, in find_executable raise FileNotFoundError(f"{exe} not found in {path}") FileNotFoundError: mwm_diff_tool not found in /var/home/harry/Documents/Git/organicmaps/../omim-build-release ``` The docs don't mention that you also have to run `./tools/unix/build_omim.sh -r mwm_diff_tool`. This should instead also be built while building `generator_tool`.
This repo is archived. You cannot comment on issues.
No labels
Accessibility
Accessibility
Address
Address
Android
Android
Android Auto
Android Auto
Android Automotive (AAOS)
Android Automotive (AAOS)
API
API
AppGallery
AppGallery
AppStore
AppStore
Battery and Performance
Battery and Performance
Blocker
Blocker
Bookmarks and Tracks
Bookmarks and Tracks
Borders
Borders
Bug
Bug
Build
Build
CarPlay
CarPlay
Classificator
Classificator
Community
Community
Core
Core
CrashReports
CrashReports
Cycling
Cycling
Desktop
Desktop
DevEx
DevEx
DevOps
DevOps
dev_sandbox
dev_sandbox
Directions
Directions
Documentation
Documentation
Downloader
Downloader
Drape
Drape
Driving
Driving
Duplicate
Duplicate
Editor
Editor
Elevation
Elevation
Enhancement
Enhancement
Epic
Epic
External Map Datasets
External Map Datasets
F-Droid
F-Droid
Fonts
Fonts
Frequently User Reported
Frequently User Reported
Fund
Fund
Generator
Generator
Good first issue
Good first issue
Google Play
Google Play
GPS
GPS
GSoC
GSoC
iCloud
iCloud
Icons
Icons
iOS
iOS
Legal
Legal
Linux Desktop
Linux Desktop
Linux packaging
Linux packaging
Linux Phone
Linux Phone
Mac OS
Mac OS
Map Data
Map Data
Metro
Metro
Navigation
Navigation
Need Feedback
Need Feedback
Night Mode
Night Mode
NLnet 2024-06-281
NLnet 2024-06-281
No Feature Parity
No Feature Parity
Opening Hours
Opening Hours
Outdoors
Outdoors
POI Info
POI Info
Privacy
Privacy
Public Transport
Public Transport
Raw Idea
Raw Idea
Refactoring
Refactoring
Regional
Regional
Regression
Regression
Releases
Releases
RoboTest
RoboTest
Route Planning
Route Planning
Routing
Routing
Ruler
Ruler
Search
Search
Security
Security
Styles
Styles
Tests
Tests
Track Recording
Track Recording
Translations
Translations
TTS
TTS
UI
UI
UX
UX
Walk Navigation
Walk Navigation
Watches
Watches
Web
Web
Wikipedia
Wikipedia
Windows
Windows
Won't fix
Won't fix
World Map
World Map
No milestone
No project
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: organicmaps/organicmaps-tmp#9719
No description provided.