From d1b918c2634f970caa3082a6a6d7cdeb8e5791a6 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 25 Nov 2024 17:20:57 +0000
Subject: [PATCH 01/49] [android] rework Light, Dark, and System modes

(rebased from PR, some additional minor cleanup/fixes)
TODO: debug commands like ?light don't work.
Signed-off-by: Harry Bond <me@hbond.xyz>
Signed-off-by: Sebastiao Sousa <sebastiao.sousa@tecnico.ulisboa.pt>
Co-authored-by: Francisco Nael Salgado <francisco.nael.salgado@tecnico.ulisboa.pt>
---
 android/app/src/main/AndroidManifest.xml      |  28 +++--
 .../java/app/organicmaps/SplashActivity.java  |  10 ++
 .../base/BaseMwmFragmentActivity.java         |  10 ++
 .../car/screens/settings/SettingsScreen.java  |   2 +-
 .../car/screens/settings/ThemeScreen.java     |   4 +-
 .../app/organicmaps/car/util/ThemeUtils.java  |  18 +--
 .../settings/SettingsPrefsFragment.java       |   7 +-
 .../java/app/organicmaps/util/Config.java     |   8 +-
 .../app/organicmaps/util/ThemeSwitcher.java   | 116 +++++++++---------
 .../java/app/organicmaps/util/ThemeUtils.java |  32 ++++-
 .../src/main/res/values/donottranslate.xml    |   1 +
 .../app/src/main/res/values/string-arrays.xml |  16 +--
 android/app/src/main/res/xml/prefs_main.xml   |  52 ++++----
 data/strings/strings.txt                      |  61 +++++++--
 14 files changed, 229 insertions(+), 136 deletions(-)

diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
index 86bdadc494..0a7e8fb475 100644
--- a/android/app/src/main/AndroidManifest.xml
+++ b/android/app/src/main/AndroidManifest.xml
@@ -343,10 +343,13 @@
       </intent-filter>
 
     </activity>
+    <activity
+        android:name="app.organicmaps.base.BaseMwmFragmentActivity"
+        android:configChanges="uiMode" />
 
     <activity
         android:name="app.organicmaps.DownloadResourcesLegacyActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize" />
         android:screenOrientation="fullUser"/>
 
     <activity-alias
@@ -374,7 +377,7 @@
 
     <activity
         android:name="app.organicmaps.downloader.DownloaderActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/download_maps"
         android:parentActivityName="app.organicmaps.MwmActivity"
@@ -382,7 +385,7 @@
 
     <activity
         android:name="app.organicmaps.search.SearchActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/search_map"
         android:parentActivityName="app.organicmaps.MwmActivity"
@@ -390,7 +393,7 @@
 
     <activity
         android:name="app.organicmaps.settings.SettingsActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/settings"
         android:parentActivityName="app.organicmaps.MwmActivity" />
@@ -399,6 +402,7 @@
         android:name="app.organicmaps.help.HelpActivity"
         android:label="@string/about_menu_title"
         android:parentActivityName="app.organicmaps.MwmActivity"
+        android:configChanges="uiMode"
         android:exported="false">
       <intent-filter>
         <action android:name="app.organicmaps.help.HelpActivity" />
@@ -408,7 +412,7 @@
 
     <activity
         android:name="app.organicmaps.bookmarks.BookmarkCategoriesActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/bookmarks_and_tracks"
         android:parentActivityName="app.organicmaps.MwmActivity"
@@ -416,7 +420,7 @@
 
     <activity
         android:name="app.organicmaps.bookmarks.BookmarkListActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/bookmarks"
         android:parentActivityName="app.organicmaps.bookmarks.BookmarkCategoriesActivity"
@@ -424,7 +428,7 @@
 
     <activity
         android:name="app.organicmaps.editor.EditorActivity"
-        android:configChanges="orientation|screenLayout|screenSize"
+        android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/edit_place"
         android:parentActivityName="app.organicmaps.MwmActivity"
@@ -432,33 +436,41 @@
 
     <activity
         android:name="app.organicmaps.editor.ProfileActivity"
+        android:configChanges="uiMode"
         android:parentActivityName="app.organicmaps.settings.SettingsActivity" />
 
     <activity
         android:name="app.organicmaps.editor.FeatureCategoryActivity"
         android:parentActivityName="app.organicmaps.MwmActivity"
+        android:configChanges="uiMode"
         android:windowSoftInputMode="adjustResize" />
 
     <activity
         android:name="app.organicmaps.editor.ReportActivity"
+        android:configChanges="uiMode"
         android:parentActivityName="app.organicmaps.MwmActivity" />
 
     <activity
         android:name="app.organicmaps.editor.OsmLoginActivity"
+        android:configChanges="uiMode"
         android:parentActivityName="app.organicmaps.MwmActivity" />
 
     <activity
       android:name="app.organicmaps.bookmarks.BookmarkCategorySettingsActivity"
       android:label="@string/edit"
+      android:configChanges="uiMode"
       android:windowSoftInputMode="stateVisible"/>
     <activity
       android:name="app.organicmaps.widget.placepage.PlaceDescriptionActivity"
+      android:configChanges="uiMode"
       android:label="@string/place_description_title"/>
     <activity
       android:name="app.organicmaps.settings.DrivingOptionsActivity"
+      android:configChanges="uiMode"
       android:label="@string/driving_options_title"/>
     <activity
-        android:name="app.organicmaps.MapPlaceholderActivity"/>
+      android:name="app.organicmaps.MapPlaceholderActivity"
+      android:configChanges="uiMode" />
     <activity
         android:name="app.organicmaps.car.screens.permissions.RequestPermissionsActivity"/>
     <service
diff --git a/android/app/src/main/java/app/organicmaps/SplashActivity.java b/android/app/src/main/java/app/organicmaps/SplashActivity.java
index 37c7cd976b..27f1c635ba 100644
--- a/android/app/src/main/java/app/organicmaps/SplashActivity.java
+++ b/android/app/src/main/java/app/organicmaps/SplashActivity.java
@@ -7,6 +7,7 @@ import static app.organicmaps.api.Const.EXTRA_PICK_POINT;
 import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
+import android.content.res.Configuration;
 import android.os.Bundle;
 import android.util.Log;
 
@@ -25,6 +26,7 @@ import app.organicmaps.location.LocationHelper;
 import app.organicmaps.util.Config;
 import app.organicmaps.util.LocationUtils;
 import app.organicmaps.util.SharingUtils;
+import app.organicmaps.util.ThemeSwitcher;
 import app.organicmaps.util.ThemeUtils;
 import app.organicmaps.util.Utils;
 import app.organicmaps.util.concurrency.UiThread;
@@ -121,6 +123,14 @@ public class SplashActivity extends AppCompatActivity
     mApiRequest = null;
   }
 
+  @Override
+  public void onConfigurationChanged(@NonNull Configuration newConfig)
+  {
+    super.onConfigurationChanged(newConfig);
+    ThemeSwitcher.INSTANCE.restart(false);
+    UiThread.runLater(this::recreate);
+  }
+  
   private void showFatalErrorDialog(@StringRes int titleId, @StringRes int messageId, Exception error)
   {
     mCanceled = true;
diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
index 16cc5397c1..b5a1f31bd0 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
@@ -4,6 +4,7 @@ import android.content.ComponentName;
 import android.content.Context;
 import android.content.Intent;
 import android.graphics.Color;
+import android.content.res.Configuration;
 import android.media.AudioManager;
 import android.os.Bundle;
 import android.view.MenuItem;
@@ -25,6 +26,7 @@ import app.organicmaps.R;
 import app.organicmaps.SplashActivity;
 import app.organicmaps.util.Config;
 import app.organicmaps.util.RtlUtils;
+import app.organicmaps.util.ThemeSwitcher;
 import app.organicmaps.util.ThemeUtils;
 import app.organicmaps.util.concurrency.UiThread;
 import app.organicmaps.util.log.Logger;
@@ -132,6 +134,14 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
     }
   }
 
+  @Override
+  public void onConfigurationChanged(@NonNull Configuration newConfig)
+  {
+    super.onConfigurationChanged(newConfig);
+    ThemeSwitcher.INSTANCE.restart(false);
+    UiThread.runLater(this::recreate);
+  }
+
   @Override
   public boolean onOptionsItemSelected(MenuItem item)
   {
diff --git a/android/app/src/main/java/app/organicmaps/car/screens/settings/SettingsScreen.java b/android/app/src/main/java/app/organicmaps/car/screens/settings/SettingsScreen.java
index 3c493b2ac6..5bbc6d3f22 100644
--- a/android/app/src/main/java/app/organicmaps/car/screens/settings/SettingsScreen.java
+++ b/android/app/src/main/java/app/organicmaps/car/screens/settings/SettingsScreen.java
@@ -75,7 +75,7 @@ public class SettingsScreen extends BaseMapScreen
   private Item createThemeItem()
   {
     final Row.Builder builder = new Row.Builder();
-    builder.setTitle(getCarContext().getString(R.string.pref_map_style_title));
+    builder.setTitle(getCarContext().getString(R.string.pref_appearance_title));
     builder.addText(getCarContext().getString(ThemeUtils.getThemeMode(getCarContext()).getTitleId()));
     builder.setOnClickListener(() -> getScreenManager().push(new ThemeScreen(getCarContext(), getSurfaceRenderer())));
     builder.setBrowsable(true);
diff --git a/android/app/src/main/java/app/organicmaps/car/screens/settings/ThemeScreen.java b/android/app/src/main/java/app/organicmaps/car/screens/settings/ThemeScreen.java
index 530a3259b5..f2a83959e8 100644
--- a/android/app/src/main/java/app/organicmaps/car/screens/settings/ThemeScreen.java
+++ b/android/app/src/main/java/app/organicmaps/car/screens/settings/ThemeScreen.java
@@ -47,7 +47,7 @@ public class ThemeScreen extends BaseMapScreen
   {
     final Header.Builder builder = new Header.Builder();
     builder.setStartHeaderAction(Action.BACK);
-    builder.setTitle(getCarContext().getString(R.string.pref_map_style_title));
+    builder.setTitle(getCarContext().getString(R.string.pref_appearance_title));
     return builder.build();
   }
 
@@ -56,7 +56,7 @@ public class ThemeScreen extends BaseMapScreen
   {
     final ItemList.Builder builder = new ItemList.Builder();
     final ThemeUtils.ThemeMode currentThemeMode = ThemeUtils.getThemeMode(getCarContext());
-    builder.addItem(createRadioButton(ThemeUtils.ThemeMode.AUTO, currentThemeMode));
+    builder.addItem(createRadioButton(ThemeUtils.ThemeMode.FOLLOW_SYSTEM, currentThemeMode));
     builder.addItem(createRadioButton(ThemeUtils.ThemeMode.NIGHT, currentThemeMode));
     builder.addItem(createRadioButton(ThemeUtils.ThemeMode.LIGHT, currentThemeMode));
     return new ListTemplate.Builder().setHeader(createHeader()).setSingleList(builder.build()).build();
diff --git a/android/app/src/main/java/app/organicmaps/car/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/car/util/ThemeUtils.java
index cb6806cfd5..f38dc77add 100644
--- a/android/app/src/main/java/app/organicmaps/car/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/car/util/ThemeUtils.java
@@ -17,9 +17,9 @@ public final class ThemeUtils
 {
   public enum ThemeMode
   {
-    AUTO(R.string.auto, R.string.theme_auto),
-    LIGHT(R.string.off, R.string.theme_default),
-    NIGHT(R.string.on, R.string.theme_night);
+    LIGHT(R.string.light, R.string.theme_default),
+    NIGHT(R.string.dark, R.string.theme_night),
+    FOLLOW_SYSTEM(R.string.follow_system, R.string.theme_follow_system);
 
     ThemeMode(@StringRes int titleId, @StringRes int prefsKeyId)
     {
@@ -58,7 +58,7 @@ public final class ThemeUtils
   @UiThread
   public static void update(@NonNull CarContext context, @NonNull ThemeMode oldThemeMode)
   {
-    final ThemeMode newThemeMode = oldThemeMode == ThemeMode.AUTO ? (context.isDarkMode() ? ThemeMode.NIGHT : ThemeMode.LIGHT) : oldThemeMode;
+    final ThemeMode newThemeMode = oldThemeMode == ThemeMode.FOLLOW_SYSTEM ? (context.isDarkMode() ? ThemeMode.NIGHT : ThemeMode.LIGHT) : oldThemeMode;
 
     @Framework.MapStyle
     int newMapStyle;
@@ -74,7 +74,7 @@ public final class ThemeUtils
   public static boolean isNightMode(@NonNull CarContext context)
   {
     final ThemeMode themeMode = getThemeMode(context);
-    return themeMode == ThemeMode.NIGHT || (themeMode == ThemeMode.AUTO && context.isDarkMode());
+    return themeMode == ThemeMode.NIGHT || (themeMode == ThemeMode.FOLLOW_SYSTEM && context.isDarkMode());
   }
 
   @SuppressLint("ApplySharedPref")
@@ -88,13 +88,13 @@ public final class ThemeUtils
   @NonNull
   public static ThemeMode getThemeMode(@NonNull CarContext context)
   {
-    final String autoTheme = context.getString(R.string.theme_auto);
+    final String followSystemTheme = context.getString(R.string.theme_follow_system);
     final String lightTheme = context.getString(R.string.theme_default);
     final String nightTheme = context.getString(R.string.theme_night);
-    final String themeMode = getSharedPreferences(context).getString(THEME_KEY, autoTheme);
+    final String themeMode = getSharedPreferences(context).getString(THEME_KEY, followSystemTheme);
 
-    if (themeMode.equals(autoTheme))
-      return ThemeMode.AUTO;
+    if (themeMode.equals(followSystemTheme))
+      return ThemeMode.FOLLOW_SYSTEM;
     else if (themeMode.equals(lightTheme))
       return ThemeMode.LIGHT;
     else if (themeMode.equals(nightTheme))
diff --git a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
index b7d8e35f69..2597c3fd4c 100644
--- a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
+++ b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
@@ -507,10 +507,9 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La
 
   enum ThemeMode
   {
+    FOLLOW_SYSTEM(R.string.theme_follow_system),
     DEFAULT(R.string.theme_default),
-    NIGHT(R.string.theme_night),
-    AUTO(R.string.theme_auto),
-    NAV_AUTO(R.string.theme_nav_auto);
+    NIGHT(R.string.theme_night);
 
     private final int mModeStringId;
 
@@ -527,7 +526,7 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La
         if (context.getResources().getString(each.mModeStringId).equals(src))
           return each;
       }
-      return AUTO;
+      return FOLLOW_SYSTEM;
     }
   }
 
diff --git a/android/app/src/main/java/app/organicmaps/util/Config.java b/android/app/src/main/java/app/organicmaps/util/Config.java
index 2f9cdbf882..55670340d9 100644
--- a/android/app/src/main/java/app/organicmaps/util/Config.java
+++ b/android/app/src/main/java/app/organicmaps/util/Config.java
@@ -275,12 +275,12 @@ public final class Config
   @NonNull
   public static String getUiThemeSettings(@NonNull Context context)
   {
-    String autoTheme = MwmApplication.from(context).getString(R.string.theme_auto);
-    String res = getString(KEY_MISC_UI_THEME_SETTINGS, autoTheme);
-    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isAutoTheme(context, res) || ThemeUtils.isNavAutoTheme(context, res))
+    String followSystemTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
+    String res = getString(KEY_MISC_UI_THEME_SETTINGS, followSystemTheme);
+    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isFollowSystemTheme(context, res))
       return res;
 
-    return autoTheme;
+    return followSystemTheme;
   }
 
   public static boolean setUiThemeSettings(@NonNull Context context, String theme)
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index d70055b0f9..b1bdc24177 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -1,21 +1,15 @@
 package app.organicmaps.util;
 
 import android.app.Activity;
-import android.app.UiModeManager;
 import android.content.Context;
-import android.location.Location;
-import android.os.Build;
 
 import androidx.annotation.NonNull;
 import androidx.appcompat.app.AppCompatDelegate;
 import app.organicmaps.Framework;
 import app.organicmaps.MwmApplication;
-import app.organicmaps.R;
 import app.organicmaps.display.DisplayManager;
 import app.organicmaps.downloader.DownloaderStatusIcon;
-import app.organicmaps.location.LocationHelper;
 import app.organicmaps.routing.RoutingController;
-import app.organicmaps.util.concurrency.UiThread;
 
 public enum ThemeSwitcher
 {
@@ -24,37 +18,37 @@ public enum ThemeSwitcher
   private static final long CHECK_INTERVAL_MS = 30 * 60 * 1000;
   private static boolean mRendererActive = false;
 
-  private final Runnable mAutoThemeChecker = new Runnable()
-  {
-    @Override
-    public void run()
-    {
-      String nightTheme = MwmApplication.from(mContext).getString(R.string.theme_night);
-      String defaultTheme = MwmApplication.from(mContext).getString(R.string.theme_default);
-      String theme = defaultTheme;
-      Location last = LocationHelper.from(mContext).getSavedLocation();
-
-      boolean navAuto = RoutingController.get().isNavigating() && ThemeUtils.isNavAutoTheme(mContext);
-
-      if (navAuto || ThemeUtils.isAutoTheme(mContext))
-      {
-        if (last == null)
-          theme = Config.getCurrentUiTheme(mContext);
-        else
-        {
-          long currentTime = System.currentTimeMillis() / 1000;
-          boolean day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
-          theme = (day ? defaultTheme : nightTheme);
-        }
-      }
-
-      setThemeAndMapStyle(theme);
-      UiThread.cancelDelayedTasks(mAutoThemeChecker);
-
-      if (navAuto || ThemeUtils.isAutoTheme(mContext))
-        UiThread.runLater(mAutoThemeChecker, CHECK_INTERVAL_MS);
-    }
-  };
+//  private final Runnable mAutoThemeChecker = new Runnable()
+//  {
+//    @Override
+//    public void run()
+//    {
+//      String nightTheme = MwmApplication.from(mContext).getString(R.string.theme_night);
+//      String defaultTheme = MwmApplication.from(mContext).getString(R.string.theme_default);
+//      String theme = defaultTheme;
+//      Location last = LocationHelper.from(mContext).getSavedLocation();
+//
+//      boolean navAuto = RoutingController.get().isNavigating() && ThemeUtils.isNavAutoTheme(mContext);
+//
+//      if (navAuto || ThemeUtils.isAutoTheme(mContext))
+//      {
+//        if (last == null)
+//          theme = Config.getCurrentUiTheme(mContext);
+//        else
+//        {
+//          long currentTime = System.currentTimeMillis() / 1000;
+//          boolean day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
+//          theme = (day ? defaultTheme : nightTheme);
+//        }
+//      }
+//
+//      setThemeAndMapStyle(theme);
+//      UiThread.cancelDelayedTasks(mAutoThemeChecker);
+//
+//      if (navAuto || ThemeUtils.isAutoTheme(mContext))
+//        UiThread.runLater(mAutoThemeChecker, CHECK_INTERVAL_MS);
+//    }
+//  };
 
   @SuppressWarnings("NotNullFieldNotInitialized")
   @NonNull
@@ -79,32 +73,34 @@ public enum ThemeSwitcher
   {
     mRendererActive = isRendererActive;
     String theme = Config.getUiThemeSettings(mContext);
-    if (ThemeUtils.isAutoTheme(mContext, theme) || ThemeUtils.isNavAutoTheme(mContext, theme))
-    {
-      mAutoThemeChecker.run();
-      return;
-    }
+//    if (ThemeUtils.isAutoTheme(mContext, theme) || ThemeUtils.isNavAutoTheme(mContext, theme))
+//    {
+//      mAutoThemeChecker.run();
+//      return;
+//    }
+    setAndroidTheme(theme);
 
-    UiThread.cancelDelayedTasks(mAutoThemeChecker);
-    setThemeAndMapStyle(theme);
+    final String themeToApply = ThemeUtils.getAndroidTheme(mContext);
+    final int style = getStyle(themeToApply);
+    setThemeAndMapStyle(themeToApply, style);
   }
 
-  private void setThemeAndMapStyle(@NonNull String theme)
+  private void setAndroidTheme(@NonNull String theme)
   {
-    UiModeManager uiModeManager = (UiModeManager) mContext.getSystemService(Context.UI_MODE_SERVICE);
-    String oldTheme = Config.getCurrentUiTheme(mContext);
-    @Framework.MapStyle
-    int oldStyle = Framework.nativeGetMapStyle();
+    if (ThemeUtils.isFollowSystemTheme(mContext, theme))
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
+    else if (ThemeUtils.isNightTheme(mContext, theme))
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
+    else if (ThemeUtils.isDefaultTheme(mContext, theme))
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
+  }
 
+  private int getStyle(@NonNull String theme)
+  {
     @Framework.MapStyle
     int style;
     if (ThemeUtils.isNightTheme(mContext, theme))
     {
-      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S)
-        uiModeManager.setApplicationNightMode(UiModeManager.MODE_NIGHT_YES);
-      else
-        AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
-
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_DARK;
       else if (Framework.nativeIsOutdoorsLayerEnabled())
@@ -114,11 +110,6 @@ public enum ThemeSwitcher
     }
     else
     {
-      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S)
-        uiModeManager.setApplicationNightMode(UiModeManager.MODE_NIGHT_NO);
-      else
-        AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
-
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_CLEAR;
       else if (Framework.nativeIsOutdoorsLayerEnabled())
@@ -127,6 +118,13 @@ public enum ThemeSwitcher
         style = Framework.MAP_STYLE_CLEAR;
     }
 
+    return style;
+  }
+
+  private void setThemeAndMapStyle(@NonNull String theme, @Framework.MapStyle int style)
+  {
+    String oldTheme = Config.getCurrentUiTheme(mContext);
+
     if (!theme.equals(oldTheme))
     {
       Config.setCurrentUiTheme(mContext, theme);
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index c121c8d313..b3613e7cab 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -1,6 +1,7 @@
 package app.organicmaps.util;
 
 import android.content.Context;
+import android.content.res.Configuration;
 import android.content.res.TypedArray;
 import android.util.TypedValue;
 
@@ -8,7 +9,7 @@ import androidx.annotation.AttrRes;
 import androidx.annotation.ColorInt;
 import androidx.annotation.NonNull;
 import androidx.annotation.StyleRes;
-
+import androidx.appcompat.app.AppCompatDelegate;
 import app.organicmaps.R;
 
 public final class ThemeUtils
@@ -45,6 +46,25 @@ public final class ThemeUtils
     return VALUE_BUFFER.resourceId;
   }
 
+  public static String getAndroidTheme(@NonNull Context context)
+  {
+    String nightTheme = context.getString(R.string.theme_night);
+    String defaultTheme = context.getString(R.string.theme_default);
+
+    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_YES)
+      return nightTheme;
+
+    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_NO)
+      return defaultTheme;
+
+    int nightModeFlags = context.getResources()
+                                .getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
+    if (nightModeFlags == Configuration.UI_MODE_NIGHT_YES)
+      return nightTheme;
+    else
+      return defaultTheme;
+  }
+
   public static boolean isDefaultTheme(@NonNull Context context)
   {
     return isDefaultTheme(context, Config.getCurrentUiTheme(context));
@@ -67,15 +87,15 @@ public final class ThemeUtils
     return nightTheme.equals(theme);
   }
 
-  public static boolean isAutoTheme(@NonNull Context context)
+  public static boolean isFollowSystemTheme(@NonNull Context context)
   {
-    return isAutoTheme(context, Config.getUiThemeSettings(context));
+    return isFollowSystemTheme(context, Config.getCurrentUiTheme(context));
   }
 
-  public static boolean isAutoTheme(@NonNull Context context, String theme)
+  public static boolean isFollowSystemTheme(@NonNull Context context, String theme)
   {
-    String autoTheme = context.getString(R.string.theme_auto);
-    return autoTheme.equals(theme);
+    String followSystemTheme = context.getString(R.string.theme_follow_system);
+    return followSystemTheme.equals(theme);
   }
 
   public static boolean isNavAutoTheme(@NonNull Context context)
diff --git a/android/app/src/main/res/values/donottranslate.xml b/android/app/src/main/res/values/donottranslate.xml
index 976c1ecd7c..79c9be7f89 100644
--- a/android/app/src/main/res/values/donottranslate.xml
+++ b/android/app/src/main/res/values/donottranslate.xml
@@ -53,6 +53,7 @@
   <string name="theme_night" translatable="false">night</string>
   <string name="theme_auto" translatable="false">auto</string>
   <string name="theme_nav_auto" translatable="false">nav-auto</string>
+  <string name="theme_follow_system" translatable="false">follow-system</string>
 
   <!-- Tags -->
   <string name="tag_menu_collapse" translatable="false">collapse</string>
diff --git a/android/app/src/main/res/values/string-arrays.xml b/android/app/src/main/res/values/string-arrays.xml
index ee0e6210fd..a5e7c4fd81 100644
--- a/android/app/src/main/res/values/string-arrays.xml
+++ b/android/app/src/main/res/values/string-arrays.xml
@@ -23,20 +23,16 @@
     <item>0</item>
     <item>1</item>
   </string-array>
-
-  <string-array name="map_style">
-    <item>@string/off</item>
-    <item>@string/on</item>
-    <item>@string/auto</item>
-    <item>@string/nav_auto</item>
+  <string-array name="appearance">
+    <item>@string/follow_system</item>
+    <item>@string/light</item>
+    <item>@string/dark</item>
   </string-array>
-
-  <string-array name="map_style_values"
+  <string-array name="appearance_values"
                 translatable="false">
+    <item>@string/theme_follow_system</item>
     <item>@string/theme_default</item>
     <item>@string/theme_night</item>
-    <item>@string/theme_auto</item>
-    <item>@string/theme_nav_auto</item>
   </string-array>
 
   <string-array name="speed_cameras">
diff --git a/android/app/src/main/res/xml/prefs_main.xml b/android/app/src/main/res/xml/prefs_main.xml
index e162e025d6..6f278ca16c 100644
--- a/android/app/src/main/res/xml/prefs_main.xml
+++ b/android/app/src/main/res/xml/prefs_main.xml
@@ -14,6 +14,13 @@
     android:key="@string/pref_settings_general"
     android:title="@string/prefs_group_general"
     android:order="2">
+    <ListPreference
+      android:entries="@array/appearance"
+      android:entryValues="@array/appearance_values"
+      android:key="@string/pref_map_style"
+      android:title="@string/pref_appearance_title"
+      app:singleLineTitle="false"
+      android:order="1" />
     <ListPreference
       android:key="@string/pref_munits"
       android:title="@string/measurement_units"
@@ -21,23 +28,23 @@
       android:summary="@string/measurement_units_summary"
       android:entries="@array/measument_units"
       android:entryValues="@array/measument_units_values"
-      android:order="1"/>
+      android:order="2"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_show_zoom_buttons"
       android:title="@string/pref_zoom_title"
       app:singleLineTitle="false"
       android:summary="@string/pref_zoom_summary"
-      android:order="2"/>
+      android:order="3"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_3d_buildings"
       android:title="@string/pref_map_3d_buildings_title"
       app:singleLineTitle="false"
-      android:order="3"/>
+      android:order="4"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_autodownload"
       android:title="@string/autodownload"
       app:singleLineTitle="false"
-      android:order="4"/>
+      android:order="5"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_large_fonts_size"
       android:title="@string/big_font"
@@ -62,13 +69,13 @@
       app:singleLineTitle="false"
       android:summary="@string/enable_logging_warning_message"
       android:defaultValue="false"
-      android:order="12"/>
+      android:order="9"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_emulate_bad_external_storage"
       android:title="@string/setting_emulate_bad_storage"
       app:singleLineTitle="false"
       android:defaultValue="false"
-      android:order="13"/>
+      android:order="10"/>
     <ListPreference
       android:key="@string/pref_use_mobile_data"
       android:title="@string/mobile_data"
@@ -76,7 +83,7 @@
       android:summary="@string/mobile_data_description"
       android:entries="@array/mobile_data_options"
       android:entryValues="@array/mobile_data_options_values"
-      android:order="14"/>
+      android:order="11"/>
     <ListPreference
       android:key="@string/pref_power_management"
       android:title="@string/power_managment_title"
@@ -84,60 +91,53 @@
       android:summary="@string/power_managment_description"
       android:entries="@array/power_management_scheme"
       android:entryValues="@array/power_management_scheme_values"
-      android:order="15"/>
+      android:order="12"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_keep_screen_on"
       android:title="@string/enable_keep_screen_on"
       app:singleLineTitle="false"
       android:summary="@string/enable_keep_screen_on_description"
       android:defaultValue="false"
-      android:order="16"/>
+      android:order="13"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_show_on_lock_screen"
       android:title="@string/enable_show_on_lock_screen"
       app:singleLineTitle="false"
       android:summary="@string/enable_show_on_lock_screen_description"
       android:defaultValue="true"
-      android:order="17"/>
+      android:order="14"/>
     <Preference
-        android:key="@string/pref_map_locale"
-        android:title="@string/change_map_locale"
-        app:singleLineTitle="false"
-        android:persistent="false"
-        android:order="18"/>
+      android:key="@string/pref_map_locale"
+      android:title="@string/change_map_locale"
+      app:singleLineTitle="false"
+      android:persistent="false"
+      android:order="15"/>
   </androidx.preference.PreferenceCategory>
 
   <androidx.preference.PreferenceCategory
     android:key="@string/pref_navigation"
     android:title="@string/prefs_group_route"
     android:order="3">
-    <ListPreference
-      android:key="@string/pref_map_style"
-      android:title="@string/pref_map_style_title"
-      app:singleLineTitle="false"
-      android:entries="@array/map_style"
-      android:entryValues="@array/map_style_values"
-      android:order="1"/>
     <SwitchPreferenceCompat
       android:key="@string/pref_3d"
       android:title="@string/pref_map_3d_title"
       app:singleLineTitle="false"
-      android:order="2"/>
+      android:order="1" />
     <SwitchPreferenceCompat
       android:key="@string/pref_auto_zoom"
       android:title="@string/pref_map_auto_zoom"
       app:singleLineTitle="false"
-      android:order="3"/>
+      android:order="2" />
     <Preference
       android:key="@string/pref_tts_screen"
       android:title="@string/pref_tts_enable_title"
       app:singleLineTitle="false"
       android:persistent="false"
-      android:order="4">
+      android:order="3">
     </Preference>
     <PreferenceScreen
       android:key="@string/prefs_routing"
-      android:order="5"
+      android:order="4"
       android:title="@string/driving_options_title">
       <intent
         android:targetClass="app.organicmaps.settings.DrivingOptionsActivity"
diff --git a/data/strings/strings.txt b/data/strings/strings.txt
index ab0d4f09a8..e73f62b54c 100644
--- a/data/strings/strings.txt
+++ b/data/strings/strings.txt
@@ -5715,7 +5715,7 @@
 
   [pref_appearance_title]
     comment = Settings «Map» category: «Appearance» title
-    tags = ios
+    tags = android,ios
     en = Appearance
     ar = المظهر
     az = Görünüş
@@ -5759,9 +5759,9 @@
     zh-Hans = 外观
     zh-Hant = 外觀
 
-  [pref_appearance_light]
-    comment = Settings "Appearance" category: "Light" title, should be consistent with the pref_appearance_title translation.
-    tags = ios
+  [light]
+    comment = Generic «Light» string (eg. light theme, not lamps)
+    tags = android,ios
     en = Light
     ar = فاتح
     az = Parlaq
@@ -5805,9 +5805,9 @@
     zh-Hans = 浅色
     zh-Hant = 淺色
 
-  [pref_appearance_dark]
-    comment = Settings "Appearance" category: "Dark" title, should be consistent with the pref_appearance_title translation.
-    tags = ios
+  [dark]
+    comment = Generic «Dark» string
+    tags = android,ios
     en = Dark
     ar = داكن
     az = Tünd
@@ -5851,6 +5851,53 @@
     zh-Hans = 深色
     zh-Hant = 深色
 
+  [follow_system]
+    comment = Appearance setting, OM should follow the system theme
+    tags = android
+    en = Follow System
+    af = Volg Stelsel
+    ar = نظام المتابعة
+    az = Sistemi izləyin
+    be = Сачыце за сістэмай
+    bg = Следване на системата
+    ca = Seguiu el sistema
+    cs = Sledování systému
+    da = Følg systemet
+    de = System folgen
+    el = Ακολουθήστε το σύστημα
+    es = Sistema de seguimiento
+    et = Jälgi süsteemi
+    eu = Jarraitu Sistema
+    fa = سیستم را دنبال کنید
+    fi = Seuraa järjestelmää
+    fr = Suivre le système
+    he = עקוב אחר מערכת
+    hi = सिस्टम का पालन करें
+    hu = Rendszer követése
+    id = Ikuti Sistem
+    it = Seguire il sistema
+    ja = フォローシステム
+    ko = 팔로우 시스템
+    lt = Sekite sistemą
+    lv = Sekojiet sistēmai
+    mr = सिस्टम फॉलो करा
+    nb = Følg systemet
+    nl = Systeem volgen
+    pl = Proszę śledzić system
+    pt = Siga o sistema
+    pt-BR = Seguir o sistema
+    ro = Urmați sistemul
+    ru = Система следования
+    sk = Sledovanie systému
+    sv = Följ systemet
+    sw = Fuata Mfumo
+    th = ติดตามระบบ
+    tr = Sistemi Takip Edin
+    uk = Система стеження
+    vi = Theo dõi hệ thống
+    zh-Hans = 遵循系统
+    zh-Hant = 關注系統
+
   [off]
     comment = Generic «Off» string
     tags = android,ios
-- 
2.45.3


From 7cf9de5d05e12edba980341b6a15ff468aae7688 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 15 Dec 2024 17:38:03 +0000
Subject: [PATCH 02/49] dfrg

---
 .../main/java/app/organicmaps/util/ThemeSwitcher.java    | 7 +------
 android/app/src/main/res/values/string-arrays.xml        | 9 +++++++--
 android/app/src/main/res/values/strings.xml              | 8 ++++++++
 3 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index b1bdc24177..997134beb7 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -15,7 +15,6 @@ public enum ThemeSwitcher
 {
   INSTANCE;
 
-  private static final long CHECK_INTERVAL_MS = 30 * 60 * 1000;
   private static boolean mRendererActive = false;
 
 //  private final Runnable mAutoThemeChecker = new Runnable()
@@ -73,11 +72,7 @@ public enum ThemeSwitcher
   {
     mRendererActive = isRendererActive;
     String theme = Config.getUiThemeSettings(mContext);
-//    if (ThemeUtils.isAutoTheme(mContext, theme) || ThemeUtils.isNavAutoTheme(mContext, theme))
-//    {
-//      mAutoThemeChecker.run();
-//      return;
-//    }
+
     setAndroidTheme(theme);
 
     final String themeToApply = ThemeUtils.getAndroidTheme(mContext);
diff --git a/android/app/src/main/res/values/string-arrays.xml b/android/app/src/main/res/values/string-arrays.xml
index a5e7c4fd81..1a1b7fdca7 100644
--- a/android/app/src/main/res/values/string-arrays.xml
+++ b/android/app/src/main/res/values/string-arrays.xml
@@ -23,14 +23,19 @@
     <item>0</item>
     <item>1</item>
   </string-array>
+
   <string-array name="appearance">
     <item>@string/follow_system</item>
+    <item>@string/nav_auto</item>
+    <item>@string/auto</item>
     <item>@string/light</item>
     <item>@string/dark</item>
   </string-array>
-  <string-array name="appearance_values"
-                translatable="false">
+
+  <string-array name="appearance_values" translatable="false">
     <item>@string/theme_follow_system</item>
+    <item>@string/theme_nav_auto</item>
+    <item>@string/theme_auto</item>
     <item>@string/theme_default</item>
     <item>@string/theme_night</item>
   </string-array>
diff --git a/android/app/src/main/res/values/strings.xml b/android/app/src/main/res/values/strings.xml
index c6058a9554..4921bd8dd9 100644
--- a/android/app/src/main/res/values/strings.xml
+++ b/android/app/src/main/res/values/strings.xml
@@ -235,6 +235,14 @@
     <string name="pref_zoom_summary">Display on the map</string>
     <!-- Settings «Map» category: «Night style» title -->
     <string name="pref_map_style_title">Night Mode</string>
+    <!-- Settings «Map» category: «Appearance» title -->
+    <string name="pref_appearance_title">Appearance</string>
+    <!-- Generic «Light» string (eg. light theme, not lamps) -->
+    <string name="light">Light</string>
+    <!-- Generic «Dark» string -->
+    <string name="dark">Dark</string>
+    <!-- Appearance setting, OM should follow the system theme -->
+    <string name="follow_system">Follow System</string>
     <!-- Generic «Off» string -->
     <string name="off">Off</string>
     <!-- Generic «On» string -->
-- 
2.45.3


From 2383c021b9bb26ea5ca690baf4e2c6ece8da202e Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 15 Dec 2024 18:50:20 +0000
Subject: [PATCH 03/49] check

---
 .../main/java/app/organicmaps/util/Config.java |  3 ++-
 .../java/app/organicmaps/util/ThemeUtils.java  | 18 +++++++++++++++++-
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/Config.java b/android/app/src/main/java/app/organicmaps/util/Config.java
index 55670340d9..6d8eb90a35 100644
--- a/android/app/src/main/java/app/organicmaps/util/Config.java
+++ b/android/app/src/main/java/app/organicmaps/util/Config.java
@@ -2,6 +2,7 @@ package app.organicmaps.util;
 
 import android.content.Context;
 import android.content.SharedPreferences;
+import android.content.res.Resources;
 import android.os.Build;
 
 import androidx.annotation.NonNull;
@@ -277,7 +278,7 @@ public final class Config
   {
     String followSystemTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
     String res = getString(KEY_MISC_UI_THEME_SETTINGS, followSystemTheme);
-    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isFollowSystemTheme(context, res))
+    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isValidThemeMode(context, res))
       return res;
 
     return followSystemTheme;
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index b3613e7cab..06cede0982 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -107,7 +107,23 @@ public final class ThemeUtils
   {
     String navAutoTheme = context.getString(R.string.theme_nav_auto);
     return navAutoTheme.equals(theme);
-}
+  }
+
+  public static boolean isAutoTheme(@NonNull Context context)
+  {
+    return isFollowSystemTheme(context, Config.getCurrentUiTheme(context));
+  }
+
+  public static boolean isAutoTheme(@NonNull Context context, String theme)
+  {
+    String followSystemTheme = context.getString(R.string.theme_auto);
+    return followSystemTheme.equals(theme);
+  }
+
+  public static boolean isValidThemeMode(@NonNull Context context, String res)
+  {
+    return isFollowSystemTheme(context, res) || isNavAutoTheme(context, res) || isAutoTheme(context, res);
+  }
 
   public static boolean isValidTheme(@NonNull Context context, String theme)
   {
-- 
2.45.3


From 54c8a4c8ed49d6f5081ea90af74bb7f40275d7db Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 15 Dec 2024 19:39:45 +0000
Subject: [PATCH 04/49] cvbg

---
 android/app/src/main/java/app/organicmaps/util/Config.java | 7 ++++---
 .../src/main/java/app/organicmaps/util/ThemeSwitcher.java  | 6 +++++-
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/Config.java b/android/app/src/main/java/app/organicmaps/util/Config.java
index 6d8eb90a35..dc2ab12919 100644
--- a/android/app/src/main/java/app/organicmaps/util/Config.java
+++ b/android/app/src/main/java/app/organicmaps/util/Config.java
@@ -276,12 +276,13 @@ public final class Config
   @NonNull
   public static String getUiThemeSettings(@NonNull Context context)
   {
-    String followSystemTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
-    String res = getString(KEY_MISC_UI_THEME_SETTINGS, followSystemTheme);
+    // Fallback & default theme
+    String fallbackTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
+    String res = getString(KEY_MISC_UI_THEME_SETTINGS, fallbackTheme);
     if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isValidThemeMode(context, res))
       return res;
 
-    return followSystemTheme;
+    return fallbackTheme;
   }
 
   public static boolean setUiThemeSettings(@NonNull Context context, String theme)
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 997134beb7..fb6d2fe968 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -84,6 +84,10 @@ public enum ThemeSwitcher
   {
     if (ThemeUtils.isFollowSystemTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
+    else if (ThemeUtils.isAutoTheme(mContext, theme)) //TODO: Proper behaviour
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
+    else if (ThemeUtils.isNavAutoTheme(mContext, theme)) //TODO: Proper behaviour
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
@@ -103,7 +107,7 @@ public enum ThemeSwitcher
       else
         style = Framework.MAP_STYLE_DARK;
     }
-    else
+    else//TODO: and here?
     {
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_CLEAR;
-- 
2.45.3


From 6b0c05bdc898b4c6d5549abfd71a3cf0a9477cf6 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 16 Dec 2024 19:54:35 +0000
Subject: [PATCH 05/49] fgdgfg

---
 .../app/organicmaps/util/ThemeSwitcher.java   | 56 +++++++++----------
 .../java/app/organicmaps/util/ThemeUtils.java |  2 +-
 2 files changed, 28 insertions(+), 30 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index fb6d2fe968..48556108cc 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -1,14 +1,11 @@
 package app.organicmaps.util;
 
-import android.app.Activity;
 import android.content.Context;
 
 import androidx.annotation.NonNull;
 import androidx.appcompat.app.AppCompatDelegate;
 import app.organicmaps.Framework;
-import app.organicmaps.MwmApplication;
 import app.organicmaps.display.DisplayManager;
-import app.organicmaps.downloader.DownloaderStatusIcon;
 import app.organicmaps.routing.RoutingController;
 
 public enum ThemeSwitcher
@@ -71,13 +68,14 @@ public enum ThemeSwitcher
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
+    // First, set the last saved theme
     String theme = Config.getUiThemeSettings(mContext);
-
+    int currentStyle = Framework.nativeGetMapStyle();
     setAndroidTheme(theme);
 
-    final String themeToApply = ThemeUtils.getAndroidTheme(mContext);
-    final int style = getStyle(themeToApply);
-    setThemeAndMapStyle(themeToApply, style);
+    final String themeToApply = ThemeUtils.getUiTheme(mContext);
+    // final int style = getStyle(theme);
+    // setThemeAndMapStyle(theme, style);
   }
 
   private void setAndroidTheme(@NonNull String theme)
@@ -120,28 +118,28 @@ public enum ThemeSwitcher
     return style;
   }
 
-  private void setThemeAndMapStyle(@NonNull String theme, @Framework.MapStyle int style)
-  {
-    String oldTheme = Config.getCurrentUiTheme(mContext);
-
-    if (!theme.equals(oldTheme))
-    {
-      Config.setCurrentUiTheme(mContext, theme);
-      DownloaderStatusIcon.clearCache();
-
-      final Activity a = MwmApplication.from(mContext).getTopActivity();
-      if (a != null && !a.isFinishing())
-        a.recreate();
-    }
-    else
-    {
-      // If the UI theme is not changed we just need to change the map style if needed.
-      int currentStyle = Framework.nativeGetMapStyle();
-      if (currentStyle == style)
-        return;
-      SetMapStyle(style);
-    }
-  }
+//  private void setThemeAndMapStyle(@NonNull String theme, @Framework.MapStyle int style)
+//  {
+//    String oldTheme = Config.getCurrentUiTheme(mContext);
+//
+//    if (!theme.equals(oldTheme))
+//    {
+//      Config.setCurrentUiTheme(mContext, theme);
+//      DownloaderStatusIcon.clearCache();
+//
+//      final Activity a = MwmApplication.from(mContext).getTopActivity();
+//      if (a != null && !a.isFinishing())
+//        a.recreate();
+//    }
+//    else
+//    {
+//      // If the UI theme is not changed we just need to change the map style if needed.
+//      int currentStyle = Framework.nativeGetMapStyle();
+//      if (currentStyle == style)
+//        return;
+//      SetMapStyle(style);
+//    }
+//  }
 
   private void SetMapStyle(@Framework.MapStyle int style)
   {
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index 06cede0982..39ce84e39f 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -46,7 +46,7 @@ public final class ThemeUtils
     return VALUE_BUFFER.resourceId;
   }
 
-  public static String getAndroidTheme(@NonNull Context context)
+  public static String getUiTheme(@NonNull Context context)
   {
     String nightTheme = context.getString(R.string.theme_night);
     String defaultTheme = context.getString(R.string.theme_default);
-- 
2.45.3


From ce9822f950a0eb490aa488fa0b0c2eea2a09225a Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 16 Dec 2024 21:58:31 +0000
Subject: [PATCH 06/49] srfdtghjhfgh

---
 .../src/main/java/app/organicmaps/Map.java    |  4 +-
 .../java/app/organicmaps/SplashActivity.java  |  2 +-
 .../base/BaseMwmFragmentActivity.java         |  4 +-
 .../java/app/organicmaps/util/Config.java     | 48 +++++++++----------
 .../app/organicmaps/util/ThemeSwitcher.java   | 29 +++++++----
 .../java/app/organicmaps/util/ThemeUtils.java | 44 ++++++++---------
 6 files changed, 71 insertions(+), 60 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/Map.java b/android/app/src/main/java/app/organicmaps/Map.java
index 96d4da0288..03d8a99b7d 100644
--- a/android/app/src/main/java/app/organicmaps/Map.java
+++ b/android/app/src/main/java/app/organicmaps/Map.java
@@ -253,7 +253,7 @@ public final class Map
 
   public void onPause(final Context context)
   {
-    mUiThemeOnPause = Config.getCurrentUiTheme(context);
+    mUiThemeOnPause = Config.getUiThemeSettings(context);
 
     // Pause/Resume can be called without surface creation/destroy.
     if (mSurfaceAttached)
@@ -363,7 +363,7 @@ public final class Map
 
   private boolean isThemeChangingProcess(final Context context)
   {
-    return mUiThemeOnPause != null && !mUiThemeOnPause.equals(Config.getCurrentUiTheme(context));
+    return mUiThemeOnPause != null && !mUiThemeOnPause.equals(Config.getUiThemeSettings(context));
   }
 
   // Engine
diff --git a/android/app/src/main/java/app/organicmaps/SplashActivity.java b/android/app/src/main/java/app/organicmaps/SplashActivity.java
index 27f1c635ba..ca2efa2dab 100644
--- a/android/app/src/main/java/app/organicmaps/SplashActivity.java
+++ b/android/app/src/main/java/app/organicmaps/SplashActivity.java
@@ -62,7 +62,7 @@ public class SplashActivity extends AppCompatActivity
     super.onCreate(savedInstanceState);
 
     final Context context = getApplicationContext();
-    final String theme = Config.getCurrentUiTheme(context);
+    final String theme = Config.getUiThemeSettings(context);
     if (ThemeUtils.isDefaultTheme(context, theme))
       setTheme(R.style.MwmTheme_Splash);
     else if (ThemeUtils.isNightTheme(context, theme))
diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
index b5a1f31bd0..2fb1d6cde7 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
@@ -67,7 +67,7 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   protected final void onCreate(@Nullable Bundle savedInstanceState)
   {
     super.onCreate(savedInstanceState);
-    mThemeName = Config.getCurrentUiTheme(getApplicationContext());
+    mThemeName = Config.getUiThemeSettings(getApplicationContext());
     setTheme(getThemeResourceId(mThemeName));
     EdgeToEdge.enable(this, SystemBarStyle.dark(Color.TRANSPARENT));
     RtlUtils.manageRtl(this);
@@ -127,7 +127,7 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   public void onPostResume()
   {
     super.onPostResume();
-    if (!mThemeName.equals(Config.getCurrentUiTheme(getApplicationContext())))
+    if (!mThemeName.equals(Config.getUiThemeSettings(getApplicationContext())))
     {
       // Workaround described in https://code.google.com/p/android/issues/detail?id=93731
       UiThread.runLater(this::recreate);
diff --git a/android/app/src/main/java/app/organicmaps/util/Config.java b/android/app/src/main/java/app/organicmaps/util/Config.java
index dc2ab12919..b2c021fc03 100644
--- a/android/app/src/main/java/app/organicmaps/util/Config.java
+++ b/android/app/src/main/java/app/organicmaps/util/Config.java
@@ -25,7 +25,6 @@ public final class Config
   private static final String KEY_MISC_KAYAK_ACCEPTED = "IsKayakApproved";
   private static final String KEY_MISC_LOCATION_REQUESTED = "LocationRequested";
   private static final String KEY_MISC_UI_THEME = "UiTheme";
-  private static final String KEY_MISC_UI_THEME_SETTINGS = "UiThemeSettings";
   private static final String KEY_MISC_USE_MOBILE_DATA = "UseMobileData";
   private static final String KEY_MISC_USE_MOBILE_DATA_TIMESTAMP = "UseMobileDataTimestamp";
   private static final String KEY_MISC_USE_MOBILE_DATA_ROAMING = "UseMobileDataRoaming";
@@ -254,7 +253,7 @@ public final class Config
   }
 
   @NonNull
-  public static String getCurrentUiTheme(@NonNull Context context)
+  public static String getUiThemeSettings(@NonNull Context context)
   {
     String defaultTheme = MwmApplication.from(context).getString(R.string.theme_default);
     String res = getString(KEY_MISC_UI_THEME, defaultTheme);
@@ -265,35 +264,36 @@ public final class Config
     return defaultTheme;
   }
 
-  static void setCurrentUiTheme(@NonNull Context context, @NonNull String theme)
-  {
-    if (getCurrentUiTheme(context).equals(theme))
-      return;
-
-    setString(KEY_MISC_UI_THEME, theme);
-  }
-
-  @NonNull
-  public static String getUiThemeSettings(@NonNull Context context)
-  {
-    // Fallback & default theme
-    String fallbackTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
-    String res = getString(KEY_MISC_UI_THEME_SETTINGS, fallbackTheme);
-    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isValidThemeMode(context, res))
-      return res;
-
-    return fallbackTheme;
-  }
-
-  public static boolean setUiThemeSettings(@NonNull Context context, String theme)
+  public static boolean setUiThemeSettings(@NonNull Context context, @NonNull String theme)
   {
     if (getUiThemeSettings(context).equals(theme))
       return false;
 
-    setString(KEY_MISC_UI_THEME_SETTINGS, theme);
+    setString(KEY_MISC_UI_THEME, theme);
     return true;
   }
 
+//  @NonNull
+//  public static String getUiThemeSettings(@NonNull Context context)
+//  {
+//    // Fallback & default theme
+//    String fallbackTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
+//    String res = getString(KEY_MISC_UI_THEME_SETTINGS, fallbackTheme);
+//    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isValidThemeMode(context, res))
+//      return res;
+//
+//    return fallbackTheme;
+//  }
+//
+//  public static boolean setUiThemeSettings(@NonNull Context context, String theme)
+//  {
+//    if (getUiThemeSettings(context).equals(theme))
+//      return false;
+//
+//    setString(KEY_MISC_UI_THEME_SETTINGS, theme);
+//    return true;
+//  }
+
   public static boolean isLargeFontsSize()
   {
     return nativeGetLargeFontsSize();
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 48556108cc..880c6d0082 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -69,12 +69,23 @@ public enum ThemeSwitcher
   {
     mRendererActive = isRendererActive;
     // First, set the last saved theme
-    String theme = Config.getUiThemeSettings(mContext);
-    int currentStyle = Framework.nativeGetMapStyle();
-    setAndroidTheme(theme);
+    String storedTheme = Config.getUiThemeSettings(mContext);
+    Config.setUiThemeSettings(mContext, storedTheme);
+    int currentMapStyle = Framework.nativeGetMapStyle();
+    // If current style is different to the style from theme, only set theme
+    // To handle case of debug commands
+    if (currentMapStyle != getMapStyle(storedTheme))
+    {
+      SetMapStyle(getMapStyle(storedTheme));
+      setAndroidTheme(storedTheme);
+    }
+    else
+    {
+      setAndroidTheme(storedTheme);
+    }
 
-    final String themeToApply = ThemeUtils.getUiTheme(mContext);
-    // final int style = getStyle(theme);
+    // final String themeToApply = ThemeUtils.getUiTheme(mContext);
+    // final int style = ;
     // setThemeAndMapStyle(theme, style);
   }
 
@@ -83,16 +94,16 @@ public enum ThemeSwitcher
     if (ThemeUtils.isFollowSystemTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
     else if (ThemeUtils.isAutoTheme(mContext, theme)) //TODO: Proper behaviour
-      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
     else if (ThemeUtils.isNavAutoTheme(mContext, theme)) //TODO: Proper behaviour
-      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
     else if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
   }
 
-  private int getStyle(@NonNull String theme)
+  private int getMapStyle(@NonNull String theme)
   {
     @Framework.MapStyle
     int style;
@@ -105,7 +116,7 @@ public enum ThemeSwitcher
       else
         style = Framework.MAP_STYLE_DARK;
     }
-    else//TODO: and here?
+    else
     {
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_CLEAR;
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index 39ce84e39f..fbd3f7afe2 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -46,28 +46,28 @@ public final class ThemeUtils
     return VALUE_BUFFER.resourceId;
   }
 
-  public static String getUiTheme(@NonNull Context context)
-  {
-    String nightTheme = context.getString(R.string.theme_night);
-    String defaultTheme = context.getString(R.string.theme_default);
-
-    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_YES)
-      return nightTheme;
-
-    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_NO)
-      return defaultTheme;
-
-    int nightModeFlags = context.getResources()
-                                .getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
-    if (nightModeFlags == Configuration.UI_MODE_NIGHT_YES)
-      return nightTheme;
-    else
-      return defaultTheme;
-  }
+//  public static String getUiTheme(@NonNull Context context)
+//  {
+//    String nightTheme = context.getString(R.string.theme_night);
+//    String defaultTheme = context.getString(R.string.theme_default);
+//
+//    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_YES)
+//      return nightTheme;
+//
+//    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_NO)
+//      return defaultTheme;
+//
+//    int nightModeFlags = context.getResources()
+//                                .getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
+//    if (nightModeFlags == Configuration.UI_MODE_NIGHT_YES)
+//      return nightTheme;
+//    else
+//      return defaultTheme;
+//  }
 
   public static boolean isDefaultTheme(@NonNull Context context)
   {
-    return isDefaultTheme(context, Config.getCurrentUiTheme(context));
+    return isDefaultTheme(context, Config.getUiThemeSettings(context));
   }
 
   public static boolean isDefaultTheme(@NonNull Context context, String theme)
@@ -78,7 +78,7 @@ public final class ThemeUtils
 
   public static boolean isNightTheme(@NonNull Context context)
   {
-    return isNightTheme(context, Config.getCurrentUiTheme(context));
+    return isNightTheme(context, Config.getUiThemeSettings(context));
   }
 
   public static boolean isNightTheme(@NonNull Context context, String theme)
@@ -89,7 +89,7 @@ public final class ThemeUtils
 
   public static boolean isFollowSystemTheme(@NonNull Context context)
   {
-    return isFollowSystemTheme(context, Config.getCurrentUiTheme(context));
+    return isFollowSystemTheme(context, Config.getUiThemeSettings(context));
   }
 
   public static boolean isFollowSystemTheme(@NonNull Context context, String theme)
@@ -111,7 +111,7 @@ public final class ThemeUtils
 
   public static boolean isAutoTheme(@NonNull Context context)
   {
-    return isFollowSystemTheme(context, Config.getCurrentUiTheme(context));
+    return isFollowSystemTheme(context, Config.getUiThemeSettings(context));
   }
 
   public static boolean isAutoTheme(@NonNull Context context, String theme)
-- 
2.45.3


From bfad3195adc858c71d8e80e1286404dbe901f9d9 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 16 Dec 2024 22:15:21 +0000
Subject: [PATCH 07/49] dfdfg

---
 .../java/app/organicmaps/util/Config.java     | 31 +++----------------
 1 file changed, 5 insertions(+), 26 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/Config.java b/android/app/src/main/java/app/organicmaps/util/Config.java
index b2c021fc03..23ac69d341 100644
--- a/android/app/src/main/java/app/organicmaps/util/Config.java
+++ b/android/app/src/main/java/app/organicmaps/util/Config.java
@@ -255,13 +255,13 @@ public final class Config
   @NonNull
   public static String getUiThemeSettings(@NonNull Context context)
   {
-    String defaultTheme = MwmApplication.from(context).getString(R.string.theme_default);
-    String res = getString(KEY_MISC_UI_THEME, defaultTheme);
-
-    if (ThemeUtils.isValidTheme(context, res))
+    // Fallback & default theme
+    String fallbackTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
+    String res = getString(KEY_MISC_UI_THEME, fallbackTheme);
+    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isValidThemeMode(context, res))
       return res;
 
-    return defaultTheme;
+    return fallbackTheme;
   }
 
   public static boolean setUiThemeSettings(@NonNull Context context, @NonNull String theme)
@@ -273,27 +273,6 @@ public final class Config
     return true;
   }
 
-//  @NonNull
-//  public static String getUiThemeSettings(@NonNull Context context)
-//  {
-//    // Fallback & default theme
-//    String fallbackTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
-//    String res = getString(KEY_MISC_UI_THEME_SETTINGS, fallbackTheme);
-//    if (ThemeUtils.isValidTheme(context, res) || ThemeUtils.isValidThemeMode(context, res))
-//      return res;
-//
-//    return fallbackTheme;
-//  }
-//
-//  public static boolean setUiThemeSettings(@NonNull Context context, String theme)
-//  {
-//    if (getUiThemeSettings(context).equals(theme))
-//      return false;
-//
-//    setString(KEY_MISC_UI_THEME_SETTINGS, theme);
-//    return true;
-//  }
-
   public static boolean isLargeFontsSize()
   {
     return nativeGetLargeFontsSize();
-- 
2.45.3


From d005ee6149119032bd8c1058a27946c8ad812d91 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 16 Dec 2024 23:33:59 +0000
Subject: [PATCH 08/49] sfdsdfsd

---
 .../app/organicmaps/util/ThemeSwitcher.java   | 41 +++++++++----------
 .../java/app/organicmaps/util/ThemeUtils.java | 13 +++---
 2 files changed, 26 insertions(+), 28 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 880c6d0082..7f4603730d 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -68,35 +68,31 @@ public enum ThemeSwitcher
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
-    // First, set the last saved theme
     String storedTheme = Config.getUiThemeSettings(mContext);
-    Config.setUiThemeSettings(mContext, storedTheme);
     int currentMapStyle = Framework.nativeGetMapStyle();
-    // If current style is different to the style from theme, only set theme
-    // To handle case of debug commands
-    if (currentMapStyle != getMapStyle(storedTheme))
-    {
-      SetMapStyle(getMapStyle(storedTheme));
-      setAndroidTheme(storedTheme);
-    }
-    else
-    {
-      setAndroidTheme(storedTheme);
-    }
 
-    // final String themeToApply = ThemeUtils.getUiTheme(mContext);
-    // final int style = ;
-    // setThemeAndMapStyle(theme, style);
+    // If current style is different to the style from theme, only set theme
+    // to handle debug commands
+    if (currentMapStyle != getMapStyle(storedTheme))
+      SetMapStyle(getMapStyle(storedTheme));
+
+    setAndroidTheme(storedTheme);
   }
 
   private void setAndroidTheme(@NonNull String theme)
   {
-    if (ThemeUtils.isFollowSystemTheme(mContext, theme))
+    if (ThemeUtils.isSystemTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
-    else if (ThemeUtils.isAutoTheme(mContext, theme)) //TODO: Proper behaviour
-      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
-    else if (ThemeUtils.isNavAutoTheme(mContext, theme)) //TODO: Proper behaviour
-      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
+    else if (ThemeUtils.isAutoTheme(mContext, theme))
+      {
+        //TODO: Proper behaviour
+        AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
+      }
+    else if (ThemeUtils.isNavAutoTheme(mContext, theme))
+      {
+        //TODO: Proper behaviour
+        AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
+      }
     else if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
@@ -152,6 +148,9 @@ public enum ThemeSwitcher
 //    }
 //  }
 
+  /**
+   * calls back to core framework and sets the map style.
+   */
   private void SetMapStyle(@Framework.MapStyle int style)
   {
     // Because of the distinct behavior in auto theme, Android Auto employs its own mechanism for theme switching.
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index fbd3f7afe2..8d66691289 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -1,7 +1,6 @@
 package app.organicmaps.util;
 
 import android.content.Context;
-import android.content.res.Configuration;
 import android.content.res.TypedArray;
 import android.util.TypedValue;
 
@@ -9,7 +8,7 @@ import androidx.annotation.AttrRes;
 import androidx.annotation.ColorInt;
 import androidx.annotation.NonNull;
 import androidx.annotation.StyleRes;
-import androidx.appcompat.app.AppCompatDelegate;
+
 import app.organicmaps.R;
 
 public final class ThemeUtils
@@ -87,12 +86,12 @@ public final class ThemeUtils
     return nightTheme.equals(theme);
   }
 
-  public static boolean isFollowSystemTheme(@NonNull Context context)
+  public static boolean isSystemTheme(@NonNull Context context)
   {
-    return isFollowSystemTheme(context, Config.getUiThemeSettings(context));
+    return isSystemTheme(context, Config.getUiThemeSettings(context));
   }
 
-  public static boolean isFollowSystemTheme(@NonNull Context context, String theme)
+  public static boolean isSystemTheme(@NonNull Context context, String theme)
   {
     String followSystemTheme = context.getString(R.string.theme_follow_system);
     return followSystemTheme.equals(theme);
@@ -111,7 +110,7 @@ public final class ThemeUtils
 
   public static boolean isAutoTheme(@NonNull Context context)
   {
-    return isFollowSystemTheme(context, Config.getUiThemeSettings(context));
+    return isSystemTheme(context, Config.getUiThemeSettings(context));
   }
 
   public static boolean isAutoTheme(@NonNull Context context, String theme)
@@ -122,7 +121,7 @@ public final class ThemeUtils
 
   public static boolean isValidThemeMode(@NonNull Context context, String res)
   {
-    return isFollowSystemTheme(context, res) || isNavAutoTheme(context, res) || isAutoTheme(context, res);
+    return isSystemTheme(context, res) || isNavAutoTheme(context, res) || isAutoTheme(context, res);
   }
 
   public static boolean isValidTheme(@NonNull Context context, String theme)
-- 
2.45.3


From 57624499865418c331385b601fd6bd51a53c5d18 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Tue, 17 Dec 2024 00:09:41 +0000
Subject: [PATCH 09/49] eggdfgdgf

---
 .../app/organicmaps/util/ThemeSwitcher.java     | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 7f4603730d..03eef31636 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -5,6 +5,7 @@ import android.content.Context;
 import androidx.annotation.NonNull;
 import androidx.appcompat.app.AppCompatDelegate;
 import app.organicmaps.Framework;
+import app.organicmaps.R;
 import app.organicmaps.display.DisplayManager;
 import app.organicmaps.routing.RoutingController;
 
@@ -71,10 +72,13 @@ public enum ThemeSwitcher
     String storedTheme = Config.getUiThemeSettings(mContext);
     int currentMapStyle = Framework.nativeGetMapStyle();
 
+    // Resolve dynamic themes (follow-system, nav-auto etc.)
+    int resolvedTheme = resolveTheme(storedTheme);
+
     // If current style is different to the style from theme, only set theme
     // to handle debug commands
     if (currentMapStyle != getMapStyle(storedTheme))
-      SetMapStyle(getMapStyle(storedTheme));
+      setMapStyle(getMapStyle(storedTheme));
 
     setAndroidTheme(storedTheme);
   }
@@ -148,10 +152,7 @@ public enum ThemeSwitcher
 //    }
 //  }
 
-  /**
-   * calls back to core framework and sets the map style.
-   */
-  private void SetMapStyle(@Framework.MapStyle int style)
+  private void setMapStyle(@Framework.MapStyle int style)
   {
     // Because of the distinct behavior in auto theme, Android Auto employs its own mechanism for theme switching.
     // For the Android Auto theme switcher, please consult the app.organicmaps.car.util.ThemeUtils module.
@@ -164,4 +165,10 @@ public enum ThemeSwitcher
     else
       Framework.nativeMarkMapStyle(style);
   }
+
+  private int resolveTheme(@NonNull String theme)
+  {
+    //TODO: Dynamic themes processing here, or passthrough for normal ones
+    return R.string.theme_default;
+  }
 }
-- 
2.45.3


From 0edbc5c42123531b48f875a55c8434bc33cfeead Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 19 Dec 2024 16:30:04 +0000
Subject: [PATCH 10/49] change this

---
 .../main/java/app/organicmaps/SplashActivity.java   | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/SplashActivity.java b/android/app/src/main/java/app/organicmaps/SplashActivity.java
index ca2efa2dab..5f5fe41458 100644
--- a/android/app/src/main/java/app/organicmaps/SplashActivity.java
+++ b/android/app/src/main/java/app/organicmaps/SplashActivity.java
@@ -63,12 +63,13 @@ public class SplashActivity extends AppCompatActivity
 
     final Context context = getApplicationContext();
     final String theme = Config.getUiThemeSettings(context);
-    if (ThemeUtils.isDefaultTheme(context, theme))
-      setTheme(R.style.MwmTheme_Splash);
-    else if (ThemeUtils.isNightTheme(context, theme))
-      setTheme(R.style.MwmTheme_Night_Splash);
-    else
-      throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
+    //Need to change this to use android theme system instead of manually setting
+//    if (ThemeUtils.isDefaultTheme(context, theme))
+//      setTheme(R.style.MwmTheme_Splash);
+//    else if (ThemeUtils.isNightTheme(context, theme))
+//      setTheme(R.style.MwmTheme_Night_Splash);
+//    else
+//      throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
 
     UiThread.cancelDelayedTasks(mInitCoreDelayedTask);
     setContentView(R.layout.activity_splash);
-- 
2.45.3


From ebbe713f8f3ac590ef5898dab4b4f20d65020f7d Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 19 Dec 2024 16:33:18 +0000
Subject: [PATCH 11/49] more change needed

---
 .../DownloadResourcesLegacyActivity.java      | 12 ++++----
 .../java/app/organicmaps/MwmActivity.java     | 28 +++++++++---------
 .../base/BaseMwmFragmentActivity.java         | 29 ++++++++++---------
 .../bookmarks/BookmarkCategoriesActivity.java | 12 ++++----
 .../bookmarks/BookmarkListActivity.java       | 12 ++++----
 .../organicmaps/search/SearchActivity.java    | 12 ++++----
 6 files changed, 53 insertions(+), 52 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java b/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java
index 2eb49fc6d3..a873f763aa 100644
--- a/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java
+++ b/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java
@@ -450,12 +450,12 @@ public class DownloadResourcesLegacyActivity extends BaseMwmFragmentActivity
         .show();
   }
 
-  @Override
-  @StyleRes
-  public int getThemeResourceId(@NonNull String theme)
-  {
-    return R.style.MwmTheme_DownloadResourcesLegacy;
-  }
+//  @Override
+//  @StyleRes
+//  public int getThemeResourceId(@NonNull String theme)
+//  {
+//    return R.style.MwmTheme_DownloadResourcesLegacy;
+//  }
 
   private static native int nativeGetBytesToDownload();
   private static native int nativeStartNextFileDownload(Listener listener);
diff --git a/android/app/src/main/java/app/organicmaps/MwmActivity.java b/android/app/src/main/java/app/organicmaps/MwmActivity.java
index 416f528e24..262bdbb65f 100644
--- a/android/app/src/main/java/app/organicmaps/MwmActivity.java
+++ b/android/app/src/main/java/app/organicmaps/MwmActivity.java
@@ -475,20 +475,20 @@ public class MwmActivity extends BaseMwmFragmentActivity
     }
   }
 
-  @Override
-  @StyleRes
-  protected int getThemeResourceId(@NonNull String theme)
-  {
-    Context context = getApplicationContext();
-
-    if (ThemeUtils.isDefaultTheme(context, theme))
-      return R.style.MwmTheme_MainActivity;
-
-    if (ThemeUtils.isNightTheme(context, theme))
-      return R.style.MwmTheme_Night_MainActivity;
-
-    return super.getThemeResourceId(theme);
-  }
+//  @Override
+//  @StyleRes
+//  protected int getThemeResourceId(@NonNull String theme)
+//  {
+//    Context context = getApplicationContext();
+//
+//    if (ThemeUtils.isDefaultTheme(context, theme))
+//      return R.style.MwmTheme_MainActivity;
+//
+//    if (ThemeUtils.isNightTheme(context, theme))
+//      return R.style.MwmTheme_Night_MainActivity;
+//
+//    return super.getThemeResourceId(theme);
+//  }
 
   @Override
   public void onDisplayChangedToCar(@NonNull Runnable onTaskFinishedCallback)
diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
index 2fb1d6cde7..9c8de1428f 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
@@ -42,19 +42,20 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   @NonNull
   private String mThemeName;
 
-  @StyleRes
-  protected int getThemeResourceId(@NonNull String theme)
-  {
-    Context context = getApplicationContext();
-
-    if (ThemeUtils.isDefaultTheme(context, theme))
-        return R.style.MwmTheme;
-
-    if (ThemeUtils.isNightTheme(context, theme))
-      return R.style.MwmTheme_Night;
-
-    throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
-  }
+// TODO: need to set theme with android system, not custom
+//  @StyleRes
+//  protected int getThemeResourceId(@NonNull String theme)
+//  {
+//    Context context = getApplicationContext();
+//
+//    if (ThemeUtils.isDefaultTheme(context, theme))
+//        return R.style.MwmTheme;
+//
+//    if (ThemeUtils.isNightTheme(context, theme))
+//      return R.style.MwmTheme_Night;
+//
+//    throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
+//  }
 
   /**
    * Shows splash screen and initializes the core in case when it was not initialized.
@@ -68,7 +69,7 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   {
     super.onCreate(savedInstanceState);
     mThemeName = Config.getUiThemeSettings(getApplicationContext());
-    setTheme(getThemeResourceId(mThemeName));
+    //setTheme(getThemeResourceId(mThemeName));
     EdgeToEdge.enable(this, SystemBarStyle.dark(Color.TRANSPARENT));
     RtlUtils.manageRtl(this);
     if (!MwmApplication.from(this).arePlatformAndCoreInitialized())
diff --git a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java
index a15a30f1bf..76068e7375 100644
--- a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java
+++ b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java
@@ -40,12 +40,12 @@ public class BookmarkCategoriesActivity extends BaseToolbarActivity
     super.onPause();
   }
 
-  @Override
-  @StyleRes
-  public int getThemeResourceId(@NonNull String theme)
-  {
-    return ThemeUtils.getWindowBgThemeResourceId(getApplicationContext(), theme);
-  }
+//  @Override
+//  @StyleRes
+//  public int getThemeResourceId(@NonNull String theme)
+//  {
+//    return ThemeUtils.getWindowBgThemeResourceId(getApplicationContext(), theme);
+//  }
 
   @Override
   protected Class<? extends Fragment> getFragmentClass()
diff --git a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java
index 353df29639..169140b615 100644
--- a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java
+++ b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java
@@ -39,12 +39,12 @@ public class BookmarkListActivity extends BaseToolbarActivity
     super.onPause();
   }
 
-  @Override
-  @StyleRes
-  public int getThemeResourceId(@NonNull String theme)
-  {
-    return ThemeUtils.getCardBgThemeResourceId(getApplicationContext(), theme);
-  }
+//  @Override
+//  @StyleRes
+//  public int getThemeResourceId(@NonNull String theme)
+//  {
+//    return ThemeUtils.getCardBgThemeResourceId(getApplicationContext(), theme);
+//  }
 
   @Override
   protected Class<? extends Fragment> getFragmentClass()
diff --git a/android/app/src/main/java/app/organicmaps/search/SearchActivity.java b/android/app/src/main/java/app/organicmaps/search/SearchActivity.java
index abcb5cd1bd..edf414bc86 100644
--- a/android/app/src/main/java/app/organicmaps/search/SearchActivity.java
+++ b/android/app/src/main/java/app/organicmaps/search/SearchActivity.java
@@ -34,12 +34,12 @@ public class SearchActivity extends BaseMwmFragmentActivity
     activity.startActivity(i);
   }
 
-  @Override
-  @StyleRes
-  public int getThemeResourceId(@NonNull String theme)
-  {
-    return ThemeUtils.getCardBgThemeResourceId(getApplicationContext(), theme);
-  }
+//  @Override
+//  @StyleRes
+//  public int getThemeResourceId(@NonNull String theme)
+//  {
+//    return ThemeUtils.getCardBgThemeResourceId(getApplicationContext(), theme);
+//  }
 
   @Override
   protected Class<? extends Fragment> getFragmentClass()
-- 
2.45.3


From 9d6a1fb1ba13ff2e03a24d05d9f53a856e1b1e57 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 19 Dec 2024 18:37:16 +0000
Subject: [PATCH 12/49] fix splash light/dark implementation

---
 .../main/java/app/organicmaps/SplashActivity.java    | 10 ----------
 android/app/src/main/res/drawable/splash.xml         |  6 ------
 android/app/src/main/res/layout/activity_splash.xml  |  5 +++--
 android/app/src/main/res/values-night/themes.xml     | 12 ++++++++++++
 android/app/src/main/res/values/themes.xml           |  9 +--------
 5 files changed, 16 insertions(+), 26 deletions(-)
 delete mode 100644 android/app/src/main/res/drawable/splash.xml
 create mode 100644 android/app/src/main/res/values-night/themes.xml

diff --git a/android/app/src/main/java/app/organicmaps/SplashActivity.java b/android/app/src/main/java/app/organicmaps/SplashActivity.java
index 5f5fe41458..464842cc99 100644
--- a/android/app/src/main/java/app/organicmaps/SplashActivity.java
+++ b/android/app/src/main/java/app/organicmaps/SplashActivity.java
@@ -61,16 +61,6 @@ public class SplashActivity extends AppCompatActivity
   {
     super.onCreate(savedInstanceState);
 
-    final Context context = getApplicationContext();
-    final String theme = Config.getUiThemeSettings(context);
-    //Need to change this to use android theme system instead of manually setting
-//    if (ThemeUtils.isDefaultTheme(context, theme))
-//      setTheme(R.style.MwmTheme_Splash);
-//    else if (ThemeUtils.isNightTheme(context, theme))
-//      setTheme(R.style.MwmTheme_Night_Splash);
-//    else
-//      throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
-
     UiThread.cancelDelayedTasks(mInitCoreDelayedTask);
     setContentView(R.layout.activity_splash);
     mPermissionRequest = registerForActivityResult(new ActivityResultContracts.RequestMultiplePermissions(),
diff --git a/android/app/src/main/res/drawable/splash.xml b/android/app/src/main/res/drawable/splash.xml
deleted file mode 100644
index 13c05b365f..0000000000
--- a/android/app/src/main/res/drawable/splash.xml
+++ /dev/null
@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<layer-list xmlns:android="http://schemas.android.com/apk/res/android"
-            android:opacity="opaque">
-  <item android:drawable="?attr/colorPrimary"/>
-  <item android:drawable="@drawable/ic_splash" android:gravity="center"/>
-</layer-list>
diff --git a/android/app/src/main/res/layout/activity_splash.xml b/android/app/src/main/res/layout/activity_splash.xml
index 94da3281a2..e43bf0ab82 100644
--- a/android/app/src/main/res/layout/activity_splash.xml
+++ b/android/app/src/main/res/layout/activity_splash.xml
@@ -5,14 +5,15 @@
   android:layout_height="match_parent"
   xmlns:app="http://schemas.android.com/apk/res-auto"
   android:orientation="vertical"
-  android:gravity="center">
+  android:gravity="center"
+  android:theme="@style/MwmTheme.Splash">
 
   <ImageView
       android:id="@+id/iv__logo"
       android:layout_width="wrap_content"
       android:layout_height="0dp"
       android:contentDescription="@null"
-      app:srcCompat="@drawable/splash"
+      app:srcCompat="@drawable/ic_splash"
       android:layout_weight="1000"
       android:layout_margin="@dimen/margin_double"/>
 
diff --git a/android/app/src/main/res/values-night/themes.xml b/android/app/src/main/res/values-night/themes.xml
new file mode 100644
index 0000000000..8a17b3f3a5
--- /dev/null
+++ b/android/app/src/main/res/values-night/themes.xml
@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+  <style name="MwmTheme" parent="MwmTheme.Base"/>
+  <style name="MwmTheme.Night" parent="MwmTheme.Night.Base"/>
+
+  <style name="MwmTheme.Splash">
+    <item name="android:background">@color/bg_primary_night</item>
+    <item name="android:textColorPrimary">@color/white_primary</item>
+    <item name="android:navigationBarColor">@color/bg_primary_night</item>
+    <item name="android:statusBarColor">@color/bg_primary_night</item>
+  </style>
+</resources>
diff --git a/android/app/src/main/res/values/themes.xml b/android/app/src/main/res/values/themes.xml
index 47a97a0165..3051d68bad 100644
--- a/android/app/src/main/res/values/themes.xml
+++ b/android/app/src/main/res/values/themes.xml
@@ -4,19 +4,12 @@
   <style name="MwmTheme.Night" parent="MwmTheme.Night.Base"/>
 
   <style name="MwmTheme.Splash">
-    <item name="android:windowBackground">@color/bg_primary</item>
+    <item name="android:background">@color/bg_primary</item>
     <item name="android:textColorPrimary">@color/white_primary</item>
     <item name="android:navigationBarColor">@color/bg_primary</item>
     <item name="android:statusBarColor">@color/bg_primary</item>
   </style>
 
-  <style name="MwmTheme.Night.Splash">
-    <item name="android:windowBackground">@color/bg_primary_night</item>
-    <item name="android:textColorPrimary">@color/white_primary</item>
-    <item name="android:navigationBarColor">@color/bg_primary_night</item>
-    <item name="android:statusBarColor">@color/bg_primary_night</item>
-  </style>
-
   <!-- Theme is overridden in v27 folder to handle cutouts -->
   <style name="MwmTheme.MainActivity">
     <item name="android:colorPrimaryDark">@android:color/black</item>
-- 
2.45.3


From e6670730d9980433b0766af2bdebc52c0fc3f959 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 19 Dec 2024 19:20:43 +0000
Subject: [PATCH 13/49] split night themes into values-night

---
 .../src/main/res/values-night/themes-base.xml | 122 ++++++++++++++++++
 .../app/src/main/res/values-night/themes.xml  |  71 +++++++++-
 .../app/src/main/res/values-v27/themes.xml    |   7 -
 .../app/src/main/res/values/themes-base.xml   | 122 ------------------
 android/app/src/main/res/values/themes.xml    |  84 +-----------
 5 files changed, 195 insertions(+), 211 deletions(-)
 create mode 100644 android/app/src/main/res/values-night/themes-base.xml

diff --git a/android/app/src/main/res/values-night/themes-base.xml b/android/app/src/main/res/values-night/themes-base.xml
new file mode 100644
index 0000000000..f4ba6ef5df
--- /dev/null
+++ b/android/app/src/main/res/values-night/themes-base.xml
@@ -0,0 +1,122 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources xmlns:tools="http://schemas.android.com/tools">
+  <style name="MwmTheme.Base" parent="Theme.MaterialComponents.DayNight.NoActionBar.Bridge">
+    <item name="materialCalendarStyle">@style/Widget.MaterialComponents.MaterialCalendar</item>
+    <item name="materialCalendarFullscreenTheme">@style/MwmWidget.MaterialCalendar.Theme.FullScreen.Dark</item>
+    <item name="materialCalendarTheme">@style/MwmWidget.MaterialCalendar.Theme.Dark</item>
+    <item name="android:listViewStyle">@style/MwmWidget.ListView</item>
+    <item name="android:textViewStyle">@style/MwmWidget.TextView</item>
+    <item name="android:forceDarkAllowed" tools:targetApi="Q">false</item>
+
+    <item name="android:textColorPrimary">@color/text_light</item>
+    <item name="android:textColorPrimaryInverse">@color/text_dark</item>
+    <item name="android:textColorSecondary">@color/text_light_subtitle</item>
+    <item name="android:windowBackground">?windowBackgroundForced</item>
+    <item name="android:colorPrimaryDark">@color/bg_primary_dark_night</item>
+    <item name="android:windowSoftInputMode">stateUnspecified|adjustPan</item>
+    <item name="android:fontFamily">@string/robotoRegular</item>
+    <item name="android:colorBackgroundCacheHint">@null</item>
+    <item name="android:windowActionBarOverlay">true</item>
+    <item name="clickableBackground">?selectableItemBackground</item>
+    <item name="android:statusBarColor">?colorPrimary</item>
+    <item name="android:windowTranslucentNavigation">false</item>
+
+    <item name="alertDialogTheme">@style/MwmTheme.AlertDialog</item>
+    <item name="windowBackgroundForced">@color/bg_window_night</item>
+    <item name="cardBackground">@color/bg_cards_night</item>
+    <item name="titleDialogTheme">@color/white_primary</item>
+    <item name="textDialogTheme">@color/white_secondary</item>
+    <item name="fullscreenDialogTheme">@style/MwmTheme.DialogFragment.Fullscreen</item>
+    <item name="colorPrimary">@color/bg_primary_night</item>
+    <item name="colorControlNormal">?secondary</item>
+    <item name="colorAccent">@color/base_accent_night</item>
+    <item name="colorAccentTransparent">@color/base_accent_transparent</item>
+    <item name="colorBtnHighlight">@color/white_24</item>
+    <item name="panel">@color/bg_panel_night</item>
+    <item name="colorLogo">@color/white_primary</item>
+    <item name="iconTint">@color/white_secondary</item>
+    <item name="iconTintDisabled">@color/white_12</item>
+    <item name="iconTintActive">@color/yellow</item>
+    <item name="iconTintLight">@color/icon_tint_light_night</item>
+
+    <item name="secondary">@color/text_light_hint</item>
+    <item name="dividerHorizontal">@color/divider_night</item>
+
+    <item name="ppBackground">@color/bg_cards_night</item>
+    <item name="ppButtonsBackground">@color/bg_window_night</item>
+
+    <item name="navNextTurnFrame">@drawable/bg_nav_next_turn_night</item>
+    <item name="navNextNextTurnFrame">@drawable/bg_nav_next_next_turn_night</item>
+    <item name="navLanesBackgroundColor">@color/base_accent_night</item>
+    <item name="navLaneArrowActiveColor">@color/nav_lane_arrow_active_night</item>
+    <item name="navLaneArrowInactiveColor">@color/nav_lane_arrow_inactive_night</item>
+
+    <item name="buttonBackground">@drawable/button_night</item>
+    <item name="buttonTextColor">@color/button_text_night</item>
+    <item name="buttonTextColorDisabled">@color/button_text_disabled_night</item>
+    <item name="buttonDialogTextColor">@color/base_accent_night</item>
+
+    <item name="accentButtonBackground">@drawable/button_accent_night</item>
+    <item name="accentButtonTextColor">@color/button_accent_text_night</item>
+    <!-- TODO: remove accentButtonTextColorDisabled attribute and use everywhere
+               accentButtonTextColor selector -->
+    <item name="accentButtonTextColorDisabled">@color/button_accent_text_disabled_night</item>
+
+    <item name="redButtonBackground">@drawable/button_red</item>
+    <item name="redButtonTextColor">@color/button_red_text</item>
+    <item name="redButtonTextColorDisabled">@color/button_red_text_disabled</item>
+
+    <item name="primaryButtonBackground">@drawable/button_accent</item>
+
+    <item name="menuBackground">@color/bg_menu_night</item>
+
+    <item name="myPositionButtonAnimation">@drawable/ic_menu_location_pending_night</item>
+    <item name="wheelPendingAnimation">@drawable/anim_spinner_pending</item>
+    <item name="trafficLoadingAnimation">@drawable/anim_traffic_loading_night</item>
+
+    <item name="navButtonsThemeRect">@style/MwmTheme.NavButtonsRect</item>
+    <item name="navButtonsThemeRound">@style/MwmTheme.NavButtonsRound</item>
+    <item name="downloaderTheme">@style/MwmTheme.Downloader</item>
+    <item name="navigationTheme">@style/MwmTheme.Navigation</item>
+
+    <item name="routingButtonHint">@color/routing_button_tint</item>
+
+    <item name="android:listDivider">@drawable/list_divider_night</item>
+
+    <item name="transitPedestrianBackground">@color/white_4</item>
+    <item name="transitRulerBackground">@color/white_4</item>
+    <item name="transitStepDivider">@drawable/dot_divider_night</item>
+    <item name="accentColorSelector">@color/accent_color_selector_night</item>
+    <item name="android:textAppearance">@style/TextAppearance</item>
+    <item name="android:textAppearanceSmall">@style/TextAppearance.Small</item>
+    <item name="android:textAppearanceMedium">@style/TextAppearance.Medium</item>
+    <item name="android:textAppearanceLarge">@style/TextAppearance.Large</item>
+    <item name="fontHeadline1">@style/TextAppearance.MdcTypographyStyles.Headline1</item>
+    <item name="fontHeadline2">@style/TextAppearance.MdcTypographyStyles.Headline2</item>
+    <item name="fontHeadline3">@style/TextAppearance.MdcTypographyStyles.Headline3</item>
+    <item name="fontHeadline4">@style/TextAppearance.MdcTypographyStyles.Headline4</item>
+    <item name="fontHeadline5">@style/TextAppearance.MaterialComponents.Headline5</item>
+    <item name="fontHeadline6">@style/TextAppearance.MdcTypographyStyles.Headline6</item>
+    <item name="fontSubtitle1">@style/TextAppearance.MdcTypographyStyles.Subtitle1</item>
+    <item name="fontSubtitle2">@style/TextAppearance.MdcTypographyStyles.Subtitle2</item>
+    <item name="fontBody1">@style/TextAppearance.MdcTypographyStyles.Body1</item>
+    <item name="fontBody2">@style/TextAppearance.MdcTypographyStyles.Body2</item>
+    <item name="fontButton">@style/TextAppearance.MdcTypographyStyles.Button</item>
+    <item name="fontCaption">@style/TextAppearance.MdcTypographyStyles.Caption</item>
+    <item name="fontOverline">@style/TextAppearance.MdcTypographyStyles.Overline</item>
+    <item name="drivingOptionsViewBg">@color/driving_options_bg_black</item>
+    <item name="elevationProfilePropertyBg">@drawable/bg_rounded_rect_night</item>
+    <item name="elevationProfilePropIconTint">@color/white_secondary</item>
+    <item name="altitudeBg">@drawable/bg_altitude_night</item>
+    <item name="elevationProfileAxisLabelColor">@color/white_54</item>
+    <item name="elevationProfileYourLocationPinBg">@drawable/bg_your_location_pin_night</item>
+    <item name="elevationProfileSelectedPointBg">@drawable/bg_point_desc_night</item>
+    <item name="elevationProfileSelectedPointTriangle">@drawable/ic_triangle_night</item>
+    <item name="elevationProfileFloatingTriangle">@drawable/ic_triangle_elevation_night</item>
+    <item name="elevationProfileColor">@color/elevation_profile_dark</item>
+    <item name="android:popupMenuStyle">@style/PopupMenu.Dark</item>
+
+    <item name="bottomSheetStyle">@style/MwmWidget.BottomSheet</item>
+    <item name="bottomSheetDialogTheme">@style/MwmTheme.BottomSheetDialog</item>
+  </style>
+</resources>
diff --git a/android/app/src/main/res/values-night/themes.xml b/android/app/src/main/res/values-night/themes.xml
index 8a17b3f3a5..237a0c34f4 100644
--- a/android/app/src/main/res/values-night/themes.xml
+++ b/android/app/src/main/res/values-night/themes.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
   <style name="MwmTheme" parent="MwmTheme.Base"/>
-  <style name="MwmTheme.Night" parent="MwmTheme.Night.Base"/>
 
   <style name="MwmTheme.Splash">
     <item name="android:background">@color/bg_primary_night</item>
@@ -9,4 +8,74 @@
     <item name="android:navigationBarColor">@color/bg_primary_night</item>
     <item name="android:statusBarColor">@color/bg_primary_night</item>
   </style>
+
+  <style name="MwmTheme.CardBg">
+    <item name="android:windowBackground">@color/bg_cards_night</item>
+  </style>
+
+  <style name="MwmTheme.WindowBg">
+    <item name="android:windowBackground">@color/bg_window_night</item>
+  </style>
+
+  <style name="MwmTheme.AlertDialog" parent="Theme.MaterialComponents.Dialog.Alert">
+    <item name="colorAccent">?buttonDialogTextColor</item>
+    <item name="colorPrimary">?buttonDialogTextColor</item>
+    <item name="android:background">?cardBackground</item>
+    <!-- Used for the message in the dialog -->
+    <item name="android:textColorPrimary">?textDialogTheme</item>
+    <item name="android:textSize">@dimen/text_size_body_1</item>
+    <!-- Used for the title in the dialog -->
+    <item name="android:windowTitleStyle">@style/MwmTheme.DialogTitleStyle</item>
+  </style>
+
+  <style name="MwmTheme.DialogTitleStyle" parent="MwmTheme.DialogTitleBase">
+    <item name="android:textColor">?titleDialogTheme</item>
+  </style>
+
+  <style name="MwmTheme.NavButtonsRound" parent="MwmTheme">
+    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_round_night</item>
+  </style>
+
+  <style name="MwmTheme.NavButtonsRect" parent="MwmTheme">
+    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_rect_night</item>
+  </style>
+
+  <style name="MwmTheme.Navigation" parent="MwmTheme">
+    <item name="iconTint">@color/black_primary</item>
+  </style>
+
+  <style name="MwmTheme.DialogFragment.Fullscreen" parent="Theme.AppCompat">
+    <item name="colorPrimary">@color/bg_primary_night</item>
+    <item name="android:colorPrimaryDark">?statusBar</item>
+    <item name="colorAccent">@color/base_accent_night</item>
+    <item name="clickableBackground">?selectableItemBackground</item>
+    <item name="colorControlNormal">@color/text_dark_hint</item>
+    <item name="android:windowIsFloating">false</item>
+    <item name="android:textColorHint">@color/text_light_hint</item>
+    <item name="android:textViewStyle">@style/MwmWidget.TextView</item>
+    <item name="android:colorBackgroundCacheHint">@null</item>
+    <item name="android:fontFamily">@string/robotoRegular</item>
+    <item name="android:windowTranslucentStatus">true</item>
+    <item name="android:statusBarColor">@android:color/transparent</item>
+  </style>
+
+  <style name="MwmTheme.DialogFragment.NoFullscreen" parent="MwmTheme.DialogFragment.Fullscreen">
+    <item name="android:windowTranslucentStatus">false</item>
+    <item name="android:statusBarColor">@color/bg_dialog_translucent</item>
+  </style>
+
+  <style name="MwmMain.DialogFragment.TimePicker" parent="Theme.MaterialComponents.Dialog.Alert">
+    <item name="colorAccent">@color/base_accent_night</item>
+    <item name="colorPrimary">?buttonDialogTextColor</item>
+    <item name="android:fontFamily">@string/robotoMedium</item>
+    <item name="android:windowBackground">@color/bg_cards_night</item>
+    <item name="android:background">@color/bg_cards_night</item>
+  </style>
+
+  <style name="MwmTheme.Downloader">
+    <item name="status_done">@drawable/ic_downloader_done_night</item>
+    <item name="status_downloadable">@drawable/ic_downloader_download_night</item>
+    <item name="status_folder">@drawable/ic_downloader_folder_night</item>
+    <item name="status_folder_done">@drawable/ic_downloader_folder_done_night</item>
+  </style>
 </resources>
diff --git a/android/app/src/main/res/values-v27/themes.xml b/android/app/src/main/res/values-v27/themes.xml
index 49e90150ec..e4528b86ff 100644
--- a/android/app/src/main/res/values-v27/themes.xml
+++ b/android/app/src/main/res/values-v27/themes.xml
@@ -8,11 +8,4 @@
     <!-- Allows to show the app behind the camera notch in landscape and when hiding the status bar -->
     <item name="android:windowLayoutInDisplayCutoutMode">shortEdges</item>
   </style>
-  <style name="MwmTheme.Night.MainActivity">
-    <item name="android:colorPrimaryDark">@android:color/black</item>
-    <item name="android:windowBackground">@null</item>
-    <item name="android:windowTranslucentNavigation">false</item>
-    <!-- Allows to show the app behind the camera notch in landscape and when hiding the status bar -->
-    <item name="android:windowLayoutInDisplayCutoutMode">shortEdges</item>
-  </style>
 </resources>
\ No newline at end of file
diff --git a/android/app/src/main/res/values/themes-base.xml b/android/app/src/main/res/values/themes-base.xml
index 8aa30d5793..a822323ea2 100644
--- a/android/app/src/main/res/values/themes-base.xml
+++ b/android/app/src/main/res/values/themes-base.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources xmlns:tools="http://schemas.android.com/tools">
-  <!-- Default theme -->
   <style name="MwmTheme.Base" parent="Theme.MaterialComponents.Light.NoActionBar.Bridge">
     <item name="materialCalendarStyle">@style/Widget.MaterialComponents.MaterialCalendar</item>
     <item name="materialCalendarFullscreenTheme">@style/ThemeOverlay.MaterialComponents.MaterialCalendar.Fullscreen</item>
@@ -134,125 +133,4 @@
     <!-- Theme used for bottom sheet dialog components -->
     <item name="bottomSheetDialogTheme">@style/MwmTheme.BottomSheetDialog</item>
   </style>
-
-  <!-- Night theme -->
-  <style name="MwmTheme.Night.Base" parent="Theme.MaterialComponents.DayNight.NoActionBar.Bridge">
-    <item name="materialCalendarStyle">@style/Widget.MaterialComponents.MaterialCalendar</item>
-    <item name="materialCalendarFullscreenTheme">@style/MwmWidget.MaterialCalendar.Theme.FullScreen.Dark</item>
-    <item name="materialCalendarTheme">@style/MwmWidget.MaterialCalendar.Theme.Dark</item>
-    <item name="android:listViewStyle">@style/MwmWidget.ListView</item>
-    <item name="android:textViewStyle">@style/MwmWidget.TextView</item>
-    <item name="android:forceDarkAllowed" tools:targetApi="Q">false</item>
-
-    <item name="android:textColorPrimary">@color/text_light</item>
-    <item name="android:textColorPrimaryInverse">@color/text_dark</item>
-    <item name="android:textColorSecondary">@color/text_light_subtitle</item>
-    <item name="android:windowBackground">?windowBackgroundForced</item>
-    <item name="android:colorPrimaryDark">@color/bg_primary_dark_night</item>
-    <item name="android:windowSoftInputMode">stateUnspecified|adjustPan</item>
-    <item name="android:fontFamily">@string/robotoRegular</item>
-    <item name="android:colorBackgroundCacheHint">@null</item>
-    <item name="android:windowActionBarOverlay">true</item>
-    <item name="clickableBackground">?selectableItemBackground</item>
-    <item name="android:statusBarColor">?colorPrimary</item>
-    <item name="android:windowTranslucentNavigation">false</item>
-
-    <item name="alertDialogTheme">@style/MwmTheme.Night.AlertDialog</item>
-    <item name="windowBackgroundForced">@color/bg_window_night</item>
-    <item name="cardBackground">@color/bg_cards_night</item>
-    <item name="titleDialogTheme">@color/white_primary</item>
-    <item name="textDialogTheme">@color/white_secondary</item>
-    <item name="fullscreenDialogTheme">@style/MwmTheme.DialogFragment.Fullscreen.Night</item>
-    <item name="colorPrimary">@color/bg_primary_night</item>
-    <item name="colorControlNormal">?secondary</item>
-    <item name="colorAccent">@color/base_accent_night</item>
-    <item name="colorAccentTransparent">@color/base_accent_transparent</item>
-    <item name="colorBtnHighlight">@color/white_24</item>
-    <item name="panel">@color/bg_panel_night</item>
-    <item name="colorLogo">@color/white_primary</item>
-    <item name="iconTint">@color/white_secondary</item>
-    <item name="iconTintDisabled">@color/white_12</item>
-    <item name="iconTintActive">@color/yellow</item>
-    <item name="iconTintLight">@color/icon_tint_light_night</item>
-
-    <item name="secondary">@color/text_light_hint</item>
-    <item name="dividerHorizontal">@color/divider_night</item>
-
-    <item name="ppBackground">@color/bg_cards_night</item>
-    <item name="ppButtonsBackground">@color/bg_window_night</item>
-
-    <item name="navNextTurnFrame">@drawable/bg_nav_next_turn_night</item>
-    <item name="navNextNextTurnFrame">@drawable/bg_nav_next_next_turn_night</item>
-    <item name="navLanesBackgroundColor">@color/base_accent_night</item>
-    <item name="navLaneArrowActiveColor">@color/nav_lane_arrow_active_night</item>
-    <item name="navLaneArrowInactiveColor">@color/nav_lane_arrow_inactive_night</item>
-
-    <item name="buttonBackground">@drawable/button_night</item>
-    <item name="buttonTextColor">@color/button_text_night</item>
-    <item name="buttonTextColorDisabled">@color/button_text_disabled_night</item>
-    <item name="buttonDialogTextColor">@color/base_accent_night</item>
-
-    <item name="accentButtonBackground">@drawable/button_accent_night</item>
-    <item name="accentButtonTextColor">@color/button_accent_text_night</item>
-    <!-- TODO: remove accentButtonTextColorDisabled attribute and use everywhere
-               accentButtonTextColor selector -->
-    <item name="accentButtonTextColorDisabled">@color/button_accent_text_disabled_night</item>
-
-    <item name="redButtonBackground">@drawable/button_red</item>
-    <item name="redButtonTextColor">@color/button_red_text</item>
-    <item name="redButtonTextColorDisabled">@color/button_red_text_disabled</item>
-
-    <item name="primaryButtonBackground">@drawable/button_accent</item>
-
-    <item name="menuBackground">@color/bg_menu_night</item>
-
-    <item name="myPositionButtonAnimation">@drawable/ic_menu_location_pending_night</item>
-    <item name="wheelPendingAnimation">@drawable/anim_spinner_pending</item>
-    <item name="trafficLoadingAnimation">@drawable/anim_traffic_loading_night</item>
-
-    <item name="navButtonsThemeRect">@style/MwmTheme.NavButtonsRect.Night</item>
-    <item name="navButtonsThemeRound">@style/MwmTheme.NavButtonsRound.Night</item>
-    <item name="downloaderTheme">@style/MwmTheme.Downloader.Night</item>
-    <item name="navigationTheme">@style/MwmTheme.Navigation.Night</item>
-
-    <item name="routingButtonHint">@color/routing_button_tint</item>
-
-    <item name="android:listDivider">@drawable/list_divider_night</item>
-
-    <item name="transitPedestrianBackground">@color/white_4</item>
-    <item name="transitRulerBackground">@color/white_4</item>
-    <item name="transitStepDivider">@drawable/dot_divider_night</item>
-    <item name="accentColorSelector">@color/accent_color_selector_night</item>
-    <item name="android:textAppearance">@style/TextAppearance</item>
-    <item name="android:textAppearanceSmall">@style/TextAppearance.Small</item>
-    <item name="android:textAppearanceMedium">@style/TextAppearance.Medium</item>
-    <item name="android:textAppearanceLarge">@style/TextAppearance.Large</item>
-    <item name="fontHeadline1">@style/TextAppearance.MdcTypographyStyles.Headline1</item>
-    <item name="fontHeadline2">@style/TextAppearance.MdcTypographyStyles.Headline2</item>
-    <item name="fontHeadline3">@style/TextAppearance.MdcTypographyStyles.Headline3</item>
-    <item name="fontHeadline4">@style/TextAppearance.MdcTypographyStyles.Headline4</item>
-    <item name="fontHeadline5">@style/TextAppearance.MaterialComponents.Headline5</item>
-    <item name="fontHeadline6">@style/TextAppearance.MdcTypographyStyles.Headline6</item>
-    <item name="fontSubtitle1">@style/TextAppearance.MdcTypographyStyles.Subtitle1</item>
-    <item name="fontSubtitle2">@style/TextAppearance.MdcTypographyStyles.Subtitle2</item>
-    <item name="fontBody1">@style/TextAppearance.MdcTypographyStyles.Body1</item>
-    <item name="fontBody2">@style/TextAppearance.MdcTypographyStyles.Body2</item>
-    <item name="fontButton">@style/TextAppearance.MdcTypographyStyles.Button</item>
-    <item name="fontCaption">@style/TextAppearance.MdcTypographyStyles.Caption</item>
-    <item name="fontOverline">@style/TextAppearance.MdcTypographyStyles.Overline</item>
-    <item name="drivingOptionsViewBg">@color/driving_options_bg_black</item>
-    <item name="elevationProfilePropertyBg">@drawable/bg_rounded_rect_night</item>
-    <item name="elevationProfilePropIconTint">@color/white_secondary</item>
-    <item name="altitudeBg">@drawable/bg_altitude_night</item>
-    <item name="elevationProfileAxisLabelColor">@color/white_54</item>
-    <item name="elevationProfileYourLocationPinBg">@drawable/bg_your_location_pin_night</item>
-    <item name="elevationProfileSelectedPointBg">@drawable/bg_point_desc_night</item>
-    <item name="elevationProfileSelectedPointTriangle">@drawable/ic_triangle_night</item>
-    <item name="elevationProfileFloatingTriangle">@drawable/ic_triangle_elevation_night</item>
-    <item name="elevationProfileColor">@color/elevation_profile_dark</item>
-    <item name="android:popupMenuStyle">@style/PopupMenu.Dark</item>
-
-    <item name="bottomSheetStyle">@style/MwmWidget.BottomSheet</item>
-    <item name="bottomSheetDialogTheme">@style/MwmTheme.BottomSheetDialog</item>
-  </style>
 </resources>
diff --git a/android/app/src/main/res/values/themes.xml b/android/app/src/main/res/values/themes.xml
index 3051d68bad..69f325eab5 100644
--- a/android/app/src/main/res/values/themes.xml
+++ b/android/app/src/main/res/values/themes.xml
@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
   <style name="MwmTheme" parent="MwmTheme.Base"/>
-  <style name="MwmTheme.Night" parent="MwmTheme.Night.Base"/>
 
   <style name="MwmTheme.Splash">
     <item name="android:background">@color/bg_primary</item>
@@ -17,13 +16,6 @@
     <item name="android:windowTranslucentNavigation">false</item>
   </style>
 
-  <!-- Theme is overridden in v27 folder to handle cutouts -->
-  <style name="MwmTheme.Night.MainActivity">
-    <item name="android:colorPrimaryDark">@android:color/black</item>
-    <item name="android:windowBackground">@null</item>
-    <item name="android:windowTranslucentNavigation">false</item>
-  </style>
-
   <style name="MwmTheme.DownloadResourcesLegacy">
     <item name="android:statusBarColor">@android:color/white</item>
     <item name="android:navigationBarColor">@android:color/transparent</item>
@@ -33,25 +25,17 @@
     <item name="android:windowBackground">@color/bg_cards</item>
   </style>
 
-  <style name="MwmTheme.Night.CardBg">
-    <item name="android:windowBackground">@color/bg_cards_night</item>
-  </style>
-
   <style name="MwmTheme.WindowBg">
     <item name="android:windowBackground">@color/bg_window</item>
   </style>
-
-  <style name="MwmTheme.Night.WindowBg">
-    <item name="android:windowBackground">@color/bg_window_night</item>
-  </style>
-
+  
   <style name="MwmTheme.AlertDialog" parent="Theme.MaterialComponents.Light.Dialog.Alert">
     <item name="colorAccent">?buttonDialogTextColor</item>
     <item name="colorPrimary">?buttonDialogTextColor</item>
     <item name="android:background">?cardBackground</item>
     <item name="android:textColorPrimary">?textDialogTheme</item>
     <item name="android:textSize">@dimen/text_size_body_1</item>
-    <item name="android:windowTitleStyle">@style/MwmTheme.DialogTitleStyle.Light</item>
+    <item name="android:windowTitleStyle">@style/MwmTheme.DialogTitleStyle</item>
   </style>
 
   <style name="MwmTheme.DialogTitleBase">
@@ -59,22 +43,7 @@
     <item name="android:fontFamily">@string/robotoMedium</item>
   </style>
 
-  <style name="MwmTheme.DialogTitleStyle.Light" parent="MwmTheme.DialogTitleBase">
-    <item name="android:textColor">?titleDialogTheme</item>
-  </style>
-
-  <style name="MwmTheme.Night.AlertDialog" parent="Theme.MaterialComponents.Dialog.Alert">
-    <item name="colorAccent">?buttonDialogTextColor</item>
-    <item name="colorPrimary">?buttonDialogTextColor</item>
-    <item name="android:background">?cardBackground</item>
-    <!-- Used for the message in the dialog -->
-    <item name="android:textColorPrimary">?textDialogTheme</item>
-    <item name="android:textSize">@dimen/text_size_body_1</item>
-    <!-- Used for the title in the dialog -->
-    <item name="android:windowTitleStyle">@style/MwmTheme.DialogTitleStyle.Night</item>
-  </style>
-
-  <style name="MwmTheme.DialogTitleStyle.Night" parent="MwmTheme.DialogTitleBase">
+  <style name="MwmTheme.DialogTitleStyle" parent="MwmTheme.DialogTitleBase">
     <item name="android:textColor">?titleDialogTheme</item>
   </style>
 
@@ -103,26 +72,6 @@
     <item name="android:statusBarColor">@color/bg_dialog_translucent</item>
   </style>
 
-  <style name="MwmTheme.DialogFragment.Fullscreen.Night" parent="Theme.AppCompat">
-    <item name="colorPrimary">@color/bg_primary_night</item>
-    <item name="android:colorPrimaryDark">?statusBar</item>
-    <item name="colorAccent">@color/base_accent_night</item>
-    <item name="clickableBackground">?selectableItemBackground</item>
-    <item name="colorControlNormal">@color/text_dark_hint</item>
-    <item name="android:windowIsFloating">false</item>
-    <item name="android:textColorHint">@color/text_light_hint</item>
-    <item name="android:textViewStyle">@style/MwmWidget.TextView</item>
-    <item name="android:colorBackgroundCacheHint">@null</item>
-    <item name="android:fontFamily">@string/robotoRegular</item>
-    <item name="android:windowTranslucentStatus">true</item>
-    <item name="android:statusBarColor">@android:color/transparent</item>
-  </style>
-
-  <style name="MwmTheme.DialogFragment.NoFullscreen.Night" parent="MwmTheme.DialogFragment.Fullscreen.Night">
-    <item name="android:windowTranslucentStatus">false</item>
-    <item name="android:statusBarColor">@color/bg_dialog_translucent</item>
-  </style>
-
   <style name="MwmTheme.DialogFragment.Fullscreen.Translucent">
     <item name="android:colorPrimaryDark">@android:color/black</item>
     <item name="android:windowBackground">@color/bg_dialog_translucent</item>
@@ -138,14 +87,6 @@
     <item name="android:background">@color/bg_cards</item>
   </style>
 
-  <style name="MwmMain.DialogFragment.TimePicker.Night" parent="Theme.MaterialComponents.Dialog.Alert">
-    <item name="colorAccent">@color/base_accent_night</item>
-    <item name="colorPrimary">?buttonDialogTextColor</item>
-    <item name="android:fontFamily">@string/robotoMedium</item>
-    <item name="android:windowBackground">@color/bg_cards_night</item>
-    <item name="android:background">@color/bg_cards_night</item>
-  </style>
-
   <style name="MwmTheme.ProgressDialog" parent="MwmTheme.AlertDialog">
     <item name="android:textColor">?textDialogTheme</item>
   </style>
@@ -159,37 +100,18 @@
     <item name="status_folder_done">@drawable/ic_downloader_folder_done</item>
   </style>
 
-  <style name="MwmTheme.Downloader.Night">
-    <item name="status_done">@drawable/ic_downloader_done_night</item>
-    <item name="status_downloadable">@drawable/ic_downloader_download_night</item>
-    <item name="status_folder">@drawable/ic_downloader_folder_night</item>
-    <item name="status_folder_done">@drawable/ic_downloader_folder_done_night</item>
-  </style>
-
   <style name="MwmTheme.NavButtonsRound">
     <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_round</item>
   </style>
 
-  <style name="MwmTheme.NavButtonsRound.Night" parent="MwmTheme.Night">
-    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_round_night</item>
-  </style>
-
   <style name="MwmTheme.NavButtonsRect">
     <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_rect</item>
   </style>
 
-  <style name="MwmTheme.NavButtonsRect.Night" parent="MwmTheme.Night">
-    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_rect_night</item>
-  </style>
-
   <style name="MwmTheme.Navigation">
     <item name="iconTint">@color/white_primary</item>
   </style>
 
-  <style name="MwmTheme.Navigation.Night" parent="MwmTheme.Night">
-    <item name="iconTint">@color/black_primary</item>
-  </style>
-
   <style name="PopupMenu" parent="ThemeOverlay.AppCompat">
     <item name="android:popupBackground">?windowBackgroundForced</item>
   </style>
-- 
2.45.3


From 6135c19079f51a38220e25e7d108db10606af5cc Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 19 Dec 2024 20:58:23 +0000
Subject: [PATCH 14/49] remove superfluous theme setting code

---
 .../base/BaseMwmDialogFragment.java           | 35 -------------------
 .../editor/HoursMinutesPickerFragment.java    |  5 +--
 .../java/app/organicmaps/util/ThemeUtils.java | 24 -------------
 .../widget/placepage/DirectionFragment.java   |  7 ----
 .../placepage/EditBookmarkFragment.java       |  6 ----
 5 files changed, 1 insertion(+), 76 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java
index dd6a9f5777..aebb8d757e 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java
@@ -14,46 +14,11 @@ import app.organicmaps.util.ThemeUtils;
 
 public class BaseMwmDialogFragment extends DialogFragment
 {
-  @StyleRes
-  protected final int getFullscreenTheme()
-  {
-    return ThemeUtils.isNightTheme(requireContext()) ? getFullscreenDarkTheme() : getFullscreenLightTheme();
-  }
-
   protected int getStyle()
   {
     return STYLE_NORMAL;
   }
 
-  protected @StyleRes int getCustomTheme()
-  {
-    return 0;
-  }
-
-  @Override
-  public void onCreate(@Nullable Bundle savedInstanceState)
-  {
-    super.onCreate(savedInstanceState);
-
-    int style = getStyle();
-    int theme = getCustomTheme();
-    if (style != STYLE_NORMAL || theme != 0)
-      //noinspection WrongConstant
-      setStyle(style, theme);
-  }
-
-  @StyleRes
-  protected int getFullscreenLightTheme()
-  {
-    return R.style.MwmTheme_DialogFragment_Fullscreen;
-  }
-
-  @StyleRes
-  protected int getFullscreenDarkTheme()
-  {
-    return R.style.MwmTheme_DialogFragment_Fullscreen_Night;
-  }
-
   @NonNull
   protected Application getAppContextOrThrow()
   {
diff --git a/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java b/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java
index 3708921150..948327d89c 100644
--- a/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java
@@ -79,10 +79,7 @@ public class HoursMinutesPickerFragment extends BaseMwmDialogFragment
     //noinspection ConstantConditions
     mTabs.getTabAt(mSelectedTab).select();
 
-    @StyleRes final int theme = ThemeUtils.isNightTheme(requireContext()) ?
-        R.style.MwmMain_DialogFragment_TimePicker_Night :
-        R.style.MwmMain_DialogFragment_TimePicker;
-    final AlertDialog dialog = new MaterialAlertDialogBuilder(requireActivity(), theme)
+    final AlertDialog dialog = new MaterialAlertDialogBuilder(requireActivity())
         .setView(root)
         .setNegativeButton(R.string.cancel, null)
         .setPositiveButton(R.string.ok, null)
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index 8d66691289..b620518c78 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -130,28 +130,4 @@ public final class ThemeUtils
     String nightTheme = context.getString(R.string.theme_night);
     return (defaultTheme.equals(theme) || nightTheme.equals(theme));
   }
-
-  @StyleRes
-  public static int getCardBgThemeResourceId(@NonNull Context context, @NonNull String theme)
-  {
-    if (isDefaultTheme(context, theme))
-      return R.style.MwmTheme_CardBg;
-
-    if (isNightTheme(context, theme))
-      return R.style.MwmTheme_Night_CardBg;
-
-    throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
-  }
-
-  @StyleRes
-  public static int getWindowBgThemeResourceId(@NonNull Context context, @NonNull String theme)
-  {
-    if (isDefaultTheme(context, theme))
-      return R.style.MwmTheme_WindowBg;
-
-    if (isNightTheme(context, theme))
-      return R.style.MwmTheme_Night_WindowBg;
-
-    throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
-  }
 }
diff --git a/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java b/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java
index 28cbf2b032..59cba0d921 100644
--- a/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java
+++ b/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java
@@ -35,13 +35,6 @@ public class DirectionFragment extends BaseMwmDialogFragment
   private TextView mTvDistance;
 
   private MapObject mMapObject;
-
-  @Override
-  protected int getCustomTheme()
-  {
-    return R.style.MwmTheme_DialogFragment_Fullscreen_Translucent;
-  }
-
   @Override
   public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState)
   {
diff --git a/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java b/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java
index dd31a18ac1..be1696a5b6 100644
--- a/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java
+++ b/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java
@@ -103,12 +103,6 @@ public class EditBookmarkFragment extends BaseMwmDialogFragment implements View.
 
   public EditBookmarkFragment() {}
 
-  @Override
-  protected int getCustomTheme()
-  {
-    return getFullscreenTheme();
-  }
-
   @Nullable
   @Override
   public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)
-- 
2.45.3


From c037e951a0706067eb397de3a653af38a36ba0f7 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 19 Dec 2024 22:05:10 +0000
Subject: [PATCH 15/49] remove uimode configchanges in manifest

---
 android/app/src/main/AndroidManifest.xml | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
index 0a7e8fb475..f252e36e8d 100644
--- a/android/app/src/main/AndroidManifest.xml
+++ b/android/app/src/main/AndroidManifest.xml
@@ -344,8 +344,7 @@
 
     </activity>
     <activity
-        android:name="app.organicmaps.base.BaseMwmFragmentActivity"
-        android:configChanges="uiMode" />
+        android:name="app.organicmaps.base.BaseMwmFragmentActivity" />
 
     <activity
         android:name="app.organicmaps.DownloadResourcesLegacyActivity"
@@ -402,7 +401,6 @@
         android:name="app.organicmaps.help.HelpActivity"
         android:label="@string/about_menu_title"
         android:parentActivityName="app.organicmaps.MwmActivity"
-        android:configChanges="uiMode"
         android:exported="false">
       <intent-filter>
         <action android:name="app.organicmaps.help.HelpActivity" />
@@ -436,41 +434,33 @@
 
     <activity
         android:name="app.organicmaps.editor.ProfileActivity"
-        android:configChanges="uiMode"
         android:parentActivityName="app.organicmaps.settings.SettingsActivity" />
 
     <activity
         android:name="app.organicmaps.editor.FeatureCategoryActivity"
         android:parentActivityName="app.organicmaps.MwmActivity"
-        android:configChanges="uiMode"
         android:windowSoftInputMode="adjustResize" />
 
     <activity
         android:name="app.organicmaps.editor.ReportActivity"
-        android:configChanges="uiMode"
         android:parentActivityName="app.organicmaps.MwmActivity" />
 
     <activity
         android:name="app.organicmaps.editor.OsmLoginActivity"
-        android:configChanges="uiMode"
         android:parentActivityName="app.organicmaps.MwmActivity" />
 
     <activity
       android:name="app.organicmaps.bookmarks.BookmarkCategorySettingsActivity"
       android:label="@string/edit"
-      android:configChanges="uiMode"
-      android:windowSoftInputMode="stateVisible"/>
+      android:windowSoftInputMode="stateVisible" />
     <activity
       android:name="app.organicmaps.widget.placepage.PlaceDescriptionActivity"
-      android:configChanges="uiMode"
-      android:label="@string/place_description_title"/>
+      android:label="@string/place_description_title" />
     <activity
       android:name="app.organicmaps.settings.DrivingOptionsActivity"
-      android:configChanges="uiMode"
-      android:label="@string/driving_options_title"/>
+      android:label="@string/driving_options_title" />
     <activity
-      android:name="app.organicmaps.MapPlaceholderActivity"
-      android:configChanges="uiMode" />
+      android:name="app.organicmaps.MapPlaceholderActivity" />
     <activity
         android:name="app.organicmaps.car.screens.permissions.RequestPermissionsActivity"/>
     <service
-- 
2.45.3


From c65fb530626360b784c241db42ef172b80693ac6 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Fri, 20 Dec 2024 15:41:34 +0000
Subject: [PATCH 16/49] these need to be duplicated to night theme

getResource in themeutils doesn't fall back (but i don't think it should)
---
 android/app/src/main/res/values-night/themes-base.xml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/android/app/src/main/res/values-night/themes-base.xml b/android/app/src/main/res/values-night/themes-base.xml
index f4ba6ef5df..d3158b3fe4 100644
--- a/android/app/src/main/res/values-night/themes-base.xml
+++ b/android/app/src/main/res/values-night/themes-base.xml
@@ -116,6 +116,15 @@
     <item name="elevationProfileColor">@color/elevation_profile_dark</item>
     <item name="android:popupMenuStyle">@style/PopupMenu.Dark</item>
 
+    <item name="outdoorsMenuEnabled">@drawable/ic_layers_outdoors_active</item>
+    <item name="trafficMenuEnabled">@drawable/ic_layers_traffic_active</item>
+    <item name="subwayMenuEnabled">@drawable/ic_layers_subway_active</item>
+    <item name="isoLinesMenuEnabled">@drawable/ic_layers_isoline_active</item>
+    <item name="outdoorsMenuDisabled">@drawable/ic_layers_outdoors_inactive</item>
+    <item name="trafficMenuDisabled">@drawable/ic_layers_traffic_inactive</item>
+    <item name="subwayMenuDisabled">@drawable/ic_layers_subway_inactive</item>
+    <item name="isoLinesMenuDisabled">@drawable/ic_layers_isoline_inactive</item>
+
     <item name="bottomSheetStyle">@style/MwmWidget.BottomSheet</item>
     <item name="bottomSheetDialogTheme">@style/MwmTheme.BottomSheetDialog</item>
   </style>
-- 
2.45.3


From 637a0510338bfcae9d542faea479d15fef8a2f79 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Fri, 20 Dec 2024 15:58:03 +0000
Subject: [PATCH 17/49] return getcustomtheme

still needed
---
 .../organicmaps/base/BaseMwmDialogFragment.java  | 16 ++++++++++++++++
 .../widget/placepage/DirectionFragment.java      |  7 +++++++
 .../widget/placepage/EditBookmarkFragment.java   |  6 ++++++
 3 files changed, 29 insertions(+)

diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java
index aebb8d757e..df1f2abc3b 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmDialogFragment.java
@@ -19,6 +19,22 @@ public class BaseMwmDialogFragment extends DialogFragment
     return STYLE_NORMAL;
   }
 
+  protected @StyleRes int getCustomTheme()
+  {
+    return 0;
+  }
+
+  @Override
+  public void onCreate(@Nullable Bundle savedInstanceState)
+  {
+    super.onCreate(savedInstanceState);
+
+    int style = getStyle();
+    int theme = getCustomTheme();
+    if (style != STYLE_NORMAL || theme != 0)
+      setStyle(style, theme);
+  }
+
   @NonNull
   protected Application getAppContextOrThrow()
   {
diff --git a/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java b/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java
index 59cba0d921..28cbf2b032 100644
--- a/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java
+++ b/android/app/src/main/java/app/organicmaps/widget/placepage/DirectionFragment.java
@@ -35,6 +35,13 @@ public class DirectionFragment extends BaseMwmDialogFragment
   private TextView mTvDistance;
 
   private MapObject mMapObject;
+
+  @Override
+  protected int getCustomTheme()
+  {
+    return R.style.MwmTheme_DialogFragment_Fullscreen_Translucent;
+  }
+
   @Override
   public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState)
   {
diff --git a/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java b/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java
index be1696a5b6..66e4ffac81 100644
--- a/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java
+++ b/android/app/src/main/java/app/organicmaps/widget/placepage/EditBookmarkFragment.java
@@ -103,6 +103,12 @@ public class EditBookmarkFragment extends BaseMwmDialogFragment implements View.
 
   public EditBookmarkFragment() {}
 
+  @Override
+  protected int getCustomTheme()
+  {
+    return R.style.MwmTheme_DialogFragment_Fullscreen;
+  }
+
   @Nullable
   @Override
   public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)
-- 
2.45.3


From 4b420f8c5bacc8815f348dee0fbb421f62ec6aee Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 12:14:52 +0000
Subject: [PATCH 18/49] rename get/setThemeSettings - no longer just UI theme

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 android/app/src/main/java/app/organicmaps/Map.java    |  4 ++--
 .../app/organicmaps/base/BaseMwmFragmentActivity.java |  7 ++-----
 .../organicmaps/settings/SettingsPrefsFragment.java   |  4 ++--
 .../src/main/java/app/organicmaps/util/Config.java    |  7 +++----
 .../main/java/app/organicmaps/util/ThemeSwitcher.java |  2 +-
 .../main/java/app/organicmaps/util/ThemeUtils.java    | 11 +++++------
 6 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/Map.java b/android/app/src/main/java/app/organicmaps/Map.java
index 03d8a99b7d..8c609b8aa7 100644
--- a/android/app/src/main/java/app/organicmaps/Map.java
+++ b/android/app/src/main/java/app/organicmaps/Map.java
@@ -253,7 +253,7 @@ public final class Map
 
   public void onPause(final Context context)
   {
-    mUiThemeOnPause = Config.getUiThemeSettings(context);
+    mUiThemeOnPause = Config.getThemeSettings(context);
 
     // Pause/Resume can be called without surface creation/destroy.
     if (mSurfaceAttached)
@@ -363,7 +363,7 @@ public final class Map
 
   private boolean isThemeChangingProcess(final Context context)
   {
-    return mUiThemeOnPause != null && !mUiThemeOnPause.equals(Config.getUiThemeSettings(context));
+    return mUiThemeOnPause != null && !mUiThemeOnPause.equals(Config.getThemeSettings(context));
   }
 
   // Engine
diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
index 9c8de1428f..b4ff839308 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
@@ -1,7 +1,6 @@
 package app.organicmaps.base;
 
 import android.content.ComponentName;
-import android.content.Context;
 import android.content.Intent;
 import android.graphics.Color;
 import android.content.res.Configuration;
@@ -14,7 +13,6 @@ import androidx.activity.SystemBarStyle;
 import androidx.annotation.CallSuper;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
-import androidx.annotation.StyleRes;
 import androidx.appcompat.app.AppCompatActivity;
 import androidx.appcompat.widget.Toolbar;
 import androidx.fragment.app.Fragment;
@@ -27,7 +25,6 @@ import app.organicmaps.SplashActivity;
 import app.organicmaps.util.Config;
 import app.organicmaps.util.RtlUtils;
 import app.organicmaps.util.ThemeSwitcher;
-import app.organicmaps.util.ThemeUtils;
 import app.organicmaps.util.concurrency.UiThread;
 import app.organicmaps.util.log.Logger;
 
@@ -68,7 +65,7 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   protected final void onCreate(@Nullable Bundle savedInstanceState)
   {
     super.onCreate(savedInstanceState);
-    mThemeName = Config.getUiThemeSettings(getApplicationContext());
+    mThemeName = Config.getThemeSettings(getApplicationContext());
     //setTheme(getThemeResourceId(mThemeName));
     EdgeToEdge.enable(this, SystemBarStyle.dark(Color.TRANSPARENT));
     RtlUtils.manageRtl(this);
@@ -128,7 +125,7 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   public void onPostResume()
   {
     super.onPostResume();
-    if (!mThemeName.equals(Config.getUiThemeSettings(getApplicationContext())))
+    if (!mThemeName.equals(Config.getThemeSettings(getApplicationContext())))
     {
       // Workaround described in https://code.google.com/p/android/issues/detail?id=93731
       UiThread.runLater(this::recreate);
diff --git a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
index 2597c3fd4c..816385f861 100644
--- a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
+++ b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
@@ -395,12 +395,12 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La
   {
     final ListPreference pref = getPreference(getString(R.string.pref_map_style));
 
-    String curTheme = Config.getUiThemeSettings(requireContext());
+    String curTheme = Config.getThemeSettings(requireContext());
     pref.setValue(curTheme);
     pref.setSummary(pref.getEntry());
     pref.setOnPreferenceChangeListener((preference, newValue) -> {
       final String themeName = (String) newValue;
-      if (!Config.setUiThemeSettings(requireContext(), themeName))
+      if (!Config.setThemeSettings(requireContext(), themeName))
         return true;
 
       ThemeSwitcher.INSTANCE.restart(false);
diff --git a/android/app/src/main/java/app/organicmaps/util/Config.java b/android/app/src/main/java/app/organicmaps/util/Config.java
index 23ac69d341..068a39b9c9 100644
--- a/android/app/src/main/java/app/organicmaps/util/Config.java
+++ b/android/app/src/main/java/app/organicmaps/util/Config.java
@@ -2,7 +2,6 @@ package app.organicmaps.util;
 
 import android.content.Context;
 import android.content.SharedPreferences;
-import android.content.res.Resources;
 import android.os.Build;
 
 import androidx.annotation.NonNull;
@@ -253,7 +252,7 @@ public final class Config
   }
 
   @NonNull
-  public static String getUiThemeSettings(@NonNull Context context)
+  public static String getThemeSettings(@NonNull Context context)
   {
     // Fallback & default theme
     String fallbackTheme = MwmApplication.from(context).getString(R.string.theme_follow_system);
@@ -264,9 +263,9 @@ public final class Config
     return fallbackTheme;
   }
 
-  public static boolean setUiThemeSettings(@NonNull Context context, @NonNull String theme)
+  public static boolean setThemeSettings(@NonNull Context context, @NonNull String theme)
   {
-    if (getUiThemeSettings(context).equals(theme))
+    if (getThemeSettings(context).equals(theme))
       return false;
 
     setString(KEY_MISC_UI_THEME, theme);
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 03eef31636..faf5cbf7b4 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -69,7 +69,7 @@ public enum ThemeSwitcher
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
-    String storedTheme = Config.getUiThemeSettings(mContext);
+    String storedTheme = Config.getThemeSettings(mContext);
     int currentMapStyle = Framework.nativeGetMapStyle();
 
     // Resolve dynamic themes (follow-system, nav-auto etc.)
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index b620518c78..854c47ce19 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -7,7 +7,6 @@ import android.util.TypedValue;
 import androidx.annotation.AttrRes;
 import androidx.annotation.ColorInt;
 import androidx.annotation.NonNull;
-import androidx.annotation.StyleRes;
 
 import app.organicmaps.R;
 
@@ -66,7 +65,7 @@ public final class ThemeUtils
 
   public static boolean isDefaultTheme(@NonNull Context context)
   {
-    return isDefaultTheme(context, Config.getUiThemeSettings(context));
+    return isDefaultTheme(context, Config.getThemeSettings(context));
   }
 
   public static boolean isDefaultTheme(@NonNull Context context, String theme)
@@ -77,7 +76,7 @@ public final class ThemeUtils
 
   public static boolean isNightTheme(@NonNull Context context)
   {
-    return isNightTheme(context, Config.getUiThemeSettings(context));
+    return isNightTheme(context, Config.getThemeSettings(context));
   }
 
   public static boolean isNightTheme(@NonNull Context context, String theme)
@@ -88,7 +87,7 @@ public final class ThemeUtils
 
   public static boolean isSystemTheme(@NonNull Context context)
   {
-    return isSystemTheme(context, Config.getUiThemeSettings(context));
+    return isSystemTheme(context, Config.getThemeSettings(context));
   }
 
   public static boolean isSystemTheme(@NonNull Context context, String theme)
@@ -99,7 +98,7 @@ public final class ThemeUtils
 
   public static boolean isNavAutoTheme(@NonNull Context context)
   {
-    return isNavAutoTheme(context, Config.getUiThemeSettings(context));
+    return isNavAutoTheme(context, Config.getThemeSettings(context));
   }
 
   public static boolean isNavAutoTheme(@NonNull Context context, String theme)
@@ -110,7 +109,7 @@ public final class ThemeUtils
 
   public static boolean isAutoTheme(@NonNull Context context)
   {
-    return isSystemTheme(context, Config.getUiThemeSettings(context));
+    return isSystemTheme(context, Config.getThemeSettings(context));
   }
 
   public static boolean isAutoTheme(@NonNull Context context, String theme)
-- 
2.45.3


From a352d870bf54c88030a4a5922618eca04b6c4c64 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 12:26:02 +0000
Subject: [PATCH 19/49] add notes, re-name and reorder stuff

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 50 +++++++++----------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index faf5cbf7b4..27cedb68b8 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -69,12 +69,12 @@ public enum ThemeSwitcher
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
-    String storedTheme = Config.getThemeSettings(mContext);
+    String storedTheme = Config.getThemeSettings(mContext); // follow-system etc
+
     int currentMapStyle = Framework.nativeGetMapStyle();
-
-    // Resolve dynamic themes (follow-system, nav-auto etc.)
-    int resolvedTheme = resolveTheme(storedTheme);
-
+    // Resolve dynamic themes (follow-system, nav-auto etc.) to light or dark
+    int resolvedTheme = getAndroidTheme(storedTheme);
+    // Then derive map style from that, but handle debug commands
     // If current style is different to the style from theme, only set theme
     // to handle debug commands
     if (currentMapStyle != getMapStyle(storedTheme))
@@ -103,6 +103,26 @@ public enum ThemeSwitcher
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
   }
 
+  private void setMapStyle(@Framework.MapStyle int style)
+  {
+    // Because of the distinct behavior in auto theme, Android Auto employs its own mechanism for theme switching.
+    // For the Android Auto theme switcher, please consult the app.organicmaps.car.util.ThemeUtils module.
+    if (DisplayManager.from(mContext).isCarDisplayUsed())
+      return;
+    // If rendering is not active we can mark map style, because all graphics
+    // will be recreated after rendering activation.
+    if (mRendererActive)
+      Framework.nativeSetMapStyle(style);
+    else
+      Framework.nativeMarkMapStyle(style);
+  }
+
+  private int getAndroidTheme(@NonNull String theme)
+  {
+    //TODO: Dynamic themes processing here, or passthrough for normal ones
+    return R.string.theme_default;
+  }
+
   private int getMapStyle(@NonNull String theme)
   {
     @Framework.MapStyle
@@ -151,24 +171,4 @@ public enum ThemeSwitcher
 //      SetMapStyle(style);
 //    }
 //  }
-
-  private void setMapStyle(@Framework.MapStyle int style)
-  {
-    // Because of the distinct behavior in auto theme, Android Auto employs its own mechanism for theme switching.
-    // For the Android Auto theme switcher, please consult the app.organicmaps.car.util.ThemeUtils module.
-    if (DisplayManager.from(mContext).isCarDisplayUsed())
-      return;
-    // If rendering is not active we can mark map style, because all graphics
-    // will be recreated after rendering activation.
-    if (mRendererActive)
-      Framework.nativeSetMapStyle(style);
-    else
-      Framework.nativeMarkMapStyle(style);
-  }
-
-  private int resolveTheme(@NonNull String theme)
-  {
-    //TODO: Dynamic themes processing here, or passthrough for normal ones
-    return R.string.theme_default;
-  }
 }
-- 
2.45.3


From 7ecf0ba8407fee05c35981036ab139fbb3ff8cfc Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 13:24:20 +0000
Subject: [PATCH 20/49] fix flow

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 69 +++++++------------
 1 file changed, 24 insertions(+), 45 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 27cedb68b8..0527b235ab 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -70,33 +70,20 @@ public enum ThemeSwitcher
   {
     mRendererActive = isRendererActive;
     String storedTheme = Config.getThemeSettings(mContext); // follow-system etc
-
-    int currentMapStyle = Framework.nativeGetMapStyle();
     // Resolve dynamic themes (follow-system, nav-auto etc.) to light or dark
-    int resolvedTheme = getAndroidTheme(storedTheme);
     // Then derive map style from that, but handle debug commands
     // If current style is different to the style from theme, only set theme
     // to handle debug commands
-    if (currentMapStyle != getMapStyle(storedTheme))
-      setMapStyle(getMapStyle(storedTheme));
-
-    setAndroidTheme(storedTheme);
+    setMapStyle(resolveMapStyle(storedTheme));
+    setAndroidTheme(resolveCustomThemes(storedTheme));
   }
 
   private void setAndroidTheme(@NonNull String theme)
   {
+    // custom-handled themes (auto and navauto) are converted
+    // to default or night before being passed here
     if (ThemeUtils.isSystemTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
-    else if (ThemeUtils.isAutoTheme(mContext, theme))
-      {
-        //TODO: Proper behaviour
-        AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
-      }
-    else if (ThemeUtils.isNavAutoTheme(mContext, theme))
-      {
-        //TODO: Proper behaviour
-        AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
-      }
     else if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
@@ -117,13 +104,28 @@ public enum ThemeSwitcher
       Framework.nativeMarkMapStyle(style);
   }
 
-  private int getAndroidTheme(@NonNull String theme)
+  /**
+   * Convert custom themes (auto, navauto) to default ones (light, dark, follow-system)
+   * @return theme handle-able by android theme system.
+   */
+  private String resolveCustomThemes(@NonNull String theme)
   {
-    //TODO: Dynamic themes processing here, or passthrough for normal ones
-    return R.string.theme_default;
+    if (ThemeUtils.isAutoTheme(mContext, theme))
+    {
+      //TODO: Proper behaviour
+      return mContext.getResources().getString(R.string.theme_night);
+    }
+    else if (ThemeUtils.isNavAutoTheme(mContext, theme))
+    {
+      //TODO: Proper behaviour
+      return mContext.getResources().getString(R.string.theme_night);
+    }
+    else
+      // Passthrough for normal themes
+      return theme;
   }
 
-  private int getMapStyle(@NonNull String theme)
+  private int resolveMapStyle(@NonNull String theme)
   {
     @Framework.MapStyle
     int style;
@@ -148,27 +150,4 @@ public enum ThemeSwitcher
 
     return style;
   }
-
-//  private void setThemeAndMapStyle(@NonNull String theme, @Framework.MapStyle int style)
-//  {
-//    String oldTheme = Config.getCurrentUiTheme(mContext);
-//
-//    if (!theme.equals(oldTheme))
-//    {
-//      Config.setCurrentUiTheme(mContext, theme);
-//      DownloaderStatusIcon.clearCache();
-//
-//      final Activity a = MwmApplication.from(mContext).getTopActivity();
-//      if (a != null && !a.isFinishing())
-//        a.recreate();
-//    }
-//    else
-//    {
-//      // If the UI theme is not changed we just need to change the map style if needed.
-//      int currentStyle = Framework.nativeGetMapStyle();
-//      if (currentStyle == style)
-//        return;
-//      SetMapStyle(style);
-//    }
-//  }
-}
+}
\ No newline at end of file
-- 
2.45.3


From db3c88f62fa68196605097f5abdc817f5c7f18a5 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 13:37:44 +0000
Subject: [PATCH 21/49] split autotheme into new function

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 24 +++++++++++--------
 1 file changed, 14 insertions(+), 10 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 0527b235ab..631310f472 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -105,24 +105,22 @@ public enum ThemeSwitcher
   }
 
   /**
-   * Convert custom themes (auto, navauto) to default ones (light, dark, follow-system)
+   * Process custom themes (auto, navauto) to default ones (light, dark, follow-system)
    * @return theme handle-able by android theme system.
    */
   private String resolveCustomThemes(@NonNull String theme)
   {
     if (ThemeUtils.isAutoTheme(mContext, theme))
-    {
-      //TODO: Proper behaviour
-      return mContext.getResources().getString(R.string.theme_night);
-    }
+      return calcAutoTheme();
     else if (ThemeUtils.isNavAutoTheme(mContext, theme))
     {
-      //TODO: Proper behaviour
-      return mContext.getResources().getString(R.string.theme_night);
+      if (RoutingController.get().isVehicleNavigation())
+        return calcAutoTheme();
+      else
+        return mContext.getResources().getString(R.string.theme_default);
     }
-    else
-      // Passthrough for normal themes
-      return theme;
+    // Passthrough for normal themes
+    return theme;
   }
 
   private int resolveMapStyle(@NonNull String theme)
@@ -150,4 +148,10 @@ public enum ThemeSwitcher
 
     return style;
   }
+
+  private String calcAutoTheme()
+  {
+    //TODO: Proper behaviour - return light or dark based on time
+    return mContext.getResources().getString(R.string.theme_night);
+  }
 }
\ No newline at end of file
-- 
2.45.3


From 8305cd42b2c344c3df7735e95531d7ea38c34274 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 14:44:43 +0000
Subject: [PATCH 22/49] handle system-theme in resolveMapStyle

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 32 ++++++++++++++++---
 1 file changed, 28 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 631310f472..b57c72bea4 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -1,13 +1,16 @@
 package app.organicmaps.util;
 
 import android.content.Context;
+import android.content.res.Configuration;
 
 import androidx.annotation.NonNull;
+import androidx.annotation.UiThread;
 import androidx.appcompat.app.AppCompatDelegate;
 import app.organicmaps.Framework;
 import app.organicmaps.R;
 import app.organicmaps.display.DisplayManager;
 import app.organicmaps.routing.RoutingController;
+import app.organicmaps.util.log.Logger;
 
 public enum ThemeSwitcher
 {
@@ -65,7 +68,7 @@ public enum ThemeSwitcher
    *                         <code>true</code> only if the map is rendered and visible on the screen
    *                         at this moment, otherwise <code>false</code>.
    */
-  @androidx.annotation.UiThread
+  @UiThread
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
@@ -74,8 +77,10 @@ public enum ThemeSwitcher
     // Then derive map style from that, but handle debug commands
     // If current style is different to the style from theme, only set theme
     // to handle debug commands
-    setMapStyle(resolveMapStyle(storedTheme));
-    setAndroidTheme(resolveCustomThemes(storedTheme));
+    String resolvedTheme = resolveCustomThemes(storedTheme);
+    setAndroidTheme(resolvedTheme);
+    int resolvedMapStyle = resolveMapStyle(resolvedTheme);
+    setMapStyle(resolvedMapStyle);
   }
 
   private void setAndroidTheme(@NonNull String theme)
@@ -123,10 +128,27 @@ public enum ThemeSwitcher
     return theme;
   }
 
+  /**
+   * resolve the map (drape) theme
+   * @param theme MUST be theme_light or theme_dark
+   * @return drape/core compatible map style
+   */
   private int resolveMapStyle(@NonNull String theme)
   {
     @Framework.MapStyle
     int style;
+    // if follow-system, reassign theme to default/dark
+    if(ThemeUtils.isSystemTheme(mContext,theme))
+    {
+      switch (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK)
+      {
+        case Configuration.UI_MODE_NIGHT_YES:
+          theme = mContext.getResources().getString(R.string.theme_night);
+        case Configuration.UI_MODE_NIGHT_NO:
+          theme = mContext.getResources().getString(R.string.theme_default);
+      }
+    }
+    // Then
     if (ThemeUtils.isNightTheme(mContext, theme))
     {
       if (RoutingController.get().isVehicleNavigation())
@@ -136,7 +158,7 @@ public enum ThemeSwitcher
       else
         style = Framework.MAP_STYLE_DARK;
     }
-    else
+    else if (ThemeUtils.isDefaultTheme(mContext, theme))
     {
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_CLEAR;
@@ -145,6 +167,8 @@ public enum ThemeSwitcher
       else
         style = Framework.MAP_STYLE_CLEAR;
     }
+    else
+      throw new IllegalArgumentException("resolveMapStyle() should only be passed theme_light/dark/follow-system");
 
     return style;
   }
-- 
2.45.3


From a035bb3d9a0e299fab0805962116045be1ad3ac6 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 15:14:05 +0000
Subject: [PATCH 23/49] fix system theme more

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index b57c72bea4..e6af085362 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -79,7 +79,7 @@ public enum ThemeSwitcher
     // to handle debug commands
     String resolvedTheme = resolveCustomThemes(storedTheme);
     setAndroidTheme(resolvedTheme);
-    int resolvedMapStyle = resolveMapStyle(resolvedTheme);
+    int resolvedMapStyle = resolveMapStyle(resolvedTheme); // needs to be after theme is applied
     setMapStyle(resolvedMapStyle);
   }
 
@@ -138,18 +138,18 @@ public enum ThemeSwitcher
     @Framework.MapStyle
     int style;
     // if follow-system, reassign theme to default/dark
-    if(ThemeUtils.isSystemTheme(mContext,theme))
+    String resolvedTheme = theme;
+    if(ThemeUtils.isSystemTheme(mContext, theme))
     {
-      switch (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK)
+      resolvedTheme = switch (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK)
       {
-        case Configuration.UI_MODE_NIGHT_YES:
-          theme = mContext.getResources().getString(R.string.theme_night);
-        case Configuration.UI_MODE_NIGHT_NO:
-          theme = mContext.getResources().getString(R.string.theme_default);
-      }
+        case Configuration.UI_MODE_NIGHT_YES -> mContext.getResources().getString(R.string.theme_night);
+        case Configuration.UI_MODE_NIGHT_NO -> mContext.getResources().getString(R.string.theme_default);
+        default -> resolvedTheme;
+      };
     }
     // Then
-    if (ThemeUtils.isNightTheme(mContext, theme))
+    if (ThemeUtils.isNightTheme(mContext, resolvedTheme))
     {
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_DARK;
@@ -158,7 +158,7 @@ public enum ThemeSwitcher
       else
         style = Framework.MAP_STYLE_DARK;
     }
-    else if (ThemeUtils.isDefaultTheme(mContext, theme))
+    else if (ThemeUtils.isDefaultTheme(mContext, resolvedTheme))
     {
       if (RoutingController.get().isVehicleNavigation())
         style = Framework.MAP_STYLE_VEHICLE_CLEAR;
-- 
2.45.3


From 557121f55a3e30ba4aff29acb915c2422551917f Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sat, 28 Dec 2024 16:40:03 +0000
Subject: [PATCH 24/49] auto and navauto working

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 27 ++++++++++++++-----
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index e6af085362..8675c0a017 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -2,6 +2,7 @@ package app.organicmaps.util;
 
 import android.content.Context;
 import android.content.res.Configuration;
+import android.location.Location;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.UiThread;
@@ -9,6 +10,7 @@ import androidx.appcompat.app.AppCompatDelegate;
 import app.organicmaps.Framework;
 import app.organicmaps.R;
 import app.organicmaps.display.DisplayManager;
+import app.organicmaps.location.LocationHelper;
 import app.organicmaps.routing.RoutingController;
 import app.organicmaps.util.log.Logger;
 
@@ -116,11 +118,11 @@ public enum ThemeSwitcher
   private String resolveCustomThemes(@NonNull String theme)
   {
     if (ThemeUtils.isAutoTheme(mContext, theme))
-      return calcAutoTheme();
+      return calcAutoTheme(theme);
     else if (ThemeUtils.isNavAutoTheme(mContext, theme))
     {
       if (RoutingController.get().isVehicleNavigation())
-        return calcAutoTheme();
+        return calcAutoTheme(theme);
       else
         return mContext.getResources().getString(R.string.theme_default);
     }
@@ -168,14 +170,27 @@ public enum ThemeSwitcher
         style = Framework.MAP_STYLE_CLEAR;
     }
     else
-      throw new IllegalArgumentException("resolveMapStyle() should only be passed theme_light/dark/follow-system");
+      throw new IllegalArgumentException(resolvedTheme+" passed, only follow-system/theme_light/dark are allowed.");
 
     return style;
   }
 
-  private String calcAutoTheme()
+  /**
+   * determine light/dark theme based on time and location
+   * @param currentTheme needed as a fallback
+   * @return theme_light/dark string
+   */
+  private String calcAutoTheme(String currentTheme)
   {
-    //TODO: Proper behaviour - return light or dark based on time
-    return mContext.getResources().getString(R.string.theme_night);
+    String defaultTheme = mContext.getResources().getString(R.string.theme_default);
+    String nightTheme = mContext.getResources().getString(R.string.theme_night);
+    Location last = LocationHelper.from(mContext).getSavedLocation();
+    if (last != null)
+    {
+      long currentTime = System.currentTimeMillis() / 1000;
+      boolean day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
+      currentTheme = (day ? defaultTheme : nightTheme);
+    }
+    return currentTheme;
   }
 }
\ No newline at end of file
-- 
2.45.3


From 50cbcd0171b3a2a83c65ae6ce803ecd4817c4526 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 13:58:35 +0000
Subject: [PATCH 25/49] add time-based fallback for auto

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 27 ++++++++++++-------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 8675c0a017..46dfa95923 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -7,6 +7,9 @@ import android.location.Location;
 import androidx.annotation.NonNull;
 import androidx.annotation.UiThread;
 import androidx.appcompat.app.AppCompatDelegate;
+
+import java.util.Calendar;
+
 import app.organicmaps.Framework;
 import app.organicmaps.R;
 import app.organicmaps.display.DisplayManager;
@@ -118,11 +121,12 @@ public enum ThemeSwitcher
   private String resolveCustomThemes(@NonNull String theme)
   {
     if (ThemeUtils.isAutoTheme(mContext, theme))
-      return calcAutoTheme(theme);
+      return calcAutoTheme();
     else if (ThemeUtils.isNavAutoTheme(mContext, theme))
     {
+      // nav-auto always falls back to light mode
       if (RoutingController.get().isVehicleNavigation())
-        return calcAutoTheme(theme);
+        return calcAutoTheme();
       else
         return mContext.getResources().getString(R.string.theme_default);
     }
@@ -176,21 +180,26 @@ public enum ThemeSwitcher
   }
 
   /**
-   * determine light/dark theme based on time and location
-   * @param currentTheme needed as a fallback
+   * determine light/dark theme based on time and location,
+   * and falls back to time-based (06:00-18:00) when no location fix
    * @return theme_light/dark string
    */
-  private String calcAutoTheme(String currentTheme)
+  private String calcAutoTheme()
   {
     String defaultTheme = mContext.getResources().getString(R.string.theme_default);
     String nightTheme = mContext.getResources().getString(R.string.theme_night);
     Location last = LocationHelper.from(mContext).getSavedLocation();
+    long currentTime = System.currentTimeMillis() / 1000;
+    boolean day;
     if (last != null)
+      day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
+    else
     {
-      long currentTime = System.currentTimeMillis() / 1000;
-      boolean day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
-      currentTheme = (day ? defaultTheme : nightTheme);
+      currentTime = Calendar.getInstance().get(Calendar.HOUR_OF_DAY);
+      Logger.e("HELLO", String.valueOf(currentTime));
+      day = (currentTime < 18 && currentTime > 6);
     }
-    return currentTheme;
+    // Finally
+    return (day ? defaultTheme : nightTheme);
   }
 }
\ No newline at end of file
-- 
2.45.3


From 685c77df2a1d4652f31d8a9c7052d70495067f14 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 14:19:35 +0000
Subject: [PATCH 26/49] comment cleanup

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 57 ++++---------------
 .../java/app/organicmaps/util/ThemeUtils.java | 19 -------
 2 files changed, 12 insertions(+), 64 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 46dfa95923..eb94d7c5c4 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -23,38 +23,6 @@ public enum ThemeSwitcher
 
   private static boolean mRendererActive = false;
 
-//  private final Runnable mAutoThemeChecker = new Runnable()
-//  {
-//    @Override
-//    public void run()
-//    {
-//      String nightTheme = MwmApplication.from(mContext).getString(R.string.theme_night);
-//      String defaultTheme = MwmApplication.from(mContext).getString(R.string.theme_default);
-//      String theme = defaultTheme;
-//      Location last = LocationHelper.from(mContext).getSavedLocation();
-//
-//      boolean navAuto = RoutingController.get().isNavigating() && ThemeUtils.isNavAutoTheme(mContext);
-//
-//      if (navAuto || ThemeUtils.isAutoTheme(mContext))
-//      {
-//        if (last == null)
-//          theme = Config.getCurrentUiTheme(mContext);
-//        else
-//        {
-//          long currentTime = System.currentTimeMillis() / 1000;
-//          boolean day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
-//          theme = (day ? defaultTheme : nightTheme);
-//        }
-//      }
-//
-//      setThemeAndMapStyle(theme);
-//      UiThread.cancelDelayedTasks(mAutoThemeChecker);
-//
-//      if (navAuto || ThemeUtils.isAutoTheme(mContext))
-//        UiThread.runLater(mAutoThemeChecker, CHECK_INTERVAL_MS);
-//    }
-//  };
-
   @SuppressWarnings("NotNullFieldNotInitialized")
   @NonNull
   private Context mContext;
@@ -77,14 +45,12 @@ public enum ThemeSwitcher
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
-    String storedTheme = Config.getThemeSettings(mContext); // follow-system etc
-    // Resolve dynamic themes (follow-system, nav-auto etc.) to light or dark
-    // Then derive map style from that, but handle debug commands
-    // If current style is different to the style from theme, only set theme
-    // to handle debug commands
+    String storedTheme = Config.getThemeSettings(mContext);
+    // TODO: Handle debug commands
     String resolvedTheme = resolveCustomThemes(storedTheme);
     setAndroidTheme(resolvedTheme);
-    int resolvedMapStyle = resolveMapStyle(resolvedTheme); // needs to be after theme is applied
+    // Depends on Android theme being set due to follow-system, so has to be after setAndroidTheme.
+    int resolvedMapStyle = resolveMapStyle(resolvedTheme);
     setMapStyle(resolvedMapStyle);
   }
 
@@ -124,7 +90,7 @@ public enum ThemeSwitcher
       return calcAutoTheme();
     else if (ThemeUtils.isNavAutoTheme(mContext, theme))
     {
-      // nav-auto always falls back to light mode
+      // navauto always falls back to light mode
       if (RoutingController.get().isVehicleNavigation())
         return calcAutoTheme();
       else
@@ -135,7 +101,7 @@ public enum ThemeSwitcher
   }
 
   /**
-   * resolve the map (drape) theme
+   * Resolve the map (drape) style from a resolved theme string.
    * @param theme MUST be theme_light or theme_dark
    * @return drape/core compatible map style
    */
@@ -143,10 +109,11 @@ public enum ThemeSwitcher
   {
     @Framework.MapStyle
     int style;
-    // if follow-system, reassign theme to default/dark
     String resolvedTheme = theme;
-    if(ThemeUtils.isSystemTheme(mContext, theme))
+    // First convert the android-but-dynamic follow system theme.
+    if (ThemeUtils.isSystemTheme(mContext, theme))
     {
+      // Depends on android theme already being calculated and set.
       resolvedTheme = switch (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK)
       {
         case Configuration.UI_MODE_NIGHT_YES -> mContext.getResources().getString(R.string.theme_night);
@@ -154,7 +121,7 @@ public enum ThemeSwitcher
         default -> resolvedTheme;
       };
     }
-    // Then
+    // Then return a dark/light map style taking into account variants.
     if (ThemeUtils.isNightTheme(mContext, resolvedTheme))
     {
       if (RoutingController.get().isVehicleNavigation())
@@ -180,8 +147,8 @@ public enum ThemeSwitcher
   }
 
   /**
-   * determine light/dark theme based on time and location,
-   * and falls back to time-based (06:00-18:00) when no location fix
+   * Determine light/dark theme based on time and location,
+   * or fall back to time-based (06:00-18:00) when there's no location fix
    * @return theme_light/dark string
    */
   private String calcAutoTheme()
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index 854c47ce19..d4ec7d4e43 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -44,25 +44,6 @@ public final class ThemeUtils
     return VALUE_BUFFER.resourceId;
   }
 
-//  public static String getUiTheme(@NonNull Context context)
-//  {
-//    String nightTheme = context.getString(R.string.theme_night);
-//    String defaultTheme = context.getString(R.string.theme_default);
-//
-//    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_YES)
-//      return nightTheme;
-//
-//    if (AppCompatDelegate.getDefaultNightMode() == AppCompatDelegate.MODE_NIGHT_NO)
-//      return defaultTheme;
-//
-//    int nightModeFlags = context.getResources()
-//                                .getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
-//    if (nightModeFlags == Configuration.UI_MODE_NIGHT_YES)
-//      return nightTheme;
-//    else
-//      return defaultTheme;
-//  }
-
   public static boolean isDefaultTheme(@NonNull Context context)
   {
     return isDefaultTheme(context, Config.getThemeSettings(context));
-- 
2.45.3


From 8c32a35806ca886e3f2e6b46196f425aae52039a Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 14:42:21 +0000
Subject: [PATCH 27/49] throw error if bad theme passed to setAndroidTheme

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../java/app/organicmaps/util/ThemeSwitcher.java    | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index eb94d7c5c4..6f50da4a29 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -54,16 +54,21 @@ public enum ThemeSwitcher
     setMapStyle(resolvedMapStyle);
   }
 
+  /**
+   * Applies the android theme
+   * @param theme MUST be follow-system/theme_light/dark
+   */
   private void setAndroidTheme(@NonNull String theme)
   {
-    // custom-handled themes (auto and navauto) are converted
-    // to default or night before being passed here
     if (ThemeUtils.isSystemTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
     else if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
+    else
+      throw new IllegalArgumentException(theme+" passed, but only follow-system/theme_light/dark are allowed.");
+
   }
 
   private void setMapStyle(@Framework.MapStyle int style)
@@ -102,7 +107,7 @@ public enum ThemeSwitcher
 
   /**
    * Resolve the map (drape) style from a resolved theme string.
-   * @param theme MUST be theme_light or theme_dark
+   * @param theme MUST be follow-system/theme_light/dark
    * @return drape/core compatible map style
    */
   private int resolveMapStyle(@NonNull String theme)
@@ -141,7 +146,7 @@ public enum ThemeSwitcher
         style = Framework.MAP_STYLE_CLEAR;
     }
     else
-      throw new IllegalArgumentException(resolvedTheme+" passed, only follow-system/theme_light/dark are allowed.");
+      throw new IllegalArgumentException(resolvedTheme+" passed, but only follow-system/theme_light/dark are allowed.");
 
     return style;
   }
-- 
2.45.3


From a85b84c72082da921c45ff7a5538544866dc18aa Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 14:50:31 +0000
Subject: [PATCH 28/49] clean up manifest

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 android/app/src/main/AndroidManifest.xml | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
index f252e36e8d..1fc509c3b3 100644
--- a/android/app/src/main/AndroidManifest.xml
+++ b/android/app/src/main/AndroidManifest.xml
@@ -343,8 +343,6 @@
       </intent-filter>
 
     </activity>
-    <activity
-        android:name="app.organicmaps.base.BaseMwmFragmentActivity" />
 
     <activity
         android:name="app.organicmaps.DownloadResourcesLegacyActivity"
@@ -452,13 +450,13 @@
     <activity
       android:name="app.organicmaps.bookmarks.BookmarkCategorySettingsActivity"
       android:label="@string/edit"
-      android:windowSoftInputMode="stateVisible" />
+      android:windowSoftInputMode="stateVisible"/>
     <activity
       android:name="app.organicmaps.widget.placepage.PlaceDescriptionActivity"
-      android:label="@string/place_description_title" />
+      android:label="@string/place_description_title"/>
     <activity
       android:name="app.organicmaps.settings.DrivingOptionsActivity"
-      android:label="@string/driving_options_title" />
+      android:label="@string/driving_options_title"/>
     <activity
       android:name="app.organicmaps.MapPlaceholderActivity" />
     <activity
-- 
2.45.3


From 48916d6e06d6ae0394fb0c95faa50a84055a3750 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 15:01:40 +0000
Subject: [PATCH 29/49] remove commented out stuff

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../DownloadResourcesLegacyActivity.java          |  7 -------
 .../organicmaps/base/BaseMwmFragmentActivity.java | 15 ---------------
 .../bookmarks/BookmarkCategoriesActivity.java     |  8 --------
 .../bookmarks/BookmarkListActivity.java           |  8 --------
 4 files changed, 38 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java b/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java
index a873f763aa..fc486abecd 100644
--- a/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java
+++ b/android/app/src/main/java/app/organicmaps/DownloadResourcesLegacyActivity.java
@@ -450,13 +450,6 @@ public class DownloadResourcesLegacyActivity extends BaseMwmFragmentActivity
         .show();
   }
 
-//  @Override
-//  @StyleRes
-//  public int getThemeResourceId(@NonNull String theme)
-//  {
-//    return R.style.MwmTheme_DownloadResourcesLegacy;
-//  }
-
   private static native int nativeGetBytesToDownload();
   private static native int nativeStartNextFileDownload(Listener listener);
   private static native void nativeCancelCurrentFile();
diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
index b4ff839308..9292686a99 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
@@ -39,21 +39,6 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   @NonNull
   private String mThemeName;
 
-// TODO: need to set theme with android system, not custom
-//  @StyleRes
-//  protected int getThemeResourceId(@NonNull String theme)
-//  {
-//    Context context = getApplicationContext();
-//
-//    if (ThemeUtils.isDefaultTheme(context, theme))
-//        return R.style.MwmTheme;
-//
-//    if (ThemeUtils.isNightTheme(context, theme))
-//      return R.style.MwmTheme_Night;
-//
-//    throw new IllegalArgumentException("Attempt to apply unsupported theme: " + theme);
-//  }
-
   /**
    * Shows splash screen and initializes the core in case when it was not initialized.
    *
diff --git a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java
index 76068e7375..8fed8bfe35 100644
--- a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java
+++ b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkCategoriesActivity.java
@@ -39,14 +39,6 @@ public class BookmarkCategoriesActivity extends BaseToolbarActivity
 
     super.onPause();
   }
-
-//  @Override
-//  @StyleRes
-//  public int getThemeResourceId(@NonNull String theme)
-//  {
-//    return ThemeUtils.getWindowBgThemeResourceId(getApplicationContext(), theme);
-//  }
-
   @Override
   protected Class<? extends Fragment> getFragmentClass()
   {
diff --git a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java
index 169140b615..63c7dc3713 100644
--- a/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java
+++ b/android/app/src/main/java/app/organicmaps/bookmarks/BookmarkListActivity.java
@@ -38,14 +38,6 @@ public class BookmarkListActivity extends BaseToolbarActivity
 
     super.onPause();
   }
-
-//  @Override
-//  @StyleRes
-//  public int getThemeResourceId(@NonNull String theme)
-//  {
-//    return ThemeUtils.getCardBgThemeResourceId(getApplicationContext(), theme);
-//  }
-
   @Override
   protected Class<? extends Fragment> getFragmentClass()
   {
-- 
2.45.3


From a577a2491178b130863aa9d1b7a3de17f81e349f Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 15:27:43 +0000
Subject: [PATCH 30/49] cleanup comments

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../main/java/app/organicmaps/MwmActivity.java    | 15 ---------------
 .../organicmaps/base/BaseMwmFragmentActivity.java |  2 +-
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/MwmActivity.java b/android/app/src/main/java/app/organicmaps/MwmActivity.java
index 262bdbb65f..083e0054ad 100644
--- a/android/app/src/main/java/app/organicmaps/MwmActivity.java
+++ b/android/app/src/main/java/app/organicmaps/MwmActivity.java
@@ -475,21 +475,6 @@ public class MwmActivity extends BaseMwmFragmentActivity
     }
   }
 
-//  @Override
-//  @StyleRes
-//  protected int getThemeResourceId(@NonNull String theme)
-//  {
-//    Context context = getApplicationContext();
-//
-//    if (ThemeUtils.isDefaultTheme(context, theme))
-//      return R.style.MwmTheme_MainActivity;
-//
-//    if (ThemeUtils.isNightTheme(context, theme))
-//      return R.style.MwmTheme_Night_MainActivity;
-//
-//    return super.getThemeResourceId(theme);
-//  }
-
   @Override
   public void onDisplayChangedToCar(@NonNull Runnable onTaskFinishedCallback)
   {
diff --git a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
index 9292686a99..60c004565b 100644
--- a/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
+++ b/android/app/src/main/java/app/organicmaps/base/BaseMwmFragmentActivity.java
@@ -51,7 +51,6 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
   {
     super.onCreate(savedInstanceState);
     mThemeName = Config.getThemeSettings(getApplicationContext());
-    //setTheme(getThemeResourceId(mThemeName));
     EdgeToEdge.enable(this, SystemBarStyle.dark(Color.TRANSPARENT));
     RtlUtils.manageRtl(this);
     if (!MwmApplication.from(this).arePlatformAndCoreInitialized())
@@ -112,6 +111,7 @@ public abstract class BaseMwmFragmentActivity extends AppCompatActivity
     super.onPostResume();
     if (!mThemeName.equals(Config.getThemeSettings(getApplicationContext())))
     {
+      // TODO: is this still needed?
       // Workaround described in https://code.google.com/p/android/issues/detail?id=93731
       UiThread.runLater(this::recreate);
     }
-- 
2.45.3


From 8a4468ac1d5d07956aad6d6f40a7d03a4765828f Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 15:47:16 +0000
Subject: [PATCH 31/49] remove manual theme setting in timepicker

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/editor/HoursMinutesPickerFragment.java   | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java b/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java
index 948327d89c..f7c3480220 100644
--- a/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/HoursMinutesPickerFragment.java
@@ -138,14 +138,9 @@ public class HoursMinutesPickerFragment extends BaseMwmDialogFragment
     mTabs = root.findViewById(R.id.tabs);
     TextView tabView = (TextView) inflater.inflate(R.layout.tab_timepicker, mTabs, false);
     tabView.setText(getResources().getString(R.string.editor_time_from));
-    final ColorStateList textColor = AppCompatResources.getColorStateList(requireContext(),
-        ThemeUtils.isNightTheme(requireContext()) ? R.color.accent_color_selector_night
-                                                  : R.color.accent_color_selector);
-    tabView.setTextColor(textColor);
     mTabs.addTab(mTabs.newTab().setCustomView(tabView), true);
     tabView = (TextView) inflater.inflate(R.layout.tab_timepicker, mTabs, false);
     tabView.setText(getResources().getString(R.string.editor_time_to));
-    tabView.setTextColor(textColor);
     mTabs.addTab(mTabs.newTab().setCustomView(tabView), true);
     mTabs.setOnTabSelectedListener(new TabLayout.OnTabSelectedListener()
     {
-- 
2.45.3


From 881e86dd93fb075a7108919738778adcca1a07ec Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 16:30:39 +0000
Subject: [PATCH 32/49] set help icon tint with xml, not programatically

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../java/app/organicmaps/maplayer/MapButtonsController.java    | 3 ---
 android/app/src/main/res/layout/map_buttons_help.xml           | 3 ++-
 android/app/src/main/res/values-night/themes-base.xml          | 1 +
 android/app/src/main/res/values/themes-attrs.xml               | 1 +
 android/app/src/main/res/values/themes-base.xml                | 1 +
 5 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/maplayer/MapButtonsController.java b/android/app/src/main/java/app/organicmaps/maplayer/MapButtonsController.java
index e1d4c125b7..5bd7965c37 100644
--- a/android/app/src/main/java/app/organicmaps/maplayer/MapButtonsController.java
+++ b/android/app/src/main/java/app/organicmaps/maplayer/MapButtonsController.java
@@ -106,9 +106,6 @@ public class MapButtonsController extends Fragment
         helpButton.setImageResource(R.drawable.ic_christmas_tree);
       else
         helpButton.setImageResource(R.drawable.logo);
-      // Keep this button colorful in normal theme.
-      if (!ThemeUtils.isNightTheme(requireContext()))
-        helpButton.getDrawable().setTintList(null);
     }
 
     final View zoomFrame = mFrame.findViewById(R.id.zoom_buttons_container);
diff --git a/android/app/src/main/res/layout/map_buttons_help.xml b/android/app/src/main/res/layout/map_buttons_help.xml
index 563961dd5d..f7edc00fc7 100644
--- a/android/app/src/main/res/layout/map_buttons_help.xml
+++ b/android/app/src/main/res/layout/map_buttons_help.xml
@@ -6,4 +6,5 @@
   style="@style/MwmWidget.MapButton.Square"
   android:contentDescription="@string/help"
   app:shapeAppearanceOverlay="@style/MwmWidget.MapButton.Square"
-  app:srcCompat="@drawable/ic_question_mark" />
\ No newline at end of file
+  app:srcCompat="@drawable/logo"
+  android:tint="?helpIconTint"/>
\ No newline at end of file
diff --git a/android/app/src/main/res/values-night/themes-base.xml b/android/app/src/main/res/values-night/themes-base.xml
index d3158b3fe4..968b7f479e 100644
--- a/android/app/src/main/res/values-night/themes-base.xml
+++ b/android/app/src/main/res/values-night/themes-base.xml
@@ -38,6 +38,7 @@
     <item name="iconTintDisabled">@color/white_12</item>
     <item name="iconTintActive">@color/yellow</item>
     <item name="iconTintLight">@color/icon_tint_light_night</item>
+    <item name="helpIconTint">@color/white_secondary</item>
 
     <item name="secondary">@color/text_light_hint</item>
     <item name="dividerHorizontal">@color/divider_night</item>
diff --git a/android/app/src/main/res/values/themes-attrs.xml b/android/app/src/main/res/values/themes-attrs.xml
index 75a651c16c..4c13463cda 100644
--- a/android/app/src/main/res/values/themes-attrs.xml
+++ b/android/app/src/main/res/values/themes-attrs.xml
@@ -15,6 +15,7 @@
     <attr name="iconTintDisabled" format="color" />
     <attr name="iconTintActive" format="color" />
     <attr name="iconTintLight" format="color" />
+    <attr name="helpIconTint" format="color" />
     <attr name="ppBackground" format="color" />
     <attr name="ppButtonsBackground" format="color" />
     <attr name="navNextTurnFrame" format="reference" />
diff --git a/android/app/src/main/res/values/themes-base.xml b/android/app/src/main/res/values/themes-base.xml
index a822323ea2..8f0945efca 100644
--- a/android/app/src/main/res/values/themes-base.xml
+++ b/android/app/src/main/res/values/themes-base.xml
@@ -36,6 +36,7 @@
     <item name="iconTintDisabled">@color/black_12</item>
     <item name="iconTintActive">@color/yellow</item>
     <item name="iconTintLight">@color/icon_tint_light</item>
+    <item name="helpIconTint">@android:color/transparent</item>
 
     <item name="secondary">@color/text_dark_hint</item>
     <item name="dividerHorizontal">@color/divider</item>
-- 
2.45.3


From 3f4721bbd9ee73b34ac9d50093fdf0c74ce06041 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 17:51:33 +0000
Subject: [PATCH 33/49] set routing buttons colour with xml, not
 programatically

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../organicmaps/widget/RoutingToolbarButton.java    |  6 ++----
 .../main/res/color/routing_toolbar_icon_tint.xml    |  2 +-
 .../res/color/routing_toolbar_icon_tint_night.xml   | 11 -----------
 .../res/drawable/routing_toolbar_button_active.xml  |  2 +-
 .../res/drawable/routing_toolbar_button_night.xml   | 13 -------------
 .../res/drawable/routing_toolbar_button_normal.xml  |  2 +-
 .../routing_toolbar_button_normal_night.xml         |  7 -------
 .../app/src/main/res/values-night/themes-base.xml   |  3 +++
 android/app/src/main/res/values/themes-attrs.xml    |  3 +++
 android/app/src/main/res/values/themes-base.xml     |  4 ++++
 10 files changed, 15 insertions(+), 38 deletions(-)
 delete mode 100644 android/app/src/main/res/color/routing_toolbar_icon_tint_night.xml
 delete mode 100644 android/app/src/main/res/drawable/routing_toolbar_button_night.xml
 delete mode 100644 android/app/src/main/res/drawable/routing_toolbar_button_normal_night.xml

diff --git a/android/app/src/main/java/app/organicmaps/widget/RoutingToolbarButton.java b/android/app/src/main/java/app/organicmaps/widget/RoutingToolbarButton.java
index cfad34db1f..00ba4381f6 100644
--- a/android/app/src/main/java/app/organicmaps/widget/RoutingToolbarButton.java
+++ b/android/app/src/main/java/app/organicmaps/widget/RoutingToolbarButton.java
@@ -37,10 +37,8 @@ public class RoutingToolbarButton extends AppCompatRadioButton
 
   private void initView()
   {
-    setBackgroundResource(ThemeUtils.isNightTheme(getContext()) ? R.drawable.routing_toolbar_button_night
-                                                                : R.drawable.routing_toolbar_button);
-    setButtonTintList(ThemeUtils.isNightTheme(getContext()) ? R.color.routing_toolbar_icon_tint_night
-                                                            : R.color.routing_toolbar_icon_tint);
+    setBackgroundResource(R.drawable.routing_toolbar_button);
+    setButtonTintList(R.color.routing_toolbar_icon_tint);
   }
 
   public void progress()
diff --git a/android/app/src/main/res/color/routing_toolbar_icon_tint.xml b/android/app/src/main/res/color/routing_toolbar_icon_tint.xml
index c324c3fdc0..0eb6cc00f4 100644
--- a/android/app/src/main/res/color/routing_toolbar_icon_tint.xml
+++ b/android/app/src/main/res/color/routing_toolbar_icon_tint.xml
@@ -2,7 +2,7 @@
 <selector xmlns:android="http://schemas.android.com/apk/res/android">
   <item
     android:state_activated="true"
-    android:color="@color/routing_button_activated_tint"/>
+    android:color="?routingToolbarButtonIconActive"/>
   <item
     android:state_pressed="true"
     android:color="@color/routing_button_pressed_tint"/>
diff --git a/android/app/src/main/res/color/routing_toolbar_icon_tint_night.xml b/android/app/src/main/res/color/routing_toolbar_icon_tint_night.xml
deleted file mode 100644
index 883a8200a2..0000000000
--- a/android/app/src/main/res/color/routing_toolbar_icon_tint_night.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<selector xmlns:android="http://schemas.android.com/apk/res/android">
-  <item
-    android:state_activated="true"
-    android:color="@color/routing_button_activated_tint_night"/>
-  <item
-    android:state_pressed="true"
-    android:color="@color/routing_button_pressed_tint"/>
-  <item
-    android:color="@color/routing_button_tint"/>
-</selector>
diff --git a/android/app/src/main/res/drawable/routing_toolbar_button_active.xml b/android/app/src/main/res/drawable/routing_toolbar_button_active.xml
index 1d422d4e2f..93f5580705 100644
--- a/android/app/src/main/res/drawable/routing_toolbar_button_active.xml
+++ b/android/app/src/main/res/drawable/routing_toolbar_button_active.xml
@@ -3,5 +3,5 @@
        android:shape="oval"
        android:height="40dp"
        android:width="40dp">
-  <solid android:color="@color/white_primary"/>
+  <solid android:color="?routingToolbarButtonActive"/>
 </shape>
diff --git a/android/app/src/main/res/drawable/routing_toolbar_button_night.xml b/android/app/src/main/res/drawable/routing_toolbar_button_night.xml
deleted file mode 100644
index 0be952a4b4..0000000000
--- a/android/app/src/main/res/drawable/routing_toolbar_button_night.xml
+++ /dev/null
@@ -1,13 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<ripple xmlns:android="http://schemas.android.com/apk/res/android"
-        android:color="?attr/colorControlHighlight">
-  <item>
-    <selector>
-      <item
-        android:state_activated="true"
-        android:drawable="@drawable/routing_toolbar_button_active"/>
-      <item
-        android:drawable="@drawable/routing_toolbar_button_normal_night"/>
-    </selector>
-  </item>
-</ripple>
diff --git a/android/app/src/main/res/drawable/routing_toolbar_button_normal.xml b/android/app/src/main/res/drawable/routing_toolbar_button_normal.xml
index ebfa6cbb6a..35a47fc6a0 100644
--- a/android/app/src/main/res/drawable/routing_toolbar_button_normal.xml
+++ b/android/app/src/main/res/drawable/routing_toolbar_button_normal.xml
@@ -3,5 +3,5 @@
        android:shape="oval"
        android:height="40dp"
        android:width="40dp">
-  <solid android:color="@color/bg_primary_dark"/>
+  <solid android:color="?routingToolbarButton"/>
 </shape>
diff --git a/android/app/src/main/res/drawable/routing_toolbar_button_normal_night.xml b/android/app/src/main/res/drawable/routing_toolbar_button_normal_night.xml
deleted file mode 100644
index 47906aacb4..0000000000
--- a/android/app/src/main/res/drawable/routing_toolbar_button_normal_night.xml
+++ /dev/null
@@ -1,7 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<shape xmlns:android="http://schemas.android.com/apk/res/android"
-       android:shape="oval"
-       android:height="40dp"
-       android:width="40dp">
-  <solid android:color="@color/bg_primary_dark_night"/>
-</shape>
diff --git a/android/app/src/main/res/values-night/themes-base.xml b/android/app/src/main/res/values-night/themes-base.xml
index 968b7f479e..11d4d6eb76 100644
--- a/android/app/src/main/res/values-night/themes-base.xml
+++ b/android/app/src/main/res/values-night/themes-base.xml
@@ -81,6 +81,9 @@
     <item name="navigationTheme">@style/MwmTheme.Navigation</item>
 
     <item name="routingButtonHint">@color/routing_button_tint</item>
+    <item name="routingToolbarButtonIconActive">@color/routing_button_activated_tint_night</item>
+    <item name="routingToolbarButtonActive">@color/routing_button_tint</item>
+    <item name="routingToolbarButton">@color/bg_primary_dark_night</item>
 
     <item name="android:listDivider">@drawable/list_divider_night</item>
 
diff --git a/android/app/src/main/res/values/themes-attrs.xml b/android/app/src/main/res/values/themes-attrs.xml
index 4c13463cda..d8ee76d584 100644
--- a/android/app/src/main/res/values/themes-attrs.xml
+++ b/android/app/src/main/res/values/themes-attrs.xml
@@ -43,6 +43,9 @@
     <attr name="downloaderTheme" format="reference" />
     <attr name="navigationTheme" format="reference" />
     <attr name="routingButtonHint" format="color" />
+    <attr name="routingToolbarButtonIconActive" format="color" />
+    <attr name="routingToolbarButtonActive" format="color" />
+    <attr name="routingToolbarButton" format="color" />
     <attr name="drivingOptionsViewBg" format="color" />
     <attr name="transitPedestrianBackground" format="color" />
     <attr name="transitRulerBackground" format="color" />
diff --git a/android/app/src/main/res/values/themes-base.xml b/android/app/src/main/res/values/themes-base.xml
index 8f0945efca..6ae504024b 100644
--- a/android/app/src/main/res/values/themes-base.xml
+++ b/android/app/src/main/res/values/themes-base.xml
@@ -79,6 +79,10 @@
     <item name="navigationTheme">@style/MwmTheme.Navigation</item>
 
     <item name="routingButtonHint">@color/routing_button_tint</item>
+    <item name="routingToolbarButtonIconActive">@color/routing_button_activated_tint</item>
+    <item name="routingToolbarButtonActive">@color/routing_button_tint</item>
+    <item name="routingToolbarButton">@color/bg_primary_dark</item>
+
 
     <item name="preferenceTheme">@style/PreferenceThemeOverlay.v14.Material</item>
 
-- 
2.45.3


From ab0633ca261a19f40ad0b21fc90ad69050dd5366 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 18:01:20 +0000
Subject: [PATCH 34/49] trafficbutton - comment out isNightTheme usages

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../maplayer/traffic/widget/TrafficButton.java    | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java b/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
index edfd31a185..7d254867c0 100644
--- a/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
+++ b/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
@@ -46,22 +46,25 @@ public class TrafficButton
   void turnOff()
   {
     stopWaitingAnimation();
-    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
-                                                                           : R.drawable.ic_traffic_on);
+// Don't set theme programatically - use an xml with a night variant instead.
+//    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
+//                                                                           : R.drawable.ic_traffic_on);
   }
 
   void turnOn()
   {
     stopWaitingAnimation();
-    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
-                                                                           : R.drawable.ic_traffic_on);
+// Don't set theme programatically - use an xml with a night variant instead.
+//    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
+//                                                                           : R.drawable.ic_traffic_on);
   }
 
   void markAsOutdated()
   {
     stopWaitingAnimation();
-    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_outdated_night
-                                                                           : R.drawable.ic_traffic_outdated);
+// Don't set theme programatically - use an xml with a night variant instead.
+//    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_outdated_night
+//                                                                           : R.drawable.ic_traffic_outdated);
   }
 
   void startWaitingAnimation()
-- 
2.45.3


From d5bb82c5dea1040d50f41a22a5b937396c9c4085 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 18:18:22 +0000
Subject: [PATCH 35/49] don't set settings card background programatically

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/settings/BaseXmlSettingsFragment.java  | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/settings/BaseXmlSettingsFragment.java b/android/app/src/main/java/app/organicmaps/settings/BaseXmlSettingsFragment.java
index 2371877ae9..e4037dd1f0 100644
--- a/android/app/src/main/java/app/organicmaps/settings/BaseXmlSettingsFragment.java
+++ b/android/app/src/main/java/app/organicmaps/settings/BaseXmlSettingsFragment.java
@@ -50,13 +50,6 @@ abstract class BaseXmlSettingsFragment extends PreferenceFragmentCompat
   {
     super.onViewCreated(view, savedInstanceState);
 
-    int color;
-    if (ThemeUtils.isDefaultTheme(requireContext()))
-      color = ContextCompat.getColor(requireContext(), R.color.bg_cards);
-    else
-      color = ContextCompat.getColor(requireContext(), R.color.bg_cards_night);
-    view.setBackgroundColor(color);
-
     RecyclerView recyclerView = getListView();
     ViewCompat.setOnApplyWindowInsetsListener(recyclerView, new ScrollableContentInsetsListener(recyclerView));
   }
-- 
2.45.3


From 766014752e1d3ec01db7ae3907bafc31d0acf35e Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 19:59:41 +0000
Subject: [PATCH 36/49] use night drawable variants instead of getting category
 icons programatically

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/search/CategoriesAdapter.java   |   3 ---
 .../anim_traffic_loading.xml}                       |   0
 .../bg_altitude.xml}                                |   0
 .../bg_nav_next_next_turn.xml}                      |   0
 .../bg_nav_next_turn.xml}                           |   0
 .../bg_point_desc.xml}                              |   0
 .../bg_rounded_rect.xml}                            |   0
 .../bg_search_wheel_background_rect.xml}            |   0
 .../bg_search_wheel_background_round.xml}           |   0
 .../bg_your_location_pin.xml}                       |   0
 .../button_night.xml => drawable-night/button.xml}  |   0
 .../button_accent.xml}                              |   0
 .../button_accent_disabled.xml}                     |   0
 .../button_accent_internal.xml}                     |   0
 .../button_accent_normal.xml}                       |   0
 .../button_accent_pressed.xml}                      |   0
 .../button_disabled.xml}                            |   0
 .../button_normal.xml}                              |   0
 .../button_pressed.xml}                             |   0
 .../dot_divider.xml}                                |   0
 .../ic_category_atm.xml}                            |   0
 .../ic_category_bank.xml}                           |   0
 .../ic_category_children.xml}                       |   0
 .../ic_category_eat.xml}                            |   0
 .../ic_category_entertainment.xml}                  |   0
 .../ic_category_food.xml}                           |   0
 .../ic_category_fuel.xml}                           |   0
 .../ic_category_hospital.xml}                       |   0
 .../ic_category_hotel.xml}                          |   0
 .../ic_category_luggagehero.xml}                    |   0
 .../ic_category_nightlife.xml}                      |   0
 .../ic_category_parking.xml}                        |   0
 .../ic_category_pharmacy.xml}                       |   0
 .../ic_category_police.xml}                         |   0
 .../ic_category_post.xml}                           |   0
 .../ic_category_recycling.xml}                      |   0
 .../ic_category_rv.xml}                             |   0
 .../ic_category_secondhand.xml}                     |   0
 .../ic_category_shopping.xml}                       |   0
 .../ic_category_toilet.xml}                         |   0
 .../ic_category_tourism.xml}                        |   0
 .../ic_category_transport.xml}                      |   0
 .../ic_category_water.xml}                          |   0
 .../ic_category_wifi.xml}                           |   0
 .../ic_menu_location_pending.png}                   | Bin
 .../list_divider.xml}                               |   0
 46 files changed, 3 deletions(-)
 rename android/app/src/main/res/{drawable/anim_traffic_loading_night.xml => drawable-night/anim_traffic_loading.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_altitude_night.xml => drawable-night/bg_altitude.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_nav_next_next_turn_night.xml => drawable-night/bg_nav_next_next_turn.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_nav_next_turn_night.xml => drawable-night/bg_nav_next_turn.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_point_desc_night.xml => drawable-night/bg_point_desc.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_rounded_rect_night.xml => drawable-night/bg_rounded_rect.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_search_wheel_background_rect_night.xml => drawable-night/bg_search_wheel_background_rect.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_search_wheel_background_round_night.xml => drawable-night/bg_search_wheel_background_round.xml} (100%)
 rename android/app/src/main/res/{drawable/bg_your_location_pin_night.xml => drawable-night/bg_your_location_pin.xml} (100%)
 rename android/app/src/main/res/{drawable/button_night.xml => drawable-night/button.xml} (100%)
 rename android/app/src/main/res/{drawable/button_accent_night.xml => drawable-night/button_accent.xml} (100%)
 rename android/app/src/main/res/{drawable/button_accent_disabled_night.xml => drawable-night/button_accent_disabled.xml} (100%)
 rename android/app/src/main/res/{drawable/button_accent_night_internal.xml => drawable-night/button_accent_internal.xml} (100%)
 rename android/app/src/main/res/{drawable/button_accent_normal_night.xml => drawable-night/button_accent_normal.xml} (100%)
 rename android/app/src/main/res/{drawable/button_accent_pressed_night.xml => drawable-night/button_accent_pressed.xml} (100%)
 rename android/app/src/main/res/{drawable/button_disabled_night.xml => drawable-night/button_disabled.xml} (100%)
 rename android/app/src/main/res/{drawable/button_normal_night.xml => drawable-night/button_normal.xml} (100%)
 rename android/app/src/main/res/{drawable/button_pressed_night.xml => drawable-night/button_pressed.xml} (100%)
 rename android/app/src/main/res/{drawable/dot_divider_night.xml => drawable-night/dot_divider.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_atm_night.xml => drawable-night/ic_category_atm.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_bank_night.xml => drawable-night/ic_category_bank.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_children_night.xml => drawable-night/ic_category_children.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_eat_night.xml => drawable-night/ic_category_eat.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_entertainment_night.xml => drawable-night/ic_category_entertainment.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_food_night.xml => drawable-night/ic_category_food.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_fuel_night.xml => drawable-night/ic_category_fuel.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_hospital_night.xml => drawable-night/ic_category_hospital.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_hotel_night.xml => drawable-night/ic_category_hotel.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_luggagehero_night.xml => drawable-night/ic_category_luggagehero.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_nightlife_night.xml => drawable-night/ic_category_nightlife.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_parking_night.xml => drawable-night/ic_category_parking.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_pharmacy_night.xml => drawable-night/ic_category_pharmacy.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_police_night.xml => drawable-night/ic_category_police.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_post_night.xml => drawable-night/ic_category_post.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_recycling_night.xml => drawable-night/ic_category_recycling.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_rv_night.xml => drawable-night/ic_category_rv.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_secondhand_night.xml => drawable-night/ic_category_secondhand.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_shopping_night.xml => drawable-night/ic_category_shopping.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_toilet_night.xml => drawable-night/ic_category_toilet.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_tourism_night.xml => drawable-night/ic_category_tourism.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_transport_night.xml => drawable-night/ic_category_transport.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_water_night.xml => drawable-night/ic_category_water.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_category_wifi_night.xml => drawable-night/ic_category_wifi.xml} (100%)
 rename android/app/src/main/res/{drawable/ic_menu_location_pending_night.png => drawable-night/ic_menu_location_pending.png} (100%)
 rename android/app/src/main/res/{drawable/list_divider_night.xml => drawable-night/list_divider.xml} (100%)

diff --git a/android/app/src/main/java/app/organicmaps/search/CategoriesAdapter.java b/android/app/src/main/java/app/organicmaps/search/CategoriesAdapter.java
index ea8bf7504b..aacaaf0671 100644
--- a/android/app/src/main/java/app/organicmaps/search/CategoriesAdapter.java
+++ b/android/app/src/main/java/app/organicmaps/search/CategoriesAdapter.java
@@ -110,10 +110,7 @@ class CategoriesAdapter extends RecyclerView.Adapter<CategoriesAdapter.ViewHolde
                                            @NonNull String packageName,
                                            @NonNull String key)
   {
-    final boolean isNightTheme = ThemeUtils.isNightTheme(context);
     String iconId = "ic_" + key;
-    if (isNightTheme)
-      iconId = iconId + "_night";
     return context.getResources().getIdentifier(iconId, "drawable", packageName);
   }
 
diff --git a/android/app/src/main/res/drawable/anim_traffic_loading_night.xml b/android/app/src/main/res/drawable-night/anim_traffic_loading.xml
similarity index 100%
rename from android/app/src/main/res/drawable/anim_traffic_loading_night.xml
rename to android/app/src/main/res/drawable-night/anim_traffic_loading.xml
diff --git a/android/app/src/main/res/drawable/bg_altitude_night.xml b/android/app/src/main/res/drawable-night/bg_altitude.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_altitude_night.xml
rename to android/app/src/main/res/drawable-night/bg_altitude.xml
diff --git a/android/app/src/main/res/drawable/bg_nav_next_next_turn_night.xml b/android/app/src/main/res/drawable-night/bg_nav_next_next_turn.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_nav_next_next_turn_night.xml
rename to android/app/src/main/res/drawable-night/bg_nav_next_next_turn.xml
diff --git a/android/app/src/main/res/drawable/bg_nav_next_turn_night.xml b/android/app/src/main/res/drawable-night/bg_nav_next_turn.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_nav_next_turn_night.xml
rename to android/app/src/main/res/drawable-night/bg_nav_next_turn.xml
diff --git a/android/app/src/main/res/drawable/bg_point_desc_night.xml b/android/app/src/main/res/drawable-night/bg_point_desc.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_point_desc_night.xml
rename to android/app/src/main/res/drawable-night/bg_point_desc.xml
diff --git a/android/app/src/main/res/drawable/bg_rounded_rect_night.xml b/android/app/src/main/res/drawable-night/bg_rounded_rect.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_rounded_rect_night.xml
rename to android/app/src/main/res/drawable-night/bg_rounded_rect.xml
diff --git a/android/app/src/main/res/drawable/bg_search_wheel_background_rect_night.xml b/android/app/src/main/res/drawable-night/bg_search_wheel_background_rect.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_search_wheel_background_rect_night.xml
rename to android/app/src/main/res/drawable-night/bg_search_wheel_background_rect.xml
diff --git a/android/app/src/main/res/drawable/bg_search_wheel_background_round_night.xml b/android/app/src/main/res/drawable-night/bg_search_wheel_background_round.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_search_wheel_background_round_night.xml
rename to android/app/src/main/res/drawable-night/bg_search_wheel_background_round.xml
diff --git a/android/app/src/main/res/drawable/bg_your_location_pin_night.xml b/android/app/src/main/res/drawable-night/bg_your_location_pin.xml
similarity index 100%
rename from android/app/src/main/res/drawable/bg_your_location_pin_night.xml
rename to android/app/src/main/res/drawable-night/bg_your_location_pin.xml
diff --git a/android/app/src/main/res/drawable/button_night.xml b/android/app/src/main/res/drawable-night/button.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_night.xml
rename to android/app/src/main/res/drawable-night/button.xml
diff --git a/android/app/src/main/res/drawable/button_accent_night.xml b/android/app/src/main/res/drawable-night/button_accent.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_accent_night.xml
rename to android/app/src/main/res/drawable-night/button_accent.xml
diff --git a/android/app/src/main/res/drawable/button_accent_disabled_night.xml b/android/app/src/main/res/drawable-night/button_accent_disabled.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_accent_disabled_night.xml
rename to android/app/src/main/res/drawable-night/button_accent_disabled.xml
diff --git a/android/app/src/main/res/drawable/button_accent_night_internal.xml b/android/app/src/main/res/drawable-night/button_accent_internal.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_accent_night_internal.xml
rename to android/app/src/main/res/drawable-night/button_accent_internal.xml
diff --git a/android/app/src/main/res/drawable/button_accent_normal_night.xml b/android/app/src/main/res/drawable-night/button_accent_normal.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_accent_normal_night.xml
rename to android/app/src/main/res/drawable-night/button_accent_normal.xml
diff --git a/android/app/src/main/res/drawable/button_accent_pressed_night.xml b/android/app/src/main/res/drawable-night/button_accent_pressed.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_accent_pressed_night.xml
rename to android/app/src/main/res/drawable-night/button_accent_pressed.xml
diff --git a/android/app/src/main/res/drawable/button_disabled_night.xml b/android/app/src/main/res/drawable-night/button_disabled.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_disabled_night.xml
rename to android/app/src/main/res/drawable-night/button_disabled.xml
diff --git a/android/app/src/main/res/drawable/button_normal_night.xml b/android/app/src/main/res/drawable-night/button_normal.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_normal_night.xml
rename to android/app/src/main/res/drawable-night/button_normal.xml
diff --git a/android/app/src/main/res/drawable/button_pressed_night.xml b/android/app/src/main/res/drawable-night/button_pressed.xml
similarity index 100%
rename from android/app/src/main/res/drawable/button_pressed_night.xml
rename to android/app/src/main/res/drawable-night/button_pressed.xml
diff --git a/android/app/src/main/res/drawable/dot_divider_night.xml b/android/app/src/main/res/drawable-night/dot_divider.xml
similarity index 100%
rename from android/app/src/main/res/drawable/dot_divider_night.xml
rename to android/app/src/main/res/drawable-night/dot_divider.xml
diff --git a/android/app/src/main/res/drawable/ic_category_atm_night.xml b/android/app/src/main/res/drawable-night/ic_category_atm.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_atm_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_atm.xml
diff --git a/android/app/src/main/res/drawable/ic_category_bank_night.xml b/android/app/src/main/res/drawable-night/ic_category_bank.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_bank_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_bank.xml
diff --git a/android/app/src/main/res/drawable/ic_category_children_night.xml b/android/app/src/main/res/drawable-night/ic_category_children.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_children_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_children.xml
diff --git a/android/app/src/main/res/drawable/ic_category_eat_night.xml b/android/app/src/main/res/drawable-night/ic_category_eat.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_eat_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_eat.xml
diff --git a/android/app/src/main/res/drawable/ic_category_entertainment_night.xml b/android/app/src/main/res/drawable-night/ic_category_entertainment.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_entertainment_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_entertainment.xml
diff --git a/android/app/src/main/res/drawable/ic_category_food_night.xml b/android/app/src/main/res/drawable-night/ic_category_food.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_food_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_food.xml
diff --git a/android/app/src/main/res/drawable/ic_category_fuel_night.xml b/android/app/src/main/res/drawable-night/ic_category_fuel.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_fuel_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_fuel.xml
diff --git a/android/app/src/main/res/drawable/ic_category_hospital_night.xml b/android/app/src/main/res/drawable-night/ic_category_hospital.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_hospital_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_hospital.xml
diff --git a/android/app/src/main/res/drawable/ic_category_hotel_night.xml b/android/app/src/main/res/drawable-night/ic_category_hotel.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_hotel_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_hotel.xml
diff --git a/android/app/src/main/res/drawable/ic_category_luggagehero_night.xml b/android/app/src/main/res/drawable-night/ic_category_luggagehero.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_luggagehero_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_luggagehero.xml
diff --git a/android/app/src/main/res/drawable/ic_category_nightlife_night.xml b/android/app/src/main/res/drawable-night/ic_category_nightlife.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_nightlife_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_nightlife.xml
diff --git a/android/app/src/main/res/drawable/ic_category_parking_night.xml b/android/app/src/main/res/drawable-night/ic_category_parking.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_parking_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_parking.xml
diff --git a/android/app/src/main/res/drawable/ic_category_pharmacy_night.xml b/android/app/src/main/res/drawable-night/ic_category_pharmacy.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_pharmacy_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_pharmacy.xml
diff --git a/android/app/src/main/res/drawable/ic_category_police_night.xml b/android/app/src/main/res/drawable-night/ic_category_police.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_police_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_police.xml
diff --git a/android/app/src/main/res/drawable/ic_category_post_night.xml b/android/app/src/main/res/drawable-night/ic_category_post.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_post_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_post.xml
diff --git a/android/app/src/main/res/drawable/ic_category_recycling_night.xml b/android/app/src/main/res/drawable-night/ic_category_recycling.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_recycling_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_recycling.xml
diff --git a/android/app/src/main/res/drawable/ic_category_rv_night.xml b/android/app/src/main/res/drawable-night/ic_category_rv.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_rv_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_rv.xml
diff --git a/android/app/src/main/res/drawable/ic_category_secondhand_night.xml b/android/app/src/main/res/drawable-night/ic_category_secondhand.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_secondhand_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_secondhand.xml
diff --git a/android/app/src/main/res/drawable/ic_category_shopping_night.xml b/android/app/src/main/res/drawable-night/ic_category_shopping.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_shopping_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_shopping.xml
diff --git a/android/app/src/main/res/drawable/ic_category_toilet_night.xml b/android/app/src/main/res/drawable-night/ic_category_toilet.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_toilet_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_toilet.xml
diff --git a/android/app/src/main/res/drawable/ic_category_tourism_night.xml b/android/app/src/main/res/drawable-night/ic_category_tourism.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_tourism_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_tourism.xml
diff --git a/android/app/src/main/res/drawable/ic_category_transport_night.xml b/android/app/src/main/res/drawable-night/ic_category_transport.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_transport_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_transport.xml
diff --git a/android/app/src/main/res/drawable/ic_category_water_night.xml b/android/app/src/main/res/drawable-night/ic_category_water.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_water_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_water.xml
diff --git a/android/app/src/main/res/drawable/ic_category_wifi_night.xml b/android/app/src/main/res/drawable-night/ic_category_wifi.xml
similarity index 100%
rename from android/app/src/main/res/drawable/ic_category_wifi_night.xml
rename to android/app/src/main/res/drawable-night/ic_category_wifi.xml
diff --git a/android/app/src/main/res/drawable/ic_menu_location_pending_night.png b/android/app/src/main/res/drawable-night/ic_menu_location_pending.png
similarity index 100%
rename from android/app/src/main/res/drawable/ic_menu_location_pending_night.png
rename to android/app/src/main/res/drawable-night/ic_menu_location_pending.png
diff --git a/android/app/src/main/res/drawable/list_divider_night.xml b/android/app/src/main/res/drawable-night/list_divider.xml
similarity index 100%
rename from android/app/src/main/res/drawable/list_divider_night.xml
rename to android/app/src/main/res/drawable-night/list_divider.xml
-- 
2.45.3


From 2e66ac41822da8aeaf156c1d79e4bb1443d39178 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 20:47:42 +0000
Subject: [PATCH 37/49] replace drawables using theme query to use light/dark
 variants

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../car/screens/CategoriesScreen.java            | 16 ++++++++--------
 .../maplayer/traffic/widget/TrafficButton.java   |  8 ++++----
 .../routing/RoutingBottomMenuController.java     |  2 +-
 .../main/res/drawable-night/button_accent.xml    |  2 +-
 .../drawable-night/button_accent_internal.xml    |  6 +++---
 .../src/main/res/layout-land/layout_nav_top.xml  |  4 ++--
 .../main/res/layout/current_location_marker.xml  |  2 +-
 .../src/main/res/layout/elevation_profile.xml    |  4 ++--
 .../res/layout/elevation_profile_internal.xml    |  8 ++++----
 .../src/main/res/layout/floating_marker_view.xml |  2 +-
 .../app/src/main/res/layout/layout_nav_top.xml   |  4 ++--
 .../src/main/res/values-night/themes-base.xml    | 12 ------------
 android/app/src/main/res/values-night/themes.xml |  4 ++--
 android/app/src/main/res/values/styles.xml       |  4 ++--
 android/app/src/main/res/values/themes-attrs.xml | 11 -----------
 android/app/src/main/res/values/themes-base.xml  | 14 --------------
 16 files changed, 33 insertions(+), 70 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/car/screens/CategoriesScreen.java b/android/app/src/main/java/app/organicmaps/car/screens/CategoriesScreen.java
index 7598bfbf0c..a15fd8e90a 100644
--- a/android/app/src/main/java/app/organicmaps/car/screens/CategoriesScreen.java
+++ b/android/app/src/main/java/app/organicmaps/car/screens/CategoriesScreen.java
@@ -30,15 +30,15 @@ public class CategoriesScreen extends BaseMapScreen
   private record CategoryData(@StringRes int nameResId, @DrawableRes int iconResId, @DrawableRes int iconNightResId)
   {
   }
-
+  //TODO: previously handled theme by itself, but now icons are dynamic so not needed.
   private static final List<CategoryData> CATEGORIES = Arrays.asList(
-      new CategoryData(R.string.category_fuel, R.drawable.ic_category_fuel, R.drawable.ic_category_fuel_night),
-      new CategoryData(R.string.category_parking, R.drawable.ic_category_parking, R.drawable.ic_category_parking_night),
-      new CategoryData(R.string.category_eat, R.drawable.ic_category_eat, R.drawable.ic_category_eat_night),
-      new CategoryData(R.string.category_food, R.drawable.ic_category_food, R.drawable.ic_category_food_night),
-      new CategoryData(R.string.category_hotel, R.drawable.ic_category_hotel, R.drawable.ic_category_hotel_night),
-      new CategoryData(R.string.category_toilet, R.drawable.ic_category_toilet, R.drawable.ic_category_toilet_night),
-      new CategoryData(R.string.category_rv, R.drawable.ic_category_rv, R.drawable.ic_category_rv_night)
+      new CategoryData(R.string.category_fuel, R.drawable.ic_category_fuel, R.drawable.ic_category_fuel),
+      new CategoryData(R.string.category_parking, R.drawable.ic_category_parking, R.drawable.ic_category_parking),
+      new CategoryData(R.string.category_eat, R.drawable.ic_category_eat, R.drawable.ic_category_eat),
+      new CategoryData(R.string.category_food, R.drawable.ic_category_food, R.drawable.ic_category_food),
+      new CategoryData(R.string.category_hotel, R.drawable.ic_category_hotel, R.drawable.ic_category_hotel),
+      new CategoryData(R.string.category_toilet, R.drawable.ic_category_toilet, R.drawable.ic_category_toilet),
+      new CategoryData(R.string.category_rv, R.drawable.ic_category_rv, R.drawable.ic_category_rv)
   );
 
   private final int MAX_CATEGORIES_SIZE;
diff --git a/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java b/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
index 7d254867c0..5b1b0f339f 100644
--- a/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
+++ b/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
@@ -39,14 +39,14 @@ public class TrafficButton
   {
     Context context = trafficBtn.getContext();
     Resources res = context.getResources();
-    final int animResId = ThemeUtils.getResource(context, R.attr.trafficLoadingAnimation);
+    final int animResId = R.drawable.anim_traffic_loading;
     return (AnimationDrawable) Objects.requireNonNull(ResourcesCompat.getDrawable(res, animResId, context.getTheme()));
   }
 
   void turnOff()
   {
     stopWaitingAnimation();
-// Don't set theme programatically - use an xml with a night variant instead.
+// Don't set theme programatically - use an xml with a night variant instead. Also convert to svg.
 //    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
 //                                                                           : R.drawable.ic_traffic_on);
   }
@@ -54,7 +54,7 @@ public class TrafficButton
   void turnOn()
   {
     stopWaitingAnimation();
-// Don't set theme programatically - use an xml with a night variant instead.
+// Don't set theme programatically - use an xml with a night variant instead.  Also convert to svg.
 //    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
 //                                                                           : R.drawable.ic_traffic_on);
   }
@@ -62,7 +62,7 @@ public class TrafficButton
   void markAsOutdated()
   {
     stopWaitingAnimation();
-// Don't set theme programatically - use an xml with a night variant instead.
+// Don't set theme programatically - use an xml with a night variant instead. Also convert to svg.
 //    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_outdated_night
 //                                                                           : R.drawable.ic_traffic_outdated);
   }
diff --git a/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java b/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java
index e9745a52b5..a15a423cce 100644
--- a/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java
+++ b/android/app/src/main/java/app/organicmaps/routing/RoutingBottomMenuController.java
@@ -146,7 +146,7 @@ final class RoutingBottomMenuController implements View.OnClickListener
     mActionIcon = mActionButton.findViewById(R.id.iv__icon);
     UiUtils.hide(mAltitudeChartFrame, mActionFrame);
     mListener = listener;
-    int dividerRes = ThemeUtils.getResource(mContext, R.attr.transitStepDivider);
+    int dividerRes = R.drawable.dot_divider;
     Drawable dividerDrawable = ContextCompat.getDrawable(mContext, dividerRes);
     Resources res = mContext.getResources();
     mTransitViewDecorator = new DotDividerItemDecoration(dividerDrawable, res.getDimensionPixelSize(R.dimen.margin_base),
diff --git a/android/app/src/main/res/drawable-night/button_accent.xml b/android/app/src/main/res/drawable-night/button_accent.xml
index 192a6af3ec..102a72b2a8 100644
--- a/android/app/src/main/res/drawable-night/button_accent.xml
+++ b/android/app/src/main/res/drawable-night/button_accent.xml
@@ -3,5 +3,5 @@
   xmlns:android="http://schemas.android.com/apk/res/android"
   android:color="?attr/colorBtnHighlight">
   <item android:drawable="@drawable/ripple_mask"/>
-  <item android:drawable="@drawable/button_accent_night_internal"/>
+  <item android:drawable="@drawable/button_accent_internal"/>
 </ripple>
diff --git a/android/app/src/main/res/drawable-night/button_accent_internal.xml b/android/app/src/main/res/drawable-night/button_accent_internal.xml
index 67c7755d24..d2aa33222d 100644
--- a/android/app/src/main/res/drawable-night/button_accent_internal.xml
+++ b/android/app/src/main/res/drawable-night/button_accent_internal.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <selector
   xmlns:android="http://schemas.android.com/apk/res/android">
-  <item android:drawable="@drawable/button_accent_pressed_night"
+  <item android:drawable="@drawable/button_accent_pressed"
         android:state_pressed="true"/>
-  <item android:drawable="@drawable/button_accent_normal_night"
+  <item android:drawable="@drawable/button_accent_normal"
         android:state_enabled="true"/>
-  <item android:drawable="@drawable/button_accent_disabled_night"/>
+  <item android:drawable="@drawable/button_accent_disabled"/>
 </selector>
diff --git a/android/app/src/main/res/layout-land/layout_nav_top.xml b/android/app/src/main/res/layout-land/layout_nav_top.xml
index 3ed8acfe81..c6cc284af4 100644
--- a/android/app/src/main/res/layout-land/layout_nav_top.xml
+++ b/android/app/src/main/res/layout-land/layout_nav_top.xml
@@ -48,7 +48,7 @@
       android:layout_height="wrap_content"
       android:layout_margin="@dimen/margin_half"
       android:orientation="vertical"
-      android:background="?navNextTurnFrame"
+      android:background="@drawable/bg_nav_next_turn"
       android:elevation="@dimen/nav_elevation">
       <FrameLayout
         android:layout_width="wrap_content"
@@ -92,7 +92,7 @@
       android:layout_below="@id/nav_next_turn_frame"
       android:layout_alignStart="@id/nav_next_turn_frame"
       android:layout_alignEnd="@id/nav_next_turn_frame"
-      android:background="?navNextNextTurnFrame"
+      android:background="@drawable/bg_nav_next_next_turn"
       android:elevation="@dimen/nav_elevation"
       android:visibility="gone"
       tools:visibility="visible">
diff --git a/android/app/src/main/res/layout/current_location_marker.xml b/android/app/src/main/res/layout/current_location_marker.xml
index 50ec2a1c59..7741c329b3 100644
--- a/android/app/src/main/res/layout/current_location_marker.xml
+++ b/android/app/src/main/res/layout/current_location_marker.xml
@@ -11,7 +11,7 @@
     android:id="@+id/label"
     android:layout_width="wrap_content"
     android:layout_height="wrap_content"
-    android:background="?elevationProfileYourLocationPinBg"
+    android:background="@drawable/bg_your_location_pin"
     android:ellipsize="end"
     android:paddingStart="@dimen/margin_quarter"
     android:paddingEnd="@dimen/margin_quarter"
diff --git a/android/app/src/main/res/layout/elevation_profile.xml b/android/app/src/main/res/layout/elevation_profile.xml
index e8caa071ef..59623905aa 100644
--- a/android/app/src/main/res/layout/elevation_profile.xml
+++ b/android/app/src/main/res/layout/elevation_profile.xml
@@ -23,7 +23,7 @@
     android:layout_marginStart="@dimen/margin_half"
     android:layout_marginTop="@dimen/margin_quarter"
     android:layout_marginEnd="@dimen/margin_base_plus"
-    android:background="?altitudeBg"
+    android:background="@drawable/bg_altitude"
     android:paddingStart="@dimen/margin_quarter_plus"
     android:paddingTop="@dimen/margin_eighth"
     android:paddingEnd="@dimen/margin_quarter_plus"
@@ -39,7 +39,7 @@
     android:layout_marginStart="@dimen/margin_half"
     android:layout_marginEnd="@dimen/margin_base_plus"
     android:layout_marginBottom="@dimen/margin_base_plus"
-    android:background="?altitudeBg"
+    android:background="@drawable/bg_altitude"
     android:paddingStart="@dimen/margin_quarter_plus"
     android:paddingTop="@dimen/margin_eighth"
     android:paddingEnd="@dimen/margin_quarter_plus"
diff --git a/android/app/src/main/res/layout/elevation_profile_internal.xml b/android/app/src/main/res/layout/elevation_profile_internal.xml
index 564b3ade8f..993fafc75b 100644
--- a/android/app/src/main/res/layout/elevation_profile_internal.xml
+++ b/android/app/src/main/res/layout/elevation_profile_internal.xml
@@ -43,7 +43,7 @@
       android:layout_height="match_parent"
       android:layout_marginEnd="@dimen/margin_quarter"
       android:layout_weight="1"
-      android:background="?elevationProfilePropertyBg"
+      android:background="@drawable/bg_rounded_rect"
       android:gravity="center_horizontal"
       android:orientation="vertical"
       android:padding="@dimen/margin_quarter_plus">
@@ -73,7 +73,7 @@
       android:layout_height="match_parent"
       android:layout_marginEnd="@dimen/margin_quarter"
       android:layout_weight="1"
-      android:background="?elevationProfilePropertyBg"
+      android:background="@drawable/bg_rounded_rect"
       android:gravity="center_horizontal"
       android:orientation="vertical"
       android:padding="@dimen/margin_quarter_plus">
@@ -103,7 +103,7 @@
       android:layout_height="match_parent"
       android:layout_marginEnd="@dimen/margin_quarter"
       android:layout_weight="1"
-      android:background="?elevationProfilePropertyBg"
+      android:background="@drawable/bg_rounded_rect"
       android:gravity="center_horizontal"
       android:orientation="vertical"
       android:padding="@dimen/margin_quarter_plus">
@@ -132,7 +132,7 @@
       android:layout_width="0dp"
       android:layout_height="match_parent"
       android:layout_weight="1"
-      android:background="?elevationProfilePropertyBg"
+      android:background="@drawable/bg_rounded_rect"
       android:gravity="center_horizontal"
       android:orientation="vertical"
       android:padding="@dimen/margin_quarter_plus">
diff --git a/android/app/src/main/res/layout/floating_marker_view.xml b/android/app/src/main/res/layout/floating_marker_view.xml
index 6cee6ebd65..169678c9aa 100644
--- a/android/app/src/main/res/layout/floating_marker_view.xml
+++ b/android/app/src/main/res/layout/floating_marker_view.xml
@@ -38,7 +38,7 @@
       android:layout_marginTop="@dimen/margin_half"
       android:layout_marginBottom="@dimen/margin_half"
       android:layout_toEndOf="@id/floating_triangle"
-      android:background="?elevationProfileSelectedPointBg"
+      android:background="@drawable/bg_point_desc"
       android:elevation="@dimen/margin_eighth"
       android:maxWidth="@dimen/dialog_min_height"
       android:padding="@dimen/margin_quarter_plus"
diff --git a/android/app/src/main/res/layout/layout_nav_top.xml b/android/app/src/main/res/layout/layout_nav_top.xml
index 93ea3b9771..a3adf0d6d9 100644
--- a/android/app/src/main/res/layout/layout_nav_top.xml
+++ b/android/app/src/main/res/layout/layout_nav_top.xml
@@ -48,7 +48,7 @@
       android:layout_height="wrap_content"
       android:layout_margin="@dimen/margin_half"
       android:orientation="vertical"
-      android:background="?navNextTurnFrame"
+      android:background="@drawable/bg_nav_next_turn"
       android:elevation="@dimen/nav_elevation">
       <FrameLayout
         android:layout_width="wrap_content"
@@ -92,7 +92,7 @@
       android:layout_below="@id/nav_next_turn_frame"
       android:layout_alignStart="@id/nav_next_turn_frame"
       android:layout_alignEnd="@id/nav_next_turn_frame"
-      android:background="?navNextNextTurnFrame"
+      android:background="@drawable/bg_nav_next_next_turn"
       android:elevation="@dimen/nav_elevation"
       android:visibility="invisible"
       tools:visibility="visible">
diff --git a/android/app/src/main/res/values-night/themes-base.xml b/android/app/src/main/res/values-night/themes-base.xml
index 11d4d6eb76..2716dc5779 100644
--- a/android/app/src/main/res/values-night/themes-base.xml
+++ b/android/app/src/main/res/values-night/themes-base.xml
@@ -46,18 +46,14 @@
     <item name="ppBackground">@color/bg_cards_night</item>
     <item name="ppButtonsBackground">@color/bg_window_night</item>
 
-    <item name="navNextTurnFrame">@drawable/bg_nav_next_turn_night</item>
-    <item name="navNextNextTurnFrame">@drawable/bg_nav_next_next_turn_night</item>
     <item name="navLanesBackgroundColor">@color/base_accent_night</item>
     <item name="navLaneArrowActiveColor">@color/nav_lane_arrow_active_night</item>
     <item name="navLaneArrowInactiveColor">@color/nav_lane_arrow_inactive_night</item>
 
-    <item name="buttonBackground">@drawable/button_night</item>
     <item name="buttonTextColor">@color/button_text_night</item>
     <item name="buttonTextColorDisabled">@color/button_text_disabled_night</item>
     <item name="buttonDialogTextColor">@color/base_accent_night</item>
 
-    <item name="accentButtonBackground">@drawable/button_accent_night</item>
     <item name="accentButtonTextColor">@color/button_accent_text_night</item>
     <!-- TODO: remove accentButtonTextColorDisabled attribute and use everywhere
                accentButtonTextColor selector -->
@@ -71,9 +67,7 @@
 
     <item name="menuBackground">@color/bg_menu_night</item>
 
-    <item name="myPositionButtonAnimation">@drawable/ic_menu_location_pending_night</item>
     <item name="wheelPendingAnimation">@drawable/anim_spinner_pending</item>
-    <item name="trafficLoadingAnimation">@drawable/anim_traffic_loading_night</item>
 
     <item name="navButtonsThemeRect">@style/MwmTheme.NavButtonsRect</item>
     <item name="navButtonsThemeRound">@style/MwmTheme.NavButtonsRound</item>
@@ -85,11 +79,9 @@
     <item name="routingToolbarButtonActive">@color/routing_button_tint</item>
     <item name="routingToolbarButton">@color/bg_primary_dark_night</item>
 
-    <item name="android:listDivider">@drawable/list_divider_night</item>
 
     <item name="transitPedestrianBackground">@color/white_4</item>
     <item name="transitRulerBackground">@color/white_4</item>
-    <item name="transitStepDivider">@drawable/dot_divider_night</item>
     <item name="accentColorSelector">@color/accent_color_selector_night</item>
     <item name="android:textAppearance">@style/TextAppearance</item>
     <item name="android:textAppearanceSmall">@style/TextAppearance.Small</item>
@@ -109,12 +101,8 @@
     <item name="fontCaption">@style/TextAppearance.MdcTypographyStyles.Caption</item>
     <item name="fontOverline">@style/TextAppearance.MdcTypographyStyles.Overline</item>
     <item name="drivingOptionsViewBg">@color/driving_options_bg_black</item>
-    <item name="elevationProfilePropertyBg">@drawable/bg_rounded_rect_night</item>
     <item name="elevationProfilePropIconTint">@color/white_secondary</item>
-    <item name="altitudeBg">@drawable/bg_altitude_night</item>
     <item name="elevationProfileAxisLabelColor">@color/white_54</item>
-    <item name="elevationProfileYourLocationPinBg">@drawable/bg_your_location_pin_night</item>
-    <item name="elevationProfileSelectedPointBg">@drawable/bg_point_desc_night</item>
     <item name="elevationProfileSelectedPointTriangle">@drawable/ic_triangle_night</item>
     <item name="elevationProfileFloatingTriangle">@drawable/ic_triangle_elevation_night</item>
     <item name="elevationProfileColor">@color/elevation_profile_dark</item>
diff --git a/android/app/src/main/res/values-night/themes.xml b/android/app/src/main/res/values-night/themes.xml
index 237a0c34f4..d489133669 100644
--- a/android/app/src/main/res/values-night/themes.xml
+++ b/android/app/src/main/res/values-night/themes.xml
@@ -33,11 +33,11 @@
   </style>
 
   <style name="MwmTheme.NavButtonsRound" parent="MwmTheme">
-    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_round_night</item>
+    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_round</item>
   </style>
 
   <style name="MwmTheme.NavButtonsRect" parent="MwmTheme">
-    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_rect_night</item>
+    <item name="searchLayoutBackground">@drawable/bg_search_wheel_background_rect</item>
   </style>
 
   <style name="MwmTheme.Navigation" parent="MwmTheme">
diff --git a/android/app/src/main/res/values/styles.xml b/android/app/src/main/res/values/styles.xml
index 2442db2747..08f0d57134 100644
--- a/android/app/src/main/res/values/styles.xml
+++ b/android/app/src/main/res/values/styles.xml
@@ -49,7 +49,7 @@
   <style name="MwmWidget.Button">
     <item name="android:layout_width">wrap_content</item>
     <item name="android:layout_height">wrap_content</item>
-    <item name="android:background">?buttonBackground</item>
+    <item name="android:background">@drawable/button</item>
     <item name="android:stateListAnimator">@null</item>
     <item name="android:fontFamily">@string/robotoMedium</item>
     <item name="android:textAllCaps">true</item>
@@ -57,7 +57,7 @@
   </style>
 
   <style name="MwmWidget.Button.Accent">
-    <item name="android:background">?accentButtonBackground</item>
+    <item name="android:background">@drawable/button_accent</item>
     <item name="android:textColor">?accentButtonTextColor</item>
   </style>
 
diff --git a/android/app/src/main/res/values/themes-attrs.xml b/android/app/src/main/res/values/themes-attrs.xml
index d8ee76d584..27b5c7bdb0 100644
--- a/android/app/src/main/res/values/themes-attrs.xml
+++ b/android/app/src/main/res/values/themes-attrs.xml
@@ -18,16 +18,12 @@
     <attr name="helpIconTint" format="color" />
     <attr name="ppBackground" format="color" />
     <attr name="ppButtonsBackground" format="color" />
-    <attr name="navNextTurnFrame" format="reference" />
-    <attr name="navNextNextTurnFrame" format="reference" />
     <attr name="navLanesBackgroundColor" format="reference" />
     <attr name="navLaneArrowActiveColor" format="reference" />
     <attr name="navLaneArrowInactiveColor" format="reference" />
-    <attr name="buttonBackground" format="reference" />
     <attr name="buttonTextColor" format="color" />
     <attr name="buttonTextColorDisabled" format="color" />
     <attr name="buttonDialogTextColor" format="color" />
-    <attr name="accentButtonBackground" format="reference" />
     <attr name="accentButtonTextColor" format="color" />
     <attr name="accentButtonTextColorDisabled" format="color" />
     <attr name="redButtonBackground" format="reference" />
@@ -35,9 +31,7 @@
     <attr name="redButtonTextColorDisabled" format="color" />
     <attr name="primaryButtonBackground" format="reference" />
     <attr name="menuBackground" format="color" />
-    <attr name="myPositionButtonAnimation" format="reference" />
     <attr name="wheelPendingAnimation" format="reference" />
-    <attr name="trafficLoadingAnimation" format="reference" />
     <attr name="navButtonsThemeRect" format="reference" />
     <attr name="navButtonsThemeRound" format="reference" />
     <attr name="downloaderTheme" format="reference" />
@@ -50,7 +44,6 @@
     <attr name="transitPedestrianBackground" format="color" />
     <attr name="transitRulerBackground" format="color" />
     <attr name="colorBtnHighlight" format="color" />
-    <attr name="transitStepDivider" format="reference" />
     <attr name="colorAccentTransparent" format="reference" />
   </declare-styleable>
   <declare-styleable name="ThemeAttrs.Downloader">
@@ -66,12 +59,8 @@
   </declare-styleable>
   <declare-styleable name="ThemeAttrs.ElevationProfile">
     <attr name="elevationProfileColor" format="color" />
-    <attr name="elevationProfilePropertyBg" format="reference" />
     <attr name="elevationProfilePropIconTint" format="color" />
-    <attr name="altitudeBg" format="reference" />
     <attr name="elevationProfileAxisLabelColor" format="color" />
-    <attr name="elevationProfileYourLocationPinBg" format="reference" />
-    <attr name="elevationProfileSelectedPointBg" format="reference" />
     <attr name="elevationProfileSelectedPointTriangle" format="reference" />
     <attr name="elevationProfileFloatingTriangle" format="reference" />
   </declare-styleable>
diff --git a/android/app/src/main/res/values/themes-base.xml b/android/app/src/main/res/values/themes-base.xml
index 6ae504024b..955a55ae4b 100644
--- a/android/app/src/main/res/values/themes-base.xml
+++ b/android/app/src/main/res/values/themes-base.xml
@@ -44,18 +44,14 @@
     <item name="ppBackground">@color/bg_cards</item>
     <item name="ppButtonsBackground">?panel</item>
 
-    <item name="navNextTurnFrame">@drawable/bg_nav_next_turn</item>
-    <item name="navNextNextTurnFrame">@drawable/bg_nav_next_next_turn</item>
     <item name="navLanesBackgroundColor">@color/base_accent</item>
     <item name="navLaneArrowActiveColor">@color/nav_lane_arrow_active_light</item>
     <item name="navLaneArrowInactiveColor">@color/nav_lane_arrow_inactive_light</item>
 
-    <item name="buttonBackground">@drawable/button</item>
     <item name="buttonTextColor">@color/button_text</item>
     <item name="buttonTextColorDisabled">@color/button_text_disabled</item>
     <item name="buttonDialogTextColor">@color/base_accent</item>
 
-    <item name="accentButtonBackground">@drawable/button_accent</item>
     <item name="accentButtonTextColor">@color/button_text_accent</item>
     <!-- TODO: remove accentButtonTextColorDisabled attribute and use everywhere
                accentButtonTextColor selector -->
@@ -69,9 +65,7 @@
 
     <item name="menuBackground">@color/bg_menu</item>
 
-    <item name="myPositionButtonAnimation">@drawable/ic_menu_location_pending</item>
     <item name="wheelPendingAnimation">@drawable/anim_spinner_pending</item>
-    <item name="trafficLoadingAnimation">@drawable/anim_traffic_loading</item>
 
     <item name="navButtonsThemeRect">@style/MwmTheme.NavButtonsRect</item>
     <item name="navButtonsThemeRound">@style/MwmTheme.NavButtonsRound</item>
@@ -83,14 +77,10 @@
     <item name="routingToolbarButtonActive">@color/routing_button_tint</item>
     <item name="routingToolbarButton">@color/bg_primary_dark</item>
 
-
     <item name="preferenceTheme">@style/PreferenceThemeOverlay.v14.Material</item>
 
-    <item name="android:listDivider">@drawable/list_divider</item>
-
     <item name="transitPedestrianBackground">@color/black_4</item>
     <item name="transitRulerBackground">@color/black_4</item>
-    <item name="transitStepDivider">@drawable/dot_divider</item>
     <item name="outdoorsMenuEnabled">@drawable/ic_layers_outdoors_active</item>
     <item name="trafficMenuEnabled">@drawable/ic_layers_traffic_active</item>
     <item name="subwayMenuEnabled">@drawable/ic_layers_subway_active</item>
@@ -122,12 +112,8 @@
     <item name="fontCaption">@style/TextAppearance.MdcTypographyStyles.Caption</item>
     <item name="fontOverline">@style/TextAppearance.MdcTypographyStyles.Overline</item>
     <item name="drivingOptionsViewBg">@color/light_green</item>
-    <item name="elevationProfilePropertyBg">@drawable/bg_rounded_rect</item>
     <item name="elevationProfilePropIconTint">@color/black_secondary</item>
-    <item name="altitudeBg">@drawable/bg_altitude</item>
     <item name="elevationProfileAxisLabelColor">@color/black_54</item>
-    <item name="elevationProfileYourLocationPinBg">@drawable/bg_your_location_pin</item>
-    <item name="elevationProfileSelectedPointBg">@drawable/bg_point_desc</item>
     <item name="elevationProfileSelectedPointTriangle">@drawable/ic_triangle</item>
     <item name="elevationProfileFloatingTriangle">@drawable/ic_triangle_elevation</item>
     <item name="elevationProfileColor">@color/elevation_profile</item>
-- 
2.45.3


From c953ffd70ad4cd10e736a1f0b99673d1df66db94 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 21:43:24 +0000
Subject: [PATCH 38/49] remove unused thememode code

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../settings/SettingsPrefsFragment.java       | 29 -------------------
 1 file changed, 29 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
index 816385f861..2dbe566b60 100644
--- a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
+++ b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
@@ -404,10 +404,6 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La
         return true;
 
       ThemeSwitcher.INSTANCE.restart(false);
-
-      ThemeMode mode = ThemeMode.getInstance(requireContext().getApplicationContext(), themeName);
-      CharSequence summary = pref.getEntries()[mode.ordinal()];
-      pref.setSummary(summary);
       return true;
     });
   }
@@ -505,31 +501,6 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La
     getSettingsActivity().onBackPressed();
   }
 
-  enum ThemeMode
-  {
-    FOLLOW_SYSTEM(R.string.theme_follow_system),
-    DEFAULT(R.string.theme_default),
-    NIGHT(R.string.theme_night);
-
-    private final int mModeStringId;
-
-    ThemeMode(@StringRes int modeStringId)
-    {
-      mModeStringId = modeStringId;
-    }
-
-    @NonNull
-    public static ThemeMode getInstance(@NonNull Context context, @NonNull String src)
-    {
-      for (ThemeMode each : values())
-      {
-        if (context.getResources().getString(each.mModeStringId).equals(src))
-          return each;
-      }
-      return FOLLOW_SYSTEM;
-    }
-  }
-
   public enum SpeedCameraMode
   {
     AUTO,
-- 
2.45.3


From 2ab8eb336fb6e1ef504f7f54aeaca28375adfa23 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 29 Dec 2024 22:05:11 +0000
Subject: [PATCH 39/49] fix settings background colour not being set

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 android/app/src/main/AndroidManifest.xml         | 3 ++-
 android/app/src/main/res/values/themes-attrs.xml | 2 +-
 android/app/src/main/res/values/themes.xml       | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
index 1fc509c3b3..672c27fdda 100644
--- a/android/app/src/main/AndroidManifest.xml
+++ b/android/app/src/main/AndroidManifest.xml
@@ -393,7 +393,8 @@
         android:configChanges="uiMode|orientation|screenLayout|screenSize"
         android:screenOrientation="fullUser"
         android:label="@string/settings"
-        android:parentActivityName="app.organicmaps.MwmActivity" />
+        android:parentActivityName="app.organicmaps.MwmActivity"
+        android:theme="@style/MwmTheme.CardBg"/>
 
     <activity
         android:name="app.organicmaps.help.HelpActivity"
diff --git a/android/app/src/main/res/values/themes-attrs.xml b/android/app/src/main/res/values/themes-attrs.xml
index 27b5c7bdb0..513dbe7ef9 100644
--- a/android/app/src/main/res/values/themes-attrs.xml
+++ b/android/app/src/main/res/values/themes-attrs.xml
@@ -5,7 +5,7 @@
     <attr name="titleDialogTheme" format="reference" />
     <attr name="textDialogTheme" format="reference" />
     <attr name="windowBackgroundForced" format="reference|color" />
-    <attr name="cardBackground" format="reference" />
+    <attr name="cardBackground" format="color" />
     <attr name="clickableBackground" format="reference" />
     <attr name="statusBar" format="color" />
     <attr name="secondary" format="color" />
diff --git a/android/app/src/main/res/values/themes.xml b/android/app/src/main/res/values/themes.xml
index 69f325eab5..72ce003c8a 100644
--- a/android/app/src/main/res/values/themes.xml
+++ b/android/app/src/main/res/values/themes.xml
@@ -22,7 +22,7 @@
   </style>
 
   <style name="MwmTheme.CardBg">
-    <item name="android:windowBackground">@color/bg_cards</item>
+    <item name="android:windowBackground">?cardBackground</item>
   </style>
 
   <style name="MwmTheme.WindowBg">
-- 
2.45.3


From 36b136bed56ad3fd8b18ca9b805451558044a744 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 19 Jan 2025 19:54:34 +0000
Subject: [PATCH 40/49] minor rename

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../src/main/java/app/organicmaps/util/ThemeSwitcher.java  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 6f50da4a29..e931c3c319 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -47,7 +47,7 @@ public enum ThemeSwitcher
     mRendererActive = isRendererActive;
     String storedTheme = Config.getThemeSettings(mContext);
     // TODO: Handle debug commands
-    String resolvedTheme = resolveCustomThemes(storedTheme);
+    String resolvedTheme = resolveBasicTheme(storedTheme);
     setAndroidTheme(resolvedTheme);
     // Depends on Android theme being set due to follow-system, so has to be after setAndroidTheme.
     int resolvedMapStyle = resolveMapStyle(resolvedTheme);
@@ -68,7 +68,6 @@ public enum ThemeSwitcher
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
     else
       throw new IllegalArgumentException(theme+" passed, but only follow-system/theme_light/dark are allowed.");
-
   }
 
   private void setMapStyle(@Framework.MapStyle int style)
@@ -86,10 +85,10 @@ public enum ThemeSwitcher
   }
 
   /**
-   * Process custom themes (auto, navauto) to default ones (light, dark, follow-system)
+   * resolve custom themes (auto, navauto) to basic system ones (light, dark, follow-system)
    * @return theme handle-able by android theme system.
    */
-  private String resolveCustomThemes(@NonNull String theme)
+  public String resolveBasicTheme(@NonNull String theme)
   {
     if (ThemeUtils.isAutoTheme(mContext, theme))
       return calcAutoTheme();
-- 
2.45.3


From 18a4f6eb0ecad93ac4952d96498880224024425a Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 19 Jan 2025 21:40:19 +0000
Subject: [PATCH 41/49] remove unused thing

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../src/main/java/app/organicmaps/Map.java    | 20 -------------------
 1 file changed, 20 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/Map.java b/android/app/src/main/java/app/organicmaps/Map.java
index 8c609b8aa7..9103357e41 100644
--- a/android/app/src/main/java/app/organicmaps/Map.java
+++ b/android/app/src/main/java/app/organicmaps/Map.java
@@ -66,8 +66,6 @@ public final class Map
   private boolean mSurfaceAttached;
   private boolean mLaunchByDeepLink;
   @Nullable
-  private String mUiThemeOnPause;
-  @Nullable
   private MapRenderingListener mMapRenderingListener;
   @Nullable
   private CallbackUnsupported mCallbackUnsupported;
@@ -136,12 +134,6 @@ public final class Map
 
   public void onSurfaceCreated(final Context context, final Surface surface, Rect surfaceFrame, int surfaceDpi)
   {
-    if (isThemeChangingProcess(context))
-    {
-      Logger.d(TAG, "Theme changing process, skip 'onSurfaceCreated' callback");
-      return;
-    }
-
     Logger.d(TAG, "mSurfaceCreated = " + mSurfaceCreated);
     if (nativeIsEngineCreated())
     {
@@ -192,11 +184,6 @@ public final class Map
 
   public void onSurfaceChanged(final Context context, final Surface surface, Rect surfaceFrame, boolean isSurfaceCreating)
   {
-    if (isThemeChangingProcess(context))
-    {
-      Logger.d(TAG, "Theme changing process, skip 'onSurfaceChanged' callback");
-      return;
-    }
 
     Logger.d(TAG, "mSurfaceCreated = " + mSurfaceCreated);
     if (!mSurfaceCreated || (!mRequireResize && isSurfaceCreating))
@@ -253,8 +240,6 @@ public final class Map
 
   public void onPause(final Context context)
   {
-    mUiThemeOnPause = Config.getThemeSettings(context);
-
     // Pause/Resume can be called without surface creation/destroy.
     if (mSurfaceAttached)
       nativePauseSurfaceRendering();
@@ -361,11 +346,6 @@ public final class Map
       nativeApplyWidgets();
   }
 
-  private boolean isThemeChangingProcess(final Context context)
-  {
-    return mUiThemeOnPause != null && !mUiThemeOnPause.equals(Config.getThemeSettings(context));
-  }
-
   // Engine
   private static native boolean nativeCreateEngine(Surface surface, int density,
                                                    boolean firstLaunch,
-- 
2.45.3


From 83801d3e85d1246a9cb046542160bb9b50a08a4d Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Sun, 19 Jan 2025 22:16:05 +0000
Subject: [PATCH 42/49] note

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/src/main/java/app/organicmaps/util/ThemeSwitcher.java    | 1 +
 1 file changed, 1 insertion(+)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index e931c3c319..33182df3dd 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -117,6 +117,7 @@ public enum ThemeSwitcher
     // First convert the android-but-dynamic follow system theme.
     if (ThemeUtils.isSystemTheme(mContext, theme))
     {
+      //TODO: calc in restart() and set only light/dark
       // Depends on android theme already being calculated and set.
       resolvedTheme = switch (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK)
       {
-- 
2.45.3


From d731773c21d022f7c8a4ab6192084658659ab44d Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 20 Jan 2025 01:33:58 +0000
Subject: [PATCH 43/49] themeswitcher cleanup

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 71 ++++++++-----------
 1 file changed, 30 insertions(+), 41 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 33182df3dd..97bf8437ee 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -45,12 +45,11 @@ public enum ThemeSwitcher
   public void restart(boolean isRendererActive)
   {
     mRendererActive = isRendererActive;
-    String storedTheme = Config.getThemeSettings(mContext);
+    String savedTheme = Config.getThemeSettings(mContext);
     // TODO: Handle debug commands
-    String resolvedTheme = resolveBasicTheme(storedTheme);
-    setAndroidTheme(resolvedTheme);
-    // Depends on Android theme being set due to follow-system, so has to be after setAndroidTheme.
+    String resolvedTheme = resolveBasicTheme(savedTheme);
     int resolvedMapStyle = resolveMapStyle(resolvedTheme);
+    setAndroidTheme(resolvedTheme);
     setMapStyle(resolvedMapStyle);
   }
 
@@ -60,9 +59,9 @@ public enum ThemeSwitcher
    */
   private void setAndroidTheme(@NonNull String theme)
   {
-    if (ThemeUtils.isSystemTheme(mContext, theme))
-      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
-    else if (ThemeUtils.isNightTheme(mContext, theme))
+//    if (ThemeUtils.isSystemTheme(mContext, theme))
+//      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
+    if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
@@ -85,10 +84,10 @@ public enum ThemeSwitcher
   }
 
   /**
-   * resolve custom themes (auto, navauto) to basic system ones (light, dark, follow-system)
+   * resolve custom themes (auto, navauto) to basic ones (light or dark)
    * @return theme handle-able by android theme system.
    */
-  public String resolveBasicTheme(@NonNull String theme)
+  private String resolveBasicTheme(@NonNull String theme)
   {
     if (ThemeUtils.isAutoTheme(mContext, theme))
       return calcAutoTheme();
@@ -100,55 +99,45 @@ public enum ThemeSwitcher
       else
         return mContext.getResources().getString(R.string.theme_default);
     }
-    // Passthrough for normal themes
-    return theme;
+    else if (ThemeUtils.isSystemTheme(mContext, theme))
+    {
+      int uiMode = mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
+      return uiMode == Configuration.UI_MODE_NIGHT_YES
+              ? mContext.getResources().getString(R.string.theme_night)
+              : mContext.getResources().getString(R.string.theme_default);
+    }
+    else
+      // Passthrough for normal themes
+      return theme;
   }
 
   /**
    * Resolve the map (drape) style from a resolved theme string.
-   * @param theme MUST be follow-system/theme_light/dark
+   * @param theme MUST be theme_light/dark
    * @return drape/core compatible map style
    */
   private int resolveMapStyle(@NonNull String theme)
   {
-    @Framework.MapStyle
-    int style;
-    String resolvedTheme = theme;
-    // First convert the android-but-dynamic follow system theme.
-    if (ThemeUtils.isSystemTheme(mContext, theme))
-    {
-      //TODO: calc in restart() and set only light/dark
-      // Depends on android theme already being calculated and set.
-      resolvedTheme = switch (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK)
-      {
-        case Configuration.UI_MODE_NIGHT_YES -> mContext.getResources().getString(R.string.theme_night);
-        case Configuration.UI_MODE_NIGHT_NO -> mContext.getResources().getString(R.string.theme_default);
-        default -> resolvedTheme;
-      };
-    }
-    // Then return a dark/light map style taking into account variants.
-    if (ThemeUtils.isNightTheme(mContext, resolvedTheme))
+    if (ThemeUtils.isNightTheme(mContext, theme))
     {
       if (RoutingController.get().isVehicleNavigation())
-        style = Framework.MAP_STYLE_VEHICLE_DARK;
+        return Framework.MAP_STYLE_VEHICLE_DARK;
       else if (Framework.nativeIsOutdoorsLayerEnabled())
-        style = Framework.MAP_STYLE_OUTDOORS_DARK;
+        return Framework.MAP_STYLE_OUTDOORS_DARK;
       else
-        style = Framework.MAP_STYLE_DARK;
+        return Framework.MAP_STYLE_DARK;
     }
-    else if (ThemeUtils.isDefaultTheme(mContext, resolvedTheme))
+    else if (ThemeUtils.isDefaultTheme(mContext, theme))
     {
       if (RoutingController.get().isVehicleNavigation())
-        style = Framework.MAP_STYLE_VEHICLE_CLEAR;
+        return Framework.MAP_STYLE_VEHICLE_CLEAR;
       else if (Framework.nativeIsOutdoorsLayerEnabled())
-        style = Framework.MAP_STYLE_OUTDOORS_CLEAR;
+        return Framework.MAP_STYLE_OUTDOORS_CLEAR;
       else
-        style = Framework.MAP_STYLE_CLEAR;
+        return Framework.MAP_STYLE_CLEAR;
     }
     else
-      throw new IllegalArgumentException(resolvedTheme+" passed, but only follow-system/theme_light/dark are allowed.");
-
-    return style;
+      throw new IllegalArgumentException(theme +" passed, but only theme_light/dark are allowed.");
   }
 
   /**
@@ -163,15 +152,15 @@ public enum ThemeSwitcher
     Location last = LocationHelper.from(mContext).getSavedLocation();
     long currentTime = System.currentTimeMillis() / 1000;
     boolean day;
+
     if (last != null)
       day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
     else
     {
       currentTime = Calendar.getInstance().get(Calendar.HOUR_OF_DAY);
-      Logger.e("HELLO", String.valueOf(currentTime));
       day = (currentTime < 18 && currentTime > 6);
     }
-    // Finally
+
     return (day ? defaultTheme : nightTheme);
   }
 }
\ No newline at end of file
-- 
2.45.3


From 6074f4bfd1a3a9c2c9b7bf0ee360e31ccc832c95 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Tue, 4 Mar 2025 17:29:56 +0000
Subject: [PATCH 44/49] fix status bar colour

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 android/app/src/main/java/app/organicmaps/MwmActivity.java  | 3 ++-
 .../main/java/app/organicmaps/routing/TransitStepView.java  | 3 ++-
 .../src/main/java/app/organicmaps/util/ThemeSwitcher.java   | 6 +++---
 .../app/src/main/java/app/organicmaps/util/ThemeUtils.java  | 5 -----
 4 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/MwmActivity.java b/android/app/src/main/java/app/organicmaps/MwmActivity.java
index 083e0054ad..1ec9e882c5 100644
--- a/android/app/src/main/java/app/organicmaps/MwmActivity.java
+++ b/android/app/src/main/java/app/organicmaps/MwmActivity.java
@@ -566,8 +566,9 @@ public class MwmActivity extends BaseMwmFragmentActivity
 
   private void refreshLightStatusBar()
   {
+    int darkModeFlags = this.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
     UiUtils.setLightStatusBar(this, !(
-        ThemeUtils.isNightTheme(this)
+        (darkModeFlags == Configuration.UI_MODE_NIGHT_YES)
         || RoutingController.get().isPlanning()
         || Framework.nativeGetChoosePositionMode() != Framework.ChoosePositionMode.NONE
     ));
diff --git a/android/app/src/main/java/app/organicmaps/routing/TransitStepView.java b/android/app/src/main/java/app/organicmaps/routing/TransitStepView.java
index 9f4a965c10..f24709beee 100644
--- a/android/app/src/main/java/app/organicmaps/routing/TransitStepView.java
+++ b/android/app/src/main/java/app/organicmaps/routing/TransitStepView.java
@@ -89,7 +89,8 @@ public class TransitStepView extends View implements MultilineLayoutManager.Sque
     {
       mDrawable = null;
       mText = info.getDistance() + " " + info.getDistanceUnits();
-      mTextPaint.setColor(ThemeUtils.isDefaultTheme(getContext()) ? Color.BLACK : Color.WHITE);
+      //TODO @RedAuburn: set this with themed resource defs
+      //mTextPaint.setColor(ThemeUtils.isDefaultTheme(getContext()) ? Color.BLACK : Color.WHITE);
     }
     else
     {
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 97bf8437ee..ffd94ea11e 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -59,9 +59,9 @@ public enum ThemeSwitcher
    */
   private void setAndroidTheme(@NonNull String theme)
   {
-//    if (ThemeUtils.isSystemTheme(mContext, theme))
-//      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
-    if (ThemeUtils.isNightTheme(mContext, theme))
+    if (ThemeUtils.isSystemTheme(mContext, theme))
+      AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM);
+    else if (ThemeUtils.isNightTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_YES);
     else if (ThemeUtils.isDefaultTheme(mContext, theme))
       AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_NO);
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index d4ec7d4e43..43d47f7df6 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -44,11 +44,6 @@ public final class ThemeUtils
     return VALUE_BUFFER.resourceId;
   }
 
-  public static boolean isDefaultTheme(@NonNull Context context)
-  {
-    return isDefaultTheme(context, Config.getThemeSettings(context));
-  }
-
   public static boolean isDefaultTheme(@NonNull Context context, String theme)
   {
     String defaultTheme = context.getString(R.string.theme_default);
-- 
2.45.3


From b65e4cfa308a60c2df0074ab31032151cf3d5036 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Tue, 4 Mar 2025 17:37:34 +0000
Subject: [PATCH 45/49] banish is{theme} checkers

nav-auto not working, RoutingController.get().isVehicleNavigation() doesn't work??? maybe called too early before it's set?
Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../traffic/widget/TrafficButton.java         |  6 +++---
 .../app/organicmaps/util/ThemeSwitcher.java   |  2 +-
 .../java/app/organicmaps/util/ThemeUtils.java | 20 -------------------
 3 files changed, 4 insertions(+), 24 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java b/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
index 5b1b0f339f..db803ddfc1 100644
--- a/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
+++ b/android/app/src/main/java/app/organicmaps/maplayer/traffic/widget/TrafficButton.java
@@ -46,7 +46,7 @@ public class TrafficButton
   void turnOff()
   {
     stopWaitingAnimation();
-// Don't set theme programatically - use an xml with a night variant instead. Also convert to svg.
+// TODO: Don't set theme programatically - use an xml with a night variant instead. Also convert to svg.
 //    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
 //                                                                           : R.drawable.ic_traffic_on);
   }
@@ -54,7 +54,7 @@ public class TrafficButton
   void turnOn()
   {
     stopWaitingAnimation();
-// Don't set theme programatically - use an xml with a night variant instead.  Also convert to svg.
+// TODO: Don't set theme programatically - use an xml with a night variant instead.  Also convert to svg.
 //    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_on_night
 //                                                                           : R.drawable.ic_traffic_on);
   }
@@ -62,7 +62,7 @@ public class TrafficButton
   void markAsOutdated()
   {
     stopWaitingAnimation();
-// Don't set theme programatically - use an xml with a night variant instead. Also convert to svg.
+// TODO: Don't set theme programatically - use an xml with a night variant instead. Also convert to svg.
 //    mButton.setImageResource(ThemeUtils.isNightTheme(mButton.getContext()) ? R.drawable.ic_traffic_outdated_night
 //                                                                           : R.drawable.ic_traffic_outdated);
   }
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index ffd94ea11e..74af42bc49 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -93,7 +93,7 @@ public enum ThemeSwitcher
       return calcAutoTheme();
     else if (ThemeUtils.isNavAutoTheme(mContext, theme))
     {
-      // navauto always falls back to light mode
+      // navauto should always be light, except in nav mode
       if (RoutingController.get().isVehicleNavigation())
         return calcAutoTheme();
       else
diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
index 43d47f7df6..aa8a86786b 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeUtils.java
@@ -50,44 +50,24 @@ public final class ThemeUtils
     return defaultTheme.equals(theme);
   }
 
-  public static boolean isNightTheme(@NonNull Context context)
-  {
-    return isNightTheme(context, Config.getThemeSettings(context));
-  }
-
   public static boolean isNightTheme(@NonNull Context context, String theme)
   {
     String nightTheme = context.getString(R.string.theme_night);
     return nightTheme.equals(theme);
   }
 
-  public static boolean isSystemTheme(@NonNull Context context)
-  {
-    return isSystemTheme(context, Config.getThemeSettings(context));
-  }
-
   public static boolean isSystemTheme(@NonNull Context context, String theme)
   {
     String followSystemTheme = context.getString(R.string.theme_follow_system);
     return followSystemTheme.equals(theme);
   }
 
-  public static boolean isNavAutoTheme(@NonNull Context context)
-  {
-    return isNavAutoTheme(context, Config.getThemeSettings(context));
-  }
-
   public static boolean isNavAutoTheme(@NonNull Context context, String theme)
   {
     String navAutoTheme = context.getString(R.string.theme_nav_auto);
     return navAutoTheme.equals(theme);
   }
 
-  public static boolean isAutoTheme(@NonNull Context context)
-  {
-    return isSystemTheme(context, Config.getThemeSettings(context));
-  }
-
   public static boolean isAutoTheme(@NonNull Context context, String theme)
   {
     String followSystemTheme = context.getString(R.string.theme_auto);
-- 
2.45.3


From 4da1ac38c4b146a528118c09cceb617c665e84c3 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Tue, 4 Mar 2025 18:47:25 +0000
Subject: [PATCH 46/49] fix theme subtitle not updating

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../java/app/organicmaps/settings/SettingsPrefsFragment.java    | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
index 2dbe566b60..a23ed9e57d 100644
--- a/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
+++ b/android/app/src/main/java/app/organicmaps/settings/SettingsPrefsFragment.java
@@ -400,6 +400,8 @@ public class SettingsPrefsFragment extends BaseXmlSettingsFragment implements La
     pref.setSummary(pref.getEntry());
     pref.setOnPreferenceChangeListener((preference, newValue) -> {
       final String themeName = (String) newValue;
+      pref.setValue(themeName);
+      pref.setSummary(pref.getEntry());
       if (!Config.setThemeSettings(requireContext(), themeName))
         return true;
 
-- 
2.45.3


From 0f5f90322a9d06ec6cd1f4521527033d4dc3e478 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Thu, 6 Mar 2025 18:20:09 +0000
Subject: [PATCH 47/49] clean up calcAutoTheme

don't reuse variables, declare in scope
---
 .../src/main/java/app/organicmaps/util/ThemeSwitcher.java | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index 74af42bc49..b27cda9f6e 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -150,15 +150,17 @@ public enum ThemeSwitcher
     String defaultTheme = mContext.getResources().getString(R.string.theme_default);
     String nightTheme = mContext.getResources().getString(R.string.theme_night);
     Location last = LocationHelper.from(mContext).getSavedLocation();
-    long currentTime = System.currentTimeMillis() / 1000;
     boolean day;
 
     if (last != null)
+    {
+      long currentTime = System.currentTimeMillis() / 1000;
       day = Framework.nativeIsDayTime(currentTime, last.getLatitude(), last.getLongitude());
+    }
     else
     {
-      currentTime = Calendar.getInstance().get(Calendar.HOUR_OF_DAY);
-      day = (currentTime < 18 && currentTime > 6);
+      int currentHour = Calendar.getInstance().get(Calendar.HOUR_OF_DAY);
+      day = (currentHour < 18 && currentHour > 6);
     }
 
     return (day ? defaultTheme : nightTheme);
-- 
2.45.3


From e4967be588cadb41dc70fc068cf6a808e319a948 Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Fri, 7 Mar 2025 16:04:01 +0000
Subject: [PATCH 48/49] let android handle follow-system for UI, resolve
 manually in mapstyle

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 .../app/organicmaps/util/ThemeSwitcher.java   | 21 +++++++++++--------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
index b27cda9f6e..ecde801d5e 100644
--- a/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
+++ b/android/app/src/main/java/app/organicmaps/util/ThemeSwitcher.java
@@ -84,7 +84,7 @@ public enum ThemeSwitcher
   }
 
   /**
-   * resolve custom themes (auto, navauto) to basic ones (light or dark)
+   * resolve custom themes (auto, navauto) to basic ones (light, dark, follow-system)
    * @return theme handle-able by android theme system.
    */
   private String resolveBasicTheme(@NonNull String theme)
@@ -99,13 +99,6 @@ public enum ThemeSwitcher
       else
         return mContext.getResources().getString(R.string.theme_default);
     }
-    else if (ThemeUtils.isSystemTheme(mContext, theme))
-    {
-      int uiMode = mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
-      return uiMode == Configuration.UI_MODE_NIGHT_YES
-              ? mContext.getResources().getString(R.string.theme_night)
-              : mContext.getResources().getString(R.string.theme_default);
-    }
     else
       // Passthrough for normal themes
       return theme;
@@ -113,11 +106,21 @@ public enum ThemeSwitcher
 
   /**
    * Resolve the map (drape) style from a resolved theme string.
-   * @param theme MUST be theme_light/dark
+   * @param theme MUST be theme_light/dark/follow-system
    * @return drape/core compatible map style
    */
   private int resolveMapStyle(@NonNull String theme)
   {
+    // Resolve systemtheme for map style as android handles
+    // the UI so it's not really a custom theme.
+    if (ThemeUtils.isSystemTheme(mContext, theme))
+    {
+      int uiMode = mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK;
+      theme = uiMode == Configuration.UI_MODE_NIGHT_YES
+              ? mContext.getResources().getString(R.string.theme_night)
+              : mContext.getResources().getString(R.string.theme_default);
+    }
+
     if (ThemeUtils.isNightTheme(mContext, theme))
     {
       if (RoutingController.get().isVehicleNavigation())
-- 
2.45.3


From ba08806f153fe5af4b07f71dbec81ca7175e342a Mon Sep 17 00:00:00 2001
From: Harry Bond <me@hbond.xyz>
Date: Mon, 10 Mar 2025 17:44:45 +0000
Subject: [PATCH 49/49] fix nav bars i think??

Signed-off-by: Harry Bond <me@hbond.xyz>
---
 android/app/src/main/res/values-night/themes-base.xml | 2 ++
 android/app/src/main/res/values/themes-base.xml       | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/android/app/src/main/res/values-night/themes-base.xml b/android/app/src/main/res/values-night/themes-base.xml
index 2716dc5779..e1753b7809 100644
--- a/android/app/src/main/res/values-night/themes-base.xml
+++ b/android/app/src/main/res/values-night/themes-base.xml
@@ -20,6 +20,8 @@
     <item name="clickableBackground">?selectableItemBackground</item>
     <item name="android:statusBarColor">?colorPrimary</item>
     <item name="android:windowTranslucentNavigation">false</item>
+    <item name="android:enforceNavigationBarContrast" tools:targetApi="Q">false</item>
+    <item name="android:enforceStatusBarContrast" tools:targetApi="Q">false</item>
 
     <item name="alertDialogTheme">@style/MwmTheme.AlertDialog</item>
     <item name="windowBackgroundForced">@color/bg_window_night</item>
diff --git a/android/app/src/main/res/values/themes-base.xml b/android/app/src/main/res/values/themes-base.xml
index 955a55ae4b..f438d877d0 100644
--- a/android/app/src/main/res/values/themes-base.xml
+++ b/android/app/src/main/res/values/themes-base.xml
@@ -19,6 +19,10 @@
     <item name="android:windowActionBarOverlay">true</item>
     <item name="clickableBackground">?selectableItemBackground</item>
     <item name="android:statusBarColor">?colorPrimary</item>
+    <item name="android:windowTranslucentNavigation">false</item>
+    <item name="android:enforceNavigationBarContrast" tools:targetApi="Q">false</item>
+    <item name="android:enforceStatusBarContrast" tools:targetApi="Q">false</item>
+
     <item name="alertDialogTheme">@style/MwmTheme.AlertDialog</item>
     <item name="windowBackgroundForced">@color/bg_window</item>
     <item name="cardBackground">@color/bg_cards</item>
-- 
2.45.3