From 238e38496abc5d24775fb5ee51e33774bc1c9afc Mon Sep 17 00:00:00 2001 From: Mateusz Konieczny Date: Wed, 5 Apr 2023 09:48:49 +0200 Subject: [PATCH 1/3] [doc] fix comment - key are limited to set of known ones Signed-off-by: Mateusz Konieczny Small step toward #4895 --- tools/python/stylesheet/cat_stat.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/python/stylesheet/cat_stat.py b/tools/python/stylesheet/cat_stat.py index ba693b1774..b405d54c1d 100755 --- a/tools/python/stylesheet/cat_stat.py +++ b/tools/python/stylesheet/cat_stat.py @@ -81,7 +81,7 @@ def find_in_taginfo(cur, kv, seen): def find_popular_taginfo(cur, seen): - """Finds popular keys that have not been seen.""" + """Finds popular values that have not been seen, among some popular tags.""" RE_VALID = re.compile(r'^[a-z_]+$') keys = ('amenity', 'shop', 'craft', 'emergency', 'office', 'highway', 'railway', 'tourism', 'historic', 'leisure', 'man_made') cur.execute("select key, value, count_all from tags where key in ({}) and count_all > 1000 order by count_all desc". -- 2.45.3 From 4661e461000ffcdedeaee86ae86e75a1e3927026 Mon Sep 17 00:00:00 2001 From: Mateusz Konieczny Date: Tue, 4 Apr 2023 21:20:06 +0200 Subject: [PATCH 2/3] [doc] Do not describe using experimental GTFS as easy Really debatable is it actually easy and it adds nothing to docs anyway Signed-off-by: Mateusz Konieczny --- docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md b/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md index 1dca16b817..52d75a5c83 100644 --- a/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md +++ b/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md @@ -10,7 +10,7 @@ At the moment our app does not have full support for public transport. What we h :bus: But you can turn on the experimental feature of [GTFS](https://developers.google.com/transit/gtfs/reference) public transport and use it inside the Organic Maps app. It includes all [transit types definded by GTFS specification:](https://developers.google.com/transit/gtfs/reference/extended-route-types) bus, train, ferry, aerial lifts of different kinds, trolleybus and much more. Let's call this version of transit data **GTFS transit** from now on. -To mixin the experimental GTFS transit into the OSM transit data you should follow 2 simple steps: +To mixin the experimental GTFS transit into the OSM transit data you should follow 2 steps: - Run the pipeline for downloading and preparing GTFS data about public transport. - Switch to the new version of the transit routing section in maps: build maps with the GTFS transit section with the help of special options for generator_tool. -- 2.45.3 From 77f8fa95fa6a671e86d87abd233e2e234524ec40 Mon Sep 17 00:00:00 2001 From: Mateusz Konieczny Date: Wed, 5 Apr 2023 11:43:40 +0200 Subject: [PATCH 3/3] [doc] improve English in docs Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Mateusz Konieczny --- docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md b/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md index 52d75a5c83..8e2a6c0bee 100644 --- a/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md +++ b/docs/EXPERIMENTAL_PUBLIC_TRANSPORT_SUPPORT.md @@ -10,10 +10,10 @@ At the moment our app does not have full support for public transport. What we h :bus: But you can turn on the experimental feature of [GTFS](https://developers.google.com/transit/gtfs/reference) public transport and use it inside the Organic Maps app. It includes all [transit types definded by GTFS specification:](https://developers.google.com/transit/gtfs/reference/extended-route-types) bus, train, ferry, aerial lifts of different kinds, trolleybus and much more. Let's call this version of transit data **GTFS transit** from now on. -To mixin the experimental GTFS transit into the OSM transit data you should follow 2 steps: +To mix in the experimental GTFS transit into the OSM transit data you should follow these steps: -- Run the pipeline for downloading and preparing GTFS data about public transport. -- Switch to the new version of the transit routing section in maps: build maps with the GTFS transit section with the help of special options for generator_tool. +1. Run the pipeline for downloading and preparing GTFS data about public transport. +2. Switch to the new version of the transit routing section in maps: build maps with the GTFS transit section with the help of special options for generator_tool. After completing these steps you will have maps with: -- 2.45.3