From 4937c108a929f833938b18aeb3eb6095e0b2fe05 Mon Sep 17 00:00:00 2001 From: FinixFighter <19877271+FinixFighter@users.noreply.github.com> Date: Sat, 26 Jun 2021 09:24:18 +0200 Subject: [PATCH 1/5] Updated feature_meta.cpp Signed-off-by: Luca Finizio --- indexer/feature_meta.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indexer/feature_meta.cpp b/indexer/feature_meta.cpp index d88595bb25..61c124a42d 100644 --- a/indexer/feature_meta.cpp +++ b/indexer/feature_meta.cpp @@ -59,7 +59,7 @@ bool Metadata::TypeFromString(string const & k, Metadata::EType & outType) { if (k == "opening_hours") outType = Metadata::FMD_OPEN_HOURS; - else if (k == "phone" || k == "contact:phone") + else if (k == "phone" || k == "contact:phone" || k == "contact:mobile") outType = Metadata::FMD_PHONE_NUMBER; else if (k == "fax" || k == "contact:fax") outType = Metadata::EType::FMD_FAX_NUMBER; -- 2.45.3 From 5ad894795cf8b9c8e79d96835e27340bdca383e9 Mon Sep 17 00:00:00 2001 From: FinixFighter <19877271+FinixFighter@users.noreply.github.com> Date: Sat, 26 Jun 2021 09:27:25 +0200 Subject: [PATCH 2/5] Update feature_meta.hpp Signed-off-by: Luca Finizio --- indexer/feature_meta.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/indexer/feature_meta.hpp b/indexer/feature_meta.hpp index 97370e61e3..3dc364aef1 100644 --- a/indexer/feature_meta.hpp +++ b/indexer/feature_meta.hpp @@ -149,7 +149,7 @@ public: FMD_COUNT }; - /// Used to normalize tags like "contact:phone" and "phone" to a common metadata enum value. + /// Used to normalize tags like "contact:phone", "phone" and "contact:mobile" to a common metadata enum value. static bool TypeFromString(std::string const & osmTagKey, EType & outType); static bool IsSponsoredType(EType const & type); -- 2.45.3 From 654c8adff5e7e3e26179e6d8465e98c1ff365f9f Mon Sep 17 00:00:00 2001 From: FinixFighter <19877271+FinixFighter@users.noreply.github.com> Date: Sat, 26 Jun 2021 09:30:35 +0200 Subject: [PATCH 3/5] Update xml_feature.cpp Signed-off-by: Luca Finizio --- editor/xml_feature.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/editor/xml_feature.cpp b/editor/xml_feature.cpp index 38742f3489..992aba6b9a 100644 --- a/editor/xml_feature.cpp +++ b/editor/xml_feature.cpp @@ -168,7 +168,7 @@ string XMLFeature::ToOSMString() const void XMLFeature::ApplyPatch(XMLFeature const & featureWithChanges) { // TODO(mgsergio): Get these alt tags from the config. - vector> const alternativeTags = {{"phone", "contact:phone"}, + vector> const alternativeTags = {{"phone", "contact:phone", "contact:mobile"}, {"website", "contact:website", "url"}, {"fax", "contact:fax"}, {"email", "contact:email"}}; -- 2.45.3 From 042cd053b4af733fd11e4fd5b4634db430e46da1 Mon Sep 17 00:00:00 2001 From: FinixFighter <19877271+FinixFighter@users.noreply.github.com> Date: Sat, 26 Jun 2021 09:31:52 +0200 Subject: [PATCH 4/5] Update editor.config Signed-off-by: Luca Finizio --- data/editor.config | 1 + 1 file changed, 1 insertion(+) diff --git a/data/editor.config b/data/editor.config index 108b9e20e9..14aade5421 100644 --- a/data/editor.config +++ b/data/editor.config @@ -40,6 +40,7 @@ + -- 2.45.3 From c0478b1e6fe671a575b73210ea2dd016760a7e95 Mon Sep 17 00:00:00 2001 From: FinixFighter <19877271+FinixFighter@users.noreply.github.com> Date: Sat, 3 Jul 2021 11:25:34 +0200 Subject: [PATCH 5/5] Update editor_config.hpp Signed-off-by: Luca Finizio --- editor/editor_config.hpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/editor/editor_config.hpp b/editor/editor_config.hpp index dbfa5e9d6b..3d702e6912 100644 --- a/editor/editor_config.hpp +++ b/editor/editor_config.hpp @@ -48,7 +48,7 @@ public: void SetConfig(pugi::xml_document const & doc); // TODO(mgsergio): Implement this getter to avoid hard-code in XMLFeature::ApplyPatch. - // It should return [[phone, contact:phone], [website, contact:website, url], ...]. + // It should return [[phone, contact:phone, contact:mobile], [website, contact:website, url], ...]. //vector> GetAlternativeFields() const; private: -- 2.45.3