From cc32c187324d0f313e8cd53831417a04d024c580 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Fri, 2 Aug 2024 10:13:36 +0300
Subject: [PATCH 01/13] Added draft of "Login with OSM website" button

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../cpp/app/organicmaps/editor/OsmOAuth.cpp   | 14 ++++++++++
 .../organicmaps/editor/OsmLoginFragment.java  | 27 +++++++++++++++++++
 .../java/app/organicmaps/editor/OsmOAuth.java |  8 ++++++
 .../main/res/layout/fragment_osm_login.xml    |  7 +++++
 editor/osm_auth.hpp                           |  7 +++++
 5 files changed, 63 insertions(+)

diff --git a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
index 90d320ef65..1533aca1df 100644
--- a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
+++ b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@@ -34,6 +34,20 @@ bool LoadOsmUserPreferences(std::string const & oauthToken, UserPreferences & ou
 extern "C"
 {
 
+JNIEXPORT jobjectArray JNICALL
+Java_app_organicmaps_editor_OsmOAuth_nativeOAuthParams(JNIEnv * env, jclass clazz)
+{
+    OsmOAuth auth = OsmOAuth::ServerAuth();
+    jobjectArray oauthParams = env->NewObjectArray(5, env->FindClass("java/lang/String"), nullptr);
+    env->SetObjectArrayElement(oauthParams, 0, ToJavaString(env, auth.GetBaseUrl()));
+    env->SetObjectArrayElement(oauthParams, 1, ToJavaString(env, auth.GetClientId()));
+    env->SetObjectArrayElement(oauthParams, 2, ToJavaString(env, auth.GetClientSecret()));
+    env->SetObjectArrayElement(oauthParams, 3, ToJavaString(env, auth.GetScope()));
+    env->SetObjectArrayElement(oauthParams, 4, ToJavaString(env, auth.GetRedirectUri()));
+
+    return oauthParams;
+}
+
 JNIEXPORT jstring JNICALL
 Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithPassword(JNIEnv * env, jclass clazz,
                                                                 jstring login, jstring password)
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
index 4e33db9e22..12c558a264 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@@ -1,6 +1,8 @@
 package app.organicmaps.editor;
 
+import android.content.ActivityNotFoundException;
 import android.content.Intent;
+import android.net.Uri;
 import android.os.Bundle;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -29,6 +31,7 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
 {
   private ProgressBar mProgress;
   private Button mLoginButton;
+  private Button mLoginWebsiteButton;
   private Button mLostPasswordButton;
   private TextInputEditText mLoginInput;
   private TextInputEditText mPasswordInput;
@@ -47,6 +50,8 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
     getToolbarController().setTitle(R.string.login);
     mLoginInput = view.findViewById(R.id.osm_username);
     mPasswordInput = view.findViewById(R.id.osm_password);
+    mLoginWebsiteButton = view.findViewById(R.id.login_website);
+    mLoginWebsiteButton.setOnClickListener((v) -> loginWithBrowser());
     mLoginButton = view.findViewById(R.id.login);
     mLoginButton.setOnClickListener((v) -> login());
     mLostPasswordButton = view.findViewById(R.id.lost_password);
@@ -75,6 +80,28 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
     });
   }
 
+  private void loginWithBrowser()
+  {
+    mLoginWebsiteButton.setEnabled(false);
+
+    String[] oauthParams = OsmOAuth.nativeOAuthParams();
+    Uri oauth2url = Uri.parse(oauthParams[0] + "/oauth2/authorize")
+            .buildUpon()
+            .appendQueryParameter("client_id", oauthParams[1])
+            .appendQueryParameter("scope", oauthParams[3])
+            .appendQueryParameter("redirect_uri", oauthParams[4])
+            .appendQueryParameter("response_type", "code")
+            .build();
+    try {
+      Intent myIntent = new Intent(Intent.ACTION_VIEW, oauth2url);
+      startActivity(myIntent);
+    } catch (ActivityNotFoundException e) {
+      //Toast.makeText(this, "No application can handle this request."
+      //        + " Please install a webbrowser",  Toast.LENGTH_LONG).show();
+      e.printStackTrace();
+    }
+  }
+
   private void enableInput(boolean enable)
   {
     mPasswordInput.setEnabled(enable);
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java b/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
index d5d7dc8450..36386850a6 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
@@ -10,6 +10,8 @@ import androidx.annotation.Size;
 import androidx.annotation.WorkerThread;
 import androidx.fragment.app.FragmentManager;
 
+import java.util.Map;
+
 import app.organicmaps.MwmApplication;
 import app.organicmaps.util.NetworkPolicy;
 
@@ -98,6 +100,12 @@ public final class OsmOAuth
     return nativeGetHistoryUrl(getUsername(context));
   }
 
+  /*
+   Returns 5 strings: ServerURL, ClientId, ClientSecret, Scope, RedirectUri
+   */
+  @NonNull
+  public static native String[] nativeOAuthParams();
+
   /**
    * @return string with OAuth2 token
    */
diff --git a/android/app/src/main/res/layout/fragment_osm_login.xml b/android/app/src/main/res/layout/fragment_osm_login.xml
index 3868214a12..988ab6cb27 100644
--- a/android/app/src/main/res/layout/fragment_osm_login.xml
+++ b/android/app/src/main/res/layout/fragment_osm_login.xml
@@ -60,6 +60,13 @@
         android:text="@string/login_to_make_edits_visible"
         android:textAppearance="@style/MwmTextAppearance.Body2"
         android:textColor="?android:textColorPrimary" />
+      <Button
+          android:id="@+id/login_website"
+          style="@style/MwmWidget.Button.Accent"
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:text="Login with OSM website"
+          android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
       <com.google.android.material.textfield.TextInputLayout
         style="@style/MwmWidget.Editor.CustomTextInput"
         android:layout_marginTop="@dimen/margin_half"
diff --git a/editor/osm_auth.hpp b/editor/osm_auth.hpp
index 2c80be851e..2d48ca994c 100644
--- a/editor/osm_auth.hpp
+++ b/editor/osm_auth.hpp
@@ -93,6 +93,13 @@ public:
   /// @param[api] If false, request is made to m_baseUrl.
   Response DirectRequest(std::string const & method, bool api = true) const;
 
+  // Getters
+  std::string GetBaseUrl() const { return m_baseUrl; }
+  std::string GetClientId() const { return m_oauth2params.m_clientId; }
+  std::string GetClientSecret() const { return m_oauth2params.m_clientSecret; }
+  std::string GetScope() const { return m_oauth2params.m_scope; }
+  std::string GetRedirectUri() const { return m_oauth2params.m_redirectUri; }
+
   /// @name Methods for WebView-based authentication.
   //@{
   std::string FinishAuthorization(std::string const & oauth2code) const;
-- 
2.45.3


From c1cf2b5c9432979177a201237f6b185fdcbb1755 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Fri, 2 Aug 2024 15:09:53 +0300
Subject: [PATCH 02/13] Implemented parsing of om://oauth2/osm/callback URLs

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../src/main/cpp/app/organicmaps/Framework.cpp |  7 +++++++
 .../main/java/app/organicmaps/Framework.java   |  1 +
 .../java/app/organicmaps/api/RequestType.java  |  3 ++-
 .../java/app/organicmaps/intent/Factory.java   | 10 ++++++++++
 map/framework.cpp                              |  5 +++++
 map/framework.hpp                              |  1 +
 map/map_tests/mwm_url_tests.cpp                |  7 +++++++
 map/mwm_url.cpp                                | 18 ++++++++++++++++++
 map/mwm_url.hpp                                |  8 ++++++++
 9 files changed, 59 insertions(+), 1 deletion(-)

diff --git a/android/app/src/main/cpp/app/organicmaps/Framework.cpp b/android/app/src/main/cpp/app/organicmaps/Framework.cpp
index fe3b5435cf..76d04b2df9 100644
--- a/android/app/src/main/cpp/app/organicmaps/Framework.cpp
+++ b/android/app/src/main/cpp/app/organicmaps/Framework.cpp
@@ -862,6 +862,13 @@ Java_app_organicmaps_Framework_nativeGetParsedAppName(JNIEnv * env, jclass)
   return (appName.empty()) ? nullptr : jni::ToJavaString(env, appName);
 }
 
+JNIEXPORT jstring JNICALL
+Java_app_organicmaps_Framework_nativeGetParsedOAuth2Code(JNIEnv * env, jclass)
+{
+    std::string const & code = frm()->GetParsedOAuth2Code();
+    return jni::ToJavaString(env, code);
+}
+
 JNIEXPORT jstring JNICALL
 Java_app_organicmaps_Framework_nativeGetParsedBackUrl(JNIEnv * env, jclass)
 {
diff --git a/android/app/src/main/java/app/organicmaps/Framework.java b/android/app/src/main/java/app/organicmaps/Framework.java
index 2a076225c3..a5d65bbb96 100644
--- a/android/app/src/main/java/app/organicmaps/Framework.java
+++ b/android/app/src/main/java/app/organicmaps/Framework.java
@@ -239,6 +239,7 @@ public class Framework
   public static native ParsedRoutingData nativeGetParsedRoutingData();
   public static native ParsedSearchRequest nativeGetParsedSearchRequest();
   public static native @Nullable String nativeGetParsedAppName();
+  public static native @Nullable String nativeGetParsedOAuth2Code();
   @Nullable @Size(2)
   public static native double[] nativeGetParsedCenterLatLon();
   public static native @Nullable String nativeGetParsedBackUrl();
diff --git a/android/app/src/main/java/app/organicmaps/api/RequestType.java b/android/app/src/main/java/app/organicmaps/api/RequestType.java
index e90743a5bb..0634d305cf 100644
--- a/android/app/src/main/java/app/organicmaps/api/RequestType.java
+++ b/android/app/src/main/java/app/organicmaps/api/RequestType.java
@@ -6,7 +6,7 @@ import java.lang.annotation.Retention;
 import java.lang.annotation.RetentionPolicy;
 
 @Retention(RetentionPolicy.SOURCE)
-@IntDef({RequestType.INCORRECT, RequestType.MAP, RequestType.ROUTE, RequestType.SEARCH, RequestType.CROSSHAIR})
+@IntDef({RequestType.INCORRECT, RequestType.MAP, RequestType.ROUTE, RequestType.SEARCH, RequestType.CROSSHAIR, RequestType.OAUTH2})
 public @interface RequestType
 {
   // Represents url_scheme::ParsedMapApi::UrlType from c++ part.
@@ -15,4 +15,5 @@ public @interface RequestType
   public static final int ROUTE = 2;
   public static final int SEARCH = 3;
   public static final int CROSSHAIR = 4;
+  public static final int OAUTH2 = 5;
 }
diff --git a/android/app/src/main/java/app/organicmaps/intent/Factory.java b/android/app/src/main/java/app/organicmaps/intent/Factory.java
index 2ddf4a28c6..46c10b4213 100644
--- a/android/app/src/main/java/app/organicmaps/intent/Factory.java
+++ b/android/app/src/main/java/app/organicmaps/intent/Factory.java
@@ -3,6 +3,7 @@ package app.organicmaps.intent;
 import android.content.ContentResolver;
 import android.content.Intent;
 import android.net.Uri;
+import android.util.Log;
 
 import androidx.annotation.NonNull;
 import androidx.core.content.IntentCompat;
@@ -128,6 +129,15 @@ public class Factory
             Framework.nativeSetViewportCenter(latlon[0], latlon[1], SEARCH_IN_VIEWPORT_ZOOM);
           }
 
+          return true;
+        }
+        case RequestType.OAUTH2:
+        {
+          SearchEngine.INSTANCE.cancelInteractiveSearch();
+
+          final String oauth2code = Framework.nativeGetParsedOAuth2Code();
+          Log.i("TAG", oauth2code);
+
           return true;
         }
       }
diff --git a/map/framework.cpp b/map/framework.cpp
index e81b282ceb..eff1b1b136 100644
--- a/map/framework.cpp
+++ b/map/framework.cpp
@@ -1738,6 +1738,11 @@ url_scheme::SearchRequest Framework::GetParsedSearchRequest() const
   return m_parsedMapApi.GetSearchRequest();
 }
 
+std::string Framework::GetParsedOAuth2Code() const
+{
+  return m_parsedMapApi.GetOAuth2Code();
+}
+
 std::string const & Framework::GetParsedAppName() const
 {
   return m_parsedMapApi.GetAppName();
diff --git a/map/framework.hpp b/map/framework.hpp
index e345b7d721..6b7ea84dbe 100644
--- a/map/framework.hpp
+++ b/map/framework.hpp
@@ -578,6 +578,7 @@ public:
 
   ParsedRoutingData GetParsedRoutingData() const;
   url_scheme::SearchRequest GetParsedSearchRequest() const;
+  std::string GetParsedOAuth2Code() const;
   std::string const & GetParsedAppName() const;
   std::string const & GetParsedBackUrl() const;
   ms::LatLon GetParsedCenterLatLon() const;
diff --git a/map/map_tests/mwm_url_tests.cpp b/map/map_tests/mwm_url_tests.cpp
index 6c0e0f1454..6763f1f32e 100644
--- a/map/map_tests/mwm_url_tests.cpp
+++ b/map/map_tests/mwm_url_tests.cpp
@@ -474,6 +474,13 @@ UNIT_TEST(AppNameTest)
   }
 }
 
+UNIT_TEST(OAuth2Test)
+{
+  ParsedMapApi api("om://oauth2/osm/callback?code=THE_MEGA_CODE");
+  TEST_EQUAL(api.GetRequestType(), UrlType::OAuth2, ());
+  TEST_EQUAL(api.GetOAuth2Code(), "THE_MEGA_CODE", ());
+}
+
 namespace
 {
 string generatePartOfUrl(url_scheme::MapPoint const & point)
diff --git a/map/mwm_url.cpp b/map/mwm_url.cpp
index 9eb3dbf8fc..b99e15109d 100644
--- a/map/mwm_url.cpp
+++ b/map/mwm_url.cpp
@@ -175,6 +175,22 @@ ParsedMapApi::UrlType ParsedMapApi::SetUrlAndParse(std::string const & raw)
 
       return m_requestType = UrlType::Crosshair;
     }
+    else if (type == "oauth2")
+    {
+      if (url.GetPath() != "osm/callback")
+        return m_requestType = UrlType::Incorrect;
+
+      url.ForEachParam([this](auto const & key, auto const & value)
+      {
+        if (key == "code")
+          m_oauth2code = value;
+      });
+
+      if (m_oauth2code.empty())
+        return m_requestType = UrlType::Incorrect;
+      else
+        return m_requestType = UrlType::OAuth2;
+    }
     else if (checkForGe0Link)
     {
       // The URL is prefixed by one of the kGe0Prefixes AND doesn't match any supported API call:
@@ -386,6 +402,7 @@ void ParsedMapApi::Reset()
   m_mapPoints.clear();
   m_routePoints.clear();
   m_searchRequest = {};
+  m_oauth2code = {};
   m_globalBackUrl ={};
   m_appName = {};
   m_centerLatLon = ms::LatLon::Invalid();
@@ -467,6 +484,7 @@ std::string DebugPrint(ParsedMapApi::UrlType type)
   case ParsedMapApi::UrlType::Route: return "Route";
   case ParsedMapApi::UrlType::Search: return "Search";
   case ParsedMapApi::UrlType::Crosshair: return "Crosshair";
+  case ParsedMapApi::UrlType::OAuth2: return "OAuth2";
   }
   UNREACHABLE();
 }
diff --git a/map/mwm_url.hpp b/map/mwm_url.hpp
index 6862d74794..b5bc22ada3 100644
--- a/map/mwm_url.hpp
+++ b/map/mwm_url.hpp
@@ -45,6 +45,7 @@ public:
     Route = 2,
     Search = 3,
     Crosshair = 4,
+    OAuth2 = 5,
   };
 
   ParsedMapApi() = default;
@@ -93,6 +94,12 @@ public:
     return m_searchRequest;
   }
 
+  std::string const & GetOAuth2Code() const
+  {
+    ASSERT_EQUAL(m_requestType, UrlType::OAuth2, ("Expected Search API"));
+    return m_oauth2code;
+  }
+
 private:
   void ParseMapParam(std::string const & key, std::string const & value,
                      bool & correctOrder);
@@ -107,6 +114,7 @@ private:
   SearchRequest m_searchRequest;
   std::string m_globalBackUrl;
   std::string m_appName;
+  std::string m_oauth2code;
   ms::LatLon m_centerLatLon = ms::LatLon::Invalid();
   std::string m_routingType;
   int m_version = 0;
-- 
2.45.3


From 9081d45d9a8683fa1f2ae8a019e7d059c12b0215 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Fri, 2 Aug 2024 16:08:06 +0300
Subject: [PATCH 03/13] Completed OAuth2 flow in OsmLoginFragment

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../cpp/app/organicmaps/editor/OsmOAuth.cpp   | 21 ++++++++
 .../organicmaps/editor/OsmLoginActivity.java  | 17 +++++++
 .../organicmaps/editor/OsmLoginFragment.java  | 48 ++++++++++++++++++-
 .../java/app/organicmaps/editor/OsmOAuth.java |  7 +++
 .../organicmaps/editor/ProfileActivity.java   |  2 +
 .../organicmaps/editor/ProfileFragment.java   |  2 +-
 .../java/app/organicmaps/intent/Factory.java  |  3 +-
 7 files changed, 96 insertions(+), 4 deletions(-)

diff --git a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
index 1533aca1df..d4ee8164bb 100644
--- a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
+++ b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@@ -66,6 +66,27 @@ Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithPassword(JNIEnv * env, jclass
   return nullptr;
 }
 
+JNIEXPORT jstring JNICALL
+Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass clazz, jstring oauth2code)
+{
+  OsmOAuth auth = OsmOAuth::ServerAuth();
+  try
+  {
+    auto token = auth.FinishAuthorization(ToNativeString(env, oauth2code));
+    if (!token.empty())
+    {
+        auth.SetAuthToken(token);
+        return ToJavaString(env, token);
+    }
+    LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code"));
+  }
+  catch (std::exception const & ex)
+  {
+    LOG(LWARNING, ("nativeAuthWithOAuth2Code error ", ex.what()));
+  }
+  return nullptr;
+}
+
 JNIEXPORT jstring JNICALL
 Java_app_organicmaps_editor_OsmOAuth_nativeGetOsmUsername(JNIEnv * env, jclass, jstring oauthToken)
 {
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginActivity.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginActivity.java
index 35894517bf..0e15133d16 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginActivity.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginActivity.java
@@ -1,14 +1,31 @@
 package app.organicmaps.editor;
 
+import android.app.Activity;
+import android.content.Intent;
+import android.os.Bundle;
+
+import androidx.annotation.NonNull;
 import androidx.fragment.app.Fragment;
 
 import app.organicmaps.base.BaseMwmFragmentActivity;
 
 public class OsmLoginActivity extends BaseMwmFragmentActivity
 {
+  public static final String EXTRA_OAUTH2CODE = "oauth2code";
+
   @Override
   protected Class<? extends Fragment> getFragmentClass()
   {
     return OsmLoginFragment.class;
   }
+
+  public static void OAuth2Callback(@NonNull Activity activity, String oauth2code)
+  {
+    final Intent i = new Intent(activity, OsmLoginActivity.class);
+    Bundle args = new Bundle();
+    args.putString(EXTRA_OAUTH2CODE, oauth2code);
+    args.putBoolean(ProfileActivity.EXTRA_REDIRECT_TO_PROFILE, true);
+    i.putExtras(args);
+    activity.startActivity(i);
+  }
 }
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
index 12c558a264..b4b8b3adcd 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@@ -36,6 +36,8 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
   private TextInputEditText mLoginInput;
   private TextInputEditText mPasswordInput;
 
+  private String mArgOAuth2Code;
+
   @Nullable
   @Override
   public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState)
@@ -62,6 +64,19 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
     final String dataVersion = DateUtils.getShortDateFormatter().format(Framework.getDataVersion());
     ((TextView) view.findViewById(R.id.osm_presentation))
         .setText(getString(R.string.osm_presentation, dataVersion));
+
+    readArguments();
+    if (mArgOAuth2Code != null && !mArgOAuth2Code.isEmpty())
+      continueOAuth2Flow(mArgOAuth2Code);
+  }
+
+  private void readArguments()
+  {
+    final Bundle arguments = getArguments();
+    if (arguments == null)
+      return;
+
+    mArgOAuth2Code = arguments.getString(OsmLoginActivity.EXTRA_OAUTH2CODE);
   }
 
   private void login()
@@ -82,7 +97,7 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
 
   private void loginWithBrowser()
   {
-    mLoginWebsiteButton.setEnabled(false);
+    enableInput(false);
 
     String[] oauthParams = OsmOAuth.nativeOAuthParams();
     Uri oauth2url = Uri.parse(oauthParams[0] + "/oauth2/authorize")
@@ -108,6 +123,35 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
     mLoginInput.setEnabled(enable);
     mLoginButton.setEnabled(enable);
     mLostPasswordButton.setEnabled(enable);
+    mLoginWebsiteButton.setEnabled(enable);
+  }
+
+  // This method is called by MwmActivity & UrlProcessor when "om://oauth2/osm/callback?code=XXX" is handled
+  private void continueOAuth2Flow(String oauth2code)
+  {
+    if (!isAdded())
+      return;
+
+    if (oauth2code == null || oauth2code.length()==0)
+    {
+      enableInput(true);
+      onAuthFail();
+    }
+    else
+    {
+      // Do not enable UI until we finish interaction with OAuth2 API
+      enableInput(false);
+
+      ThreadPool.getWorker().execute(() -> {
+        // Finish OAuth2 auth flow and get username for UI.
+        final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
+        final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
+        UiThread.run(() -> {
+          enableInput(true);
+          processAuth(oauthToken, username);
+        });
+      });
+    }
   }
 
   private void processAuth(String oauthToken, String username)
@@ -136,7 +180,7 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
   {
     OsmOAuth.setAuthorization(requireContext(), oauthToken, username);
     final Bundle extras = requireActivity().getIntent().getExtras();
-    if (extras != null && extras.getBoolean("redirectToProfile", false))
+    if (extras != null && extras.getBoolean(ProfileActivity.EXTRA_REDIRECT_TO_PROFILE, false))
       startActivity(new Intent(requireContext(), ProfileActivity.class));
     requireActivity().finish();
   }
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java b/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
index 36386850a6..1509cc00f0 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
@@ -114,6 +114,13 @@ public final class OsmOAuth
   @Nullable
   public static native String nativeAuthWithPassword(String login, String password);
 
+  /**
+   * @return string with OAuth2 token
+   */
+  @WorkerThread
+  @Nullable
+  public static native String nativeAuthWithOAuth2Code(String oauth2code);
+
   @WorkerThread
   @Nullable
   public static native String nativeGetOsmUsername(String oauthToken);
diff --git a/android/app/src/main/java/app/organicmaps/editor/ProfileActivity.java b/android/app/src/main/java/app/organicmaps/editor/ProfileActivity.java
index eb5a6076c3..625b54ef3a 100644
--- a/android/app/src/main/java/app/organicmaps/editor/ProfileActivity.java
+++ b/android/app/src/main/java/app/organicmaps/editor/ProfileActivity.java
@@ -6,6 +6,8 @@ import app.organicmaps.base.BaseMwmFragmentActivity;
 
 public class ProfileActivity extends BaseMwmFragmentActivity
 {
+  public static final String EXTRA_REDIRECT_TO_PROFILE = "redirectToProfile";
+
   @Override
   protected Class<? extends Fragment> getFragmentClass()
   {
diff --git a/android/app/src/main/java/app/organicmaps/editor/ProfileFragment.java b/android/app/src/main/java/app/organicmaps/editor/ProfileFragment.java
index 95ff55c045..4f48fc11b0 100644
--- a/android/app/src/main/java/app/organicmaps/editor/ProfileFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/ProfileFragment.java
@@ -93,7 +93,7 @@ public class ProfileFragment extends BaseMwmToolbarFragment
     else
     {
       Intent intent = new Intent(requireContext(), OsmLoginActivity.class);
-      intent.putExtra("redirectToProfile", true);
+      intent.putExtra(ProfileActivity.EXTRA_REDIRECT_TO_PROFILE, true);
       startActivity(intent);
       requireActivity().finish();
     }
diff --git a/android/app/src/main/java/app/organicmaps/intent/Factory.java b/android/app/src/main/java/app/organicmaps/intent/Factory.java
index 46c10b4213..c58a84e09e 100644
--- a/android/app/src/main/java/app/organicmaps/intent/Factory.java
+++ b/android/app/src/main/java/app/organicmaps/intent/Factory.java
@@ -19,6 +19,7 @@ import app.organicmaps.api.RoutePoint;
 import app.organicmaps.bookmarks.data.BookmarkManager;
 import app.organicmaps.bookmarks.data.FeatureId;
 import app.organicmaps.bookmarks.data.MapObject;
+import app.organicmaps.editor.OsmLoginActivity;
 import app.organicmaps.routing.RoutingController;
 import app.organicmaps.search.SearchActivity;
 import app.organicmaps.search.SearchEngine;
@@ -136,7 +137,7 @@ public class Factory
           SearchEngine.INSTANCE.cancelInteractiveSearch();
 
           final String oauth2code = Framework.nativeGetParsedOAuth2Code();
-          Log.i("TAG", oauth2code);
+          OsmLoginActivity.OAuth2Callback(target, oauth2code);
 
           return true;
         }
-- 
2.45.3


From 8edf155970c5679e0910532f634efae91296cb59 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Fri, 2 Aug 2024 16:27:26 +0300
Subject: [PATCH 04/13] Improved tests for OSM OAuth2 URI parsing

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 map/map_tests/mwm_url_tests.cpp | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/map/map_tests/mwm_url_tests.cpp b/map/map_tests/mwm_url_tests.cpp
index 6763f1f32e..401fcf5925 100644
--- a/map/map_tests/mwm_url_tests.cpp
+++ b/map/map_tests/mwm_url_tests.cpp
@@ -476,9 +476,19 @@ UNIT_TEST(AppNameTest)
 
 UNIT_TEST(OAuth2Test)
 {
-  ParsedMapApi api("om://oauth2/osm/callback?code=THE_MEGA_CODE");
-  TEST_EQUAL(api.GetRequestType(), UrlType::OAuth2, ());
-  TEST_EQUAL(api.GetOAuth2Code(), "THE_MEGA_CODE", ());
+  {
+    ParsedMapApi api("om://oauth2/osm/callback?code=THE_MEGA_CODE");
+    TEST_EQUAL(api.GetRequestType(), UrlType::OAuth2, ());
+    TEST_EQUAL(api.GetOAuth2Code(), "THE_MEGA_CODE", ());
+  }
+  {
+    ParsedMapApi api("om://oauth2/google/callback?code=THE_MEGA_CODE");
+    TEST_EQUAL(api.GetRequestType(), UrlType::Incorrect, ());
+  }
+  {
+    ParsedMapApi api("om://oauth2/osm/callback?code=");
+    TEST_EQUAL(api.GetRequestType(), UrlType::Incorrect, ());
+  }
 }
 
 namespace
-- 
2.45.3


From 558b65398e8471d81dc77ed1e85cfc5cb771ea5b Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Fri, 2 Aug 2024 17:11:12 +0300
Subject: [PATCH 05/13] [ios] fixed compilation error

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.h  | 1 +
 iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.mm | 1 +
 iphone/Maps/Core/DeepLink/DeepLinkHandler.swift   | 4 ++++
 3 files changed, 6 insertions(+)

diff --git a/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.h b/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.h
index f13b642151..d62b92104d 100644
--- a/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.h
+++ b/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.h
@@ -8,6 +8,7 @@ typedef NS_ENUM(NSUInteger, DeeplinkUrlType) {
   DeeplinkUrlTypeRoute,
   DeeplinkUrlTypeSearch,
   DeeplinkUrlTypeCrosshair,
+  DeeplinkUrlTypeOAuth2
 };
 
 @interface DeepLinkParser : NSObject
diff --git a/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.mm b/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.mm
index 59d8800600..f50f0a2b0a 100644
--- a/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.mm
+++ b/iphone/CoreApi/CoreApi/DeepLink/DeepLinkParser.mm
@@ -13,6 +13,7 @@ static inline DeeplinkUrlType deeplinkUrlType(url_scheme::ParsedMapApi::UrlType
      case url_scheme::ParsedMapApi::UrlType::Route: return DeeplinkUrlTypeRoute;
      case url_scheme::ParsedMapApi::UrlType::Search: return DeeplinkUrlTypeSearch;
      case url_scheme::ParsedMapApi::UrlType::Crosshair: return DeeplinkUrlTypeCrosshair;
+     case url_scheme::ParsedMapApi::UrlType::OAuth2: return DeeplinkUrlTypeOAuth2;
    }
 }
 
diff --git a/iphone/Maps/Core/DeepLink/DeepLinkHandler.swift b/iphone/Maps/Core/DeepLink/DeepLinkHandler.swift
index 6629a4d4d8..04e6e23a2c 100644
--- a/iphone/Maps/Core/DeepLink/DeepLinkHandler.swift
+++ b/iphone/Maps/Core/DeepLink/DeepLinkHandler.swift
@@ -115,6 +115,10 @@
     case .crosshair:
       // Not supported on iOS.
       return false;
+      
+    case .oAuth2:
+      // TODO: support OAuth2
+      return false;
 
     case .incorrect:
       // Invalid URL or API parameters.
-- 
2.45.3


From c6a0ad53c370fc3fb52f3baf742d6a296a2aaf44 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Wed, 7 Aug 2024 14:24:14 +0300
Subject: [PATCH 06/13] Changed OSM login UI with 2 options: login+password or
 via browser.

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../editor/OsmLoginBottomFragment.java        | 104 +++++++++++++++++
 .../organicmaps/editor/OsmLoginFragment.java  |  79 +++----------
 .../main/res/layout/fragment_osm_login.xml    |  76 +-----------
 .../res/layout/fragment_osm_login_bottom.xml  | 108 ++++++++++++++++++
 4 files changed, 235 insertions(+), 132 deletions(-)
 create mode 100644 android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
 create mode 100644 android/app/src/main/res/layout/fragment_osm_login_bottom.xml

diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
new file mode 100644
index 0000000000..a25145a58e
--- /dev/null
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
@@ -0,0 +1,104 @@
+package app.organicmaps.editor;
+
+import android.os.Bundle;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.Button;
+import android.widget.ProgressBar;
+
+import androidx.annotation.NonNull;
+import androidx.annotation.Nullable;
+
+import com.google.android.material.bottomsheet.BottomSheetDialogFragment;
+import com.google.android.material.textfield.TextInputEditText;
+
+import app.organicmaps.R;
+import app.organicmaps.util.Constants;
+import app.organicmaps.util.InputUtils;
+import app.organicmaps.util.UiUtils;
+import app.organicmaps.util.Utils;
+import app.organicmaps.util.concurrency.ThreadPool;
+import app.organicmaps.util.concurrency.UiThread;
+
+public class OsmLoginBottomFragment extends BottomSheetDialogFragment {
+    final private OsmLoginFragment parentFragment;
+    private TextInputEditText mLoginInput;
+    private TextInputEditText mPasswordInput;
+    private Button mLoginButton;
+    private Button mLostPasswordButton;
+    private Button mRegisterButton;
+    private ProgressBar mProgress;
+
+    public OsmLoginBottomFragment(OsmLoginFragment parentFragment) {
+        super();
+        this.parentFragment = parentFragment;
+    }
+
+    @Override
+    public void onCreate(@Nullable Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+    }
+
+    @Nullable
+    @Override
+    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
+        return inflater.inflate(R.layout.fragment_osm_login_bottom, container, false);
+    }
+
+    @Override
+    public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
+        mLoginInput = view.findViewById(R.id.osm_username);
+        mPasswordInput = view.findViewById(R.id.osm_password);
+
+        mLoginButton = view.findViewById(R.id.login);
+        mLoginButton.setOnClickListener((v) -> doLogin());
+
+        mLostPasswordButton = view.findViewById(R.id.lost_password);
+        mLostPasswordButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_RECOVER_PASSWORD));
+        mRegisterButton = view.findViewById(R.id.register);
+        mRegisterButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_REGISTER));
+        mProgress = view.findViewById(R.id.osm_login_progress);
+    }
+
+    private void doLogin() {
+        InputUtils.hideKeyboard(mLoginInput);
+        final String username = mLoginInput.getText().toString().trim();
+        final String password = mPasswordInput.getText().toString();
+        enableInput(false);
+        UiUtils.show(mProgress);
+        mLoginButton.setText("");
+
+        ThreadPool.getWorker().execute(() -> {
+          final String oauthToken = OsmOAuth.nativeAuthWithPassword(username, password);
+          final String username1 = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
+          UiThread.run(() -> processAuth(oauthToken, username1));
+        });
+    }
+
+    private void processAuth(String oauthToken, String username)
+    {
+        if (!isAdded())
+            return;
+
+        enableInput(true);
+        UiUtils.hide(mProgress);
+        mLoginButton.setText(R.string.login_osm);
+
+        if (oauthToken == null)
+            parentFragment.onAuthFail();
+        else {
+            this.dismiss();
+            parentFragment.onAuthSuccess(oauthToken, username);
+        }
+    }
+
+    private void enableInput(boolean enable)
+    {
+        mPasswordInput.setEnabled(enable);
+        mLoginInput.setEnabled(enable);
+        mLoginButton.setEnabled(enable);
+        mLostPasswordButton.setEnabled(enable);
+        mRegisterButton.setEnabled(enable);
+    }
+}
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
index b4b8b3adcd..665ef25e4d 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@@ -8,33 +8,27 @@ import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.Button;
-import android.widget.ProgressBar;
+import android.widget.FrameLayout;
 import android.widget.TextView;
 
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
+import com.google.android.material.dialog.MaterialAlertDialogBuilder;
+
 import app.organicmaps.Framework;
 import app.organicmaps.R;
 import app.organicmaps.base.BaseMwmToolbarFragment;
-import app.organicmaps.util.Constants;
 import app.organicmaps.util.DateUtils;
-import app.organicmaps.util.InputUtils;
-import app.organicmaps.util.UiUtils;
-import app.organicmaps.util.Utils;
 import app.organicmaps.util.concurrency.ThreadPool;
 import app.organicmaps.util.concurrency.UiThread;
-import com.google.android.material.dialog.MaterialAlertDialogBuilder;
-import com.google.android.material.textfield.TextInputEditText;
 
 public class OsmLoginFragment extends BaseMwmToolbarFragment
 {
-  private ProgressBar mProgress;
-  private Button mLoginButton;
+  private FrameLayout loginBottomSheet;
+  //private BottomSheetBehavior<FrameLayout> standardBottomSheetBehavior;
+  private Button mLoginUsernameButton;
   private Button mLoginWebsiteButton;
-  private Button mLostPasswordButton;
-  private TextInputEditText mLoginInput;
-  private TextInputEditText mPasswordInput;
 
   private String mArgOAuth2Code;
 
@@ -50,17 +44,11 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
   {
     super.onViewCreated(view, savedInstanceState);
     getToolbarController().setTitle(R.string.login);
-    mLoginInput = view.findViewById(R.id.osm_username);
-    mPasswordInput = view.findViewById(R.id.osm_password);
+
     mLoginWebsiteButton = view.findViewById(R.id.login_website);
     mLoginWebsiteButton.setOnClickListener((v) -> loginWithBrowser());
-    mLoginButton = view.findViewById(R.id.login);
-    mLoginButton.setOnClickListener((v) -> login());
-    mLostPasswordButton = view.findViewById(R.id.lost_password);
-    mLostPasswordButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_RECOVER_PASSWORD));
-    Button registerButton = view.findViewById(R.id.register);
-    registerButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_REGISTER));
-    mProgress = view.findViewById(R.id.osm_login_progress);
+    mLoginUsernameButton = view.findViewById(R.id.login_username);
+    mLoginUsernameButton.setOnClickListener((v) -> loginUsername());
     final String dataVersion = DateUtils.getShortDateFormatter().format(Framework.getDataVersion());
     ((TextView) view.findViewById(R.id.osm_presentation))
         .setText(getString(R.string.osm_presentation, dataVersion));
@@ -79,26 +67,14 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
     mArgOAuth2Code = arguments.getString(OsmLoginActivity.EXTRA_OAUTH2CODE);
   }
 
-  private void login()
+  private void loginUsername()
   {
-    InputUtils.hideKeyboard(mLoginInput);
-    final String username = mLoginInput.getText().toString().trim();
-    final String password = mPasswordInput.getText().toString();
-    enableInput(false);
-    UiUtils.show(mProgress);
-    mLoginButton.setText("");
-
-    ThreadPool.getWorker().execute(() -> {
-      final String oauthToken = OsmOAuth.nativeAuthWithPassword(username, password);
-      final String username1 = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
-      UiThread.run(() -> processAuth(oauthToken, username1));
-    });
+    OsmLoginBottomFragment bottomSheetFragment = new OsmLoginBottomFragment(this);
+    bottomSheetFragment.show(requireActivity().getSupportFragmentManager(), bottomSheetFragment.getTag());
   }
 
   private void loginWithBrowser()
   {
-    enableInput(false);
-
     String[] oauthParams = OsmOAuth.nativeOAuthParams();
     Uri oauth2url = Uri.parse(oauthParams[0] + "/oauth2/authorize")
             .buildUpon()
@@ -117,66 +93,49 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
     }
   }
 
-  private void enableInput(boolean enable)
-  {
-    mPasswordInput.setEnabled(enable);
-    mLoginInput.setEnabled(enable);
-    mLoginButton.setEnabled(enable);
-    mLostPasswordButton.setEnabled(enable);
-    mLoginWebsiteButton.setEnabled(enable);
-  }
-
   // This method is called by MwmActivity & UrlProcessor when "om://oauth2/osm/callback?code=XXX" is handled
   private void continueOAuth2Flow(String oauth2code)
   {
     if (!isAdded())
       return;
 
-    if (oauth2code == null || oauth2code.length()==0)
+    if (oauth2code == null || oauth2code.isEmpty())
     {
-      enableInput(true);
       onAuthFail();
     }
     else
     {
-      // Do not enable UI until we finish interaction with OAuth2 API
-      enableInput(false);
-
       ThreadPool.getWorker().execute(() -> {
         // Finish OAuth2 auth flow and get username for UI.
         final String oauthToken = OsmOAuth.nativeAuthWithOAuth2Code(oauth2code);
         final String username = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
         UiThread.run(() -> {
-          enableInput(true);
           processAuth(oauthToken, username);
         });
       });
     }
   }
 
-  private void processAuth(String oauthToken, String username)
+  public void processAuth(String oauthToken, String username)
   {
     if (!isAdded())
       return;
 
-    enableInput(true);
-    UiUtils.hide(mProgress);
-    mLoginButton.setText(R.string.login_osm);
     if (oauthToken == null)
       onAuthFail();
     else
       onAuthSuccess(oauthToken, username);
   }
 
-  private void onAuthFail()
+  public void onAuthFail()
   {
     new MaterialAlertDialogBuilder(requireActivity(), R.style.MwmTheme_AlertDialog)
-        .setTitle(R.string.editor_login_error_dialog)
-        .setPositiveButton(R.string.ok, null)
-        .show();
+            .setTitle(R.string.editor_login_error_dialog)
+            .setPositiveButton(R.string.ok, null)
+            .show();
   }
 
-  private void onAuthSuccess(String oauthToken, String username)
+  public void onAuthSuccess(String oauthToken, String username)
   {
     OsmOAuth.setAuthorization(requireContext(), oauthToken, username);
     final Bundle extras = requireActivity().getIntent().getExtras();
diff --git a/android/app/src/main/res/layout/fragment_osm_login.xml b/android/app/src/main/res/layout/fragment_osm_login.xml
index 988ab6cb27..b9fdf0287c 100644
--- a/android/app/src/main/res/layout/fragment_osm_login.xml
+++ b/android/app/src/main/res/layout/fragment_osm_login.xml
@@ -63,87 +63,19 @@
       <Button
           android:id="@+id/login_website"
           style="@style/MwmWidget.Button.Accent"
+          android:layout_marginTop="@dimen/margin_base"
           android:layout_width="match_parent"
           android:layout_height="wrap_content"
           android:text="Login with OSM website"
           android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
-      <com.google.android.material.textfield.TextInputLayout
-        style="@style/MwmWidget.Editor.CustomTextInput"
-        android:layout_marginTop="@dimen/margin_half"
-        android:textColorHint="?android:textColorSecondary"
-        app:endIconMode="custom">
-        <com.google.android.material.textfield.TextInputEditText
-          android:id="@+id/osm_username"
-          style="@style/MwmWidget.Editor.FieldLayout.EditText"
-          android:autofillHints="emailAddress"
-          android:hint="@string/email_or_username" />
-      </com.google.android.material.textfield.TextInputLayout>
-      <com.google.android.material.textfield.TextInputLayout
-        style="@style/MwmWidget.Editor.CustomTextInput"
-        android:layout_marginTop="@dimen/margin_base"
-        android:textColorHint="?android:textColorSecondary"
-        app:endIconMode="password_toggle"
-        app:endIconTint="?android:textColorSecondary">
-        <com.google.android.material.textfield.TextInputEditText
-          android:id="@+id/osm_password"
-          style="@style/MwmWidget.Editor.FieldLayout.EditText"
-          android:autofillHints="password"
-          android:hint="@string/password"
-          android:inputType="textPassword" />
-      </com.google.android.material.textfield.TextInputLayout>
-      <FrameLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_marginBottom="@dimen/margin_base">
-        <Button
-          android:id="@+id/login"
-          style="@style/MwmWidget.Button.Accent"
-          android:layout_width="match_parent"
-          android:layout_height="wrap_content"
-          android:text="@string/login_osm"
-          android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
-        <ProgressBar
-          android:id="@+id/osm_login_progress"
-          android:layout_width="@dimen/editor_auth_btn_height"
-          android:layout_height="@dimen/editor_auth_btn_height"
-          android:layout_gravity="center"
-          android:elevation="@dimen/design_fab_elevation"
-          android:visibility="gone" />
-      </FrameLayout>
       <Button
-        android:id="@+id/lost_password"
-        style="@style/MwmWidget.Button"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:layout_gravity="end"
-        android:background="?clickableBackground"
-        android:padding="@dimen/margin_half"
-        android:text="@string/forgot_password"
-        android:textAppearance="@style/MwmTextAppearance.Body3" />
-      <com.google.android.material.divider.MaterialDivider
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/margin_base"
-        android:layout_marginBottom="@dimen/margin_base" />
-      <TextView
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:fontFamily="@string/robotoRegular"
-        android:text="@string/no_osm_account"
-        android:textAppearance="@style/MwmTextAppearance.Body2"
-        android:textColor="?android:textColorPrimary" />
-      <Button
-        android:id="@+id/register"
+        android:id="@+id/login_username"
         style="@style/MwmWidget.Button.Accent"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        android:text="Login with username"
         android:layout_marginTop="@dimen/margin_base"
-        android:background="@drawable/button_editor_light"
-        android:fontFamily="@string/robotoMedium"
-        android:padding="@dimen/margin_quarter"
-        android:text="@string/register_at_openstreetmap"
-        android:textAppearance="@style/MwmTextAppearance.Body2"
-        android:textColor="@color/text_dark" />
+        android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
     </LinearLayout>
   </ScrollView>
 </LinearLayout>
diff --git a/android/app/src/main/res/layout/fragment_osm_login_bottom.xml b/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
new file mode 100644
index 0000000000..65d87d1b5d
--- /dev/null
+++ b/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
@@ -0,0 +1,108 @@
+<?xml version="1.0" encoding="utf-8"?>
+<LinearLayout
+  xmlns:android="http://schemas.android.com/apk/res/android"
+  xmlns:app="http://schemas.android.com/apk/res-auto"
+  xmlns:tools="http://schemas.android.com/tools"
+  android:layout_width="match_parent"
+  android:layout_height="match_parent"
+  android:orientation="vertical">
+  <ScrollView
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    android:background="?cardBackground"
+    android:fadeScrollbars="false"
+    android:fillViewport="true"
+    tools:ignore="DuplicateIds">
+    <LinearLayout
+      android:layout_width="match_parent"
+      android:layout_height="match_parent"
+      android:clipChildren="false"
+      android:clipToPadding="false"
+      android:orientation="vertical"
+      android:padding="@dimen/margin_base"
+      tools:ignore="ScrollViewSize">
+      <LinearLayout
+          android:id="@+id/login_bottom_sheet"
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:orientation="vertical">
+
+        <com.google.android.material.textfield.TextInputLayout
+            style="@style/MwmWidget.Editor.CustomTextInput"
+            android:layout_marginTop="@dimen/margin_half"
+            android:textColorHint="?android:textColorSecondary"
+            app:endIconMode="custom">
+          <com.google.android.material.textfield.TextInputEditText
+              android:id="@+id/osm_username"
+              style="@style/MwmWidget.Editor.FieldLayout.EditText"
+              android:padding="@dimen/margin_half_double_plus"
+              android:autofillHints="emailAddress"
+              android:hint="@string/email_or_username" />
+        </com.google.android.material.textfield.TextInputLayout>
+        <com.google.android.material.textfield.TextInputLayout
+            style="@style/MwmWidget.Editor.CustomTextInput"
+            android:textColorHint="?android:textColorSecondary"
+            app:endIconMode="password_toggle"
+            app:endIconTint="?android:textColorSecondary">
+          <com.google.android.material.textfield.TextInputEditText
+              android:id="@+id/osm_password"
+              style="@style/MwmWidget.Editor.FieldLayout.EditText"
+              android:padding="@dimen/margin_half_double_plus"
+              android:autofillHints="password"
+              android:hint="@string/password"
+              android:inputType="textPassword" />
+        </com.google.android.material.textfield.TextInputLayout>
+      </LinearLayout>
+
+      <FrameLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/margin_base">
+        <Button
+          android:id="@+id/login"
+          style="@style/MwmWidget.Button.Accent"
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:text="Login with username"
+            android:layout_marginTop="@dimen/margin_half"
+          android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
+        <ProgressBar
+          android:id="@+id/osm_login_progress"
+          android:layout_width="@dimen/editor_auth_btn_height"
+          android:layout_height="@dimen/editor_auth_btn_height"
+          android:layout_gravity="center"
+          android:elevation="@dimen/design_fab_elevation"
+          android:visibility="gone" />
+      </FrameLayout>
+
+      <LinearLayout
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:orientation="horizontal"
+          android:layout_marginTop="@dimen/margin_base">
+        <Button
+            android:id="@+id/lost_password"
+            style="@style/MwmWidget.Button"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="start"
+            android:layout_weight="1"
+            android:background="?clickableBackground"
+            android:padding="@dimen/margin_quarter"
+            android:text="@string/forgot_password"
+            android:textAppearance="@style/MwmTextAppearance.Body3" />
+        <Button
+            android:id="@+id/register"
+            style="@style/MwmWidget.Button"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_weight="1"
+            android:layout_gravity="end"
+            android:background="?clickableBackground"
+            android:padding="@dimen/margin_quarter"
+            android:text="@string/register_at_openstreetmap"
+            android:textAppearance="@style/MwmTextAppearance.Body3" />
+      </LinearLayout>
+    </LinearLayout>
+  </ScrollView>
+</LinearLayout>
-- 
2.45.3


From 7cc56dd3186a428be332355e468061800e7676f5 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Mon, 19 Aug 2024 17:26:51 +0300
Subject: [PATCH 07/13] [Android] Build OAuth2 URL using native code instead of
 Java

Small changes according to PR comments

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../cpp/app/organicmaps/editor/OsmOAuth.cpp   | 19 +++++-----------
 .../organicmaps/editor/OsmLoginFragment.java  | 22 +++++--------------
 .../java/app/organicmaps/editor/OsmOAuth.java |  2 +-
 editor/osm_auth.cpp                           | 21 +++++++++++-------
 editor/osm_auth.hpp                           |  2 +-
 map/mwm_url.hpp                               |  2 +-
 6 files changed, 28 insertions(+), 40 deletions(-)

diff --git a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
index d4ee8164bb..848e7e485d 100644
--- a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
+++ b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@@ -34,18 +34,11 @@ bool LoadOsmUserPreferences(std::string const & oauthToken, UserPreferences & ou
 extern "C"
 {
 
-JNIEXPORT jobjectArray JNICALL
-Java_app_organicmaps_editor_OsmOAuth_nativeOAuthParams(JNIEnv * env, jclass clazz)
+JNIEXPORT jstring JNICALL
+Java_app_organicmaps_editor_OsmOAuth_nativeGetOAuth2Url(JNIEnv * env, jclass)
 {
-    OsmOAuth auth = OsmOAuth::ServerAuth();
-    jobjectArray oauthParams = env->NewObjectArray(5, env->FindClass("java/lang/String"), nullptr);
-    env->SetObjectArrayElement(oauthParams, 0, ToJavaString(env, auth.GetBaseUrl()));
-    env->SetObjectArrayElement(oauthParams, 1, ToJavaString(env, auth.GetClientId()));
-    env->SetObjectArrayElement(oauthParams, 2, ToJavaString(env, auth.GetClientSecret()));
-    env->SetObjectArrayElement(oauthParams, 3, ToJavaString(env, auth.GetScope()));
-    env->SetObjectArrayElement(oauthParams, 4, ToJavaString(env, auth.GetRedirectUri()));
-
-    return oauthParams;
+    auto const auth = OsmOAuth::ServerAuth();
+    return ToJavaString(env, auth.BuildOAuth2Url());
 }
 
 JNIEXPORT jstring JNICALL
@@ -67,7 +60,7 @@ Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithPassword(JNIEnv * env, jclass
 }
 
 JNIEXPORT jstring JNICALL
-Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass clazz, jstring oauth2code)
+Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jclass, jstring oauth2code)
 {
   OsmOAuth auth = OsmOAuth::ServerAuth();
   try
@@ -78,7 +71,7 @@ Java_app_organicmaps_editor_OsmOAuth_nativeAuthWithOAuth2Code(JNIEnv * env, jcla
         auth.SetAuthToken(token);
         return ToJavaString(env, token);
     }
-    LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code"));
+    LOG(LWARNING, ("nativeAuthWithOAuth2Code: invalid OAuth2 code", oauth2code));
   }
   catch (std::exception const & ex)
   {
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
index 665ef25e4d..76ee0014d0 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@@ -8,7 +8,6 @@ import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.Button;
-import android.widget.FrameLayout;
 import android.widget.TextView;
 
 import androidx.annotation.NonNull;
@@ -25,8 +24,6 @@ import app.organicmaps.util.concurrency.UiThread;
 
 public class OsmLoginFragment extends BaseMwmToolbarFragment
 {
-  private FrameLayout loginBottomSheet;
-  //private BottomSheetBehavior<FrameLayout> standardBottomSheetBehavior;
   private Button mLoginUsernameButton;
   private Button mLoginWebsiteButton;
 
@@ -75,18 +72,13 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
 
   private void loginWithBrowser()
   {
-    String[] oauthParams = OsmOAuth.nativeOAuthParams();
-    Uri oauth2url = Uri.parse(oauthParams[0] + "/oauth2/authorize")
-            .buildUpon()
-            .appendQueryParameter("client_id", oauthParams[1])
-            .appendQueryParameter("scope", oauthParams[3])
-            .appendQueryParameter("redirect_uri", oauthParams[4])
-            .appendQueryParameter("response_type", "code")
-            .build();
-    try {
-      Intent myIntent = new Intent(Intent.ACTION_VIEW, oauth2url);
+    try
+    {
+      Intent myIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(OsmOAuth.nativeGetOAuth2Url()));
       startActivity(myIntent);
-    } catch (ActivityNotFoundException e) {
+    }
+    catch (ActivityNotFoundException e)
+    {
       //Toast.makeText(this, "No application can handle this request."
       //        + " Please install a webbrowser",  Toast.LENGTH_LONG).show();
       e.printStackTrace();
@@ -100,9 +92,7 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
       return;
 
     if (oauth2code == null || oauth2code.isEmpty())
-    {
       onAuthFail();
-    }
     else
     {
       ThreadPool.getWorker().execute(() -> {
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java b/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
index 1509cc00f0..a8afa2f3b6 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmOAuth.java
@@ -104,7 +104,7 @@ public final class OsmOAuth
    Returns 5 strings: ServerURL, ClientId, ClientSecret, Scope, RedirectUri
    */
   @NonNull
-  public static native String[] nativeOAuthParams();
+  public static native String nativeGetOAuth2Url();
 
   /**
    * @return string with OAuth2 token
diff --git a/editor/osm_auth.cpp b/editor/osm_auth.cpp
index 869dc25a77..ee438b4f2c 100644
--- a/editor/osm_auth.cpp
+++ b/editor/osm_auth.cpp
@@ -241,14 +241,7 @@ string OsmOAuth::SendAuthRequest(string const & requestTokenKey, SessionID const
 
 string OsmOAuth::FetchRequestToken(SessionID const & sid) const
 {
-  string const requestTokenUrl = m_baseUrl + "/oauth2/authorize";
-  string const requestTokenQuery =  BuildPostRequest({
-      {"client_id", m_oauth2params.m_clientId},
-      {"redirect_uri", m_oauth2params.m_redirectUri},
-      {"scope", m_oauth2params.m_scope},
-      {"response_type", "code"}
-  });
-  HttpClient request(requestTokenUrl + "?" + requestTokenQuery);
+  HttpClient request(BuildOAuth2Url());
   request.SetCookies(sid.m_cookies)
          .SetFollowRedirects(false);
 
@@ -280,6 +273,18 @@ string OsmOAuth::FetchRequestToken(SessionID const & sid) const
   }
 }
 
+string OsmOAuth::BuildOAuth2Url() const
+{
+   string const requestTokenUrl = m_baseUrl + "/oauth2/authorize";
+   string const requestTokenQuery = BuildPostRequest({
+       {"client_id", m_oauth2params.m_clientId},
+       {"redirect_uri", m_oauth2params.m_redirectUri},
+       {"scope", m_oauth2params.m_scope},
+       {"response_type", "code"}
+   });
+   return requestTokenUrl + "?" + requestTokenQuery;
+}
+
 string OsmOAuth::FinishAuthorization(string const & oauth2code) const
 {
   auto params = BuildPostRequest({
diff --git a/editor/osm_auth.hpp b/editor/osm_auth.hpp
index 2d48ca994c..27320ff7a3 100644
--- a/editor/osm_auth.hpp
+++ b/editor/osm_auth.hpp
@@ -109,6 +109,7 @@ public:
   {
     return m_baseUrl + "/user/" + user + "/history";
   }
+  std::string BuildOAuth2Url() const;
   //@}
 
 private:
@@ -143,7 +144,6 @@ private:
   /// @returns valid key and secret or throws otherwise.
   std::string FetchRequestToken(SessionID const & sid) const;
   std::string FetchAccessToken(SessionID const & sid) const;
-  //AuthResult FetchAccessToken(SessionID const & sid);
 };
 
 std::string DebugPrint(OsmOAuth::Response const & code);
diff --git a/map/mwm_url.hpp b/map/mwm_url.hpp
index b5bc22ada3..aef4fe4c20 100644
--- a/map/mwm_url.hpp
+++ b/map/mwm_url.hpp
@@ -96,7 +96,7 @@ public:
 
   std::string const & GetOAuth2Code() const
   {
-    ASSERT_EQUAL(m_requestType, UrlType::OAuth2, ("Expected Search API"));
+    ASSERT_EQUAL(m_requestType, UrlType::OAuth2, ("Expected OAuth2 API"));
     return m_oauth2code;
   }
 
-- 
2.45.3


From db1552c1bfc27e6a8674151a87cb17134ffffad9 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Mon, 19 Aug 2024 19:58:44 +0300
Subject: [PATCH 08/13] Fixed landscape layout for OSM Login UI. Set
 username+password bottom panel behaviour to expand by default.

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../editor/OsmLoginBottomFragment.java        |  11 ++
 .../res/layout-land/fragment_osm_login.xml    | 125 +++---------------
 .../layout-land/fragment_osm_login_bottom.xml | 115 ++++++++++++++++
 3 files changed, 145 insertions(+), 106 deletions(-)
 create mode 100644 android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml

diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
index a25145a58e..3341d62dff 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
@@ -1,5 +1,6 @@
 package app.organicmaps.editor;
 
+import android.app.Dialog;
 import android.os.Bundle;
 import android.view.LayoutInflater;
 import android.view.View;
@@ -10,6 +11,8 @@ import android.widget.ProgressBar;
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
+import com.google.android.material.bottomsheet.BottomSheetBehavior;
+import com.google.android.material.bottomsheet.BottomSheetDialog;
 import com.google.android.material.bottomsheet.BottomSheetDialogFragment;
 import com.google.android.material.textfield.TextInputEditText;
 
@@ -46,6 +49,14 @@ public class OsmLoginBottomFragment extends BottomSheetDialogFragment {
         return inflater.inflate(R.layout.fragment_osm_login_bottom, container, false);
     }
 
+    @NonNull
+    @Override
+    public Dialog onCreateDialog(Bundle savedInstanceState) {
+        BottomSheetDialog dialog = (BottomSheetDialog) super.onCreateDialog(savedInstanceState);
+        dialog.getBehavior().setState(BottomSheetBehavior.STATE_EXPANDED);
+        return dialog;
+    }
+
     @Override
     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
         mLoginInput = view.findViewById(R.id.osm_username);
diff --git a/android/app/src/main/res/layout-land/fragment_osm_login.xml b/android/app/src/main/res/layout-land/fragment_osm_login.xml
index e5b177f708..a811956ee2 100644
--- a/android/app/src/main/res/layout-land/fragment_osm_login.xml
+++ b/android/app/src/main/res/layout-land/fragment_osm_login.xml
@@ -63,119 +63,32 @@
       <androidx.constraintlayout.widget.ConstraintLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/margin_half">
-        <com.google.android.material.textfield.TextInputLayout
-          android:id="@+id/osm_username_container"
-          style="@style/MwmWidget.Editor.CustomTextInput"
-          android:layout_width="0dp"
-          android:layout_marginEnd="@dimen/margin_half"
-          android:textColorHint="?android:textColorSecondary"
-          app:layout_constraintStart_toStartOf="parent"
-          app:layout_constraintEnd_toStartOf="@id/osm_password_container"
-          app:layout_constraintTop_toTopOf="parent"
-          app:endIconMode="custom">
-          <com.google.android.material.textfield.TextInputEditText
-            android:id="@+id/osm_username"
-            style="@style/MwmWidget.Editor.FieldLayout.EditText"
-            android:autofillHints="emailAddress"
-            android:hint="@string/email_or_username" />
-        </com.google.android.material.textfield.TextInputLayout>
-        <com.google.android.material.textfield.TextInputLayout
-          android:id="@+id/osm_password_container"
-          style="@style/MwmWidget.Editor.CustomTextInput"
-          android:layout_width="0dp"
-          android:textColorHint="?android:textColorSecondary"
-          app:layout_constraintStart_toEndOf="@id/osm_username_container"
-          app:layout_constraintEnd_toEndOf="parent"
-          app:layout_constraintTop_toTopOf="parent"
-          app:endIconMode="password_toggle"
-          app:endIconTint="?android:textColorSecondary">
-          <com.google.android.material.textfield.TextInputEditText
-            android:id="@+id/osm_password"
-            style="@style/MwmWidget.Editor.FieldLayout.EditText"
-            android:autofillHints="password"
-            android:hint="@string/password"
-            android:inputType="textPassword" />
-        </com.google.android.material.textfield.TextInputLayout>
-      </androidx.constraintlayout.widget.ConstraintLayout>
-      <androidx.constraintlayout.widget.ConstraintLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content"
-        android:layout_marginBottom="@dimen/margin_base">
-        <FrameLayout
-          android:id="@+id/login_container"
-          android:layout_width="0dp"
-          android:layout_height="wrap_content"
-          app:layout_constraintBottom_toBottomOf="parent"
-          app:layout_constraintEnd_toEndOf="parent"
-          app:layout_constraintStart_toEndOf="@id/lost_password"
-          app:layout_constraintTop_toTopOf="parent">
-          <Button
-            android:id="@+id/login"
-            style="@style/MwmWidget.Button.Accent"
-            android:layout_width="match_parent"
-            android:layout_height="wrap_content"
-            android:text="@string/login_osm"
-            android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
-          <ProgressBar
-            android:id="@+id/osm_login_progress"
-            android:layout_width="@dimen/editor_auth_btn_height"
-            android:layout_height="@dimen/editor_auth_btn_height"
-            android:layout_gravity="center"
-            android:elevation="@dimen/design_fab_elevation"
-            android:visibility="gone" />
-        </FrameLayout>
-        <Button
-          android:id="@+id/lost_password"
-          style="@style/MwmWidget.Button"
-          android:layout_width="0dp"
-          android:layout_height="wrap_content"
-          android:background="?clickableBackground"
-          android:gravity="start|center_vertical"
-          android:padding="@dimen/margin_half"
-          android:text="@string/forgot_password"
-          android:textAppearance="@style/MwmTextAppearance.Body3"
-          app:layout_constraintBottom_toBottomOf="parent"
-          app:layout_constraintEnd_toStartOf="@id/login_container"
-          app:layout_constraintStart_toStartOf="parent"
-          app:layout_constraintTop_toTopOf="parent" />
-      </androidx.constraintlayout.widget.ConstraintLayout>
-      <com.google.android.material.divider.MaterialDivider
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
         android:layout_marginTop="@dimen/margin_base"
-        android:layout_marginBottom="@dimen/margin_base" />
-      <androidx.constraintlayout.widget.ConstraintLayout
-        android:layout_width="match_parent"
-        android:layout_height="wrap_content">
-        <TextView
-          android:id="@+id/register_text"
-          android:layout_width="0dp"
-          android:layout_height="wrap_content"
-          android:fontFamily="@string/robotoRegular"
-          android:gravity="start|center_vertical"
-          android:text="@string/no_osm_account"
-          android:textAppearance="@style/MwmTextAppearance.Body2"
-          android:textColor="?android:textColorPrimary"
-          app:layout_constraintBottom_toBottomOf="parent"
-          app:layout_constraintEnd_toStartOf="@id/register"
-          app:layout_constraintStart_toStartOf="parent"
-          app:layout_constraintTop_toTopOf="parent" />
+        android:layout_marginBottom="@dimen/margin_base">
         <Button
-          android:id="@+id/register"
+          android:id="@+id/login_website"
           style="@style/MwmWidget.Button.Accent"
           android:layout_width="0dp"
           android:layout_height="wrap_content"
-          android:background="@drawable/button_editor_light"
-          android:fontFamily="@string/robotoMedium"
-          android:padding="@dimen/margin_quarter"
-          android:text="@string/register_at_openstreetmap"
-          android:textAppearance="@style/MwmTextAppearance.Body2"
-          android:textColor="@color/text_dark"
+          android:padding="@dimen/margin_half"
+            android:layout_marginEnd="@dimen/margin_base"
+          android:text="Login with OSM website"
+          android:textAppearance="@style/MwmTextAppearance.Body2.Light"
           app:layout_constraintBottom_toBottomOf="parent"
-          app:layout_constraintEnd_toEndOf="parent"
-          app:layout_constraintStart_toEndOf="@id/register_text"
+          app:layout_constraintEnd_toStartOf="@id/login_username"
+          app:layout_constraintStart_toStartOf="parent"
           app:layout_constraintTop_toTopOf="parent" />
+        <Button
+          android:id="@+id/login_username"
+          style="@style/MwmWidget.Button.Accent"
+          android:layout_width="0dp"
+          android:layout_height="wrap_content"
+          android:text="Login with username"
+          android:textAppearance="@style/MwmTextAppearance.Body2.Light"
+          app:layout_constraintStart_toEndOf="@id/login_website"
+          app:layout_constraintTop_toTopOf="parent"
+          app:layout_constraintBottom_toBottomOf="parent"
+          app:layout_constraintEnd_toEndOf="parent" />
       </androidx.constraintlayout.widget.ConstraintLayout>
     </LinearLayout>
   </ScrollView>
diff --git a/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml b/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
new file mode 100644
index 0000000000..1adcc541cf
--- /dev/null
+++ b/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
@@ -0,0 +1,115 @@
+<?xml version="1.0" encoding="utf-8"?>
+<LinearLayout
+  xmlns:android="http://schemas.android.com/apk/res/android"
+  xmlns:app="http://schemas.android.com/apk/res-auto"
+  xmlns:tools="http://schemas.android.com/tools"
+  android:layout_width="match_parent"
+  android:layout_height="match_parent"
+  android:orientation="vertical">
+  <ScrollView
+    android:layout_width="match_parent"
+    android:layout_height="match_parent"
+    android:background="?cardBackground"
+    android:fadeScrollbars="false"
+    android:fillViewport="true"
+    tools:ignore="DuplicateIds">
+    <LinearLayout
+      android:layout_width="match_parent"
+      android:layout_height="match_parent"
+      android:clipChildren="false"
+      android:clipToPadding="false"
+      android:orientation="vertical"
+      android:padding="@dimen/margin_base"
+      tools:ignore="ScrollViewSize">
+      <androidx.constraintlayout.widget.ConstraintLayout
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:layout_marginTop="@dimen/margin_half">
+        <com.google.android.material.textfield.TextInputLayout
+            android:id="@+id/osm_username_container"
+            style="@style/MwmWidget.Editor.CustomTextInput"
+            android:layout_width="0dp"
+            android:layout_marginEnd="@dimen/margin_half"
+            android:textColorHint="?android:textColorSecondary"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintEnd_toStartOf="@id/osm_password_container"
+            app:layout_constraintTop_toTopOf="parent"
+            app:endIconMode="custom">
+          <com.google.android.material.textfield.TextInputEditText
+              android:id="@+id/osm_username"
+              style="@style/MwmWidget.Editor.FieldLayout.EditText"
+              android:autofillHints="emailAddress"
+              android:hint="@string/email_or_username" />
+        </com.google.android.material.textfield.TextInputLayout>
+        <com.google.android.material.textfield.TextInputLayout
+            android:id="@+id/osm_password_container"
+            style="@style/MwmWidget.Editor.CustomTextInput"
+            android:layout_width="0dp"
+            android:textColorHint="?android:textColorSecondary"
+            app:layout_constraintStart_toEndOf="@id/osm_username_container"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintTop_toTopOf="parent"
+            app:endIconMode="password_toggle"
+            app:endIconTint="?android:textColorSecondary">
+          <com.google.android.material.textfield.TextInputEditText
+              android:id="@+id/osm_password"
+              style="@style/MwmWidget.Editor.FieldLayout.EditText"
+              android:autofillHints="password"
+              android:hint="@string/password"
+              android:inputType="textPassword" />
+        </com.google.android.material.textfield.TextInputLayout>
+      </androidx.constraintlayout.widget.ConstraintLayout>
+
+
+      <FrameLayout
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/margin_base">
+        <Button
+          android:id="@+id/login"
+          style="@style/MwmWidget.Button.Accent"
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:text="Login with username"
+            android:layout_marginTop="@dimen/margin_half"
+          android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
+        <ProgressBar
+          android:id="@+id/osm_login_progress"
+          android:layout_width="@dimen/editor_auth_btn_height"
+          android:layout_height="@dimen/editor_auth_btn_height"
+          android:layout_gravity="center"
+          android:elevation="@dimen/design_fab_elevation"
+          android:visibility="gone" />
+      </FrameLayout>
+
+      <LinearLayout
+          android:layout_width="match_parent"
+          android:layout_height="wrap_content"
+          android:orientation="horizontal"
+          android:layout_marginTop="@dimen/margin_base">
+        <Button
+            android:id="@+id/lost_password"
+            style="@style/MwmWidget.Button"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_gravity="start"
+            android:layout_weight="1"
+            android:background="?clickableBackground"
+            android:padding="@dimen/margin_quarter"
+            android:text="@string/forgot_password"
+            android:textAppearance="@style/MwmTextAppearance.Body3" />
+        <Button
+            android:id="@+id/register"
+            style="@style/MwmWidget.Button"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_weight="1"
+            android:layout_gravity="end"
+            android:background="?clickableBackground"
+            android:padding="@dimen/margin_quarter"
+            android:text="@string/register_at_openstreetmap"
+            android:textAppearance="@style/MwmTextAppearance.Body3" />
+      </LinearLayout>
+    </LinearLayout>
+  </ScrollView>
+</LinearLayout>
-- 
2.45.3


From 6371fe09eff267354feb7ba05e38189db2a37434 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Tue, 20 Aug 2024 09:39:35 +0300
Subject: [PATCH 09/13] Apply suggestions from code review

Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com>
Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 android/app/src/main/cpp/app/organicmaps/Framework.cpp        | 4 ++--
 android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp  | 4 ++--
 .../java/app/organicmaps/editor/OsmLoginBottomFragment.java   | 3 ++-
 editor/osm_auth.cpp                                           | 2 +-
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/android/app/src/main/cpp/app/organicmaps/Framework.cpp b/android/app/src/main/cpp/app/organicmaps/Framework.cpp
index 76d04b2df9..0be0e09d42 100644
--- a/android/app/src/main/cpp/app/organicmaps/Framework.cpp
+++ b/android/app/src/main/cpp/app/organicmaps/Framework.cpp
@@ -865,8 +865,8 @@ Java_app_organicmaps_Framework_nativeGetParsedAppName(JNIEnv * env, jclass)
 JNIEXPORT jstring JNICALL
 Java_app_organicmaps_Framework_nativeGetParsedOAuth2Code(JNIEnv * env, jclass)
 {
-    std::string const & code = frm()->GetParsedOAuth2Code();
-    return jni::ToJavaString(env, code);
+  std::string const & code = frm()->GetParsedOAuth2Code();
+  return jni::ToJavaString(env, code);
 }
 
 JNIEXPORT jstring JNICALL
diff --git a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
index 848e7e485d..fc18cf19f8 100644
--- a/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
+++ b/android/app/src/main/cpp/app/organicmaps/editor/OsmOAuth.cpp
@@ -37,8 +37,8 @@ extern "C"
 JNIEXPORT jstring JNICALL
 Java_app_organicmaps_editor_OsmOAuth_nativeGetOAuth2Url(JNIEnv * env, jclass)
 {
-    auto const auth = OsmOAuth::ServerAuth();
-    return ToJavaString(env, auth.BuildOAuth2Url());
+  auto const auth = OsmOAuth::ServerAuth();
+  return ToJavaString(env, auth.BuildOAuth2Url());
 }
 
 JNIEXPORT jstring JNICALL
diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
index 3341d62dff..c602cf148a 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
@@ -24,7 +24,8 @@ import app.organicmaps.util.Utils;
 import app.organicmaps.util.concurrency.ThreadPool;
 import app.organicmaps.util.concurrency.UiThread;
 
-public class OsmLoginBottomFragment extends BottomSheetDialogFragment {
+public class OsmLoginBottomFragment extends BottomSheetDialogFragment
+{
     final private OsmLoginFragment parentFragment;
     private TextInputEditText mLoginInput;
     private TextInputEditText mPasswordInput;
diff --git a/editor/osm_auth.cpp b/editor/osm_auth.cpp
index ee438b4f2c..e42c16a23f 100644
--- a/editor/osm_auth.cpp
+++ b/editor/osm_auth.cpp
@@ -282,7 +282,7 @@ string OsmOAuth::BuildOAuth2Url() const
        {"scope", m_oauth2params.m_scope},
        {"response_type", "code"}
    });
-   return requestTokenUrl + "?" + requestTokenQuery;
+   return requestTokenUrl.append('?').append(requestTokenQuery);
 }
 
 string OsmOAuth::FinishAuthorization(string const & oauth2code) const
-- 
2.45.3


From 7b2fedb93a2a960e55a1510d05f52978d851ca2b Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Tue, 20 Aug 2024 09:45:33 +0300
Subject: [PATCH 10/13] Code formatting

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../editor/OsmLoginBottomFragment.java        | 152 +++++++++---------
 .../layout-land/fragment_osm_login_bottom.xml | 110 ++++++-------
 .../main/res/layout/fragment_osm_login.xml    |  14 +-
 .../res/layout/fragment_osm_login_bottom.xml  |  96 +++++------
 4 files changed, 190 insertions(+), 182 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
index c602cf148a..f91e9bbfb3 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginBottomFragment.java
@@ -26,91 +26,99 @@ import app.organicmaps.util.concurrency.UiThread;
 
 public class OsmLoginBottomFragment extends BottomSheetDialogFragment
 {
-    final private OsmLoginFragment parentFragment;
-    private TextInputEditText mLoginInput;
-    private TextInputEditText mPasswordInput;
-    private Button mLoginButton;
-    private Button mLostPasswordButton;
-    private Button mRegisterButton;
-    private ProgressBar mProgress;
+  final private OsmLoginFragment parentFragment;
+  private TextInputEditText mLoginInput;
+  private TextInputEditText mPasswordInput;
+  private Button mLoginButton;
+  private Button mLostPasswordButton;
+  private Button mRegisterButton;
+  private ProgressBar mProgress;
 
-    public OsmLoginBottomFragment(OsmLoginFragment parentFragment) {
-        super();
-        this.parentFragment = parentFragment;
-    }
+  public OsmLoginBottomFragment(OsmLoginFragment parentFragment)
+  {
+    super();
+    this.parentFragment = parentFragment;
+  }
 
-    @Override
-    public void onCreate(@Nullable Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-    }
+  @Override
+  public void onCreate(@Nullable Bundle savedInstanceState)
+  {
+    super.onCreate(savedInstanceState);
+  }
 
-    @Nullable
-    @Override
-    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
-        return inflater.inflate(R.layout.fragment_osm_login_bottom, container, false);
-    }
+  @Nullable
+  @Override
+  public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container, @Nullable Bundle savedInstanceState)
+  {
+    return inflater.inflate(R.layout.fragment_osm_login_bottom, container, false);
+  }
 
-    @NonNull
-    @Override
-    public Dialog onCreateDialog(Bundle savedInstanceState) {
-        BottomSheetDialog dialog = (BottomSheetDialog) super.onCreateDialog(savedInstanceState);
-        dialog.getBehavior().setState(BottomSheetBehavior.STATE_EXPANDED);
-        return dialog;
-    }
+  @NonNull
+  @Override
+  public Dialog onCreateDialog(Bundle savedInstanceState)
+  {
+    BottomSheetDialog dialog = (BottomSheetDialog) super.onCreateDialog(savedInstanceState);
+    dialog.getBehavior().setState(BottomSheetBehavior.STATE_EXPANDED);
+    return dialog;
+  }
 
-    @Override
-    public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
-        mLoginInput = view.findViewById(R.id.osm_username);
-        mPasswordInput = view.findViewById(R.id.osm_password);
+  @Override
+  public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState)
+  {
+    mLoginInput = view.findViewById(R.id.osm_username);
+    mPasswordInput = view.findViewById(R.id.osm_password);
 
-        mLoginButton = view.findViewById(R.id.login);
-        mLoginButton.setOnClickListener((v) -> doLogin());
+    mLoginButton = view.findViewById(R.id.login);
+    mLoginButton.setOnClickListener((v) -> doLogin());
 
-        mLostPasswordButton = view.findViewById(R.id.lost_password);
-        mLostPasswordButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_RECOVER_PASSWORD));
-        mRegisterButton = view.findViewById(R.id.register);
-        mRegisterButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_REGISTER));
-        mProgress = view.findViewById(R.id.osm_login_progress);
-    }
+    mLostPasswordButton = view.findViewById(R.id.lost_password);
+    mLostPasswordButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_RECOVER_PASSWORD));
+    mRegisterButton = view.findViewById(R.id.register);
+    mRegisterButton.setOnClickListener((v) -> Utils.openUrl(requireActivity(), Constants.Url.OSM_REGISTER));
+    mProgress = view.findViewById(R.id.osm_login_progress);
+  }
 
-    private void doLogin() {
-        InputUtils.hideKeyboard(mLoginInput);
-        final String username = mLoginInput.getText().toString().trim();
-        final String password = mPasswordInput.getText().toString();
-        enableInput(false);
-        UiUtils.show(mProgress);
-        mLoginButton.setText("");
+  private void doLogin()
+  {
+    InputUtils.hideKeyboard(mLoginInput);
+    final String username = mLoginInput.getText().toString().trim();
+    final String password = mPasswordInput.getText().toString();
+    enableInput(false);
+    UiUtils.show(mProgress);
+    mLoginButton.setText("");
 
-        ThreadPool.getWorker().execute(() -> {
-          final String oauthToken = OsmOAuth.nativeAuthWithPassword(username, password);
-          final String username1 = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
-          UiThread.run(() -> processAuth(oauthToken, username1));
-        });
-    }
-
-    private void processAuth(String oauthToken, String username)
+    ThreadPool.getWorker().execute(() ->
     {
-        if (!isAdded())
-            return;
+      final String oauthToken = OsmOAuth.nativeAuthWithPassword(username, password);
+      final String username1 = (oauthToken == null) ? null : OsmOAuth.nativeGetOsmUsername(oauthToken);
+      UiThread.run(() -> processAuth(oauthToken, username1));
+    });
+  }
 
-        enableInput(true);
-        UiUtils.hide(mProgress);
-        mLoginButton.setText(R.string.login_osm);
+  private void processAuth(String oauthToken, String username)
+  {
+    if (!isAdded())
+      return;
 
-        if (oauthToken == null)
-            parentFragment.onAuthFail();
-        else {
-            this.dismiss();
-            parentFragment.onAuthSuccess(oauthToken, username);
-        }
-    }
+    enableInput(true);
+    UiUtils.hide(mProgress);
+    mLoginButton.setText(R.string.login_osm);
 
-    private void enableInput(boolean enable)
+    if (oauthToken == null)
+      parentFragment.onAuthFail();
+    else
     {
-        mPasswordInput.setEnabled(enable);
-        mLoginInput.setEnabled(enable);
-        mLoginButton.setEnabled(enable);
-        mLostPasswordButton.setEnabled(enable);
-        mRegisterButton.setEnabled(enable);
+      this.dismiss();
+      parentFragment.onAuthSuccess(oauthToken, username);
     }
+  }
+
+  private void enableInput(boolean enable)
+  {
+    mPasswordInput.setEnabled(enable);
+    mLoginInput.setEnabled(enable);
+    mLoginButton.setEnabled(enable);
+    mLostPasswordButton.setEnabled(enable);
+    mRegisterButton.setEnabled(enable);
+  }
 }
diff --git a/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml b/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
index 1adcc541cf..3b368f1816 100644
--- a/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
+++ b/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
@@ -22,41 +22,41 @@
       android:padding="@dimen/margin_base"
       tools:ignore="ScrollViewSize">
       <androidx.constraintlayout.widget.ConstraintLayout
-          android:layout_width="match_parent"
-          android:layout_height="wrap_content"
-          android:layout_marginTop="@dimen/margin_half">
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:layout_marginTop="@dimen/margin_half">
         <com.google.android.material.textfield.TextInputLayout
-            android:id="@+id/osm_username_container"
-            style="@style/MwmWidget.Editor.CustomTextInput"
-            android:layout_width="0dp"
-            android:layout_marginEnd="@dimen/margin_half"
-            android:textColorHint="?android:textColorSecondary"
-            app:layout_constraintStart_toStartOf="parent"
-            app:layout_constraintEnd_toStartOf="@id/osm_password_container"
-            app:layout_constraintTop_toTopOf="parent"
-            app:endIconMode="custom">
+          android:id="@+id/osm_username_container"
+          style="@style/MwmWidget.Editor.CustomTextInput"
+          android:layout_width="0dp"
+          android:layout_marginEnd="@dimen/margin_half"
+          android:textColorHint="?android:textColorSecondary"
+          app:layout_constraintStart_toStartOf="parent"
+          app:layout_constraintEnd_toStartOf="@id/osm_password_container"
+          app:layout_constraintTop_toTopOf="parent"
+          app:endIconMode="custom">
           <com.google.android.material.textfield.TextInputEditText
-              android:id="@+id/osm_username"
-              style="@style/MwmWidget.Editor.FieldLayout.EditText"
-              android:autofillHints="emailAddress"
-              android:hint="@string/email_or_username" />
+            android:id="@+id/osm_username"
+            style="@style/MwmWidget.Editor.FieldLayout.EditText"
+            android:autofillHints="emailAddress"
+            android:hint="@string/email_or_username" />
         </com.google.android.material.textfield.TextInputLayout>
         <com.google.android.material.textfield.TextInputLayout
-            android:id="@+id/osm_password_container"
-            style="@style/MwmWidget.Editor.CustomTextInput"
-            android:layout_width="0dp"
-            android:textColorHint="?android:textColorSecondary"
-            app:layout_constraintStart_toEndOf="@id/osm_username_container"
-            app:layout_constraintEnd_toEndOf="parent"
-            app:layout_constraintTop_toTopOf="parent"
-            app:endIconMode="password_toggle"
-            app:endIconTint="?android:textColorSecondary">
+          android:id="@+id/osm_password_container"
+          style="@style/MwmWidget.Editor.CustomTextInput"
+          android:layout_width="0dp"
+          android:textColorHint="?android:textColorSecondary"
+          app:layout_constraintStart_toEndOf="@id/osm_username_container"
+          app:layout_constraintEnd_toEndOf="parent"
+          app:layout_constraintTop_toTopOf="parent"
+          app:endIconMode="password_toggle"
+          app:endIconTint="?android:textColorSecondary">
           <com.google.android.material.textfield.TextInputEditText
-              android:id="@+id/osm_password"
-              style="@style/MwmWidget.Editor.FieldLayout.EditText"
-              android:autofillHints="password"
-              android:hint="@string/password"
-              android:inputType="textPassword" />
+            android:id="@+id/osm_password"
+            style="@style/MwmWidget.Editor.FieldLayout.EditText"
+            android:autofillHints="password"
+            android:hint="@string/password"
+            android:inputType="textPassword" />
         </com.google.android.material.textfield.TextInputLayout>
       </androidx.constraintlayout.widget.ConstraintLayout>
 
@@ -71,7 +71,7 @@
           android:layout_width="match_parent"
           android:layout_height="wrap_content"
           android:text="Login with username"
-            android:layout_marginTop="@dimen/margin_half"
+          android:layout_marginTop="@dimen/margin_half"
           android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
         <ProgressBar
           android:id="@+id/osm_login_progress"
@@ -83,32 +83,32 @@
       </FrameLayout>
 
       <LinearLayout
-          android:layout_width="match_parent"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal"
+        android:layout_marginTop="@dimen/margin_base">
+        <Button
+          android:id="@+id/lost_password"
+          style="@style/MwmWidget.Button"
+          android:layout_width="wrap_content"
           android:layout_height="wrap_content"
-          android:orientation="horizontal"
-          android:layout_marginTop="@dimen/margin_base">
+          android:layout_gravity="start"
+          android:layout_weight="1"
+          android:background="?clickableBackground"
+          android:padding="@dimen/margin_quarter"
+          android:text="@string/forgot_password"
+          android:textAppearance="@style/MwmTextAppearance.Body3" />
         <Button
-            android:id="@+id/lost_password"
-            style="@style/MwmWidget.Button"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_gravity="start"
-            android:layout_weight="1"
-            android:background="?clickableBackground"
-            android:padding="@dimen/margin_quarter"
-            android:text="@string/forgot_password"
-            android:textAppearance="@style/MwmTextAppearance.Body3" />
-        <Button
-            android:id="@+id/register"
-            style="@style/MwmWidget.Button"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_weight="1"
-            android:layout_gravity="end"
-            android:background="?clickableBackground"
-            android:padding="@dimen/margin_quarter"
-            android:text="@string/register_at_openstreetmap"
-            android:textAppearance="@style/MwmTextAppearance.Body3" />
+          android:id="@+id/register"
+          style="@style/MwmWidget.Button"
+          android:layout_width="wrap_content"
+          android:layout_height="wrap_content"
+          android:layout_weight="1"
+          android:layout_gravity="end"
+          android:background="?clickableBackground"
+          android:padding="@dimen/margin_quarter"
+          android:text="@string/register_at_openstreetmap"
+          android:textAppearance="@style/MwmTextAppearance.Body3" />
       </LinearLayout>
     </LinearLayout>
   </ScrollView>
diff --git a/android/app/src/main/res/layout/fragment_osm_login.xml b/android/app/src/main/res/layout/fragment_osm_login.xml
index b9fdf0287c..1951fdb17b 100644
--- a/android/app/src/main/res/layout/fragment_osm_login.xml
+++ b/android/app/src/main/res/layout/fragment_osm_login.xml
@@ -61,13 +61,13 @@
         android:textAppearance="@style/MwmTextAppearance.Body2"
         android:textColor="?android:textColorPrimary" />
       <Button
-          android:id="@+id/login_website"
-          style="@style/MwmWidget.Button.Accent"
-          android:layout_marginTop="@dimen/margin_base"
-          android:layout_width="match_parent"
-          android:layout_height="wrap_content"
-          android:text="Login with OSM website"
-          android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
+        android:id="@+id/login_website"
+        style="@style/MwmWidget.Button.Accent"
+        android:layout_marginTop="@dimen/margin_base"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:text="Login with OSM website"
+        android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
       <Button
         android:id="@+id/login_username"
         style="@style/MwmWidget.Button.Accent"
diff --git a/android/app/src/main/res/layout/fragment_osm_login_bottom.xml b/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
index 65d87d1b5d..afe7802278 100644
--- a/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
+++ b/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
@@ -22,35 +22,35 @@
       android:padding="@dimen/margin_base"
       tools:ignore="ScrollViewSize">
       <LinearLayout
-          android:id="@+id/login_bottom_sheet"
-          android:layout_width="match_parent"
-          android:layout_height="wrap_content"
-          android:orientation="vertical">
+        android:id="@+id/login_bottom_sheet"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="vertical">
 
         <com.google.android.material.textfield.TextInputLayout
-            style="@style/MwmWidget.Editor.CustomTextInput"
-            android:layout_marginTop="@dimen/margin_half"
-            android:textColorHint="?android:textColorSecondary"
-            app:endIconMode="custom">
+          style="@style/MwmWidget.Editor.CustomTextInput"
+          android:layout_marginTop="@dimen/margin_half"
+          android:textColorHint="?android:textColorSecondary"
+          app:endIconMode="custom">
           <com.google.android.material.textfield.TextInputEditText
-              android:id="@+id/osm_username"
-              style="@style/MwmWidget.Editor.FieldLayout.EditText"
-              android:padding="@dimen/margin_half_double_plus"
-              android:autofillHints="emailAddress"
-              android:hint="@string/email_or_username" />
+            android:id="@+id/osm_username"
+            style="@style/MwmWidget.Editor.FieldLayout.EditText"
+            android:padding="@dimen/margin_half_double_plus"
+            android:autofillHints="emailAddress"
+            android:hint="@string/email_or_username" />
         </com.google.android.material.textfield.TextInputLayout>
         <com.google.android.material.textfield.TextInputLayout
-            style="@style/MwmWidget.Editor.CustomTextInput"
-            android:textColorHint="?android:textColorSecondary"
-            app:endIconMode="password_toggle"
-            app:endIconTint="?android:textColorSecondary">
+          style="@style/MwmWidget.Editor.CustomTextInput"
+          android:textColorHint="?android:textColorSecondary"
+          app:endIconMode="password_toggle"
+          app:endIconTint="?android:textColorSecondary">
           <com.google.android.material.textfield.TextInputEditText
-              android:id="@+id/osm_password"
-              style="@style/MwmWidget.Editor.FieldLayout.EditText"
-              android:padding="@dimen/margin_half_double_plus"
-              android:autofillHints="password"
-              android:hint="@string/password"
-              android:inputType="textPassword" />
+            android:id="@+id/osm_password"
+            style="@style/MwmWidget.Editor.FieldLayout.EditText"
+            android:padding="@dimen/margin_half_double_plus"
+            android:autofillHints="password"
+            android:hint="@string/password"
+            android:inputType="textPassword" />
         </com.google.android.material.textfield.TextInputLayout>
       </LinearLayout>
 
@@ -64,7 +64,7 @@
           android:layout_width="match_parent"
           android:layout_height="wrap_content"
           android:text="Login with username"
-            android:layout_marginTop="@dimen/margin_half"
+          android:layout_marginTop="@dimen/margin_half"
           android:textAppearance="@style/MwmTextAppearance.Body2.Light" />
         <ProgressBar
           android:id="@+id/osm_login_progress"
@@ -76,32 +76,32 @@
       </FrameLayout>
 
       <LinearLayout
-          android:layout_width="match_parent"
+        android:layout_width="match_parent"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal"
+        android:layout_marginTop="@dimen/margin_base">
+        <Button
+          android:id="@+id/lost_password"
+          style="@style/MwmWidget.Button"
+          android:layout_width="wrap_content"
           android:layout_height="wrap_content"
-          android:orientation="horizontal"
-          android:layout_marginTop="@dimen/margin_base">
+          android:layout_gravity="start"
+          android:layout_weight="1"
+          android:background="?clickableBackground"
+          android:padding="@dimen/margin_quarter"
+          android:text="@string/forgot_password"
+          android:textAppearance="@style/MwmTextAppearance.Body3" />
         <Button
-            android:id="@+id/lost_password"
-            style="@style/MwmWidget.Button"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_gravity="start"
-            android:layout_weight="1"
-            android:background="?clickableBackground"
-            android:padding="@dimen/margin_quarter"
-            android:text="@string/forgot_password"
-            android:textAppearance="@style/MwmTextAppearance.Body3" />
-        <Button
-            android:id="@+id/register"
-            style="@style/MwmWidget.Button"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_weight="1"
-            android:layout_gravity="end"
-            android:background="?clickableBackground"
-            android:padding="@dimen/margin_quarter"
-            android:text="@string/register_at_openstreetmap"
-            android:textAppearance="@style/MwmTextAppearance.Body3" />
+          android:id="@+id/register"
+          style="@style/MwmWidget.Button"
+          android:layout_width="wrap_content"
+          android:layout_height="wrap_content"
+          android:layout_weight="1"
+          android:layout_gravity="end"
+          android:background="?clickableBackground"
+          android:padding="@dimen/margin_quarter"
+          android:text="@string/register_at_openstreetmap"
+          android:textAppearance="@style/MwmTextAppearance.Body3" />
       </LinearLayout>
     </LinearLayout>
   </ScrollView>
-- 
2.45.3


From 6fb9dbc440506ba0d1f770689f1109e1ee5197ed Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Tue, 20 Aug 2024 09:53:02 +0300
Subject: [PATCH 11/13] Fix compilation error

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 editor/osm_auth.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/editor/osm_auth.cpp b/editor/osm_auth.cpp
index e42c16a23f..48c4808a00 100644
--- a/editor/osm_auth.cpp
+++ b/editor/osm_auth.cpp
@@ -275,14 +275,14 @@ string OsmOAuth::FetchRequestToken(SessionID const & sid) const
 
 string OsmOAuth::BuildOAuth2Url() const
 {
-   string const requestTokenUrl = m_baseUrl + "/oauth2/authorize";
+   string requestTokenUrl = m_baseUrl + "/oauth2/authorize";
    string const requestTokenQuery = BuildPostRequest({
        {"client_id", m_oauth2params.m_clientId},
        {"redirect_uri", m_oauth2params.m_redirectUri},
        {"scope", m_oauth2params.m_scope},
        {"response_type", "code"}
    });
-   return requestTokenUrl.append('?').append(requestTokenQuery);
+   return requestTokenUrl.append("?").append(requestTokenQuery);
 }
 
 string OsmOAuth::FinishAuthorization(string const & oauth2code) const
-- 
2.45.3


From f692cb4cafca1aa960c32b90406609f7a9b80d40 Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Tue, 20 Aug 2024 10:15:31 +0300
Subject: [PATCH 12/13] [Android] Added round corners for OSM Login bottom
 sheet

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../app/src/main/res/layout-land/fragment_osm_login_bottom.xml  | 2 ++
 android/app/src/main/res/layout/fragment_osm_login_bottom.xml   | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml b/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
index 3b368f1816..8f360f5960 100644
--- a/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
+++ b/android/app/src/main/res/layout-land/fragment_osm_login_bottom.xml
@@ -6,6 +6,8 @@
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:orientation="vertical">
+  <include
+    layout="@layout/bottom_sheet_handle" />
   <ScrollView
     android:layout_width="match_parent"
     android:layout_height="match_parent"
diff --git a/android/app/src/main/res/layout/fragment_osm_login_bottom.xml b/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
index afe7802278..debdbaf6f8 100644
--- a/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
+++ b/android/app/src/main/res/layout/fragment_osm_login_bottom.xml
@@ -6,6 +6,8 @@
   android:layout_width="match_parent"
   android:layout_height="match_parent"
   android:orientation="vertical">
+  <include
+    layout="@layout/bottom_sheet_handle" />
   <ScrollView
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-- 
2.45.3


From 44aff764c6b46b14903fdf9762ea90abbe7403ea Mon Sep 17 00:00:00 2001
From: Sergiy Kozyr <s.trump@gmail.com>
Date: Tue, 20 Aug 2024 10:22:16 +0300
Subject: [PATCH 13/13] [Android] Using Utils.openUri(...)

Signed-off-by: Sergiy Kozyr <s.trump@gmail.com>
---
 .../app/organicmaps/editor/OsmLoginFragment.java    | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
index 76ee0014d0..a82cba792a 100644
--- a/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
+++ b/android/app/src/main/java/app/organicmaps/editor/OsmLoginFragment.java
@@ -19,6 +19,7 @@ import app.organicmaps.Framework;
 import app.organicmaps.R;
 import app.organicmaps.base.BaseMwmToolbarFragment;
 import app.organicmaps.util.DateUtils;
+import app.organicmaps.util.Utils;
 import app.organicmaps.util.concurrency.ThreadPool;
 import app.organicmaps.util.concurrency.UiThread;
 
@@ -72,17 +73,7 @@ public class OsmLoginFragment extends BaseMwmToolbarFragment
 
   private void loginWithBrowser()
   {
-    try
-    {
-      Intent myIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(OsmOAuth.nativeGetOAuth2Url()));
-      startActivity(myIntent);
-    }
-    catch (ActivityNotFoundException e)
-    {
-      //Toast.makeText(this, "No application can handle this request."
-      //        + " Please install a webbrowser",  Toast.LENGTH_LONG).show();
-      e.printStackTrace();
-    }
+    Utils.openUri(requireContext(), Uri.parse(OsmOAuth.nativeGetOAuth2Url()));
   }
 
   // This method is called by MwmActivity & UrlProcessor when "om://oauth2/osm/callback?code=XXX" is handled
-- 
2.45.3